GNU bug report logs - #36543
[PATCH] gnu: wireservice: New wireservice-package macro.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36543 in the body.
You can then email your comments to 36543 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: Guix-patches <guix-patches <at> gnu.org>
Cc: Pierre Langlois <pierre.langlois <at> gmx.com>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH] gnu: wireservice: New wireservice-package macro.
Date: Sun, 07 Jul 2019 22:02:47 +0100

[Message part 1 (text/plain, inline)]

Hi Guix, Ludo,

Here's a new 'wireservice-package' macro that factors the packages that
used to inherit for a base package with '#f fields. The main change is
that native-inputs are no longer common, I toyed with a more complicated
macro that would allow extending them but in the end I think the simpler
the better!

WDYT?

Thanks for the suggestion! I need to learn me some more macro magic,
it's fun :-).

Pierre

[0001-gnu-wireservice-New-wireservice-package-macro.patch (text/x-patch, attachment)]

Message #10 received at 36543-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 36543-done <at> debbugs.gnu.org
Subject: Re: [bug#36543] [PATCH] gnu: wireservice: New wireservice-package
 macro.
Date: Mon, 08 Jul 2019 12:57:28 +0200

Hello,

Pierre Langlois <pierre.langlois <at> gmx.com> skribis:

> Here's a new 'wireservice-package' macro that factors the packages that
> used to inherit for a base package with '#f fields. The main change is
> that native-inputs are no longer common, I toyed with a more complicated
> macro that would allow extending them but in the end I think the simpler
> the better!
>
> WDYT?

I think it looks good this way!

There’s a bit of code bloat because the macro expands the ‘arguments’
field for every package, but it doesn’t matter much here (it’d be more
of a problem if we had 100s of packages all duplicating that field.)

> Thanks for the suggestion! I need to learn me some more macro magic,
> it's fun :-).

Yup!  :-)

> From cf7559db69dd1d829e620c6b31e253a2d8911eff Mon Sep 17 00:00:00 2001
> From: Pierre Langlois <pierre.langlois <at> gmx.com>
> Date: Sun, 7 Jul 2019 16:02:26 +0100
> Subject: [PATCH] gnu: wireservice: New wireservice-package macro.
>
> Replace the parent 'base-package' variable with a 'wireservice-package' macro
> that includes all common package fields.
>
> * gnu/packages/wireservice.scm (base-package): Delete.
> (wireservice-package): New macro.
> (python-leather, python-agate, python-agate-sql, python-agate-dbf,
> python-agate-excel): Use wireservice-package.

Applied, thanks for the quick followup!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.