GNU bug report logs - #36545
[PATCH] Add Hoogle

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36545 in the body.
You can then email your comments to 36545 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add Hoogle
Date: Mon, 8 Jul 2019 06:10:43 +0000

[Message part 1 (text/plain, inline)]

Hi Guix,

Hoogle is a search tool that is invaluable when writing Haskell.  I have
linted, formatted, and built --rounds=2 all the following.

Thank you,

John

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ghc-mtl.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-non-negative.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-timeit.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-unsafe.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-storablevector.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-fmlist.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-storable-record.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-listlike.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-storable-tuple.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-process-extras.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-js-jquery.patch (text/x-patch, attachment)]

[0013-gnu-Add-hoogle.patch (text/x-patch, attachment)]

[0012-gnu-Add-ghc-js-flot.patch (text/x-patch, attachment)]

Message #8 received at 36545 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: 36545 <at> debbugs.gnu.org
Subject: two issues
Date: Tue, 9 Jul 2019 19:37:03 +0200

Hi John,

indeed hoogle would be nice to have. Thanks for packagin it!

Two remarks from looking over the patch set:

- ghc-mtl shouldn’t be packaged, as it’s a GHC-bundled library. New
versions of `guix import` were updated to take that into account
properly, but it should “just work” to remove patch 0001 and delete
the dependency lines for `ghc-mtl` where they occur.

- Is there a particular reason that tests are disabled? The general
approach seems to be to build packages with tests unless there’s a
specific reason not to, in which case it would be great if you could
add a comment explaining that next to the “#:tests? #f” line.

Cheers
Robert

Message #11 received at 36545 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: rob <at> vllmrt.net, 36545 <at> debbugs.gnu.org
Subject: [PATCH] Add Hoogle
Date: Thu, 15 Aug 2019 17:09:08 +0000

[Message part 1 (text/plain, inline)]

Hi Robert,

Thank you for your patience.

> - ghc-mtl shouldn’t be packaged, as it’s a GHC-bundled library.

I removed all references to ghc-mtl

> - Is there a particular reason that tests are disabled?

I had removed them for expedience but I have added them back. There is
one exception whose tests do network IO, so I added a comment there.

I rebased the patches on current master a few minutes ago.  Thanks again!

- John

[Message part 2 (text/html, inline)]

[0002-gnu-Add-ghc-non-negative.patch (text/x-patch, attachment)]

[0001-gnu-Add-ghc-unsafe.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-storablevector.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-fmlist.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-timeit.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-storable-record.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-listlike.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-storable-tuple.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-process-extras.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-js-jquery.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-js-flot.patch (text/x-patch, attachment)]

[0012-gnu-Add-hoogle.patch (text/x-patch, attachment)]

Message #14 received at 36545 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: rob <at> vllmrt.net, 36545 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add Hoogle
Date: Fri, 16 Aug 2019 05:58:34 +0000

[Message part 1 (text/plain, inline)]

Hi Robert and Guix,

I realized just now that I had some incorrect git configuration. I have
attached the updated patches with my correct email address.

Thanks again!

- John

[Message part 2 (text/html, inline)]

[0004-gnu-Add-ghc-storablevector.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-fmlist.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-non-negative.patch (text/x-patch, attachment)]

[0001-gnu-Add-ghc-unsafe.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-timeit.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-listlike.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-storable-record.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-storable-tuple.patch (text/x-patch, attachment)]

[0009-gnu-Add-ghc-process-extras.patch (text/x-patch, attachment)]

[0010-gnu-Add-ghc-js-jquery.patch (text/x-patch, attachment)]

[0011-gnu-Add-ghc-js-flot.patch (text/x-patch, attachment)]

[0012-gnu-Add-hoogle.patch (text/x-patch, attachment)]

Message #17 received at 36545 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 36545 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add Hoogle
Date: Fri, 16 Aug 2019 14:22:09 +0200

Hi John,

looks good to me! Hoogle builds and fine, and seems to run.

I’ve applied the patches to the wip-haskell-updates branch, will see
to get that merged soon.

Cheers
Robert

> On 16. Aug 2019, at 07:58, John Soo <jsoo1 <at> asu.edu> wrote:
> 
> Hi Robert and Guix,
> 
> I realized just now that I had some incorrect git configuration. I have attached the updated patches with my correct email address.
> 
> Thanks again!
> 
> - John
> <0004-gnu-Add-ghc-storablevector.patch><0005-gnu-Add-ghc-fmlist.patch><0002-gnu-Add-ghc-non-negative.patch><0001-gnu-Add-ghc-unsafe.patch><0003-gnu-Add-ghc-timeit.patch><0007-gnu-Add-ghc-listlike.patch><0006-gnu-Add-ghc-storable-record.patch><0008-gnu-Add-ghc-storable-tuple.patch><0009-gnu-Add-ghc-process-extras.patch><0010-gnu-Add-ghc-js-jquery.patch><0011-gnu-Add-ghc-js-flot.patch><0012-gnu-Add-hoogle.patch>

Message #20 received at 36545 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Robert Vollmert <rob <at> vllmrt.net>
Cc: 36545 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add Hoogle
Date: Fri, 16 Aug 2019 13:58:33 +0000

[Message part 1 (text/plain, inline)]

Excellent, thank you!

On Fri, Aug 16, 2019 at 12:22 PM Robert Vollmert <rob <at> vllmrt.net> wrote:

> Hi John,
>
> looks good to me! Hoogle builds and fine, and seems to run.
>
> I’ve applied the patches to the wip-haskell-updates branch, will see
> to get that merged soon.
>
> Cheers
> Robert
>
> > On 16. Aug 2019, at 07:58, John Soo <jsoo1 <at> asu.edu> wrote:
> >
> > Hi Robert and Guix,
> >
> > I realized just now that I had some incorrect git configuration. I have
> attached the updated patches with my correct email address.
> >
> > Thanks again!
> >
> > - John
> >
> <0004-gnu-Add-ghc-storablevector.patch><0005-gnu-Add-ghc-fmlist.patch><0002-gnu-Add-ghc-non-negative.patch><0001-gnu-Add-ghc-unsafe.patch><0003-gnu-Add-ghc-timeit.patch><0007-gnu-Add-ghc-listlike.patch><0006-gnu-Add-ghc-storable-record.patch><0008-gnu-Add-ghc-storable-tuple.patch><0009-gnu-Add-ghc-process-extras.patch><0010-gnu-Add-ghc-js-jquery.patch><0011-gnu-Add-ghc-js-flot.patch><0012-gnu-Add-hoogle.patch>
>
>

[Message part 2 (text/html, inline)]

Message #25 received at 36545-done <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 36545-done <at> debbugs.gnu.org, Robert Vollmert <rob <at> vllmrt.net>
Subject: Re: [bug#36545] [PATCH] Add Hoogle
Date: Mon, 02 Sep 2019 23:18:20 -0400

Hi John,

I finally got around to processing the “wip-haskell-updates” branch
(thanks for your patience).  This patch series has now landed in master
as commits a52f4c5740–6ec2450f1e.

Thanks for the packages!

(And thanks to Robert too, for moving them into “haskell-xyz”.)


-- Tim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.