GNU bug report logs - #36565
[PATCH] Suppress interactive-only warnings in undo-tests.el

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Wed, 10 Jul 2019 01:16:02 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36565 in the body.
You can then email your comments to 36565 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Wed, 10 Jul 2019 01:16:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Stefan Kangas <stefan <at> marxist.se>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 10 Jul 2019 01:16:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Suppress interactive-only warnings in undo-tests.el
Date: Wed, 10 Jul 2019 03:14:37 +0200

This patch fixes these warnings in make check:

  ELC      src/undo-tests.elc

In toplevel form:
src/undo-tests.el:262:6:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.
src/undo-tests.el:317:6:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.
src/undo-tests.el:353:47:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.
src/undo-tests.el:370:13:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.
src/undo-tests.el:394:19:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.
src/undo-tests.el:433:11:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.

(I'll send the patch in a separate message once this is assigned a bug
number.)

Thanks,
Stefan Kangas
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Wed, 10 Jul 2019 01:26:02 GMT) Full text and rfc822 format available.

Message #8 received at 36565 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 36565 <at> debbugs.gnu.org
Subject: Re: bug#36565: [PATCH] Suppress interactive-only warnings in
 undo-tests.el
Date: Wed, 10 Jul 2019 03:24:43 +0200

[Message part 1 (text/plain, inline)]
Stefan Kangas <stefan <at> marxist.se> writes:
> (I'll send the patch in a separate message once this is assigned a bug
> number.)

Patch attached.

Thanks,
Stefan Kangas

[0001-Suppress-interactive-only-warnings-in-undo-tests.el.patch (application/octet-stream, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Wed, 10 Jul 2019 03:41:02 GMT) Full text and rfc822 format available.

Message #11 received at 36565 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 36565 <at> debbugs.gnu.org
Subject: Re: bug#36565: [PATCH] Suppress interactive-only warnings in
 undo-tests.el
Date: Wed, 10 Jul 2019 05:40:02 +0200

[Message part 1 (text/plain, inline)]
Stefan Kangas <stefan <at> marxist.se> writes:
>
> Stefan Kangas <stefan <at> marxist.se> writes:
> > (I'll send the patch in a separate message once this is assigned a bug
> > number.)
>
> Patch attached.

1. Wrong patch attached, ugh.  Please find correct version attached.

2. This actually doesn't work due to an issue with with-suppressed-tests.
I have reported a separate Bug#36568 for this.

This patch therefore unfortunately would have no effect for now.

Thanks,
Stefan Kangas

[0001-Suppress-interactive-only-warnings-in-undo-tests.el.patch (application/octet-stream, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Wed, 10 Jul 2019 03:54:02 GMT) Full text and rfc822 format available.

Message #14 received at 36565 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 36565 <at> debbugs.gnu.org
Subject: Re: bug#36565: [PATCH] Suppress interactive-only warnings in
 undo-tests.el
Date: Wed, 10 Jul 2019 05:53:21 +0200

[Message part 1 (text/plain, inline)]
Correct patch attached -- third attempt.

(Sorry about the noise -- it was created in the "test" subdirectory
and I mixed it up.)

[0001-Suppress-interactive-only-warnings-in-undo-tests.el-.patch (application/octet-stream, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Wed, 10 Jul 2019 12:10:01 GMT) Full text and rfc822 format available.

Message #17 received at 36565 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36565 <at> debbugs.gnu.org
Subject: Re: bug#36565: [PATCH] Suppress interactive-only warnings in
 undo-tests.el
Date: Wed, 10 Jul 2019 14:09:43 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> This patch fixes these warnings in make check:
>
>   ELC      src/undo-tests.elc
>
> In toplevel form:
> src/undo-tests.el:262:6:Warning: `delete-forward-char' is for interactive use
>     only; use `delete-char' instead.

Hm...  is it worth it to suppress warnings in the tests, though?  I
think we kinda expect there to be a lot of noise when running the tests?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Wed, 10 Jul 2019 22:54:02 GMT) Full text and rfc822 format available.

Message #20 received at 36565 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 36565 <at> debbugs.gnu.org
Subject: Re: bug#36565: [PATCH] Suppress interactive-only warnings in
 undo-tests.el
Date: Thu, 11 Jul 2019 00:53:01 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> Hm...  is it worth it to suppress warnings in the tests, though?  I
> think we kinda expect there to be a lot of noise when running the tests?

I'm not sure I understand.  Do you mean that you're not sure if it's
worth it to fix warnings in the Emacs test suite, or do you mean
fixing with-suppressed-warnings to handle this case?

Best regards,
Stefan Kangas
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Thu, 11 Jul 2019 14:12:03 GMT) Full text and rfc822 format available.

Message #23 received at 36565 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36565 <at> debbugs.gnu.org
Subject: Re: bug#36565: [PATCH] Suppress interactive-only warnings in
 undo-tests.el
Date: Thu, 11 Jul 2019 16:11:25 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>> Hm...  is it worth it to suppress warnings in the tests, though?  I
>> think we kinda expect there to be a lot of noise when running the tests?
>
> I'm not sure I understand.  Do you mean that you're not sure if it's
> worth it to fix warnings in the Emacs test suite, or do you mean
> fixing with-suppressed-warnings to handle this case?

I meant the first.  I mean, I'm not opposed to it or anything, but my
opinion is that aiming for a warning-free test suite would be to put
an undue burden on the test writers for little gain.  (When we're used
to having a warning-free build, then any warning sticks out like a sore
thumb and is generally fixed pretty quickly...)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Thu, 11 Jul 2019 17:32:02 GMT) Full text and rfc822 format available.

Message #26 received at 36565 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 36565 <at> debbugs.gnu.org
Subject: Re: bug#36565: [PATCH] Suppress interactive-only warnings in
 undo-tests.el
Date: Thu, 11 Jul 2019 19:31:19 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I mean, I'm not opposed to it or anything, but my
> opinion is that aiming for a warning-free test suite would be to put
> an undue burden on the test writers for little gain.

Thanks for clarifying, and I fully agree.

Best regards,
Stefan Kangas
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Wed, 17 Jul 2019 20:09:02 GMT) Full text and rfc822 format available.

Message #29 received at 36565 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36565 <at> debbugs.gnu.org
Subject: Re: bug#36565: [PATCH] Suppress interactive-only warnings in
 undo-tests.el
Date: Wed, 17 Jul 2019 16:08:20 -0400

Stefan Kangas <stefan <at> marxist.se> writes:

>      (undo-boundary)
> -    (delete-forward-char 1)
> +    (with-suppressed-warnings
> +        ((interactive-only delete-forward-char))
> +      (delete-forward-char 1))

Perhaps it would be better to use funcall-interactively?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Sun, 04 Aug 2019 16:47:02 GMT) Full text and rfc822 format available.

Message #32 received at 36565 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 36565 <at> debbugs.gnu.org
Subject: Re: bug#36565: [PATCH] Suppress interactive-only warnings in
 undo-tests.el
Date: Sun, 4 Aug 2019 18:46:30 +0200

[Message part 1 (text/plain, inline)]
Noam Postavsky <npostavs <at> gmail.com> writes:

> Perhaps it would be better to use funcall-interactively?

Good idea.  How about the attached patch?

Thanks,
Stefan Kangas

[0001-Suppress-interactive-only-warnings-in-undo-tests.el-.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36565; Package emacs. (Thu, 08 Aug 2019 12:31:01 GMT) Full text and rfc822 format available.

Message #35 received at 36565 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36565 <at> debbugs.gnu.org
Subject: Re: bug#36565: [PATCH] Suppress interactive-only warnings in
 undo-tests.el
Date: Thu, 08 Aug 2019 08:30:07 -0400

tags 36565 fixed
close 36565 27.1
quit

>> Perhaps it would be better to use funcall-interactively?
>
> Good idea.  How about the attached patch?

Pushed to master.

2c0f6c3540 2019-08-08T08:26:31-04:00 "Suppress interactive-only warnings in undo-tests.el (Bug#36565)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2c0f6c3540ccad4b5832e9e00ece483a6a456bbb
Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 08 Aug 2019 12:31:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 27.1, send any further explanations to 36565 <at> debbugs.gnu.org and Stefan Kangas <stefan <at> marxist.se> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 08 Aug 2019 12:31:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 06 Sep 2019 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 234 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.