GNU bug report logs - #36603
[PATCH] Simplify calling convention of describe_map

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36603 in the body.
You can then email your comments to 36603 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Simplify calling convention of describe_map
Date: Thu, 11 Jul 2019 19:34:22 +0200

This patch simplifies the calling convention of describe_map in
keymap.c.

The immediate motivation is to simplify a set of patches that I'm
preparing for Bug#8951 to rewrite substitute-command-keys in Lisp.
But I think this makes sense in any case.

(I'll send the patch in a separate message once this is assigned a bug
number.)

Thanks,
Stefan Kangas

Message #8 received at 36603 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 36603 <at> debbugs.gnu.org
Subject: Re: bug#36603: [PATCH] Simplify calling convention of describe_map
Date: Thu, 11 Jul 2019 19:37:44 +0200

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefan <at> marxist.se> writes:
> (I'll send the patch in a separate message once this is assigned a bug
> number.)

Patch attached.

Thanks,
Stefan Kangas

[0001-Simplify-calling-convention-of-describe_map-Bug-3660.patch (text/x-patch, attachment)]

Message #11 received at 36603 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36603 <at> debbugs.gnu.org
Subject: Re: bug#36603: [PATCH] Simplify calling convention of describe_map
Date: Tue, 20 Aug 2019 11:32:52 -0400

Stefan Kangas <stefan <at> marxist.se> writes:

> +  Lisp_Object seen_orig = Qnil;
> +  Lisp_Object *seen = &seen_orig;

Do we really need the seen_orig variable?  It looks like there is no
reason for having seen as a pointer at all, but maybe I'm missing
something.

Message #14 received at 36603 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36603 <at> debbugs.gnu.org
Subject: Re: bug#36603: [PATCH] Simplify calling convention of describe_map
Date: Tue, 20 Aug 2019 12:00:35 -0400

Noam Postavsky <npostavs <at> gmail.com> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>> +  Lisp_Object seen_orig = Qnil;
>> +  Lisp_Object *seen = &seen_orig;
>
> Do we really need the seen_orig variable?  It looks like there is no
> reason for having seen as a pointer at all, but maybe I'm missing
> something.

Actually, maybe the patch is wrong (i.e., over-simplifying), because it
has describe_map start with a fresh seen pointer each time; but the
current code passes the same pointer to each describe_map call in a
loop.

Message #17 received at 36603 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 36603 <at> debbugs.gnu.org
Subject: Re: bug#36603: [PATCH] Simplify calling convention of describe_map
Date: Tue, 20 Aug 2019 18:02:56 +0200

Noam Postavsky <npostavs <at> gmail.com> writes:
>
> Noam Postavsky <npostavs <at> gmail.com> writes:
>
> > Stefan Kangas <stefan <at> marxist.se> writes:
> >
> >> +  Lisp_Object seen_orig = Qnil;
> >> +  Lisp_Object *seen = &seen_orig;
> >
> > Do we really need the seen_orig variable?  It looks like there is no
> > reason for having seen as a pointer at all, but maybe I'm missing
> > something.
>
> Actually, maybe the patch is wrong (i.e., over-simplifying), because it
> has describe_map start with a fresh seen pointer each time; but the
> current code passes the same pointer to each describe_map call in a
> loop.

Thanks for that feedback.  I'll take another look and get back to you.

Best regards,
Stefan Kangas

Message #22 received at 36603-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 36603-done <at> debbugs.gnu.org
Subject: Re: bug#36603: [PATCH] Simplify calling convention of describe_map
Date: Mon, 11 Nov 2019 19:44:29 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

>> Actually, maybe the patch is wrong (i.e., over-simplifying), because it
>> has describe_map start with a fresh seen pointer each time; but the
>> current code passes the same pointer to each describe_map call in a
>> loop.
>
> Thanks for that feedback.  I'll take another look and get back to you.

I think your analysis is correct Noam, and I'm working on a different
approach here, although this project is has been put on the
back-burner for now.  I'll get back into it once I can finish up some
other things first.

Thanks for taking the time to review this.  Closing this bug report.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.