GNU bug report logs - #36607
[PATCH 0/2] Add pngquant and libimagequant required by it.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36607 in the body.
You can then email your comments to 36607 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Add pngquant and libimagequant required by it.
Date: Thu, 11 Jul 2019 22:29:45 +0200

Add pngquant and libimagequant required by it.

Hartmut Goebel (2):
  gnu: Add libimagequant.
  gnu: Add pngquant.

 gnu/packages/image.scm | 68 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 67 insertions(+), 1 deletion(-)

-- 
2.21.0

Message #8 received at 36607 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 36607 <at> debbugs.gnu.org
Subject: [PATCH 0/2] Add pngquant and libimagequant required by it.
Date: Thu, 11 Jul 2019 22:39:09 +0200

Add pngquant and libimagequant required by it.

Hartmut Goebel (2):
  gnu: Add libimagequant.
  gnu: Add pngquant.

 gnu/packages/image.scm | 68 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 67 insertions(+), 1 deletion(-)

-- 
2.21.0

Message #11 received at 36607 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 36607 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: Add libimagequant.
Date: Thu, 11 Jul 2019 22:39:10 +0200

* gnu/packages/image.scm (libimagequant): New variable.
---
 gnu/packages/image.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index fabc2fb2d1..5a5174354c 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -14,7 +14,7 @@
 ;;; Copyright © 2016, 2017 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2016, 2017 Kei Kebreau <kkebreau <at> posteo.net>
 ;;; Copyright © 2017 ng0 <ng0 <at> n0.is>
-;;; Copyright © 2017 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
+;;; Copyright © 2017,2019 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
 ;;; Copyright © 2017 Julien Lepiller <julien <at> lepiller.eu>
 ;;; Copyright © 2018 Joshua Sierles, Nextjournal <joshua <at> nextjournal.com>
 ;;; Copyright © 2018 Fis Trivial <ybbs.daans <at> hotmail.com>
@@ -313,6 +313,28 @@ files.  It can compress them as much as 40% losslessly.")
 Currently all documentation resides in @file{pnglite.h}.")
       (license license:zlib))))
 
+(define-public libimagequant
+  (package
+   (name "libimagequant")
+   (version "2.12.3")
+   (source
+    (origin
+      (method git-fetch)
+      (uri (git-reference
+            (url "https://github.com/ImageOptim/libimagequant.git")
+            (commit version)))
+      (file-name (git-file-name name version))
+      (sha256
+       (base32 "0qsfq1kv1m5jzn9v9iz0bac66k4clcis1c9877qabnwzwmwma5v0"))))
+   (build-system gnu-build-system)
+   (arguments
+    '(#:tests? #f)) ; no check target
+   (home-page "https://pngquant.org/lib/")
+   (synopsis "Image palette quantization library")
+   (description "Small, portable C library for high-quality conversion of RGBA
+images to 8-bit indexed-color (palette) images.")
+   (license license:gpl3)))
+
 (define-public libjpeg
   (package
    (name "libjpeg")
-- 
2.21.0

Message #14 received at 36607 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 36607 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add pngquant.
Date: Thu, 11 Jul 2019 22:39:11 +0200

* gnu/packages/image.scm (pngquant): New variable.
---
 gnu/packages/image.scm | 44 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 5a5174354c..bfbf7ea823 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -335,6 +335,50 @@ Currently all documentation resides in @file{pnglite.h}.")
 images to 8-bit indexed-color (palette) images.")
    (license license:gpl3)))
 
+(define-public pngquant
+  (package
+   (name "pngquant")
+   (version "2.12.3")
+   (source
+    (origin
+      (method git-fetch)
+      (uri (git-reference
+            (url "https://github.com/kornelski/pngquant.git")
+            (commit version)))
+      (file-name (git-file-name name version))
+      (sha256
+       (base32 "1yiwbcihn4311fpfd568gg8zmmhqwg80jmhbhkb5msiipgd9xv33"))))
+   (build-system gnu-build-system)
+   (arguments
+    `(#:test-target "test"
+      #:configure-flags
+      '("--with-openmp" "--with-lcms2")))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (inputs
+    `(("libpng" ,libpng)
+      ("zlib" , zlib)
+      ("lcms" ,lcms)
+      ("libimagequant" ,libimagequant)))
+   (home-page "https://pngquant.org/")
+   (synopsis "Utility and library for lossy compressing PNG images")
+   (description "pngquant is a PNG compressor that significantly reduces file
+sizes by converting images to a more efficient 8-bit PNG format with alpha
+channel (often 60-80% smaller than 24/32-bit PNG files).  Compressed images
+are fully standards-compliant and are supported by all web browsers and
+operating systems.
+
+Features:
+@enumerate
+@item High-quality palette generation using a combination of vector
+      quantization algorithms.
+@item Unique adaptive dithering algorithm that adds less noise to images
+      than the standard Floyd-Steinberg.
+@item Easy to integrate with shell scripts, GUIs and server-side software.
+@item Fast mode for real-time processing/large numbers of images.
+@end enumerate")
+   (license license:gpl3)))
+
 (define-public libjpeg
   (package
    (name "libjpeg")
-- 
2.21.0

Message #17 received at 36607 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 36607 <at> debbugs.gnu.org
Subject: Re: [bug#36607] [PATCH 1/2] gnu: Add libimagequant.
Date: Sat, 13 Jul 2019 14:52:42 +0200

Hi Hartmut,

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> * gnu/packages/image.scm (libimagequant): New variable.
> +(define-public libimagequant
> +  (package
> +   (name "libimagequant")
      ^
Nitpick: fields should be one column further to the right.  (Maybe just
run ./etc/indent-code.el.)

> +   (home-page "https://pngquant.org/lib/")
> +   (synopsis "Image palette quantization library")
> +   (description "Small, portable C library for high-quality conversion of RGBA
> +images to 8-bit indexed-color (palette) images.")

Please write a full sentence (or two :-)).

> +   (license license:gpl3)))

It should be ‘gpl3+’ per ‘COPYRIGHT’.

OK to push with these changes, thanks!

Ludo’.

Message #20 received at 36607 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 36607 <at> debbugs.gnu.org
Subject: Re: [bug#36607] [PATCH 2/2] gnu: Add pngquant.
Date: Sat, 13 Jul 2019 14:53:57 +0200

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> * gnu/packages/image.scm (pngquant): New variable.
> +(define-public pngquant
> +  (package
> +   (name "pngquant")
      ^
Missing space.  :-)

> +   (license license:gpl3)))

This one’s also ‘gpl3+’.

OK with these changes, thank you!

Ludo’.

Message #25 received at 36607-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36607-close <at> debbugs.gnu.org
Subject: Re: [bug#36607] [PATCH 1/2] gnu: Add libimagequant.
Date: Sat, 13 Jul 2019 20:06:16 +0200

Thansk for the review. Fixed and pushe as
6b61dea3365e8cbb6d5a918df5288489e27854e2

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.