GNU bug report logs - #36628
Minor fixes for pngcrush and python-aiorpcx

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36628 in the body.
You can then email your comments to 36628 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arne Babenhauserheide <arne_bab <at> web.de>
To: guix-patches <at> gnu.org
Subject: Minor fixes for pngcrush and python-aiorpcx
Date: Fri, 12 Jul 2019 23:41:08 +0200

Hi,

The following two patches are just fixing a typo and making guix lint happier.

Happy Hacking!
- Arne

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arne Babenhauserheide <arne_bab <at> web.de>
To: guix-patches <at> gnu.org
Cc: Arne Babenhauserheide <arne_bab <at> web.de>
Subject: [PATCH 1/2] gnu: pngcrush: fix typo in description
Date: Fri, 12 Jul 2019 23:41:09 +0200

* gnu/packages/image.scm (pngcrush): fix typo in description
---
 gnu/packages/image.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 511f5302b7..b465ff376e 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -250,7 +250,7 @@ APNG patch provides APNG support to libpng.")
       ("zlib" , zlib)))
    (home-page "https://pmt.sourceforge.io/pngcrush")
    (synopsis "Utility to compress PNG files")
-   (description "pngcrusqh is an optimizer for PNG (Portable Network Graphics)
+   (description "pngcrush is an optimizer for PNG (Portable Network Graphics)
 files.  It can compress them as much as 40% losslessly.")
    (license license:zlib)))

--
2.22.0

Message #11 received at 36628 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: arne_bab <at> web.de
Cc: 36628 <at> debbugs.gnu.org
Subject: Re: [bug#36628] [PATCH 1/2] gnu: pngcrush: fix typo in description
Date: Sat, 13 Jul 2019 00:19:04 +0200

[Message part 1 (text/plain, inline)]

Arne,

Arne Babenhauserheide wrote:
> * gnu/packages/image.scm (pngcrush): fix typo in description
> ---
>  gnu/packages/image.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
> index 511f5302b7..b465ff376e 100644
> --- a/gnu/packages/image.scm
> +++ b/gnu/packages/image.scm
> @@ -250,7 +250,7 @@ APNG patch provides APNG support to 
> libpng.")
>        ("zlib" , zlib)))
>     (home-page "https://pmt.sourceforge.io/pngcrush")
>     (synopsis "Utility to compress PNG files")
> -   (description "pngcrusqh is an optimizer for PNG (Portable 
> Network Graphics)
> +   (description "pngcrush is an optimizer for PNG (Portable 
> Network Graphics)
>  files.  It can compress them as much as 40% losslessly.")
>     (license license:zlib)))

Thanks!  I was going to quickly apply these two before sleepytimes 
but noticed that your other patch changes the description (only) 
to begin with a capital letter, while this one remains lowercase. 
Is that deliberate?

I also couldn't help myself and kept editing...  What do you think 
of the following?  (It's still awfully short but that's another 
issue.)

--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -250,8 +250,8 @@ APNG patch provides APNG support to libpng.")
      ("zlib" , zlib)))
   (home-page "https://pmt.sourceforge.io/pngcrush")
   (synopsis "Utility to compress PNG files")
-   (description "pngcrusqh is an optimizer for PNG (Portable 
   Network Graphics)
-files.  It can compress them as much as 40% losslessly.")
+   (description "Pngcrush optimizes @acronym{PNG, Portable 
Network Graphics}
+images.  It can losslessly compress files by as much as an 
additional 40%.")
   (license license:zlib)))

Or something,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 36628 <at> debbugs.gnu.org (full text, mbox):

From: Arne Babenhauserheide <arne_bab <at> web.de>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 36628 <at> debbugs.gnu.org
Subject: Re: [bug#36628] [PATCH 1/2] gnu: pngcrush: fix typo in description
Date: Sat, 13 Jul 2019 09:12:56 +0200

[Message part 1 (text/plain, inline)]

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> Arne,
>
> Arne Babenhauserheide wrote:
>> * gnu/packages/image.scm (pngcrush): fix typo in description
>> ---
>>  gnu/packages/image.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
>> index 511f5302b7..b465ff376e 100644
>> --- a/gnu/packages/image.scm
>> +++ b/gnu/packages/image.scm
>> @@ -250,7 +250,7 @@ APNG patch provides APNG support to libpng.")
>>        ("zlib" , zlib)))
>>     (home-page "https://pmt.sourceforge.io/pngcrush")
>>     (synopsis "Utility to compress PNG files")
>> -   (description "pngcrusqh is an optimizer for PNG (Portable
>> Network Graphics)
>> +   (description "pngcrush is an optimizer for PNG (Portable Network
>> Graphics)
>>  files.  It can compress them as much as 40% losslessly.")
>>     (license license:zlib)))
>
> Thanks!  I was going to quickly apply these two before sleepytimes but
> noticed that your other patch changes the description (only) to begin
> with a capital letter, while this one remains lowercase. Is that
> deliberate?

For the other one guix lint complained, here it did not (maybe because
it started with exactly the package name?). That’s the only reason.

> I also couldn't help myself and kept editing...  What do you think of
> the following?  (It's still awfully short but that's another issue.)
>
> --- a/gnu/packages/image.scm
> +++ b/gnu/packages/image.scm
> @@ -250,8 +250,8 @@ APNG patch provides APNG support to libpng.")
>       ("zlib" , zlib)))
>    (home-page "https://pmt.sourceforge.io/pngcrush")
>    (synopsis "Utility to compress PNG files")
> -   (description "pngcrusqh is an optimizer for PNG (Portable  Network
> Graphics)
> -files.  It can compress them as much as 40% losslessly.")
> +   (description "Pngcrush optimizes @acronym{PNG, Portable Network
> Graphics}
> +images.  It can losslessly compress files by as much as an additional
> 40%.")
>    (license license:zlib)))

That sounds better. I think the correct English is "compress losslessly"
and not "losslessly compress", but aside from that it’s much more crisp.

I don’t think that being short is a problem, rather the opposite: if
it’s easy to read and provides the information needed, short is
often better.

So go for it! :)

Best wishes,
Arne
--
Unpolitisch sein
heißt politisch sein
ohne es zu merken

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.