GNU bug report logs - #36658
[PATCH] gnu: Add emacs-zerodark-theme.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36658 in the body.
You can then email your comments to 36658 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Giacomo Leidi <goodoldpaul <at> autistici.org>
To: guix-patches <at> gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>
Subject: [PATCH] gnu: Add emacs-zerodark-theme.
Date: Mon, 15 Jul 2019 11:28:18 +0200

* gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable.
---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 47edbaeeb6..0376dc5069 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -49,6 +49,7 @@
 ;;; Copyright © 2019 LaFreniere, Joseph <joseph <at> lafreniere.xyz>
 ;;; Copyright © 2019 Amar Singh <nly <at> disroot.org>
 ;;; Copyright © 2019 Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
+;;; Copyright © 2019 Giacomo Leidi <goodoldpaul <at> autitici.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -16564,3 +16565,29 @@ directories, direct visualisation of image files, jumping directly to links by
 name (with autocompletion), a simple bookmark management system and
 connections using TLS encryption.")
     (license license:gpl3+)))
+
+(define-public emacs-zerodark-theme
+  (package
+  (name "emacs-zerodark-theme")
+  (version "20190528.923")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "https://melpa.org/packages/zerodark-theme-"
+             version
+             ".el"))
+      (sha256
+        (base32
+          "0ajmkf6y7lvxr89cliq194qb8vzfgx4qj5c34b1pr5lrrxxaws0h"))))
+  (build-system emacs-build-system)
+  (propagated-inputs
+    `(("emacs-all-the-icons" ,emacs-all-the-icons)))
+  (home-page
+    "https://github.com/NicolasPetton/zerodark-theme")
+  (synopsis
+    "A dark, medium contrast theme for Emacs")
+  (description
+    "A dark theme inspired from One Dark and Niflheim.
+An optional mode-line format can be enabled with 'zerodark-setup-modeline-format'.")
+  (license license:gpl3+)))
-- 
2.22.0

Message #8 received at 36658 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Giacomo Leidi <goodoldpaul <at> autistici.org>
Cc: 36658 <at> debbugs.gnu.org
Subject: Re: [bug#36658] [PATCH] gnu: Add emacs-zerodark-theme.
Date: Wed, 17 Jul 2019 15:35:14 +0200

Hello,

Giacomo Leidi <goodoldpaul <at> autistici.org> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable.

Thanks for this patch!  Below are a couple of suggestions.

> +(define-public emacs-zerodark-theme
> +  (package
> +  (name "emacs-zerodark-theme")
     ^
The indentation is off here (you can do M-q to fix it if you use
paredit).

> +  (version "20190528.923")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "https://melpa.org/packages/zerodark-theme-"
> +             version
> +             ".el"))

This URL is unstable: the file will be modified in place regularly.
Consequently, could you instead use the upstream Git repository URL
along with the ‘git-fetch’ method?

> +  (synopsis
> +    "A dark, medium contrast theme for Emacs")
        ^
Please remove “A”, as suggested by ‘guix lint’.

> +  (description
> +    "A dark theme inspired from One Dark and Niflheim.

Please write a full sentence (info "(guix) Synopses and Descriptions").

> +An optional mode-line format can be enabled with 'zerodark-setup-modeline-format'.")
                                                    ^
Please use @code as suggested by ‘guix lint’.

Could you send an updated patch?

Thanks!

Ludo’.

Message #11 received at 36658 <at> debbugs.gnu.org (full text, mbox):

From: Tino il Cotechino <goodoldpaul <at> autistici.org>
To: 36658 <at> debbugs.gnu.org
Subject: Re: [bug#36658] [PATCH] gnu: Add emacs-zerodark-theme.
Date: Fri, 19 Jul 2019 12:30:23 +0200

[Message part 1 (text/plain, inline)]

Hello,

I'm not sure why but I was convinced that guix import would run guix
lint on the generated package, so I didn't even try to run it. I'll pay
more attention next time.

The attached patch should fix all previous problems.

Thank you for your review!

Giacomo




On Wed, 2019-07-17 at 15:35 +0200, Ludovic Courtès wrote:
> Hello,
> 
> Giacomo Leidi <goodoldpaul <at> autistici.org> skribis:
> 
> > * gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable.
> 
> Thanks for this patch!  Below are a couple of suggestions.
> 
> > +(define-public emacs-zerodark-theme
> > +  (package
> > +  (name "emacs-zerodark-theme")
> 
>      ^
> The indentation is off here (you can do M-q to fix it if you use
> paredit).
> 
> > +  (version "20190528.923")
> > +  (source
> > +    (origin
> > +      (method url-fetch)
> > +      (uri (string-append
> > +             "https://melpa.org/packages/zerodark-theme-"
> > +             version
> > +             ".el"))
> 
> This URL is unstable: the file will be modified in place regularly.
> Consequently, could you instead use the upstream Git repository URL
> along with the ‘git-fetch’ method?
> 
> > +  (synopsis
> > +    "A dark, medium contrast theme for Emacs")
> 
>         ^
> Please remove “A”, as suggested by ‘guix lint’.
> 
> > +  (description
> > +    "A dark theme inspired from One Dark and Niflheim.
> 
> Please write a full sentence (info "(guix) Synopses and
> Descriptions").
> 
> > +An optional mode-line format can be enabled with 'zerodark-setup-
> > modeline-format'.")
> 
>                                                     ^
> Please use @code as suggested by ‘guix lint’.
> 
> Could you send an updated patch?
> 
> Thanks!
> 
> Ludo’.

[0001-gnu-Add-emacs-zerodark-theme.patch (text/x-patch, attachment)]

Message #16 received at 36658-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tino il Cotechino <goodoldpaul <at> autistici.org>
Cc: 36658-done <at> debbugs.gnu.org
Subject: Re: [bug#36658] [PATCH] gnu: Add emacs-zerodark-theme.
Date: Sat, 20 Jul 2019 00:59:28 +0200

Hi,

Tino il Cotechino <goodoldpaul <at> autistici.org> skribis:

> From 392b3a7c34198f47f19fb6b678662971aa8a371f Mon Sep 17 00:00:00 2001
> From: Giacomo Leidi <goodoldpaul <at> autistici.org>
> Date: Mon, 15 Jul 2019 11:21:24 +0200
> Subject: [PATCH] gnu: Add emacs-zerodark-theme.
>
> * gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.