GNU bug report logs - #36707
[PATCH] Signal user-error on duplicate package refresh

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36707 in the body.
You can then email your comments to 36707 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Signal user-error on duplicate package refresh
Date: Wed, 17 Jul 2019 20:02:25 +0200

In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times
it will try to initiate more refreshes even if the first one has not finished
yet.  This is unnecessary and potentially confusing.

This patch makes it check if there is already an refresh in progress and signal
a user-error if there is one.

(I'll send the patch in a separate message once this is assigned a bug
number.)

Thanks,
Stefan Kangas

Message #8 received at 36707 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 36707 <at> debbugs.gnu.org
Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh
Date: Wed, 17 Jul 2019 20:10:12 +0200

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefan <at> marxist.se> writes:
> (I'll send the patch in a separate message once this is assigned a bug
> number.)

Patch attached.

Thanks,
Stefan Kangas

[0001-Signal-a-user-error-on-duplicate-package-refresh.patch (application/octet-stream, attachment)]

Message #11 received at 36707 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36707 <at> debbugs.gnu.org
Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh
Date: Thu, 18 Jul 2019 22:14:55 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times
> it will try to initiate more refreshes even if the first one has not finished
> yet.  This is unnecessary and potentially confusing.
>
> This patch makes it check if there is already an refresh in progress and signal
> a user-error if there is one.

Would it not be possible/better to discard the existing refresh and
start a new one, instead of signalling an error?  This would help
e.g. when a refresh hangs for whatever reason.

Thanks,

-- 
Basil

Message #14 received at 36707 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 36707 <at> debbugs.gnu.org, Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh
Date: Thu, 08 Aug 2019 20:16:13 -0400

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times
>> it will try to initiate more refreshes even if the first one has not finished
>> yet.  This is unnecessary and potentially confusing.
>>
>> This patch makes it check if there is already an refresh in progress and signal
>> a user-error if there is one.
>
> Would it not be possible/better to discard the existing refresh and
> start a new one, instead of signalling an error?  This would help
> e.g. when a refresh hangs for whatever reason.

Not sure if it's better, supposing the user is hitting "r" repeatedly,
that just interrupts the pending refreshes, preventing any progress.  I
would expect hanging to be cancelled by a timeout anyway.

Message #17 received at 36707 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 36707 <at> debbugs.gnu.org
Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh
Date: Mon, 12 Aug 2019 02:35:28 +0200

Noam Postavsky <npostavs <at> gmail.com> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
> > Stefan Kangas <stefan <at> marxist.se> writes:
> >
> >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times
> >> it will try to initiate more refreshes even if the first one has not finished
> >> yet.  This is unnecessary and potentially confusing.
> >>
> >> This patch makes it check if there is already an refresh in progress and signal
> >> a user-error if there is one.
> >
> > Would it not be possible/better to discard the existing refresh and
> > start a new one, instead of signalling an error?  This would help
> > e.g. when a refresh hangs for whatever reason.
>
> Not sure if it's better, supposing the user is hitting "r" repeatedly,
> that just interrupts the pending refreshes, preventing any progress.  I
> would expect hanging to be cancelled by a timeout anyway.

I agree with Noam that a timeout would make more sense.  Not sure if
it already exists or if that's a separate issue.

Thanks,
Stefan Kangas

Message #20 received at 36707 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 36707 <at> debbugs.gnu.org
Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh
Date: Sun, 18 Aug 2019 20:18:05 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> Noam Postavsky <npostavs <at> gmail.com> writes:
>
> > "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
> >
> > > Stefan Kangas <stefan <at> marxist.se> writes:
> > >
> > >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times
> > >> it will try to initiate more refreshes even if the first one has not finished
> > >> yet.  This is unnecessary and potentially confusing.
> > >>
> > >> This patch makes it check if there is already an refresh in progress and signal
> > >> a user-error if there is one.
> > >
> > > Would it not be possible/better to discard the existing refresh and
> > > start a new one, instead of signalling an error?  This would help
> > > e.g. when a refresh hangs for whatever reason.
> >
> > Not sure if it's better, supposing the user is hitting "r" repeatedly,
> > that just interrupts the pending refreshes, preventing any progress.  I
> > would expect hanging to be cancelled by a timeout anyway.
>
> I agree with Noam that a timeout would make more sense.  Not sure if
> it already exists or if that's a separate issue.

Are there any other objections to the patch?  Otherwise, I'll go ahead
and push it in a few days.

Thanks,
Stefan Kangas

Message #23 received at 36707 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 36707 <at> debbugs.gnu.org
Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh
Date: Thu, 22 Aug 2019 19:04:30 +0200

close 36707 27.1
quit

Stefan Kangas <stefan <at> marxist.se> writes:

> Are there any other objections to the patch?  Otherwise, I'll go ahead
> and push it in a few days.

I've now pushed this as commit a6d87ea045.  Closing the report.

Thanks,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.