GNU bug report logs - #36712
27.0.50; nnimap unconditionally setting marks in a loop

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36712 in the body.
You can then email your comments to 36712 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; nnimap unconditionally setting marks in a loop
Date: Wed, 17 Jul 2019 18:09:45 -0700

[Message part 1 (text/plain, inline)]

I started doing some very basic profiling of Gnus, and noticed that
getting new mail was resulting in a couple thousand calls to
`gnus-info-set-entry', as well as some of the range manipulation
functions.

It looks like updating IMAP group marks using qresync would loop over
all possible flag/mark pairs and unconditionally set everything, even
when there was nothing to set. With fewer than 100 IMAP groups in total,
that was a couple thousand extra function calls. Most of them with nil
arguments, but still.

I'm not super familiar with the code in question, but the attached diff
looks like it will pull the qresync behavior in line with the
non-qresync behavior, so I'm hoping it's correct. It cuts way down on
function calls, anyway!




In GNU Emacs 27.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.10)
 of 2019-07-15 built on slip
Repository revision: c687f25ee24bd29d623a23819eef930937252b25
Windowing system distributor 'The X.Org Foundation', version 11.0.12005000
System Description:	Arch Linux

[nnimap-dont-add-marks.diff (text/x-patch, attachment)]

Message #8 received at 36712 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: 36712 <at> debbugs.gnu.org
Subject: Re: bug#36712: Acknowledgement (27.0.50; nnimap unconditionally
 setting marks in a loop)
Date: Thu, 25 Jul 2019 08:32:05 -0700

Well, I'm fairly sure now this is the right thing to do. I'll leave this
open for a few more days, then push a fix.

Message #11 received at 36712 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 36712 <at> debbugs.gnu.org
Subject: Re: bug#36712: Acknowledgement (27.0.50; nnimap unconditionally
 setting marks in a loop)
Date: Thu, 25 Jul 2019 19:03:58 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Well, I'm fairly sure now this is the right thing to do. I'll leave this
> open for a few more days, then push a fix.

I think your patch looks correct...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 36712 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 36712 <at> debbugs.gnu.org, 36712-done <at> debbugs.gnu.org
Subject: Re: bug#36712: Acknowledgement (27.0.50; nnimap unconditionally
 setting marks in a loop)
Date: Thu, 25 Jul 2019 12:26:34 -0700

On 07/25/19 19:03 PM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Well, I'm fairly sure now this is the right thing to do. I'll leave this
>> open for a few more days, then push a fix.
>
> I think your patch looks correct...

Okay, I went ahead and pushed it.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.