Received: (at 36731) by debbugs.gnu.org; 22 Jul 2019 10:31:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 22 06:31:21 2019
Received: from localhost ([127.0.0.1]:59993 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hpVbE-0008RS-Ki
for submit <at> debbugs.gnu.org; Mon, 22 Jul 2019 06:31:20 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50693)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1hpVbD-0008RE-1w
for 36731 <at> debbugs.gnu.org; Mon, 22 Jul 2019 06:31:19 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:56148)
by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
id 1hpVb7-0002tl-JY; Mon, 22 Jul 2019 06:31:13 -0400
Received: from [2a01:e35:2ffd:930:d5d6:61ca:ae54:d991] (port=41444 helo=ribbon)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <ludo@HIDDEN>)
id 1hpVb5-0006cp-TI; Mon, 22 Jul 2019 06:31:13 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Mark H Weaver <mhw@HIDDEN>
Subject: Re: bug#36731: shepherd lost track of nginx
References: <E22C505B-4E64-4489-AE9C-8B19254B2BBD@HIDDEN>
<87ef2labds.fsf@HIDDEN> <871rykcniu.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 4 Thermidor an 227 de la =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Mon, 22 Jul 2019 12:31:06 +0200
In-Reply-To: <871rykcniu.fsf@HIDDEN> (Mark H. Weaver's message of "Sat, 20
Jul 2019 19:07:58 -0400")
Message-ID: <871ryi4az9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 36731
Cc: 36731 <at> debbugs.gnu.org, Robert Vollmert <rob@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi Mark,
Mark H Weaver <mhw@HIDDEN> skribis:
> Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
>
>> Robert Vollmert <rob@HIDDEN> skribis:
>>
>>> The result was this:
>>>
>>> $ sudo herd restart nginx
>>> Service nginx is not running.
>>> herd: exception caught while executing 'start' on service 'nginx':
>>> Throw to key `srfi-34' with args `("#<condition &invoke-error
>>> [program:
>>> \"/gnu/store/mlg0xfbiq03s812rm3v7mrlhyngas4xp-nginx-1.17.1/sbin/nginx\"
>>> arguments: (\"-c\"
>>> \"/gnu/store/r6gl9n7pwf4npiri05qxr40vdihdm2yy-nginx.conf\" \"-p\"
>>> \"/var/run/nginx\") exit-status: 1 term-signal: #f stop-signal: #f]
>>> 147e000>")=E2=80=99.
>
> [=E2=80=A6]
>
>>> That error message could also be clearer about what=E2=80=99s going on.=
At any
>>> rate, after I killed the nginx process, =E2=80=9Cherd start nginx=E2=80=
=9D worked fine.
>>
>> I agree that we could and should improve the error message.
>
> On the subject of this error message, why was the &invoke-error
> condition serialized to a string before apparently being embedded within
> another exception?
That serialization comes from the Shepherd when it talks to its clients
(see =E2=80=98write-reply=E2=80=99 in (shepherd comm)).
Normally service methods should write a human-readable message instead
of throwing an exception, but when that happens, shepherd serializes
those things so that one can at least diagnose the problem.
In this case we could use =E2=80=98report-invoke-error=E2=80=99 from (guix =
build utils)
on =E2=80=98core-updates=E2=80=99.
Thanks,
Ludo=E2=80=99.
bug-guix@HIDDEN:bug#36731; Package guix.
Full text available.
Received: (at 36731) by debbugs.gnu.org; 20 Jul 2019 23:10:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 20 19:10:22 2019
Received: from localhost ([127.0.0.1]:57991 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hoyUf-0008HX-Ng
for submit <at> debbugs.gnu.org; Sat, 20 Jul 2019 19:10:21 -0400
Received: from world.peace.net ([64.112.178.59]:34634)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mhw@HIDDEN>) id 1hoyUd-0008HL-Og
for 36731 <at> debbugs.gnu.org; Sat, 20 Jul 2019 19:10:20 -0400
Received: from mhw by world.peace.net with esmtpsa
(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)
(envelope-from <mhw@HIDDEN>)
id 1hoyUX-0006lB-Gh; Sat, 20 Jul 2019 19:10:13 -0400
From: Mark H Weaver <mhw@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#36731: shepherd lost track of nginx
References: <E22C505B-4E64-4489-AE9C-8B19254B2BBD@HIDDEN>
<87ef2labds.fsf@HIDDEN>
Date: Sat, 20 Jul 2019 19:07:58 -0400
In-Reply-To: <87ef2labds.fsf@HIDDEN> ("Ludovic
\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
\=\?utf-8\?Q\?s\?\= message of "Sat, 20 Jul 2019 00:49:03 +0200")
Message-ID: <871rykcniu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36731
Cc: 36731 <at> debbugs.gnu.org, Robert Vollmert <rob@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hello,
Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
> Robert Vollmert <rob@HIDDEN> skribis:
>
>> The result was this:
>>
>> $ sudo herd restart nginx
>> Service nginx is not running.
>> herd: exception caught while executing 'start' on service 'nginx':
>> Throw to key `srfi-34' with args `("#<condition &invoke-error
>> [program:
>> \"/gnu/store/mlg0xfbiq03s812rm3v7mrlhyngas4xp-nginx-1.17.1/sbin/nginx\"
>> arguments: (\"-c\"
>> \"/gnu/store/r6gl9n7pwf4npiri05qxr40vdihdm2yy-nginx.conf\" \"-p\"
>> \"/var/run/nginx\") exit-status: 1 term-signal: #f stop-signal: #f]
>> 147e000>")=E2=80=99.
[=E2=80=A6]
>> That error message could also be clearer about what=E2=80=99s going on. =
At any
>> rate, after I killed the nginx process, =E2=80=9Cherd start nginx=E2=80=
=9D worked fine.
>
> I agree that we could and should improve the error message.
On the subject of this error message, why was the &invoke-error
condition serialized to a string before apparently being embedded within
another exception? In other words, why did it print:
Throw to key `srfi-34' with args `("#<condition &invoke-error [program: \=
"/gnu/store/mlg0xfbiq03s812rm3v7mrlhyngas4xp-nginx-1.17.1/sbin/nginx\" argu=
ments: (\"-c\" \"/gnu/store/r6gl9n7pwf4npiri05qxr40vdihdm2yy-nginx.conf\" \=
"-p\" \"/var/run/nginx\") exit-status: 1 term-signal: #f stop-signal: #f] 1=
47e000>")=E2=80=99.
instead of something closer to:
Throw to key `srfi-34' with args `(#<condition &invoke-error [program: "/=
gnu/store/mlg0xfbiq03s812rm3v7mrlhyngas4xp-nginx-1.17.1/sbin/nginx" argumen=
ts: ("-c" "/gnu/store/r6gl9n7pwf4npiri05qxr40vdihdm2yy-nginx.conf" "-p" "/v=
ar/run/nginx") exit-status: 1 term-signal: #f stop-signal: #f] 147e000>)=E2=
=80=99.
We may want to go further in this specific case to make a user-friendly
error message, but in the more general case of printing arbitrary
exceptions, eliminating that second layer of string serialization would
help make the error reports a bit nicer to read.
What do you think?
Mark
bug-guix@HIDDEN:bug#36731; Package guix.
Full text available.
Received: (at 36731) by debbugs.gnu.org; 20 Jul 2019 13:51:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 20 09:51:57 2019
Received: from localhost ([127.0.0.1]:56945 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hopmG-0003rZ-Rn
for submit <at> debbugs.gnu.org; Sat, 20 Jul 2019 09:51:57 -0400
Received: from eggs.gnu.org ([209.51.188.92]:37945)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1hopmE-0003rM-So
for 36731 <at> debbugs.gnu.org; Sat, 20 Jul 2019 09:51:55 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:51010)
by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
id 1hopm8-0005XA-Ln; Sat, 20 Jul 2019 09:51:49 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41992 helo=ribbon)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <ludo@HIDDEN>)
id 1hopm8-0000CM-3i; Sat, 20 Jul 2019 09:51:48 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Robert Vollmert <rob@HIDDEN>
Subject: Re: bug#36731: shepherd lost track of nginx
References: <E22C505B-4E64-4489-AE9C-8B19254B2BBD@HIDDEN>
<87ef2labds.fsf@HIDDEN>
<78D8D737-8D4D-485D-8388-AD014C669FB9@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 2 Thermidor an 227 de la =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Sat, 20 Jul 2019 15:51:46 +0200
In-Reply-To: <78D8D737-8D4D-485D-8388-AD014C669FB9@HIDDEN> (Robert
Vollmert's message of "Sat, 20 Jul 2019 09:42:34 +0200")
Message-ID: <87d0i495l9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 36731
Cc: 36731 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi,
Robert Vollmert <rob@HIDDEN> skribis:
>>> $ sudo herd restart nginx
>>> Service nginx is not running.
>>> herd: exception caught while executing 'start' on service 'nginx':
>>> Throw to key `srfi-34' with args `("#<condition &invoke-error [program:=
\"/gnu/store/mlg0xfbiq03s812rm3v7mrlhyngas4xp-nginx-1.17.1/sbin/nginx\" ar=
guments: (\"-c\" \"/gnu/store/r6gl9n7pwf4npiri05qxr40vdihdm2yy-nginx.conf\"=
\"-p\" \"/var/run/nginx\") exit-status: 1 term-signal: #f stop-signal: #f]=
147e000>")=E2=80=99.
>>=20
>> Do you use an =E2=80=9Copaque=E2=80=9D nginx config file, or do you use =
<nginx-...>
>> records?
>
> The latter I think:
>
> (service nginx-service-type
> (nginx-configuration
> (extra-content =E2=80=9C=E2=80=A6=E2=80=9D)))
That=E2=80=99s actually the non-opaque variant, so shepherd should read the=
PID
file and it shouldn=E2=80=99t get it wrong. Not sure what happened.
If you can reproduce it, it would be great to gather the output of =E2=80=
=9Cherd
status nginx=E2=80=9D at the time shepherd is confused.
Thanks,
Ludo=E2=80=99.
bug-guix@HIDDEN:bug#36731; Package guix.
Full text available.
Received: (at 36731) by debbugs.gnu.org; 20 Jul 2019 07:42:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 20 03:42:52 2019
Received: from localhost ([127.0.0.1]:56784 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hok15-0007b1-Mi
for submit <at> debbugs.gnu.org; Sat, 20 Jul 2019 03:42:51 -0400
Received: from mx1.mailbox.org ([80.241.60.212]:22970)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <rob@HIDDEN>) id 1hok12-0007an-Tl
for 36731 <at> debbugs.gnu.org; Sat, 20 Jul 2019 03:42:50 -0400
Received: from smtp2.mailbox.org (smtp2.mailbox.org
[IPv6:2001:67c:2050:105:465:1:2:0])
(using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits))
(No client certificate requested)
by mx1.mailbox.org (Postfix) with ESMTPS id C7ABF503E6;
Sat, 20 Jul 2019 09:42:42 +0200 (CEST)
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp2.mailbox.org ([80.241.60.241])
by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de
[80.241.56.115]) (amavisd-new, port 10030)
with ESMTP id IcLQNVGu6K00; Sat, 20 Jul 2019 09:42:37 +0200 (CEST)
Content-Type: text/plain;
charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: bug#36731: shepherd lost track of nginx
From: Robert Vollmert <rob@HIDDEN>
In-Reply-To: <87ef2labds.fsf@HIDDEN>
Date: Sat, 20 Jul 2019 09:42:34 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <78D8D737-8D4D-485D-8388-AD014C669FB9@HIDDEN>
References: <E22C505B-4E64-4489-AE9C-8B19254B2BBD@HIDDEN>
<87ef2labds.fsf@HIDDEN>
To: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 36731
Cc: 36731 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> On 20. Jul 2019, at 00:49, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote:
>=20
> Hello,
>=20
> Robert Vollmert <rob@HIDDEN> skribis:
>=20
>> Not sure who=E2=80=99s at fault here, but without doing anything =
weird,
>> I ended up with a system where shepherd thought that nginx was
>> stopped, while there was still an nginx process around. I
>> certainly didn=E2=80=99t start it by hand.
>=20
> Did you try =E2=80=9Cherd status nginx=E2=80=9D to see shepherd=E2=80=99=
s notion of the nginx
> process?
Not at the time, no.
>=20
>> The result was this:
>>=20
>> $ sudo herd restart nginx
>> Service nginx is not running.
>> herd: exception caught while executing 'start' on service 'nginx':
>> Throw to key `srfi-34' with args `("#<condition &invoke-error =
[program: =
\"/gnu/store/mlg0xfbiq03s812rm3v7mrlhyngas4xp-nginx-1.17.1/sbin/nginx\" =
arguments: (\"-c\" =
\"/gnu/store/r6gl9n7pwf4npiri05qxr40vdihdm2yy-nginx.conf\" \"-p\" =
\"/var/run/nginx\") exit-status: 1 term-signal: #f stop-signal: #f] =
147e000>")=E2=80=99.
>=20
> Do you use an =E2=80=9Copaque=E2=80=9D nginx config file, or do you =
use <nginx-...>
> records?
The latter I think:
(service nginx-service-type
(nginx-configuration
(extra-content =E2=80=9C=E2=80=A6=E2=80=9D)))
bug-guix@HIDDEN:bug#36731; Package guix.
Full text available.
Received: (at 36731) by debbugs.gnu.org; 19 Jul 2019 22:49:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 19 18:49:15 2019
Received: from localhost ([127.0.0.1]:56632 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hobgh-0000u2-AV
for submit <at> debbugs.gnu.org; Fri, 19 Jul 2019 18:49:15 -0400
Received: from eggs.gnu.org ([209.51.188.92]:33767)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1hobge-0000tn-Us
for 36731 <at> debbugs.gnu.org; Fri, 19 Jul 2019 18:49:13 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:40227)
by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
id 1hobgZ-0001Bq-6x; Fri, 19 Jul 2019 18:49:07 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39494 helo=ribbon)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <ludo@HIDDEN>)
id 1hobgY-0004xF-MJ; Fri, 19 Jul 2019 18:49:07 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Robert Vollmert <rob@HIDDEN>
Subject: Re: bug#36731: shepherd lost track of nginx
References: <E22C505B-4E64-4489-AE9C-8B19254B2BBD@HIDDEN>
Date: Sat, 20 Jul 2019 00:49:03 +0200
In-Reply-To: <E22C505B-4E64-4489-AE9C-8B19254B2BBD@HIDDEN> (Robert
Vollmert's message of "Fri, 19 Jul 2019 18:49:32 +0200")
Message-ID: <87ef2labds.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 36731
Cc: 36731 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hello,
Robert Vollmert <rob@HIDDEN> skribis:
> Not sure who=E2=80=99s at fault here, but without doing anything weird,
> I ended up with a system where shepherd thought that nginx was
> stopped, while there was still an nginx process around. I
> certainly didn=E2=80=99t start it by hand.
Did you try =E2=80=9Cherd status nginx=E2=80=9D to see shepherd=E2=80=99s n=
otion of the nginx
process?
> The result was this:
>
> $ sudo herd restart nginx
> Service nginx is not running.
> herd: exception caught while executing 'start' on service 'nginx':
> Throw to key `srfi-34' with args `("#<condition &invoke-error [program: \=
"/gnu/store/mlg0xfbiq03s812rm3v7mrlhyngas4xp-nginx-1.17.1/sbin/nginx\" argu=
ments: (\"-c\" \"/gnu/store/r6gl9n7pwf4npiri05qxr40vdihdm2yy-nginx.conf\" \=
"-p\" \"/var/run/nginx\") exit-status: 1 term-signal: #f stop-signal: #f] 1=
47e000>")=E2=80=99.
Do you use an =E2=80=9Copaque=E2=80=9D nginx config file, or do you use <ng=
inx-...>
records?
In the former case, the =E2=80=98start=E2=80=99 method won=E2=80=99t attemp=
t to read the PID
file (because it cannot be sure it=E2=80=99ll exist), so it=E2=80=99s effec=
tively unable
to track the process. See comment in =E2=80=98nginx-shepherd-service=E2=80=
=99.
> That error message could also be clearer about what=E2=80=99s going on. A=
t any
> rate, after I killed the nginx process, =E2=80=9Cherd start nginx=E2=80=
=9D worked fine.
I agree that we could and should improve the error message. Redirecting
nginx=E2=80=99s stderr so that shepherd clients can see it would be best.
Thanks,
Ludo=E2=80=99.
bug-guix@HIDDEN:bug#36731; Package guix.
Full text available.
Received: (at submit) by debbugs.gnu.org; 19 Jul 2019 16:49:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 19 12:49:41 2019
Received: from localhost ([127.0.0.1]:56499 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hoW4j-000836-FR
for submit <at> debbugs.gnu.org; Fri, 19 Jul 2019 12:49:41 -0400
Received: from lists.gnu.org ([209.51.188.17]:33526)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <rob@HIDDEN>) id 1hoW4h-00082y-De
for submit <at> debbugs.gnu.org; Fri, 19 Jul 2019 12:49:39 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:47444)
by lists.gnu.org with esmtp (Exim 4.86_2)
(envelope-from <rob@HIDDEN>) id 1hoW4g-0003G3-Gx
for bug-guix@HIDDEN; Fri, 19 Jul 2019 12:49:39 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled
version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <rob@HIDDEN>) id 1hoW4f-0007zf-Dm
for bug-guix@HIDDEN; Fri, 19 Jul 2019 12:49:38 -0400
Received: from mx1.mailbox.org ([2001:67c:2050:104:0:1:25:1]:19488)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <rob@HIDDEN>) id 1hoW4f-0007wk-4f
for bug-guix@HIDDEN; Fri, 19 Jul 2019 12:49:37 -0400
Received: from smtp1.mailbox.org (smtp1.mailbox.org
[IPv6:2001:67c:2050:105:465:1:1:0])
(using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits))
(No client certificate requested)
by mx1.mailbox.org (Postfix) with ESMTPS id A2054506B7
for <bug-guix@HIDDEN>; Fri, 19 Jul 2019 18:49:34 +0200 (CEST)
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp1.mailbox.org ([80.241.60.240])
by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de
[80.241.56.122]) (amavisd-new, port 10030)
with ESMTP id np0KIY67u0sB for <bug-guix@HIDDEN>;
Fri, 19 Jul 2019 18:49:33 +0200 (CEST)
From: Robert Vollmert <rob@HIDDEN>
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: shepherd lost track of nginx
Message-Id: <E22C505B-4E64-4489-AE9C-8B19254B2BBD@HIDDEN>
Date: Fri, 19 Jul 2019 18:49:32 +0200
To: bug-guix@HIDDEN
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-Received-From: 2001:67c:2050:104:0:1:25:1
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)
Not sure who=E2=80=99s at fault here, but without doing anything weird,
I ended up with a system where shepherd thought that nginx was
stopped, while there was still an nginx process around. I
certainly didn=E2=80=99t start it by hand.
The result was this:
$ sudo herd restart nginx
Service nginx is not running.
herd: exception caught while executing 'start' on service 'nginx':
Throw to key `srfi-34' with args `("#<condition &invoke-error [program: =
\"/gnu/store/mlg0xfbiq03s812rm3v7mrlhyngas4xp-nginx-1.17.1/sbin/nginx\" =
arguments: (\"-c\" =
\"/gnu/store/r6gl9n7pwf4npiri05qxr40vdihdm2yy-nginx.conf\" \"-p\" =
\"/var/run/nginx\") exit-status: 1 term-signal: #f stop-signal: #f] =
147e000>")=E2=80=99.
That error message could also be clearer about what=E2=80=99s going on. =
At any
rate, after I killed the nginx process, =E2=80=9Cherd start nginx=E2=80=9D=
worked fine.
I should add that nginx was still doing its job fine before I killed it.
Robert Vollmert <rob@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#36731; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.