GNU bug report logs - #36741
26.2.90; view-mode: Update docstring

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36741 in the body.
You can then email your comments to 36741 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.2.90; view-mode: Update docstring
Date: Sat, 20 Jul 2019 15:45:13 +0200

The mention to kill buffers in this context is likely an original
implementation detail; nowadays, Emacs saves the killed text in variables.

Either way for the purpose to document this mode, the way how the text
is stored is not relevant.

--8<-----------------------------cut here---------------start------------->8---
From 54267d85f3418e0cb4cb1009fcd4e680bfda6825 Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha <at> gmail.com>
Date: Sat, 20 Jul 2019 15:23:38 +0200
Subject: [PATCH] * lisp/view.el (view-mode): Update docstring.

---
 lisp/view.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/view.el b/lisp/view.el
index 3d423f1748..5e6f3e2caa 100644
--- a/lisp/view.el
+++ b/lisp/view.el
@@ -386,8 +386,8 @@ view-mode
 if ARG is omitted or nil.
 
 When View mode is enabled, commands that do not change the buffer
-contents are available as usual.  Kill commands insert text in
-kill buffers but do not delete.  Most other commands beep and
+contents are available as usual.  Kill commands save text but
+do not delete it from the buffer.  Most other commands beep and
 tell the user that the buffer is read-only.
 
 \\<view-mode-map>
-- 
2.20.1

--8<-----------------------------cut here---------------end--------------->8---

In GNU Emacs 26.2.90 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
Repository revision: 021f32cca1b9082e7219b06aee28c00c4323a72a
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description:	Debian GNU/Linux 10 (buster)

Message #10 received at 36741 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 36741 <at> debbugs.gnu.org
Subject: Re: bug#36741: 26.2.90; view-mode: Update docstring
Date: Thu, 25 Jul 2019 09:50:49 -0400

Tino Calancha <tino.calancha <at> gmail.com> writes:

> The mention to kill buffers in this context is likely an original
> implementation detail; nowadays, Emacs saves the killed text in variables.

I think "kill buffers" is a typo for "kill ring".

Message #13 received at 36741 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 36741 <at> debbugs.gnu.org, Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#36741: 26.2.90; view-mode: Update docstring
Date: Thu, 25 Jul 2019 17:34:42 +0200 (CEST)

On Thu, 25 Jul 2019, Noam Postavsky wrote:
> I think "kill buffers" is a typo for "kill ring".

I think you are right.  I prefer to avoid saying "kill ring" because the 
sentence iw written in plural (kill commands); `kill-rectangle' won't
save the text in the kill ring by default.  It might confuse newbies.

Message #16 received at 36741 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 36741 <at> debbugs.gnu.org
Subject: Re: bug#36741: 26.2.90; view-mode: Update docstring
Date: Thu, 25 Jul 2019 12:51:16 -0400

Tino Calancha <tino.calancha <at> gmail.com> writes:

> `kill-rectangle' won't save the text in the kill ring by default.

Ah good point, hadn't thought of that.  Then I think your patch is good,
you should push to emacs-26 (perhaps also mention the above point in the
commit message though).

Message #21 received at 36741-done <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: 36741-done <at> debbugs.gnu.org
Subject: Re: bug#36741: 26.2.90; view-mode: Update docstring
Date: Fri, 26 Jul 2019 17:42:26 +0200 (CEST)

On Thu, 25 Jul 2019, Noam Postavsky wrote:

> Tino Calancha <tino.calancha <at> gmail.com> writes:
>> `kill-rectangle' won't save the text in the kill ring by default.
>
> I think your patch is good, you should push to emacs-26 (perhaps also 
> mention the above point in the  commit message though).

Pushed into emacs-26 branch with commit 'Update view-mode docstring'
(d4c49875eaae3078ea3b51cc7b72ae3403cb2c04)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.