GNU bug report logs - #36755
Upgrade mallard-ducktype to 1.0.2

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36755 in the body.
You can then email your comments to 36755 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: guix-patches <at> gnu.org
Subject: Upgrade mallard-ducktype to 1.0.2
Date: Sun, 21 Jul 2019 20:05:52 -0400 (EDT)

Hi Guix,

mallard-ducktype 1.0.2 has been released, so I've prepared the following 
patch to update our package definition.

Notable in this release is the availability of a source tarball on pypi, 
so I've updated the package definition to use that instead of a git 
reference.

[0] http://projectmallard.org/pipermail/mallard-list/2019-July/000295.html

Best,
Jack

Message #8 received at 36755 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 36755 <at> debbugs.gnu.org
Cc: Jack Hill <jackhill <at> jackhill.us>
Subject: [PATCH] gnu: mallard-ducktype: Update to 1.0.2.
Date: Sun, 21 Jul 2019 20:08:00 -0400

With this release a source tarball is newly available on PyPI.

* gnu/packages/python-xyz.scm (mallard-ducktype) Update to 1.0.2.
[source] Use pypi uri.
---
 gnu/packages/python-xyz.scm | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 6e90c9a933..43bcc377e7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -3122,19 +3122,14 @@ and is very extensible.")
 (define-public mallard-ducktype
   (package
     (name "mallard-ducktype")
-    (version "1.0.1")
+    (version "1.0.2")
     (source
      (origin
-       (method git-fetch)
-       ;; git-reference because a proper source tarball is not available
-       ;; https://lists.gnu.org/archive/html/guix-devel/2019-05/msg00209.html
-       (uri (git-reference
-             (url "https://github.com/projectmallard/mallard-ducktype.git")
-             (commit version)))
-       (file-name (git-file-name name version))
+       (method url-fetch)
+       (uri (pypi-uri name version))
        (sha256
         (base32
-         "0crland0kmpsyjfmnflcw7gaqy5b87b6ah17cmr9d5z1kyazf54n"))))
+         "1xxx8jqsqais91li2wl9jbc9fzhgq1gbi24lf9kx43j6fjck25cf"))))
     (build-system python-build-system)
     (home-page "http://projectmallard.org")
     (synopsis "Convert Ducktype to Mallard documentation markup")
-- 
2.22.0

Message #11 received at 36755 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: 36755 <at> debbugs.gnu.org
Subject: Re: [bug#36755] [PATCH] gnu: mallard-ducktype: Update to 1.0.2.
Date: Mon, 22 Jul 2019 09:50:56 +0300

[Message part 1 (text/plain, inline)]

The patch applies cleanly but it turns out the test suite doesn't run.
Digging a little further, the test suite isn't included with the pypi
release, so I'd prefer to stay with the git checkout so we can run the
test suite.

Can you send an updated patch that keeps the git checkout?

Thanks


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 36755 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 36755 <at> debbugs.gnu.org
Subject: Re: [bug#36755] [PATCH] gnu: mallard-ducktype: Update to 1.0.2.
Date: Mon, 22 Jul 2019 09:27:14 -0400 (EDT)

On Mon, 22 Jul 2019, Efraim Flashner wrote:

> The patch applies cleanly but it turns out the test suite doesn't run.
> Digging a little further, the test suite isn't included with the pypi
> release, so I'd prefer to stay with the git checkout so we can run the
> test suite.

Thanks for the review and catching that. I agree that sticking with the 
git checkout sounds like the correct course of action.

> Can you send an updated patch that keeps the git checkout?

Sure, new patch coming shortly.

Message #17 received at 36755 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 36755 <at> debbugs.gnu.org
Cc: Jack Hill <jackhill <at> jackhill.us>, efraim <at> flashner.co.il
Subject: [PATCH v2] gnu: mallard-ducktype: Update to 1.0.2.
Date: Mon, 22 Jul 2019 09:33:01 -0400

* gnu/packages/python-xyz.scm (mallard-ducktype) Update to 1.0.2.
---
 gnu/packages/python-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d8f144893d..362ab7f031 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -3122,19 +3122,19 @@ and is very extensible.")
 (define-public mallard-ducktype
   (package
     (name "mallard-ducktype")
-    (version "1.0.1")
+    (version "1.0.2")
     (source
      (origin
        (method git-fetch)
-       ;; git-reference because a proper source tarball is not available
-       ;; https://lists.gnu.org/archive/html/guix-devel/2019-05/msg00209.html
+       ;; git-reference because tests are not included in pypi source tarball
+       ;; https://issues.guix.gnu.org/issue/36755#2
        (uri (git-reference
              (url "https://github.com/projectmallard/mallard-ducktype.git")
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "0crland0kmpsyjfmnflcw7gaqy5b87b6ah17cmr9d5z1kyazf54n"))))
+         "1jk9bfz7g04ip78s03b0xak6d54rj4h9zpgadkziy1ji216g6y4c"))))
     (build-system python-build-system)
     (arguments
      '(#:phases
-- 
2.22.0

Message #22 received at 36755-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: 36755-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: mallard-ducktype: Update to 1.0.2.
Date: Tue, 23 Jul 2019 09:10:44 +0300

[Message part 1 (text/plain, inline)]

patch pushed. Thanks!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.