GNU logs - #36772, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#36772: feature request: checked variant of "substitute*"
Resent-From: Robert Vollmert <rob@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 23 Jul 2019 12:51:01 +0000
Resent-Message-ID: <handler.36772.B.15638862136280 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 36772 <at> debbugs.gnu.org
From: Robert Vollmert <rob@HIDDEN>
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Message-Id: <E8613602-3151-405B-AC42-20D0A2CAD299@HIDDEN>
Date: Tue, 23 Jul 2019 14:49:46 +0200
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

I think it would be great to have the following variant of substitute*:

(substitute*-once filename (pattern vars) body)

which acts like the usual substitute-*, except it also asserts that the
substitution applies to exactly one line in the file, causing a build
failure otherwise.

In the cases where this is sufficient (I believe most), it would make
substitution work quite a bit more reliably, making it both easier to
debug substitution when first packaging, and noticing more easily when
they need to be adapted on upgrades.

(It would be possible to make the signature a bit more flexible and to
allow multiple files or patterns as in substitute*, but that would
make the meaning of =E2=80=9Capplies exactly once=E2=80=9D a bit =
unclear, so I=E2=80=99d prefer
to not do that. Similarly, I find it cleaner to potentially call
substitute*-once several times in a row with different substitutions to
make the ordering of effects explicit.)

(I=E2=80=99d be happy to supply a patch myself eventually, but the =
syntax rule
business is a bit out of reach at this point.)

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Robert Vollmert <rob@HIDDEN>
Subject: bug#36772: Acknowledgement (feature request: checked variant of
 "substitute*")
Message-ID: <handler.36772.B.15638862136280.ack <at> debbugs.gnu.org>
References: <E8613602-3151-405B-AC42-20D0A2CAD299@HIDDEN>
X-Gnu-PR-Message: ack 36772
X-Gnu-PR-Package: guix
Reply-To: 36772 <at> debbugs.gnu.org
Date: Tue, 23 Jul 2019 12:51:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 36772 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
36772: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36772
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#36772: feature request: checked variant of "substitute*"
Resent-From: Ricardo Wurmus <rekado@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 23 Jul 2019 13:36:01 +0000
Resent-Message-ID: <handler.36772.B36772.156388893026752 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Robert Vollmert <rob@HIDDEN>
Cc: 36772 <at> debbugs.gnu.org
References: <E8613602-3151-405B-AC42-20D0A2CAD299@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.2
From: Ricardo Wurmus <rekado@HIDDEN>
In-reply-to: <E8613602-3151-405B-AC42-20D0A2CAD299@HIDDEN>
Date: Tue, 23 Jul 2019 15:35:19 +0200
Message-ID: <87zhl4c1rc.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


Hi Robert,

> I think it would be great to have the following variant of substitute*:
>
> (substitute*-once filename (pattern vars) body)
>
> which acts like the usual substitute-*, except it also asserts that the
> substitution applies to exactly one line in the file, causing a build
> failure otherwise.

I agree that the effect of substitute* should be checked.  I think
substitute* should fail when one of its clauses failed to match
anything.

Each clause could also accept an optional argument to make them only
match one location.  We wouldn=E2=80=99t have to duplicate the macro for th=
at
and it=E2=80=99s a simple extension to failing on zero matches.

What do you think?

--
Ricardo

Message sent to bug-guix@HIDDEN:

Subject: bug#36772: feature request: checked variant of "substitute*"
Resent-From: Robert Vollmert <rob@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 23 Jul 2019 13:43:02 +0000
Resent-Message-ID: <handler.36772.B36772.156388934027407 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ricardo Wurmus <rekado@HIDDEN>
Cc: 36772 <at> debbugs.gnu.org
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Robert Vollmert <rob@HIDDEN>
In-Reply-To: <87zhl4c1rc.fsf@HIDDEN>
Date: Tue, 23 Jul 2019 15:41:58 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <15DD757F-8CCE-4092-925C-0B76824B5E47@HIDDEN>
References: <E8613602-3151-405B-AC42-20D0A2CAD299@HIDDEN>
 <87zhl4c1rc.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>



> On 23. Jul 2019, at 15:35, Ricardo Wurmus <rekado@HIDDEN> wrote:
>=20
>=20
> Hi Robert,
>=20
>> I think it would be great to have the following variant of =
substitute*:
>>=20
>> (substitute*-once filename (pattern vars) body)
>>=20
>> which acts like the usual substitute-*, except it also asserts that =
the
>> substitution applies to exactly one line in the file, causing a build
>> failure otherwise.
>=20
> I agree that the effect of substitute* should be checked.  I think
> substitute* should fail when one of its clauses failed to match
> anything.
>=20
> Each clause could also accept an optional argument to make them only
> match one location.  We wouldn=E2=80=99t have to duplicate the macro =
for that
> and it=E2=80=99s a simple extension to failing on zero matches.
>=20
> What do you think?

That sounds like a good improvement, too. I think the important part is
ensuring the substitution matches at all, maybe we could leave out the
=E2=80=9Cat most once=E2=80=9D part. (I doubt it would be used a lot if =
it=E2=80=99s not the default.)

Cheers
Robert

Message sent to bug-guix@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#36772: feature request: checked variant of "substitute*"
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 25 Jul 2019 17:41:01 +0000
Resent-Message-ID: <handler.36772.B36772.156407645717757 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 36772
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Ricardo Wurmus <rekado@HIDDEN>
Cc: 36772 <at> debbugs.gnu.org, Robert Vollmert <rob@HIDDEN>
Received: via spool by 36772-submit <at> debbugs.gnu.org id=B36772.156407645717757
          (code B ref 36772); Thu, 25 Jul 2019 17:41:01 +0000
Received: (at 36772) by debbugs.gnu.org; 25 Jul 2019 17:40:57 +0000
Received: from localhost ([127.0.0.1]:40407 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hqhjd-0004cK-1S
	for submit <at> debbugs.gnu.org; Thu, 25 Jul 2019 13:40:57 -0400
Received: from eggs.gnu.org ([209.51.188.92]:33915)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1hqhjb-0004c3-LX
 for 36772 <at> debbugs.gnu.org; Thu, 25 Jul 2019 13:40:55 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:47811)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
 id 1hqhjW-0002wA-GW; Thu, 25 Jul 2019 13:40:50 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=49616 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1hqhjW-0002vv-2u; Thu, 25 Jul 2019 13:40:50 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <E8613602-3151-405B-AC42-20D0A2CAD299@HIDDEN>
 <87zhl4c1rc.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 7 Thermidor an 227 de la =?UTF-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Thu, 25 Jul 2019 19:40:48 +0200
In-Reply-To: <87zhl4c1rc.fsf@HIDDEN> (Ricardo Wurmus's message of "Tue,
 23 Jul 2019 15:35:19 +0200")
Message-ID: <875znqrp0f.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Ricardo Wurmus <rekado@HIDDEN> skribis:

>> I think it would be great to have the following variant of substitute*:
>>
>> (substitute*-once filename (pattern vars) body)
>>
>> which acts like the usual substitute-*, except it also asserts that the
>> substitution applies to exactly one line in the file, causing a build
>> failure otherwise.
>
> I agree that the effect of substitute* should be checked.  I think
> substitute* should fail when one of its clauses failed to match
> anything.
>
> Each clause could also accept an optional argument to make them only
> match one location.  We wouldn=E2=80=99t have to duplicate the macro for =
that
> and it=E2=80=99s a simple extension to failing on zero matches.
>
> What do you think?

That=E2=80=99d be a useful extension.

Ludo=E2=80=99.

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.