GNU bug report logs - #36776
WIP: upgrade emacs-ess to 18.10.2

Previous Next

Package: guix-patches;

Reported by: Nicolò Balzarotti <anothersms <at> gmail.com>

Date: Tue, 23 Jul 2019 22:12:02 UTC

Severity: normal

Done: Nicolò Balzarotti <anothersms <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36776 in the body.
You can then email your comments to 36776 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#36776; Package guix-patches. (Tue, 23 Jul 2019 22:12:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolò Balzarotti <anothersms <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 23 Jul 2019 22:12:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: WIP: upgrade emacs-ess to 18.10.2
Date: Tue, 23 Jul 2019 22:11:16 +0000
[Message part 1 (text/plain, inline)]
Hello guix!
I'm sorry for this work in progress. I got emacs-ess 18 working, but I
really don't like how I did it (I don't think the way I'm helping emacs
finding julia-mode during the build is right), so I'm asking help here!

On irc, @rekado expressed interest in helping.

Thanks everybody,
Nicolò
[Message part 2 (text/html, inline)]
[0001-wip-gnu-packages-Upgrade-emacs-ess-to-18.10.2.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#36776; Package guix-patches. (Tue, 10 Dec 2019 16:12:02 GMT) Full text and rfc822 format available.

Message #8 received at 36776 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: 36776 <at> debbugs.gnu.org
Subject: Re: [bug#36776] WIP: upgrade emacs-ess to 18.10.2
Date: Tue, 10 Dec 2019 17:11:47 +0100
Nicolò Balzarotti <anothersms <at> gmail.com> writes:

Hello again!

After changes to EMACSLOADPATH, emacs is failing to find ess (.el files
are placed under ~/.guix-profile/share/emacs/site-lisp/guix.d)

Looking at the mail archive I found this patch I sent 3 months ago >.<.
It's outdated now (for the LOAD PATH thing).  But we might take the time
to fix this.

Any thought?

Thanks!

Nicolò

> Hello guix!
> I'm sorry for this work in progress. I got emacs-ess 18 working, but I
> really don't like how I did it (I don't think the way I'm helping emacs
> finding julia-mode during the build is right), so I'm asking help here!
>
> On irc, @rekado expressed interest in helping.
>
> Thanks everybody,
> Nicolò
> From 39420bfed259d22bf0368fa0da0a6093a42e0f78 Mon Sep 17 00:00:00 2001
> From: nixo <nicolo <at> nixo.xyz>
> Date: Wed, 24 Jul 2019 00:04:37 +0200
> Subject: [PATCH] wip: gnu packages: Upgrade emacs-ess to 18.10.2
>
> ---
>  gnu/packages/statistics.scm | 62 ++++++++++++++++++-------------------
>  1 file changed, 30 insertions(+), 32 deletions(-)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index eb5e5b4b76..35af00c58e 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -5877,35 +5877,15 @@ Java package that provides routines for various statistical distributions.")
>  (define-public emacs-ess
>    (package
>      (name "emacs-ess")
> -    (version "17.11")
> +    (version "18.10.2")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "https://github.com/emacs-ess/ESS/archive/v"
>                                    version ".tar.gz"))
>                (sha256
>                 (base32
> -                "0cbilbsiwvcyf6d5y24mymp57m3ana5dkzab3knfs83w4a3a4c5c"))
> -              (file-name (string-append name "-" version ".tar.gz"))
> -              (modules '((guix build utils)))
> -              (snippet
> -               '(begin
> -                  ;; Stop ESS from trying to bundle an external julia-mode.el.
> -                  (substitute* "lisp/Makefile"
> -                    (("^\tjulia-mode.elc\\\\\n") "")
> -                    (("^dist: all julia-mode.el")
> -                     "dist: all"))
> -                  ;; No need to build docs in so many formats.  Also, skipping
> -                  ;; pdf lets us not pull in texlive.
> -                  (substitute* "doc/Makefile"
> -                    (("all  : info text html pdf")
> -                     "all  : info")
> -                    (("install: install-info install-other-docs")
> -                     "install: install-info"))
> -                  ;; Test fails upstream
> -                  (substitute* "test/ess-r-tests.el"
> -                    (("ert-deftest ess-r-namespaced-eval-no-srcref-in-errors ()")
> -                     "ert-deftest ess-r-namespaced-eval-no-srcref-in-errors () :expected-result :failed"))
> -                  #t))))
> +                "0akz3wf6b4dvwm55875ap45rdb52m4fwxfs6nlfpccmm1q55nvbb"))
> +              (modules '((guix build utils)))))
>      (build-system gnu-build-system)
>      (arguments
>       (let ((base-directory "/share/emacs/site-lisp/guix.d/ess"))
> @@ -5917,20 +5897,38 @@ Java package that provides routines for various statistical distributions.")
>           #:phases
>           (modify-phases %standard-phases
>             (delete 'configure)
> +	   (delete 'check) 		;; emacs: standard input is not a tty
>             (add-before 'build 'more-shebang-patching
> -             (lambda* (#:key inputs #:allow-other-keys)
> -               (substitute* "Makeconf"
> -                 (("SHELL = /bin/sh")
> -                  (string-append "SHELL = " (which "sh"))))
> -               #t))
> -           (replace 'check
> -             (lambda _
> -               (invoke "make" "test")))))))
> +	     (lambda* (#:key inputs propagated-inputs #:allow-other-keys)
> +	       (substitute* "Makeconf"
> +		 (("SHELL = /bin/sh")
> +		  (string-append "SHELL = " (which "sh"))))
> +	       ;; No need to build docs in so many formats.  Also, skipping
> +	       ;; pdf lets us not pull in texlive.
> +	       (substitute* "doc/Makefile"
> +		 (("install: install-info install-other-docs")
> +		  "install: install-info"))
> +	       ;; This seems too much like a hack
> +	       (substitute* "Makeconf"
> +		 (("-no-site-file")
> +		  (string-append "-no-site-file -L "
> +				 (string-append
> +				  (assoc-ref inputs "emacs-julia-mode")
> +				  "/share/emacs/site-lisp/guix.d/*/"
> +				  ))))
> +	       (substitute* "lisp/Makefile"
> +                 (("^\tjulia-mode.elc\\\\\n") "")
> +                 (("^all: julia-mode.el")
> +                  "all: ")
> +	      	 (("^ess-julia.elc: julia-mode.elc")
> +                  ""))
> +	       #t)
> +	     )))))
>      (inputs
>       `(("emacs" ,emacs-minimal)
>         ("r-minimal" ,r-minimal)))
>      (native-inputs
> -     `(("perl" ,perl)
> +     `(("which" ,which)
>         ("texinfo" ,texinfo)))
>      (propagated-inputs
>       `(("emacs-julia-mode" ,emacs-julia-mode)))
> -- 
> 2.22.0




Reply sent to Nicolò Balzarotti <anothersms <at> gmail.com>:
You have taken responsibility. (Thu, 07 May 2020 08:40:02 GMT) Full text and rfc822 format available.

Notification sent to Nicolò Balzarotti <anothersms <at> gmail.com>:
bug acknowledged by developer. (Thu, 07 May 2020 08:40:03 GMT) Full text and rfc822 format available.

Message #13 received at 36776-close <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: 36776-close <at> debbugs.gnu.org
Subject: Re: [bug#36776] WIP: upgrade emacs-ess to 18.10.2
Date: Thu, 07 May 2020 10:39:45 +0200
Closing as another patch has been merged in 51ac5ce4b509fac151e646deaff41a527270a74f.

Nicolò Balzarotti <anothersms <at> gmail.com> writes:

> Hello guix!
> I'm sorry for this work in progress. I got emacs-ess 18 working, but I
> really don't like how I did it (I don't think the way I'm helping emacs
> finding julia-mode during the build is right), so I'm asking help here!
>
> On irc, @rekado expressed interest in helping.
>
> Thanks everybody,
> Nicolò
> From 39420bfed259d22bf0368fa0da0a6093a42e0f78 Mon Sep 17 00:00:00 2001
> From: nixo <nicolo <at> nixo.xyz>
> Date: Wed, 24 Jul 2019 00:04:37 +0200
> Subject: [PATCH] wip: gnu packages: Upgrade emacs-ess to 18.10.2
>
> ---
>  gnu/packages/statistics.scm | 62 ++++++++++++++++++-------------------
>  1 file changed, 30 insertions(+), 32 deletions(-)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index eb5e5b4b76..35af00c58e 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -5877,35 +5877,15 @@ Java package that provides routines for various statistical distributions.")
>  (define-public emacs-ess
>    (package
>      (name "emacs-ess")
> -    (version "17.11")
> +    (version "18.10.2")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "https://github.com/emacs-ess/ESS/archive/v"
>                                    version ".tar.gz"))
>                (sha256
>                 (base32
> -                "0cbilbsiwvcyf6d5y24mymp57m3ana5dkzab3knfs83w4a3a4c5c"))
> -              (file-name (string-append name "-" version ".tar.gz"))
> -              (modules '((guix build utils)))
> -              (snippet
> -               '(begin
> -                  ;; Stop ESS from trying to bundle an external julia-mode.el.
> -                  (substitute* "lisp/Makefile"
> -                    (("^\tjulia-mode.elc\\\\\n") "")
> -                    (("^dist: all julia-mode.el")
> -                     "dist: all"))
> -                  ;; No need to build docs in so many formats.  Also, skipping
> -                  ;; pdf lets us not pull in texlive.
> -                  (substitute* "doc/Makefile"
> -                    (("all  : info text html pdf")
> -                     "all  : info")
> -                    (("install: install-info install-other-docs")
> -                     "install: install-info"))
> -                  ;; Test fails upstream
> -                  (substitute* "test/ess-r-tests.el"
> -                    (("ert-deftest ess-r-namespaced-eval-no-srcref-in-errors ()")
> -                     "ert-deftest ess-r-namespaced-eval-no-srcref-in-errors () :expected-result :failed"))
> -                  #t))))
> +                "0akz3wf6b4dvwm55875ap45rdb52m4fwxfs6nlfpccmm1q55nvbb"))
> +              (modules '((guix build utils)))))
>      (build-system gnu-build-system)
>      (arguments
>       (let ((base-directory "/share/emacs/site-lisp/guix.d/ess"))
> @@ -5917,20 +5897,38 @@ Java package that provides routines for various statistical distributions.")
>           #:phases
>           (modify-phases %standard-phases
>             (delete 'configure)
> +	   (delete 'check) 		;; emacs: standard input is not a tty
>             (add-before 'build 'more-shebang-patching
> -             (lambda* (#:key inputs #:allow-other-keys)
> -               (substitute* "Makeconf"
> -                 (("SHELL = /bin/sh")
> -                  (string-append "SHELL = " (which "sh"))))
> -               #t))
> -           (replace 'check
> -             (lambda _
> -               (invoke "make" "test")))))))
> +	     (lambda* (#:key inputs propagated-inputs #:allow-other-keys)
> +	       (substitute* "Makeconf"
> +		 (("SHELL = /bin/sh")
> +		  (string-append "SHELL = " (which "sh"))))
> +	       ;; No need to build docs in so many formats.  Also, skipping
> +	       ;; pdf lets us not pull in texlive.
> +	       (substitute* "doc/Makefile"
> +		 (("install: install-info install-other-docs")
> +		  "install: install-info"))
> +	       ;; This seems too much like a hack
> +	       (substitute* "Makeconf"
> +		 (("-no-site-file")
> +		  (string-append "-no-site-file -L "
> +				 (string-append
> +				  (assoc-ref inputs "emacs-julia-mode")
> +				  "/share/emacs/site-lisp/guix.d/*/"
> +				  ))))
> +	       (substitute* "lisp/Makefile"
> +                 (("^\tjulia-mode.elc\\\\\n") "")
> +                 (("^all: julia-mode.el")
> +                  "all: ")
> +	      	 (("^ess-julia.elc: julia-mode.elc")
> +                  ""))
> +	       #t)
> +	     )))))
>      (inputs
>       `(("emacs" ,emacs-minimal)
>         ("r-minimal" ,r-minimal)))
>      (native-inputs
> -     `(("perl" ,perl)
> +     `(("which" ,which)
>         ("texinfo" ,texinfo)))
>      (propagated-inputs
>       `(("emacs-julia-mode" ,emacs-julia-mode)))
> -- 
> 2.22.0




Information forwarded to guix-patches <at> gnu.org:
bug#36776; Package guix-patches. (Fri, 08 May 2020 13:48:02 GMT) Full text and rfc822 format available.

Message #16 received at 36776-close <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Nicolò Balzarotti <anothersms <at> gmail.com>,
 36776-close <at> debbugs.gnu.org
Subject: Re: bug#36776: WIP: upgrade emacs-ess to 18.10.2
Date: Fri, 08 May 2020 15:46:53 +0200
[Message part 1 (text/plain, inline)]
Nicolò Balzarotti <anothersms <at> gmail.com> writes:

> Closing as another patch has been merged in 51ac5ce4b509fac151e646deaff41a527270a74f.

Whoops, sorry for the duplicate work.  Don't be afraid to ping the bug
tracker when patches go stale like in this case.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#36776; Package guix-patches. (Fri, 08 May 2020 19:05:02 GMT) Full text and rfc822 format available.

Message #19 received at 36776-close <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>, 36776-close <at> debbugs.gnu.org
Subject: Re: [bug#36776] WIP: upgrade emacs-ess to 18.10.2
Date: Fri, 08 May 2020 21:03:59 +0200
Marius Bakke <mbakke <at> fastmail.com> writes:

Hi Marius,
> Nicolò Balzarotti <anothersms <at> gmail.com> writes:
>
>> Closing as another patch has been merged in 51ac5ce4b509fac151e646deaff41a527270a74f.
>
> Whoops, sorry for the duplicate work.  Don't be afraid to ping the bug
> tracker when patches go stale like in this case.

Thanks, and don't worry.  The patch was incomplete, I'm happy that
finally emacs-ess has been updated, thanks!

Nicolò




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 06 Jun 2020 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 296 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.