GNU bug report logs - #36804
[PATCH] gnu: Add xchm.

Previous Next

Package: guix-patches;

Reported by: "Jovany Leandro G.C" <bit4bit <at> riseup.net>

Date: Thu, 25 Jul 2019 01:36:02 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36804 in the body.
You can then email your comments to 36804 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#36804; Package guix-patches. (Thu, 25 Jul 2019 01:36:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Jovany Leandro G.C" <bit4bit <at> riseup.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 25 Jul 2019 01:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Jovany Leandro G.C" <bit4bit <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: "Jovany Leandro G.C" <bit4bit <at> riseup.net>
Subject: [PATCH] gnu: Add xchm.
Date: Wed, 24 Jul 2019 20:35:15 -0500
* gnu/packages/ebook.scm (xchm): New variable.
---
 gnu/packages/ebook.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
index cf424f285d..7c919710d4 100644
--- a/gnu/packages/ebook.scm
+++ b/gnu/packages/ebook.scm
@@ -330,3 +330,31 @@ following formats:
 @item XHTML
 @end enumerate")
     (license license:gpl2+)))
+
+(define-public xchm
+  (package
+    (name "xchm")
+    (version "1.30")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/rzvncj/xCHM/archive/"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "13733g2bz84a15z08qwhrdcn0ff6g9c0aabdn0kzvx0nanj9vra9"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("wxwidgets" ,wxwidgets)
+       ("chmlib" ,chmlib)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)
+       ("gettext" ,gettext-minimal)))
+    (home-page "https://github.com/rzvncj/xCHM")
+    (synopsis "UNIX CHM Viewer")
+    (description "xCHM is a cross-platform GPL frontend for CHMLIB written
+with the wxWidgets framework.")
+    (license license:gpl2+)))
-- 
2.19.0





Reply sent to Ricardo Wurmus <rekado <at> elephly.net>:
You have taken responsibility. (Thu, 25 Jul 2019 07:25:02 GMT) Full text and rfc822 format available.

Notification sent to "Jovany Leandro G.C" <bit4bit <at> riseup.net>:
bug acknowledged by developer. (Thu, 25 Jul 2019 07:25:02 GMT) Full text and rfc822 format available.

Message #10 received at 36804-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 36804-done <at> debbugs.gnu.org
Cc: "Jovany Leandro G.C" <bit4bit <at> riseup.net>
Subject: Re: [bug#36804] [PATCH] gnu: Add xchm.
Date: Thu, 25 Jul 2019 09:23:52 +0200
Hi,

thank you for your patch.

> * gnu/packages/ebook.scm (xchm): New variable.
> ---
>  gnu/packages/ebook.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
> index cf424f285d..7c919710d4 100644
> --- a/gnu/packages/ebook.scm
> +++ b/gnu/packages/ebook.scm
> @@ -330,3 +330,31 @@ following formats:
>  @item XHTML
>  @end enumerate")
>      (license license:gpl2+)))
> +
> +(define-public xchm
> +  (package
> +    (name "xchm")
> +    (version "1.30")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/rzvncj/xCHM/archive/"
> +                                  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))

The project provides a bootstrapped tarball.  We avoid the “/archive”
URLs on Github as they may change over time.

> +              (sha256
> +               (base32
> +                "13733g2bz84a15z08qwhrdcn0ff6g9c0aabdn0kzvx0nanj9vra9"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("wxwidgets" ,wxwidgets)
> +       ("chmlib" ,chmlib)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("gettext" ,gettext-minimal)))

When using the bootstrapped tarball most of these inputs are not needed.

> +    (home-page "https://github.com/rzvncj/xCHM")
> +    (synopsis "UNIX CHM Viewer")
> +    (description "xCHM is a cross-platform GPL frontend for CHMLIB written
> +with the wxWidgets framework.")

I have changed both synopsis and description.  We don’t usually mention
UNIX, nor do we repeat the license or the inputs in the description.

You missed the import of (gnu packages wxwidgets), which makes me think
that you haven’t tried building this patch.

I have pushed this to the master branch with commit 7c0411879b after
including my changes.

Thanks!

--
Ricardo





Information forwarded to guix-patches <at> gnu.org:
bug#36804; Package guix-patches. (Thu, 25 Jul 2019 15:06:02 GMT) Full text and rfc822 format available.

Message #13 received at 36804-done <at> debbugs.gnu.org (full text, mbox):

From: "Jovany Leandro G.C" <bit4bit <at> riseup.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 36804-done <at> debbugs.gnu.org
Subject: Re: [bug#36804] [PATCH] gnu: Add xchm.
Date: Thu, 25 Jul 2019 08:05:57 -0700
On 2019-07-25 07:23, Ricardo Wurmus wrote:
> Hi,
> 
> thank you for your patch.
> 
>> * gnu/packages/ebook.scm (xchm): New variable.
>> ---
>>  gnu/packages/ebook.scm | 28 ++++++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>
>> diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
>> index cf424f285d..7c919710d4 100644
>> --- a/gnu/packages/ebook.scm
>> +++ b/gnu/packages/ebook.scm
>> @@ -330,3 +330,31 @@ following formats:
>>  @item XHTML
>>  @end enumerate")
>>      (license license:gpl2+)))
>> +
>> +(define-public xchm
>> +  (package
>> +    (name "xchm")
>> +    (version "1.30")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "https://github.com/rzvncj/xCHM/archive/"
>> +                                  version ".tar.gz"))
>> +              (file-name (string-append name "-" version ".tar.gz"))
> 
> The project provides a bootstrapped tarball.  We avoid the “/archive”
> URLs on Github as they may change over time.
> 
>> +              (sha256
>> +               (base32
>> +                "13733g2bz84a15z08qwhrdcn0ff6g9c0aabdn0kzvx0nanj9vra9"))))
>> +    (build-system gnu-build-system)
>> +    (inputs
>> +     `(("wxwidgets" ,wxwidgets)
>> +       ("chmlib" ,chmlib)))
>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)
>> +       ("autoconf" ,autoconf)
>> +       ("automake" ,automake)
>> +       ("libtool" ,libtool)
>> +       ("gettext" ,gettext-minimal)))
> 
> When using the bootstrapped tarball most of these inputs are not needed.
> 
>> +    (home-page "https://github.com/rzvncj/xCHM")
>> +    (synopsis "UNIX CHM Viewer")
>> +    (description "xCHM is a cross-platform GPL frontend for CHMLIB written
>> +with the wxWidgets framework.")
> 
> I have changed both synopsis and description.  We don’t usually mention
> UNIX, nor do we repeat the license or the inputs in the description.
> 
> You missed the import of (gnu packages wxwidgets), which makes me think
> that you haven’t tried building this patch.
> 
> I have pushed this to the master branch with commit 7c0411879b after
> including my changes.
> 
> Thanks!
> 
> --
> Ricardo
thanks for your time, sorry i already build with rounds=2, but i have 
the source
[https://efossils.somxslibres.net/fossil/user/bit4bit/repository/guix_packages/index]
in other place when i sure it's build and i use for a time i merge the
patch to guix-dev, i miss the import sorry.

si 'guix lint' show about tarball but i was not sure what to do
thanks
Fossil: https://efossils.somxslibres.net
E-Sitio: https://www.somxslibres.net




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 23 Aug 2019 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 219 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.