GNU bug report logs - #36824
[PATCH] gnu: Add oshu.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36824 in the body.
You can then email your comments to 36824 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Frumin <dfrumin <at> cs.ru.nl>
To: guix-patches <at> gnu.org
Cc: Dan Frumin <dfrumin <at> cs.ru.nl>
Subject: [PATCH] gnu: Add oshu.
Date: Sat, 27 Jul 2019 20:18:41 +0200

---
 gnu/packages/games.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a17ac9728c..3bb17c5735 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -6374,6 +6374,40 @@ to download and install them in @file{$HOME/.stepmania-X.Y/Songs} directory.")
     (home-page "https://www.stepmania.com")
     (license license:expat)))
 
+(define-public oshu
+  (package
+    (name "oshu")
+    (version "2.0.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/fmang/oshu.git")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "01w1x46hh36idjl94xd18dwppp0y30qxmb498gp7hnjzy205q6rw"))))
+    (build-system cmake-build-system)
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (inputs `(("sdl2" ,sdl2)
+              ("sdl2-image" ,sdl2-image)
+              ("ffmpeg" ,ffmpeg)
+              ("cairo" ,cairo)
+              ("pango" ,pango)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; `make test' doesn't actually build the test executable
+         (add-before 'check 'zerotokei
+           (lambda _ (invoke "make" "zerotokei"))))))
+    (home-page "https://github.com/fmang/oshu/")
+    (synopsis "Clone of the Osu! rhythm game")
+    (description "Oshu! is a free clone of the Osu! rhythm game, designed to
+be run on GNU/Linux without requiring a powerful videocard. Oshu! is capable
+of playing the original Osu! beatmaps (not included in this package). ")
+    (license license:gpl3)))
+
 (define-public btanks
   (package
     (name "btanks")
-- 
2.17.1

Message #8 received at 36824 <at> debbugs.gnu.org (full text, mbox):

From: Dan Frumin <dfrumin <at> cs.ru.nl>
To: 36824 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add oshu.
Date: Sun, 28 Jul 2019 13:42:49 +0200

[Message part 1 (text/plain, inline)]

Sorry, I forgot to do the linting.
Here is an updated version with two spaces.

Best,
Dan

On 27-07-19 20:18, Dan Frumin wrote:
> ---
>   gnu/packages/games.scm | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
> 
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index a17ac9728c..3bb17c5735 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -6374,6 +6374,40 @@ to download and install them in @file{$HOME/.stepmania-X.Y/Songs} directory.")
>       (home-page "https://www.stepmania.com")
>       (license license:expat)))
>   
> +(define-public oshu
> +  (package
> +    (name "oshu")
> +    (version "2.0.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/fmang/oshu.git")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "01w1x46hh36idjl94xd18dwppp0y30qxmb498gp7hnjzy205q6rw"))))
> +    (build-system cmake-build-system)
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("sdl2" ,sdl2)
> +              ("sdl2-image" ,sdl2-image)
> +              ("ffmpeg" ,ffmpeg)
> +              ("cairo" ,cairo)
> +              ("pango" ,pango)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; `make test' doesn't actually build the test executable
> +         (add-before 'check 'zerotokei
> +           (lambda _ (invoke "make" "zerotokei"))))))
> +    (home-page "https://github.com/fmang/oshu/")
> +    (synopsis "Clone of the Osu! rhythm game")
> +    (description "Oshu! is a free clone of the Osu! rhythm game, designed to
> +be run on GNU/Linux without requiring a powerful videocard. Oshu! is capable
> +of playing the original Osu! beatmaps (not included in this package). ")
> +    (license license:gpl3)))
> +
>   (define-public btanks
>     (package
>       (name "btanks")
> 

[0001-gnu-Add-oshu.patch (text/x-patch, attachment)]

Message #11 received at 36824 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 36824 <at> debbugs.gnu.org
Subject: Re: [bug#36824] [PATCH] gnu: Add oshu.
Date: Sun, 28 Jul 2019 18:07:10 +0200

[Message part 1 (text/plain, inline)]

Dan,

Thanks!  I'm deprived of Guix for the moment, so I can't review 
the package itself.  Looks good on first glance, though.

Dan Frumin 写道：
>    (synopsis "Clone of the Osu! rhythm game")
>    (description "Oshu! is a free clone of the Osu! rhythm game, 
>    designed to

I'd rather see a 'first-class' description of what this game is 
and does and drop the 'is a clone of' part entirely: 'is capable 
of playing the original Osu! beatmaps' already says it all without 
implying it's some kind of knock-off ;-)

If you don't have time fo' that I understand, but you're 
presumably familiar with both games & in the best position to 
write something accurate.

> be run on GNU/Linux without requiring a powerful videocard. 
> Oshu! is capable

s/videocard/video card/, or graphics card.  Is it really tied to 
the kernel?  (Not entirely implausible considering the real-time 
audio nature.  Interesting design, by the way.)

> of playing the original Osu! beatmaps (not included in this 
> package). ")

Could we package these separately?  How are they licenced?

>    (license license:gpl3)))

Ugh, no licence headers?  I guess that does make it GPL 3-only, 
but I'm no expert.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 36824 <at> debbugs.gnu.org (full text, mbox):

From: Dan Frumin <dfrumin <at> cs.ru.nl>
To: 36824 <at> debbugs.gnu.org, me <at> tobias.gr
Subject: Re: bug#36824: [PATCH] gnu: Add oshu.
Date: Mon, 29 Jul 2019 13:32:04 +0200

[Message part 1 (text/plain, inline)]

Hi Tobias,

Thank you for your timely reply.

(As a side note, can you please CC the messages to me, because I am not subscribed to the guix-patches mailing list. Maybe I am using debbugs in some 
wrong way).

> I'd rather see a 'first-class' description of what this game is
> and does and drop the 'is a clone of' part entirely: 'is capable
> of playing the original Osu! beatmaps' already says it all without
> implying it's some kind of knock-off ;-)

That's a good point. I changed the description to something more appropriate.

> s/videocard/video card/, or graphics card.  Is it really tied to
> the kernel?  (Not entirely implausible considering the real-time
> audio nature.  Interesting design, by the way.)

Oops, I didn't mean to say that it's tied to the Linux kernel (although I don't think it's developed/tested on other platforms). I just wanted to 
contrast that with the old original Osu! game which is for Windows.

> Could we package these separately?  How are they licenced?

I am not sure. You basically have to download them manually from the Osu! website or from other places on the web.
I don't think they are licensed very well at all..


> Ugh, no licence headers?  I guess that does make it GPL 3-only,
> but I'm no expert.

Yeah I am not sure about the headers, but the COPYING file indicates that it's GPL 3

Best,
Dan

[0001-gnu-Add-oshu.patch (text/x-patch, attachment)]

Message #17 received at 36824 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: dfrumin <at> cs.ru.nl
Cc: me <at> tobias.gr, 36824 <at> debbugs.gnu.org
Subject: Re: [bug#36824] [PATCH] gnu: Add oshu.
Date: Mon, 29 Jul 2019 15:20:40 +0200

Dan Frumin <dfrumin <at> cs.ru.nl> writes:

>  > Ugh, no licence headers?  I guess that does make it GPL 3-only,
>  > but I'm no expert.
>
> Yeah I am not sure about the headers, but the COPYING file indicates that it's GPL 3

Here are more details:

    https://github.com/fmang/oshu/blob/30b316173aca8fd6b2dce8b7d425845241ae5f13/src/oshu/main.cc#L69

The license is GPL version 3 or later.

-- 
Ricardo

Message #20 received at 36824 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 36824 <at> debbugs.gnu.org, dfrumin <at> cs.ru.nl
Subject: Re: [bug#36824] [PATCH] gnu: Add oshu.
Date: Mon, 29 Jul 2019 15:29:20 +0200

[Message part 1 (text/plain, inline)]

Ricardo,

Ricardo Wurmus 写道：
> Dan Frumin <dfrumin <at> cs.ru.nl> writes:
>
>>  > Ugh, no licence headers?  I guess that does make it GPL 
>>  > 3-only,
>>  > but I'm no expert.
>>
>> Yeah I am not sure about the headers, but the COPYING file 
>> indicates that it's GPL 3
>
> Here are more details:
>
>     https://github.com/fmang/oshu/blob/30b316173aca8fd6b2dce8b7d425845241ae5f13/src/oshu/main.cc#L69
>
> The license is GPL version 3 or later.

Thanks!  I opened about 5 files at random through the Web interfac 
but not the right one…

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 36824 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>
Cc: dfrumin <at> cs.ru.nl, 36824 <at> debbugs.gnu.org
Subject: Re: [bug#36824] [PATCH] gnu: Add oshu.
Date: Sat, 20 Feb 2021 20:07:32 +0100

[Message part 1 (text/plain, inline)]

Hello everyone,

I'm reviving this old patch and hopefully address most of the issues
raised for the old one while also sneaking in a version upgrade.

Regards,
Leo

[0001-gnu-Add-oshu.patch (text/x-patch, attachment)]

Message #26 received at 36824 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus
 <rekado <at> elephly.net>,  Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: dfrumin <at> cs.ru.nl, 36824 <at> debbugs.gnu.org
Subject: Re: [bug#36824] [PATCH] gnu: Add oshu.
Date: Sun, 21 Feb 2021 01:36:24 +0100

[Message part 1 (text/plain, inline)]

Hello again,

after Nicolas gave me some feedback in IRC I've sorted the package
fields and inputs and also now use @i for "proper names".  This is
somewhat consistent with other packages in Guix.

Regards,
Leo

Am Samstag, den 20.02.2021, 20:07 +0100 schrieb Leo Prikler:
> Hello everyone,
> 
> I'm reviving this old patch and hopefully address most of the issues
> raised for the old one while also sneaking in a version upgrade.
> 
> Regards,
> Leo

[0001-gnu-Add-oshu.patch (text/x-patch, attachment)]

Message #31 received at 36824-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus
 <rekado <at> elephly.net>,  Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: dfrumin <at> cs.ru.nl, 36824-done <at> debbugs.gnu.org
Subject: Re: [bug#36824] [PATCH] gnu: Add oshu.
Date: Wed, 24 Feb 2021 01:06:58 +0100

Am Sonntag, den 21.02.2021, 01:36 +0100 schrieb Leo Prikler:
> Hello again,
> 
> after Nicolas gave me some feedback in IRC I've sorted the package
> fields and inputs and also now use @i for "proper names".  This is
> somewhat consistent with other packages in Guix.
> 
> Regards,
> Leo

Sliding this in as 46c5ae03cef60d78463edd2e5934ed90c1cebcd7.  Hope none
of you want to spin.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.