Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 36861) by debbugs.gnu.org; 9 Aug 2020 19:18:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 09 15:18:32 2020 Received: from localhost ([127.0.0.1]:33467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1k4qq0-0003Mn-De for submit <at> debbugs.gnu.org; Sun, 09 Aug 2020 15:18:32 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1k4qpx-0003MP-NC for 36861 <at> debbugs.gnu.org; Sun, 09 Aug 2020 15:18:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yIKas1XntM2wqXc6wlNu4aHsE3akI/CX1iyONIDDqDg=; b=p30K+/q8DzDiSSQwBsNNH4WL8R F3B5XIvvJNDDUrciIPZ1MoNUB6d9OSd0saeoQXNIHJ7tJptNTKj1q6WYQWNJ6EfSAF2v13htohKQ8 X+4Y7QH9ZwLlKkT2ZsF43yDfTFSvEKCpmIqrK81eFaBqOWUv9bRpk9CpW8jbDWHrqEQY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1k4qpo-0002g0-EH; Sun, 09 Aug 2020 21:18:23 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN> <871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN> <87sgqhricg.fsf@HIDDEN> <B7351DA2-9B0D-4DA5-9AC6-CDB9B8CECE7E@HIDDEN> <87o914u65x.fsf@HIDDEN> <04C790C7-2667-4480-BDC9-BE838D307A74@HIDDEN> <837e7qcpbj.fsf@HIDDEN> <20190806175146.fpgzslvlaydpih7k@Ergus> <831rxycfqp.fsf@HIDDEN> <2F586079-3687-4DF0-984D-467F442E68D1@HIDDEN> <83sgqdavg9.fsf@HIDDEN> Date: Sun, 09 Aug 2020 21:18:18 +0200 In-Reply-To: <83sgqdavg9.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 07 Aug 2019 17:42:14 +0300") Message-ID: <87o8njbpc5.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> There is also the case when a user sets ?| by default and then call >> the function. If the check we add is just >> comparing to the default value then ?| will be always overwritten so >> an extra [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36861 Cc: Ergus <spacibba@HIDDEN>, 36861 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> There is also the case when a user sets ?| by default and then call >> the function. If the check we add is just >> comparing to the default value then ?| will be always overwritten so >> an extra internal variable will be needed to >> cache where the ?| comes from. > > Not sure we need another variable. After all, if the conditions > stayed the same, the result will be the same as well, and you will > overwrite the value with an identical one. Right? Reading the code, if display-fill-column-indicator-character is set, then the mode will never do its computation to see whether we can use the prettier U+2502 =E2=94=82 character. We could special-case that, thoug= h, and if it's ?|, then we replace it with ?=E2=94=82 (that is, ascii bar with Unicode bar). That would be kinda hacky, though, wouldn't it? Then there would no way to use the ASCII bar, for those that hate all things Unicode. So we'd need another variable, unfortunately. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.Received: (at 36861) by debbugs.gnu.org; 7 Aug 2019 14:42:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 07 10:42:32 2019 Received: from localhost ([127.0.0.1]:39199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hvN95-0003mO-TI for submit <at> debbugs.gnu.org; Wed, 07 Aug 2019 10:42:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1hvN94-0003mB-7A for 36861 <at> debbugs.gnu.org; Wed, 07 Aug 2019 10:42:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1hvN8y-0001yr-Jk; Wed, 07 Aug 2019 10:42:24 -0400 Received: from [176.228.60.248] (port=2375 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1hvN8x-0003fa-Mo; Wed, 07 Aug 2019 10:42:24 -0400 Date: Wed, 07 Aug 2019 17:42:14 +0300 Message-Id: <83sgqdavg9.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Ergus <spacibba@HIDDEN> In-reply-to: <2F586079-3687-4DF0-984D-467F442E68D1@HIDDEN> (message from Ergus on Tue, 06 Aug 2019 21:25:00 +0200) Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN> <871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN> <87sgqhricg.fsf@HIDDEN> <B7351DA2-9B0D-4DA5-9AC6-CDB9B8CECE7E@HIDDEN> <87o914u65x.fsf@HIDDEN> <04C790C7-2667-4480-BDC9-BE838D307A74@HIDDEN> <837e7qcpbj.fsf@HIDDEN> <20190806175146.fpgzslvlaydpih7k@Ergus> <831rxycfqp.fsf@HIDDEN> <2F586079-3687-4DF0-984D-467F442E68D1@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36861 Cc: 36861 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Tue, 06 Aug 2019 21:25:00 +0200 > CC: juri@HIDDEN,36861 <at> debbugs.gnu.org > From: Ergus <spacibba@HIDDEN> > > We can do that... I was just trying to avoid using ?| by default in any case. Why should we avoid that? It might be not the best alternative, but at least it lets users who just set the mode variable have an indicator. If they want a prettier display, they will have to call the mode function instead, as they do now. So I think this is a net win. Or am I missing something? > There is also the case when a user sets ?| by default and then call the function. If the check we add is just > comparing to the default value then ?| will be always overwritten so an extra internal variable will be needed to > cache where the ?| comes from. Not sure we need another variable. After all, if the conditions stayed the same, the result will be the same as well, and you will overwrite the value with an identical one. Right?
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.Received: (at 36861) by debbugs.gnu.org; 6 Aug 2019 19:25:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 15:25:16 2019 Received: from localhost ([127.0.0.1]:37799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hv559-0003qA-Tp for submit <at> debbugs.gnu.org; Tue, 06 Aug 2019 15:25:16 -0400 Received: from sonic309-25.consmr.mail.ir2.yahoo.com ([77.238.179.83]:45075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1hv557-0003pt-QR for 36861 <at> debbugs.gnu.org; Tue, 06 Aug 2019 15:25:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1565119507; bh=uOKowXAXBrkY7c7qVNuDoXCPCnPkjo3gbfDxest1DNo=; h=Date:In-Reply-To:References:Subject:To:From:From:Subject; b=H6qbXK60zomdTBVSpiwyKrUD9jtq967bG2KTbk7S3l+xeoL3UJRTOuNJfaFguZ8y+DBqxu2jFeU4+vrc4fRpKrixUyaYRYX9ZQ8gnCkKA+Yi6aFQtTDed6epDwxBQt6PRrqtxsAr46duXqsYadq1vwlMwsl905T6YifqVdR0FS6j/ke2JXlF8n1cph5lJyD/mmgT4+81QietDZ4FOm6XtWav5nS4A5HwnYuVGxlIko3q77SXD7ZcwUs3pGlrLCJ/lO4Q3gxvXgQqbRdq/p20Ov+uH+7wNpBs5hUFfo+U5OpgLoLKp4YcWnSXG3LkU8mDv8DPmlbfwJtHMFlb4yZHdQ== X-YMail-OSG: hIAttnsVM1kcQdZml_4ZyfLCw2W3NPRLB5oRIJ6SIhPaEgiB9q_bfeKEY3wokzU 3SLvNRv_MOSjq6IuqeEYmb8wFigFqUYn8bwIV5adDLmcTlxSZRRtXyf1ttjBQlxy9IXdTgqSAz1_ gydbTYIz1u1rY5Qjz_k30FO5YkADXII8OshaQ7tuE_v3USQw.upaWJEUPv1eW_gT.xs3B1zL_5cp QopKTHEUic2fcJr649CpGMrGEf6sauFmuSiJ2tMnQe_lRaMAmJsN5GFTJld944JdyAtHvZXK5U35 XS10DRtRu0OzZppniKTWCZIU_UOt9BDBuCBzZLB4UkFbsZTYxEjMyhc5PJPwD6mUz539AuEzt4K4 RiyPMhkZVbrrhq7S6pG4WMPGSOdFJsXShL5YqyOwi2F7rWiIoHIDkhvWRqlO.TxoiGibNnzRgdRE kmFaat54WGZlNY7EWUgQxQOAxGAhIp6YdowJUT1UvqcrBbzc7aLnLPX2HOnpik80_U7Fn93v3Y77 gTO4MuYcTI.Huky7e.K6nTJvx9LvnGbzgYq8n5ImMvyfUTmnEMkj0Em1LT.8flpaAiImQkoMqLsd GF6wd7tMe3RAEmbP0iSFI56IWC8kmKI_y_4hLT85IVzZyWjdYNVUn.OVJIWK5tkBn50GA7iHX8XG 9RA7QYt61y..Eps3ibtuMuivissfmOjLGlFIak8eG9JCRQBhW2GRvjxZZDj.YT8TfFxL_OBB7ahw jw8ULogExI74.mbhGRcwU3m0f4dn1o1dprE5RH1SknqMYPwKF7F42wWFIOLc7l2o87PYKZF366kE _6VtriXplpyf8Vw7HCCyId2Iu2Qt3X.AMzjGCQVbs.wqq6dzUBe2C3WUwhR02rxoX_mp3dCBt7no 49acg_hA0wzhcQ.MEz8cpipIYmW9ABahTCc4ZTKaVk5sIDvgA_3w8mz4H2ygNN8u8dtcg4aL4Wdk xDUzJsVTKEgfBLIIi7iMHBkZeOe5XqEYV0LDVuUXcsvA6v1arYRbqFymJ.gJ4wopXPJCo4y1MzBQ Pc_tBm9LGvv9NLXboezMO4Vs1akYdG124X85k1JHpAhZ7CobNeXOCCCWwOXZ9O1pJyg4_ZIpkEwV OF_BLf8Cyr8MMuuBTAcW4nb7SuTYai2HcIG8ZRh5r.0bWFQFB_IGBQQAMirX3FLh7EQ86o9BX.5j XOdCOx3LHz9nq2rYSV.VAJcr5r0syOwSgsUCjsOIoCUPH1WC.Y4qzjND9MFBffcxE7ow5QjW6u.d 0fIhZjR74E6MQ Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Tue, 6 Aug 2019 19:25:07 +0000 Received: by smtp420.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID b769fb70379b4d09306779308fb4124c; Tue, 06 Aug 2019 19:25:03 +0000 (UTC) Date: Tue, 06 Aug 2019 21:25:00 +0200 User-Agent: K-9 Mail for Android In-Reply-To: <831rxycfqp.fsf@HIDDEN> References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN> <871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN> <87sgqhricg.fsf@HIDDEN> <B7351DA2-9B0D-4DA5-9AC6-CDB9B8CECE7E@HIDDEN> <87o914u65x.fsf@HIDDEN> <04C790C7-2667-4480-BDC9-BE838D307A74@HIDDEN> <837e7qcpbj.fsf@HIDDEN> <20190806175146.fpgzslvlaydpih7k@Ergus> <831rxycfqp.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----0M3XFHE5MIYAOWEJQOZPMIB6ULP6Q9" Content-Transfer-Encoding: 7bit Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode To: Eli Zaretskii <eliz@HIDDEN> From: Ergus <spacibba@HIDDEN> Message-ID: <2F586079-3687-4DF0-984D-467F442E68D1@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36861 Cc: 36861 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) ------0M3XFHE5MIYAOWEJQOZPMIB6ULP6Q9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable We can do that=2E=2E=2E I was just trying to avoid using ?| by default in a= ny case=2E=20 There is also the case when a user sets ?| by default and then call the fu= nction=2E If the check we add is just comparing to the default value then ?= | will be always overwritten so an extra internal variable will be needed t= o cache where the ?| comes from=2E But OK, if this use case seems to be gen= eral enough I can make this changes=2E BTW=2E Have you seen my comments abo= ut the display engine in the other issue? Best, Ergus On August 6, 2019 8:26:22 PM GMT+02:00, Eli Zaretskii <eliz@gnu=2Eorg> wro= te: >> Date: Tue, 6 Aug 2019 19:51:46 +0200 >> From: Ergus <spacibba@aol=2Ecom> >> Cc: juri@linkov=2Enet, 36861@debbugs=2Egnu=2Eorg >>=20 >> >I don't think I understand the problem=2E Why doesn't just setting >the >> >characters and the mode variable work as expected? AFAIU, one needs >> >to call the mode function only if one wants Emacs to deduce the >> >indicator character automatically=2E >>=20 >> Hi: >>=20 >> It should work as you say=2E But the default value for >> display-fill-column-indicator-character is nil until the mode >function >> is executed (at least once)=2E >>=20 >> I think that what they want is >display-fill-column-indicator-character >> to be non-nil without initialization; which we cannot set without >some >> checks=2E > >Why can't we set display-fill-column-indicator-character to ?| by >default? Invoking the mode function will still do its job, but at >least people who want to just set the variable will have a functional >feature=2E Am I missing something? --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------0M3XFHE5MIYAOWEJQOZPMIB6ULP6Q9 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head></head><body>We can do that=2E=2E=2E I was just trying to avoid= using ?| by default in any case=2E <br><br>There is also the case when a u= ser sets ?| by default and then call the function=2E If the check we add is= just comparing to the default value then ?| will be always overwritten so = an extra internal variable will be needed to cache where the ?| comes from= =2E But OK, if this use case seems to be general enough I can make this cha= nges=2E BTW=2E Have you seen my comments about the display engine in the ot= her issue?<br>Best,<br>Ergus<br><br><br><br><div class=3D"gmail_quote">On A= ugust 6, 2019 8:26:22 PM GMT+02:00, Eli Zaretskii <eliz@gnu=2Eorg> wr= ote:<blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 0pt 0=2E8ex;= border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <pre class=3D"k9mail"><blockquote class=3D"gmail_quote" style=3D"margin: 0= pt 0pt 1ex 0=2E8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Dat= e: Tue, 6 Aug 2019 19:51:46 +0200<br>From: Ergus <spacibba@aol=2Ecom>= <br>Cc: juri@linkov=2Enet, 36861@debbugs=2Egnu=2Eorg<br><br><blockquote cla= ss=3D"gmail_quote" style=3D"margin: 0pt 0pt 1ex 0=2E8ex; border-left: 1px s= olid #ad7fa8; padding-left: 1ex;">I don't think I understand the problem=2E= Why doesn't just setting the<br>characters and the mode variable work as = expected? AFAIU, one needs<br>to call the mode function only if one wants = Emacs to deduce the<br>indicator character automatically=2E<br></blockquote= ><br>Hi:<br><br>It should work as you say=2E But the default value for<br>d= isplay-fill-column-indicator-character is nil until the mode function<br>is= executed (at least once)=2E<br><br>I think that what they want is display-= fill-column-indicator-character<br>to be non-nil without initialization; wh= ich we cannot set without some<br>checks=2E<br></blockquote><br>Why can't w= e set display-fill-column-indicator-character to ?| by<br>default? Invokin= g the mode function will still do its job, but at<br>least people who want = to just set the variable will have a functional<br>feature=2E Am I missing= something?<br></pre></blockquote></div><br>-- <br>Sent from my Android dev= ice with K-9 Mail=2E Please excuse my brevity=2E</body></html> ------0M3XFHE5MIYAOWEJQOZPMIB6ULP6Q9--
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.Received: (at 36861) by debbugs.gnu.org; 6 Aug 2019 18:26:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 14:26:41 2019 Received: from localhost ([127.0.0.1]:37754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hv4AT-0004Ip-CG for submit <at> debbugs.gnu.org; Tue, 06 Aug 2019 14:26:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1hv4AS-0004Ie-IK for 36861 <at> debbugs.gnu.org; Tue, 06 Aug 2019 14:26:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1hv4AN-00057y-3I; Tue, 06 Aug 2019 14:26:35 -0400 Received: from [176.228.60.248] (port=4120 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1hv4AL-00017b-5j; Tue, 06 Aug 2019 14:26:34 -0400 Date: Tue, 06 Aug 2019 21:26:22 +0300 Message-Id: <831rxycfqp.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Ergus <spacibba@HIDDEN> In-reply-to: <20190806175146.fpgzslvlaydpih7k@Ergus> (message from Ergus on Tue, 6 Aug 2019 19:51:46 +0200) Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN> <871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN> <87sgqhricg.fsf@HIDDEN> <B7351DA2-9B0D-4DA5-9AC6-CDB9B8CECE7E@HIDDEN> <87o914u65x.fsf@HIDDEN> <04C790C7-2667-4480-BDC9-BE838D307A74@HIDDEN> <837e7qcpbj.fsf@HIDDEN> <20190806175146.fpgzslvlaydpih7k@Ergus> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36861 Cc: 36861 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Tue, 6 Aug 2019 19:51:46 +0200 > From: Ergus <spacibba@HIDDEN> > Cc: juri@HIDDEN, 36861 <at> debbugs.gnu.org > > >I don't think I understand the problem. Why doesn't just setting the > >characters and the mode variable work as expected? AFAIU, one needs > >to call the mode function only if one wants Emacs to deduce the > >indicator character automatically. > > Hi: > > It should work as you say. But the default value for > display-fill-column-indicator-character is nil until the mode function > is executed (at least once). > > I think that what they want is display-fill-column-indicator-character > to be non-nil without initialization; which we cannot set without some > checks. Why can't we set display-fill-column-indicator-character to ?| by default? Invoking the mode function will still do its job, but at least people who want to just set the variable will have a functional feature. Am I missing something?
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.Received: (at 36861) by debbugs.gnu.org; 6 Aug 2019 17:52:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 13:52:04 2019 Received: from localhost ([127.0.0.1]:37727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hv3cx-0003B7-FE for submit <at> debbugs.gnu.org; Tue, 06 Aug 2019 13:52:04 -0400 Received: from sonic310-11.consmr.mail.ir2.yahoo.com ([77.238.177.32]:37224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1hv3cv-0003Ac-IM for 36861 <at> debbugs.gnu.org; Tue, 06 Aug 2019 13:52:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1565113914; bh=uOgKKxfRwC9YPlWi3SsSgNsJCD68QUZPhbvsMW7VRvs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=dTgKwz1GsniK7VkcKLdGvUNJhnXiOtngNTLKJ8AXt9LP90MrznjEh52j303//zMqIYD3kpQ4fiT4Ywm7Hy9fKIYHkX1t7UnWvncRhrMKjYuJgoXf6qzfOmqID0uKpZj380NBPIS5Ed/ela4jco6XrurAgUjnQmmbdABba8jkDx4o+C9skZ05fax/D6ZFKI2uXnC2Q+yj9l92J40sSKK3WkdHU8p4AxFF82Av9wYybZm4fVHC+j1yMqSWbBhlipC6cNwFkdeBVCPGkGgX7oJm1SAexIZaVaf4fiDpv0DN4dDRXSyezrGJojs9BRKCrQVjB7zLtR/eIAqtoneHZTUo0Q== X-YMail-OSG: buXSF.YVM1kHS2Y_OybeWIckfCIBKY59YSWUY2sHLtgUTGJ7EqLeaoLpyvqLcCc QlOCh6MsjlbpVXwxneriYUJYFVttcnzgF57O5.odWDo4hs2bs23yWigF973JyW5YXN8EuWilUWcu 8RZ1.4XUOT4ez_mO2Ayg1Hu9XGnvUNnCJai3E.eamBNm75ywRh8tqHcwNtXF2pdsBecCXViaDALN GZFgRJdcYAQ7hgsVdqwTxk8QaMviKYGgIHc0B0kLWGJsV2Ji893QTSCrIQZFIHRTwdhmHCxHjtlW d0MUuk8N9EnhC4Xy1g2Bywk4spRwbKsfQSAm9GBrra55xEG98k1mbCPXDiGx4IiADVuSSQZxVi5m 2vO_aVELwvdTtcNwD4OesMn1Yx0Zpu5OerBETNWDTn6_Rz0_Ry.xItiXAibk38clbYj1s3HWDWD2 MvUMSVsfGS3jLT6D.q.sjgam5gewzNT6pBj_I.FlNw_cODDW2X6fxosJl.a1KNLlq6kyEhW7iSoW C12Yz4ck.qNDHl_KvtDCyri_HLaS6gIpbdDBdif7auGg2d7clBJegUyp20hVIsYgAP8gzDp3XymQ bt0x_.AdFjRMZe.xUiBWE8qhqG14gxJaVwNxUnaua1EOAFYCv_y7WXUV_fjCS.EuEgpkB1So8R0K LDKMA9pTYeSENd4yFHjaqP1V7s26rbbCa_0liLzWFcOu.L42M8.uUr_3BzUI.AscNeWxOLCgZWaY lbFJicnCxYgCe2iK1I8f1uZJbkZRFqrU8ajsP0N_5syiBaWfjqpGtdpeNSY4XpoQ45Ba43waiFOY JPifi3tsCfWnSpH8Qp9lIQzceXocbYNApGzFj9y4SxzoGrWVgyTd6H21Zc9th_8gPn0WpW7IddTS pxK4lWPFj2ZCJUcWzKiNuwITX0d6i.2Kcag9LM1hapqOkWIyasSMlGXbN09jDief9MIi5wnSDkrQ suMzi2KEURlBVV.Ssj.CwReskMaiJC7oz0toaMNMTMoCOJRKCUWVJM2r03Dpbz9fvs2OH3Qy9fhI .UBU4S2uKvg51nP5S244yGYc8nP36JkoLT5bE0zo266_vlD0XC4Qz27qJU1bS9Af5G.CWVWF1M0P xGml6tog01GbwfPX67LRvtzHVFxN.DcMqVSi8L86mDPI51pLnvLm6MqYQ70ecv.8P2VcxBms7KnQ PE7FmSAhWWpMU9E9pAkx.X7lzmiB4zF1VdQehwmmFplws3lu_fFG4aimRNBZ.sd.XokP_vyLhvU8 lls34yzu8.UzYzuy93k91 Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Tue, 6 Aug 2019 17:51:54 +0000 Received: by smtp404.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID a2ed279da6699d48ba0a7e645d050761; Tue, 06 Aug 2019 17:51:49 +0000 (UTC) Date: Tue, 6 Aug 2019 19:51:46 +0200 From: Ergus <spacibba@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Message-ID: <20190806175146.fpgzslvlaydpih7k@Ergus> References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN> <871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN> <87sgqhricg.fsf@HIDDEN> <B7351DA2-9B0D-4DA5-9AC6-CDB9B8CECE7E@HIDDEN> <87o914u65x.fsf@HIDDEN> <04C790C7-2667-4480-BDC9-BE838D307A74@HIDDEN> <837e7qcpbj.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <837e7qcpbj.fsf@HIDDEN> User-Agent: NeoMutt/20180716 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36861 Cc: 36861 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, Aug 06, 2019 at 05:59:28PM +0300, Eli Zaretskii wrote: >> Date: Sun, 04 Aug 2019 22:30:05 +0200 >> CC: Eli Zaretskii <eliz@HIDDEN>,36861 <at> debbugs.gnu.org >> From: Ergus <spacibba@HIDDEN> >> >> Dfci was not designed to be used in this way, and the mode initialization actually sets the character, but in the >> future it could make many other dynamic tests/checks if needed. So I don't think we should modify it to work >> the other way you suggest, because for menit is not general enough. But I will follow the Eli's suggestions in >> this aspects more than my own opinion. >> Any way, if you want to use the mode in this way (for now) you can/need to set the >> display-fill-column-indicator-character to your desired value and it should work as it is now. But I can't promise >> that it will work the same way in the future. >> But again, probably Eli will suggest a better solution for your use case. > >I don't think I understand the problem. Why doesn't just setting the >characters and the mode variable work as expected? AFAIU, one needs >to call the mode function only if one wants Emacs to deduce the >indicator character automatically. Hi: It should work as you say. But the default value for display-fill-column-indicator-character is nil until the mode function is executed (at least once). I think that what they want is display-fill-column-indicator-character to be non-nil without initialization; which we cannot set without some checks. Probably I'll need to reword the doc string about the default value to specify that the value is really nil and it is initialized to the other non-nil values in the mode function. Does it makes sense?
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.Received: (at 36861) by debbugs.gnu.org; 6 Aug 2019 14:59:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 10:59:50 2019 Received: from localhost ([127.0.0.1]:37639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hv0wH-00030A-RR for submit <at> debbugs.gnu.org; Tue, 06 Aug 2019 10:59:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1hv0wE-0002zx-DS for 36861 <at> debbugs.gnu.org; Tue, 06 Aug 2019 10:59:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1hv0w8-0006Lq-RZ; Tue, 06 Aug 2019 10:59:40 -0400 Received: from [176.228.60.248] (port=3346 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1hv0w8-0006e7-4R; Tue, 06 Aug 2019 10:59:40 -0400 Date: Tue, 06 Aug 2019 17:59:28 +0300 Message-Id: <837e7qcpbj.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Ergus <spacibba@HIDDEN> In-reply-to: <04C790C7-2667-4480-BDC9-BE838D307A74@HIDDEN> (message from Ergus on Sun, 04 Aug 2019 22:30:05 +0200) Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN> <871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN> <87sgqhricg.fsf@HIDDEN> <B7351DA2-9B0D-4DA5-9AC6-CDB9B8CECE7E@HIDDEN> <87o914u65x.fsf@HIDDEN> <04C790C7-2667-4480-BDC9-BE838D307A74@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36861 Cc: 36861 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sun, 04 Aug 2019 22:30:05 +0200 > CC: Eli Zaretskii <eliz@HIDDEN>,36861 <at> debbugs.gnu.org > From: Ergus <spacibba@HIDDEN> > > Dfci was not designed to be used in this way, and the mode initialization actually sets the character, but in the > future it could make many other dynamic tests/checks if needed. So I don't think we should modify it to work > the other way you suggest, because for menit is not general enough. But I will follow the Eli's suggestions in > this aspects more than my own opinion. > Any way, if you want to use the mode in this way (for now) you can/need to set the > display-fill-column-indicator-character to your desired value and it should work as it is now. But I can't promise > that it will work the same way in the future. > But again, probably Eli will suggest a better solution for your use case. I don't think I understand the problem. Why doesn't just setting the characters and the mode variable work as expected? AFAIU, one needs to call the mode function only if one wants Emacs to deduce the indicator character automatically.
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 36861) by debbugs.gnu.org; 5 Aug 2019 21:47:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 05 17:47:43 2019
Received: from localhost ([127.0.0.1]:35986 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hukpP-0005f6-SV
for submit <at> debbugs.gnu.org; Mon, 05 Aug 2019 17:47:40 -0400
Received: from camel.birch.relay.mailchannels.net ([23.83.209.29]:14033)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>)
id 1hukpN-0005ev-Uo; Mon, 05 Aug 2019 17:47:38 -0400
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
by relay.mailchannels.net (Postfix) with ESMTP id AC492216A9;
Mon, 5 Aug 2019 21:47:36 +0000 (UTC)
Received: from pdx1-sub0-mail-a2.g.dreamhost.com
(100-96-29-186.trex.outbound.svc.cluster.local [100.96.29.186])
(Authenticated sender: dreamhost)
by relay.mailchannels.net (Postfix) with ESMTPA id 30AC3216A7;
Mon, 5 Aug 2019 21:47:36 +0000 (UTC)
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from pdx1-sub0-mail-a2.g.dreamhost.com ([TEMPUNAVAIL].
[64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)
by 0.0.0.0:2500 (trex/5.17.5); Mon, 05 Aug 2019 21:47:36 +0000
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Keen-Trail: 48252de941bd5914_1565041656486_2720968957
X-MC-Loop-Signature: 1565041656486:1141340942
X-MC-Ingress-Time: 1565041656486
Received: from pdx1-sub0-mail-a2.g.dreamhost.com (localhost [127.0.0.1])
by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTP id 0F9E3837E1;
Mon, 5 Aug 2019 14:47:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc
:subject:references:date:in-reply-to:message-id:mime-version
:content-type; s=linkov.net; bh=o+l8750a+HnF1CveDNO78Wu0VOY=; b=
07h/QPbgpMRE+I8I1iKffUAhWGRe2K4mPhpKgFgzyBGcpj+Bxz99eCSg0Btw9KgA
zq803e2MrBB9Pz2UxfLsWypn51/W7K3qf2oMZCQyx4AfS0qkrkgSk9SygwIRpYB6
daKivbzMNdG0+HeitaP1nhnlrd9n+V5jtP4u7dD3zPs=
Received: from mail.jurta.org (m91-129-103-91.cust.tele2.ee [91.129.103.91])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
(Authenticated sender: jurta@HIDDEN)
by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTPSA id 2D165837E0;
Mon, 5 Aug 2019 14:47:28 -0700 (PDT)
X-DH-BACKEND: pdx1-sub0-mail-a2
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in
log-edit-mode
Organization: LINKOV.NET
References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN>
<871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN>
Date: Tue, 06 Aug 2019 00:43:18 +0300
In-Reply-To: <83zhksexvx.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 02 Aug
2019 12:10:10 +0300")
Message-ID: <87k1bruw3t.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-VR-OUT-STATUS: OK
X-VR-OUT-SCORE: -100
X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddruddtledgtdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucffohhmrghinhepvghlrdhsohenucfkphepledurdduvdelrddutdefrdeludenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdeluddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36861
Cc: 36861 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
severity 36861 wishlist
tags 36861 + patch
quit
>> diff --git a/lisp/cus-start.el b/lisp/cus-start.el
>> (display-fill-column-indicator-character display-fill-column-indicator
>> - character "27.1")
>> + character "27.1" :safe characterp)
>
> This is fine with me, but I don't think we should make the change in
> .dir-locals.el.
So I only added :safe in cus-start.el. And leaving here the
patch for the time when after Emacs 27 release it could be added
to .dir-locals.el:
diff --git a/.dir-locals.el b/.dir-locals.el
index 35dc154375..4d0151f355 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -12,7 +12,9 @@
(electric-quote-string . nil)
(mode . bug-reference-prog)))
(log-edit-mode . ((log-edit-font-lock-gnu-style . t)
- (log-edit-setup-add-author . t)))
+ (log-edit-setup-add-author . t)
+ (display-fill-column-indicator-column . 78)
+ (mode . display-fill-column-indicator)))
(change-log-mode . ((add-log-time-zone-rule . t)
(fill-column . 74)
(mode . bug-reference)))
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.Received: (at 36861) by debbugs.gnu.org; 4 Aug 2019 20:30:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 04 16:30:42 2019 Received: from localhost ([127.0.0.1]:34292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1huN9N-0007Eg-FO for submit <at> debbugs.gnu.org; Sun, 04 Aug 2019 16:30:41 -0400 Received: from sonic302-21.consmr.mail.ir2.yahoo.com ([87.248.110.84]:34261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1huN9J-0007EM-Dh for 36861 <at> debbugs.gnu.org; Sun, 04 Aug 2019 16:30:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1564950630; bh=1rZRmKdeOQzDicd4+ck1Rt6MKy4UCaoMOUiBLflg8sI=; h=Date:In-Reply-To:References:Subject:To:From:From:Subject; b=gVB6hVbVMnudXS/41ijZMiycbPlW/KtObyBJl5oDxtMnUkYljivv6e/9iaq9xh0aXdmCmS0+7RLK8/zPqiumO+s/jhyM4x64leQoEsQ5b31eB3Vv/TyEXRMJmu2+9Hui3EEokZek/Fzuvs01B1dxJWDMkaqF9a4hkbtXrABju5sWUnEkticIELl6GKSlooCEDKczit2jX08yVvcfpwHuRcWfb/M8px+g2S0odbQgp3loA9vcK7F/PsYjxf4VjA+sWKWMPE8mo0gPJ7c4MkdnkovLlKoCStNN4C9HSpZNpFhxtHEd/kroElxu3jNa8phbTe2Y0vKhECjoB8gQA6ZZzQ== X-YMail-OSG: JlZhOcIVM1lNXcIyd0HoONV2tuZQX_5pC_NA5OwGE1XqwjXz4LxnLcf.fO85BW_ pkIWwCHLdliCgJl8IpxKo2COoxe_gElc47dVvGumlrdycykoHufm3b46pEtWmO9J7Yg6CEjOTAb_ DxmyHjMIq2xnVE6vBecjMELpXFBSiQcU2orL0Oa2b7N1rALhHcdMvPeGF_60c9rXwygQ77HNHwyJ NtgPWLO4bPrdx.oWmYdaqfTBWfLdTKMV6se90koaF4esEJwptdCEl1_eSPUr_0Mn0_IHK6hiNnqh Tz6lOOF8zXiNo1yNhPzsUX3X.O2oExV9fT_u_pOX5PaH2LcRM5UoEklJZ_DPk3_2IjHHLN6a3gUy DuzaEWP_gV3DCQF3A60gwcgM_xHm8nctEOfjbirC5XR8RGnPkTSDQ7hpdckK6EMmK9y1gxkftUcr pl4iATPAIKjO8lUOTmB9oPQ6xTxncUNJ1_zpL8I5VyPR2jwD5cyo26JKB8kTU4aD5wpNJ887Gm57 Bg2m5Ai7eZvnCznddPWTVFXemGUEm9Vx5uhcgOYS5e0I2d7oG8Gwm9YJgjdyfVYEB5ASdsJiigh7 qjkL6OObjAIEip8I0S9ZCAKllctN2QH1Y0PokIlLP8E9920Dh.2Eg92426lL1T25A9I81l_5ONMC hajVOGP6fh_L16xSIsN6GWcJ_y1_lETurSczsBvW5.Wa3nhasInb.b.mbRl7CLw8hnkXfNAzFo_4 T5Efkl2.Z.lKrAE3YMSFTEu6BkPCcf1r.vh2LtrIK9nI5xshDoOO_xPI_2YByUSY2x.IuxxWYVS8 .TMaIKok0aklU5Zcvd4Eu2eM.vvK5_hcXpry2r4KkUAd.EsvSWS4vCIjbzWWdCsCi1.mMhs67Mx8 4Xr674QmZkQlQzcXgybMHTucOWEGQ9.Jg7tDLD2rKQrPmsqONdcn.IOfkrbmL9bAzIfjo7oDXWrK llv9jEM462qvZwedHxUfbk2l2XxOd8hSO.Z0vTfCKQp3lmqSBgQxLErw.fAqcu.660DbytKJAa9L pj0gDgC7eLIvuH00lYf9rekbAyXJf.eURUwOw4UM2.iUxzlGBVPVxi9GYtg_ELbLzoonrx6nmJzQ l3JUHbP.cm3sQSH.Gjx.lUPfcNzaopEfwNzERGO_VXsVqoBA1K2O0zKYMbn7k4Qb4aFVdhA8CURE xN0j5wFzlhFeVih1IP7.2FKoMfefFu6QB5v1iGoGqw8vRSXX3byKOzNylUXTP0QdjqfaoORKW0rV _10xtlKpKUhA- Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Sun, 4 Aug 2019 20:30:30 +0000 Received: by smtp406.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID a34b447647d1668c41b7af5c8b99158a; Sun, 04 Aug 2019 20:30:28 +0000 (UTC) Date: Sun, 04 Aug 2019 22:30:05 +0200 User-Agent: K-9 Mail for Android In-Reply-To: <87o914u65x.fsf@HIDDEN> References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN> <871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN> <87sgqhricg.fsf@HIDDEN> <B7351DA2-9B0D-4DA5-9AC6-CDB9B8CECE7E@HIDDEN> <87o914u65x.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----9EEVRQDT6Q2YY3GD1MP72ZQ6UH4JV9" Content-Transfer-Encoding: 7bit Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode To: Juri Linkov <juri@HIDDEN> From: Ergus <spacibba@HIDDEN> Message-ID: <04C790C7-2667-4480-BDC9-BE838D307A74@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36861 Cc: Eli Zaretskii <eliz@HIDDEN>, 36861 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) ------9EEVRQDT6Q2YY3GD1MP72ZQ6UH4JV9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dfci was not designed to be used in this way, and the mode initialization a= ctually sets the character, but in the future it could make many other dyna= mic tests/checks if needed=2E So I don't think we should modify it to work = the other way you suggest, because for menit is not general enough=2E But I= will follow the Eli's suggestions in this aspects more than my own opinion= =2E=20 Any way, if you want to use the mode in this way (for now) you can/need to= set the display-fill-column-indicator-character to your desired value and = it should work as it is now=2E But I can't promise that it will work the sa= me way in the future=2E But again, probably Eli will suggest a better solution for your use case= =2E On August 4, 2019 9:39:06 PM GMT+02:00, Juri Linkov <juri@linkov=2Enet> wr= ote: >> Hi, sorry, I don't understand actually why is so complex this >provided code >> in the email=2E The initialization for display-fill-column-indicator >makes >> some checks to set the default character as described in the >documentation, >> so no extra code is needed for that in the user side=2E >> In the initialization I see in this mail, they just set the column's >value >> to 78 which can be done also using the variable fill-column for the >whole >> major mode too=2E And actually dfci will recognize it by default and >other >> functionalities too so in the general scenario is better to use that >one=2E >> >> (setq fill-column 78) >> (display-fill-column-indicator t) >> >> Should work no matters the order=2E Maybe as you were setting the >mode's >> variable instead of calling the function with the same name; the mode >> was not properly initialized=2E > >The problem is that is when the need is to enable dfci, it is simpler >to avoid eval to enable this mode because dfci works fine without using >dfci-mode, i=2Ee=2E when only variables are set in Local Variables: > > ;;; Local Variables: > ;;; display-fill-column-indicator: t > ;;; display-fill-column-indicator-column: 78 > ;;; End: > >or in =2Edir-locals=2Eel: > > (display-fill-column-indicator =2E t) > (display-fill-column-indicator-column =2E 78) > >But the display-fill-column-indicator-character can't be set >in Local Variables because its value depends on the current display: >either U+2502 or ?| if the font does not support Unicode characters=2E > >Do you think it would be possible to set the default value of >display-fill-column-indicator-character without calling >display-fill-column-indicator-mode? --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------9EEVRQDT6Q2YY3GD1MP72ZQ6UH4JV9 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head></head><body>Dfci was not designed to be used in this way, and = the mode initialization actually sets the character, but in the future it c= ould make many other dynamic tests/checks if needed=2E So I don't think we = should modify it to work the other way you suggest, because for menit is no= t general enough=2E But I will follow the Eli's suggestions in this aspects= more than my own opinion=2E <br>Any way, if you want to use the mode in th= is way (for now) you can/need to set the display-fill-column-indicator-char= acter to your desired value and it should work as it is now=2E But I can't = promise that it will work the same way in the future=2E<br>But again, proba= bly Eli will suggest a better solution for your use case=2E<br><br><br><div= class=3D"gmail_quote">On August 4, 2019 9:39:06 PM GMT+02:00, Juri Linkov = <juri@linkov=2Enet> wrote:<blockquote class=3D"gmail_quote" style=3D"= margin: 0pt 0pt 0pt 0=2E8ex; border-left: 1px solid rgb(204, 204, 204); pad= ding-left: 1ex;"> <pre class=3D"k9mail"><blockquote class=3D"gmail_quote" style=3D"margin: 0= pt 0pt 1ex 0=2E8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Hi= , sorry, I don't understand actually why is so complex this provided code<b= r> in the email=2E The initialization for display-fill-column-indicator mak= es<br> some checks to set the default character as described in the documen= tation,<br> so no extra code is needed for that in the user side=2E<br> In = the initialization I see in this mail, they just set the column's value<br>= to 78 which can be done also using the variable fill-column for the whole<= br> major mode too=2E And actually dfci will recognize it by default and ot= her<br> functionalities too so in the general scenario is better to use tha= t one=2E<br><br> (setq fill-column 78)<br> (display-fill-column-indicator t= )<br><br> Should work no matters the order=2E Maybe as you were setting the= mode's<br> variable instead of calling the function with the same name; th= e mode<br> was not properly initialized=2E<br></blockquote><br>The problem = is that is when the need is to enable dfci, it is simpler<br>to avoid eval = to enable this mode because dfci works fine without using<br>dfci-mode, i= =2Ee=2E when only variables are set in Local Variables:<br><br> ;;; Local = Variables:<br> ;;; display-fill-column-indicator: t<br> ;;; display-fill-= column-indicator-column: 78<br> ;;; End:<br><br>or in =2Edir-locals=2Eel:<= br><br> (display-fill-column-indicator =2E t)<br> (display-fill-column-in= dicator-column =2E 78)<br><br>But the display-fill-column-indicator-charact= er can't be set<br>in Local Variables because its value depends on the curr= ent display:<br>either U+2502 or ?| if the font does not support Unicode ch= aracters=2E<br><br>Do you think it would be possible to set the default val= ue of<br>display-fill-column-indicator-character without calling<br>display= -fill-column-indicator-mode?<br></pre></blockquote></div><br>-- <br>Sent fr= om my Android device with K-9 Mail=2E Please excuse my brevity=2E</body></h= tml> ------9EEVRQDT6Q2YY3GD1MP72ZQ6UH4JV9--
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.Received: (at 36861) by debbugs.gnu.org; 4 Aug 2019 19:51:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 04 15:51:01 2019 Received: from localhost ([127.0.0.1]:34265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1huMWz-0006Cn-2Z for submit <at> debbugs.gnu.org; Sun, 04 Aug 2019 15:51:01 -0400 Received: from antelope.elm.relay.mailchannels.net ([23.83.212.4]:18445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1huMWx-0006Cf-Bf for 36861 <at> debbugs.gnu.org; Sun, 04 Aug 2019 15:50:59 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 427061A0AF7; Sun, 4 Aug 2019 19:50:58 +0000 (UTC) Received: from pdx1-sub0-mail-a13.g.dreamhost.com (100-96-4-69.trex.outbound.svc.cluster.local [100.96.4.69]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A23D51A0993; Sun, 4 Aug 2019 19:50:57 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN Received: from pdx1-sub0-mail-a13.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Sun, 04 Aug 2019 19:50:58 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN X-MailChannels-Auth-Id: dreamhost X-Broad-Scare: 34b98fb9175d74ba_1564948257943_1373951969 X-MC-Loop-Signature: 1564948257942:2041285923 X-MC-Ingress-Time: 1564948257942 Received: from pdx1-sub0-mail-a13.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a13.g.dreamhost.com (Postfix) with ESMTP id 6A6DF7FE4A; Sun, 4 Aug 2019 12:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=apHern8bZDB4YJfEwxXIk0GndCg=; b= S9hVdVEN77drE19UxsW19jxxXF+V/jsTwF5+LAgwE6SOecY7XZ1mpQea6Ig0Vt8a QUk6EfByUhKnN4BB48ybiHqWO41Mj7J6t9LLg2thGXg64mKBb000FRHFhWoP5AAv vO3fZnfeEWLNUGPmqgTzZzO1GxVJ683LiVOAWPJLTsM= Received: from mail.jurta.org (m91-129-103-91.cust.tele2.ee [91.129.103.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@HIDDEN) by pdx1-sub0-mail-a13.g.dreamhost.com (Postfix) with ESMTPSA id AF0807FE67; Sun, 4 Aug 2019 12:50:48 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a13 From: Juri Linkov <juri@HIDDEN> To: Ergus <spacibba@HIDDEN> Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Organization: LINKOV.NET References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN> <871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN> <87sgqhricg.fsf@HIDDEN> <B7351DA2-9B0D-4DA5-9AC6-CDB9B8CECE7E@HIDDEN> Date: Sun, 04 Aug 2019 22:39:06 +0300 In-Reply-To: <B7351DA2-9B0D-4DA5-9AC6-CDB9B8CECE7E@HIDDEN> (Ergus's message of "Sun, 04 Aug 2019 02:51:04 +0200") Message-ID: <87o914u65x.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddruddthedgudeggecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrledunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrledupdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepshhprggtihgssggrsegrohhlrdgtohhmnecuvehluhhsthgvrhfuihiivgepfe X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36861 Cc: Eli Zaretskii <eliz@HIDDEN>, 36861 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > Hi, sorry, I don't understand actually why is so complex this provided code > in the email. The initialization for display-fill-column-indicator makes > some checks to set the default character as described in the documentation, > so no extra code is needed for that in the user side. > In the initialization I see in this mail, they just set the column's value > to 78 which can be done also using the variable fill-column for the whole > major mode too. And actually dfci will recognize it by default and other > functionalities too so in the general scenario is better to use that one. > > (setq fill-column 78) > (display-fill-column-indicator t) > > Should work no matters the order. Maybe as you were setting the mode's > variable instead of calling the function with the same name; the mode > was not properly initialized. The problem is that is when the need is to enable dfci, it is simpler to avoid eval to enable this mode because dfci works fine without using dfci-mode, i.e. when only variables are set in Local Variables: ;;; Local Variables: ;;; display-fill-column-indicator: t ;;; display-fill-column-indicator-column: 78 ;;; End: or in .dir-locals.el: (display-fill-column-indicator . t) (display-fill-column-indicator-column . 78) But the display-fill-column-indicator-character can't be set in Local Variables because its value depends on the current display: either U+2502 or ?| if the font does not support Unicode characters. Do you think it would be possible to set the default value of display-fill-column-indicator-character without calling display-fill-column-indicator-mode?
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.
Received: (at 36861) by debbugs.gnu.org; 4 Aug 2019 00:51:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 03 20:51:26 2019
Received: from localhost ([127.0.0.1]:60234 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hu4k9-0000Vn-MT
for submit <at> debbugs.gnu.org; Sat, 03 Aug 2019 20:51:26 -0400
Received: from sonic314-20.consmr.mail.ir2.yahoo.com ([77.238.177.146]:38867)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <spacibba@HIDDEN>) id 1hu4k6-0000VY-7X
for 36861 <at> debbugs.gnu.org; Sat, 03 Aug 2019 20:51:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
t=1564879876; bh=d7ljeWpJsyMMi5y3PVTopb54LJFbE2uJL13C9NNLdcc=;
h=Date:In-Reply-To:References:Subject:To:From:From:Subject;
b=o7OcwXfa9vgaEMsAN+GwTkHZQ3cAJvFUXG5A0BlAd8vFz/lrcDVvSwJBYBLKlXIKrIURwiwNEhfVE29JgRi2eSoGrOrh2Ny2e7+Bb/6oK+/CkFWolihL6f5XrhGyl4q2pPhoYi5H3sNMilZP9+8gnWOcrK6tPskx0+EDOSm6I+OWSeH3REZRf3rVuC0zMOgkKMuPV14MDUoc5JcFL6iI9k9+cuHkrVUWADTju6n5sEVVB2VGV+dQ1ACQH93yTYhaAAPiNmhplOS1zL34q1RJtiGYxHc84nC7LTy3TVCOLzfW0WJ8+HbHtrEb16Zi5hMZaiDP5W19ZYCqXBZurjZWiQ==
X-YMail-OSG: tUEKx0MVM1nIzJIGCzi5v4VP8h84Wtr85ZExpR0akN0QlZq0XpM8AH2XuDcTDVl
.eVfGHoSAFa_ckhzQhgxNgAMOzz7KTLlZRwBuXthzhsMBERpfH86T4cCZ11wbcOM5.eg3cWRmfMQ
Ma6usgZGFibYGhHp8seADkkOaIm1sGs9aqofkXxTkn4llTuvvzkRNXXOkZJ7pb6sF6OPK8edbhBp
5IJhXKdSmqLFe2A4gtP5uKbr0JLwECgQ6qfpFpWFHgLtTD6..uBUxMf8WlxaWODXTK_s_inKAE7o
weEPNgGQ._SH0BUvjbHf59xNPPRfuw_nak.b.2dPGE_OAoMFpaAW7_QCPs9LV7UDTz_o63iOa6pR
LT73C24krBKcSaOcCmakiN1uoTnOAgfJJd3Wfeb2GDSN0I_1pM1yr4j1ZunxZnul3GgXROKxOAKC
u3sZgc3T5s2fOgCFY0MIgMwBUgx3KZJa8z05x16GOCIUYNdn2mSESr890FiMAkUiLxG_h6IC8p.q
mibk8zrcSM56l_7myv75UlFt8Bsv.7j2W9VwowKYZlhnarfIe8ZEChUe_J8PQmn_I3Cf4ibzVasZ
VjO2z0qdgT9KjMzcp4jaEocIjMFyRjB6LTpl5EVX1dB3O9mQgxBq5kHN9qRUHTH0ycsRipZKnRkr
DIXvDtprqGAv9r1Ypj5YWsqQ1Rn8HQ9cf3pHrZ8ATdqvhd5KFxyM9JG59rLIht_sS_Ui1u6IeyGI
P1A117deiv2DFBC1l4K0bMyJUxFKgkhnHiTy2fmv0MyrmGDBK545NRhfzDmpuvgfqtjU9xNhb8yM
CokE54HgbyR_Or8c05vP3.hF9qXpzYjjVNASkxuK.diDs.xGKVkuPNvSuPRK5cdJdUvQJgAfSm6_
mxR2VVXddJcgsQ0zFMQD5_.o4pGQzEjm.50KhWZ530R4opUSIq.VJoPWDD4tFXMvtmCGG4I2JeFE
KnZ1V_YeMMFdCfJrSfsiy8vFf3LZomQ9MCJVftbb4X1zLdoSCitTPdZMM03oOdDT1d_qk3o63O8t
5ADi5nQfw.EwARa07phNxHezO00GPX6uuY5eF6o7375c2Fo2HWl_98RyDj3l3NXqSTcnjXeC255w
EZ8DA1nAHVE2M85DluCxS3_sTJ.v4YR4c2w3TL8SD.YO7GQSI9ZhKF9370gz8kefrgU6SjyjX.Pn
G.LjzHdNOj8mgTVSN11LRG6Y4AVSPN4tVjI41ZbTY83iW.DYiQsdwV7s31TTkbIFveM1L0V1gwcp
QB.YwiOsONNk-
Received: from sonic.gate.mail.ne1.yahoo.com by
sonic314.consmr.mail.ir2.yahoo.com with HTTP; Sun, 4 Aug 2019 00:51:16 +0000
Received: by smtp421.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA
ID 88ef3f9471dfa8bf76ff0090f55ed85c;
Sun, 04 Aug 2019 00:51:11 +0000 (UTC)
Date: Sun, 04 Aug 2019 02:51:04 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <87sgqhricg.fsf@HIDDEN>
References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN>
<871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN>
<87sgqhricg.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="----0F9DPDWAX8IA9A0W87OY0QCMRKVV10"
Content-Transfer-Encoding: 7bit
Subject: Re: bug#36861: 27.0.50;
display-fill-column-indicator-mode in log-edit-mode
To: Juri Linkov <juri@HIDDEN>,Eli Zaretskii <eliz@HIDDEN>
From: Ergus <spacibba@HIDDEN>
Message-ID: <B7351DA2-9B0D-4DA5-9AC6-CDB9B8CECE7E@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36861
Cc: 36861 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
------0F9DPDWAX8IA9A0W87OY0QCMRKVV10
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
Hi, sorry, I don't understand actually why is so complex this provided code=
in the email=2E The initialization for display-fill-column-indicator makes=
some checks to set the default character as described in the documentation=
, so no extra code is needed for that in the user side=2E
In the initialization I see in this mail, they just set the column's value=
to 78 which can be done also using the variable fill-column for the whole =
major mode too=2E And actually dfci will recognize it by default and other =
functionalities too so in the general scenario is better to use that one=2E
(setq fill-column 78)
(display-fill-column-indicator t)
Should work no matters the order=2E Maybe as you were setting the mode's v=
ariable instead of calling the function with the same name; the mode was no=
t properly initialized=2E=20
On August 4, 2019 12:31:59 AM GMT+02:00, Juri Linkov <juri@linkov=2Enet> w=
rote:
>>> >> (log-edit-mode =2E ((log-edit-font-lock-gnu-style =2E t)
>>> >> - (log-edit-setup-add-author =2E t)))
>>> >> + (log-edit-setup-add-author =2E t)
>>> >> + (display-fill-column-indicator-column =2E 78)
>>> >> + (eval =2E
>(display-fill-column-indicator-mode))))
>>> >
>>> > This will cause an annoying message and prompt when editing Emacs
>>> > sources with an Emacs which doesn't yet have
>>> > display-fill-column-indicator-mode, right? Can we avoid that? I
>>> > routinely need to work on the latest sources with an older Emacs=2E
>>>=20
>>> Shouldn't local-variables functions ignore undefined variables and
>commands?
>>> Probably not, since such change won't help for older versions=2E
>>
>> Right, and we cannot summarily allow any variables a given Emacs
>> doesn't know about, that'd we unsafe=2E
>
>Actually by using the word "ignore" I meant to not set an unbound
>variable
>(currently `hack-local-variables' defines and sets unbound variables)=2E
>But this is not backward-compatible change=2E
>
>>> Then one way is to put such lines to the init file
>>> to avoid typing `y' to confirm local variables
>>> while using emacs-26 to commit emacs-27 changes:
>>
>> Rather than requiring users of older Emacsen to change their init
>> files in such strange ways, which will/might be a problem when they
>> upgrade to Emacs 27, why not expect users who want the early
>detection
>> of long lines to turn on display-fill-column-indicator-mode in their
>> init files? IOW, the solution that requires changes to one's init
>> files goes both ways=2E
>
>I don't understand why display-fill-column-indicator customization
>should be more complicated than necessary? Why it requires adding
>these lines:
>
> (display-fill-column-indicator-column =2E 78)
> (eval =2E (display-fill-column-indicator-mode))
>
>when it should be enough to avoid eval by:
>
> (display-fill-column-indicator-column =2E 78)
> (display-fill-column-indicator =2E t)
>
>Is it because the only purpose of display-fill-column-indicator-mode
>is to set display-fill-column-indicator-character? But then why
>display-fill-column-indicator-character is not nil by default?
>This contradicts the docstring of
>display-fill-column-indicator-character
>that says that the default is U+2502, but actually the default is nil=2E
>
>I'm CC-ing the author of display-fill-column-indicator:
>Could you please consider setting the default value of
>display-fill-column-indicator-character? This could
>simplify customization=2E
--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E
------0F9DPDWAX8IA9A0W87OY0QCMRKVV10
Content-Type: text/html;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
<html><head></head><body>Hi, sorry, I don't understand actually why is so c=
omplex this provided code in the email=2E The initialization for display-fi=
ll-column-indicator makes some checks to set the default character as descr=
ibed in the documentation, so no extra code is needed for that in the user =
side=2E<br>In the initialization I see in this mail, they just set the colu=
mn's value to 78 which can be done also using the variable fill-column for =
the whole major mode too=2E And actually dfci will recognize it by default =
and other functionalities too so in the general scenario is better to use t=
hat one=2E<br><br>(setq fill-column 78)<br>(display-fill-column-indicator t=
)<br><br><br>Should work no matters the order=2E Maybe as you were setting =
the mode's variable instead of calling the function with the same name; the=
mode was not properly initialized=2E <br><br><br><br><div class=3D"gmail_q=
uote">On August 4, 2019 12:31:59 AM GMT+02:00, Juri Linkov <juri@linkov=
=2Enet> wrote:<blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt=
0pt 0=2E8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;=
">
<pre class=3D"k9mail"><blockquote class=3D"gmail_quote" style=3D"margin: 0=
pt 0pt 1ex 0=2E8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><bl=
ockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 1ex 0=2E8ex; border=
-left: 1px solid #ad7fa8; padding-left: 1ex;"><blockquote class=3D"gmail_qu=
ote" style=3D"margin: 0pt 0pt 1ex 0=2E8ex; border-left: 1px solid #8ae234; =
padding-left: 1ex;"><blockquote class=3D"gmail_quote" style=3D"margin: 0pt =
0pt 1ex 0=2E8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"> (log=
-edit-mode =2E ((log-edit-font-lock-gnu-style =2E t)<br>- =
(log-edit-setup-add-author =2E t)))<br>+ (log-edit-setup=
-add-author =2E t)<br>+ (display-fill-column-indicator-co=
lumn =2E 78)<br>+ (eval =2E (display-fill-column-indicato=
r-mode))))<br></blockquote><br> This will cause an annoying message and pro=
mpt when editing Emacs<br> sources with an Emacs which doesn't yet have<br>=
display-fill-column-indicator-mode, right? Can we avoid that? I<br> rout=
inely need to work on the latest sources with an older Emacs=2E<br></blockq=
uote><br>Shouldn't local-variables functions ignore undefined variables and=
commands?<br>Probably not, since such change won't help for older versions=
=2E<br></blockquote><br> Right, and we cannot summarily allow any variables=
a given Emacs<br> doesn't know about, that'd we unsafe=2E<br></blockquote>=
<br>Actually by using the word "ignore" I meant to not set an unbound varia=
ble<br>(currently `hack-local-variables' defines and sets unbound variables=
)=2E<br>But this is not backward-compatible change=2E<br><br><blockquote cl=
ass=3D"gmail_quote" style=3D"margin: 0pt 0pt 1ex 0=2E8ex; border-left: 1px =
solid #729fcf; padding-left: 1ex;"><blockquote class=3D"gmail_quote" style=
=3D"margin: 0pt 0pt 1ex 0=2E8ex; border-left: 1px solid #ad7fa8; padding-le=
ft: 1ex;">Then one way is to put such lines to the init file<br>to avoid ty=
ping `y' to confirm local variables<br>while using emacs-26 to commit emacs=
-27 changes:<br></blockquote><br> Rather than requiring users of older Emac=
sen to change their init<br> files in such strange ways, which will/might b=
e a problem when they<br> upgrade to Emacs 27, why not expect users who wan=
t the early detection<br> of long lines to turn on display-fill-column-indi=
cator-mode in their<br> init files? IOW, the solution that requires change=
s to one's init<br> files goes both ways=2E<br></blockquote><br>I don't und=
erstand why display-fill-column-indicator customization<br>should be more c=
omplicated than necessary? Why it requires adding<br>these lines:<br><br> =
(display-fill-column-indicator-column =2E 78)<br> =
(eval =2E (display-fill-column-indicator-mode))<br><br>when it s=
hould be enough to avoid eval by:<br><br> (display-fill-c=
olumn-indicator-column =2E 78)<br> (display-fill-column-i=
ndicator =2E t)<br><br>Is it because the only purpose of display-fill-colum=
n-indicator-mode<br>is to set display-fill-column-indicator-character? But=
then why<br>display-fill-column-indicator-character is not nil by default?=
<br>This contradicts the docstring of display-fill-column-indicator-charact=
er<br>that says that the default is U+2502, but actually the default is nil=
=2E<br><br>I'm CC-ing the author of display-fill-column-indicator:<br>Could=
you please consider setting the default value of<br>display-fill-column-in=
dicator-character? This could<br>simplify customization=2E<br></pre></bloc=
kquote></div><br>-- <br>Sent from my Android device with K-9 Mail=2E Please=
excuse my brevity=2E</body></html>
------0F9DPDWAX8IA9A0W87OY0QCMRKVV10--
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.
Received: (at 36861) by debbugs.gnu.org; 3 Aug 2019 22:33:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 03 18:33:59 2019
Received: from localhost ([127.0.0.1]:60175 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hu2b9-0003c1-3x
for submit <at> debbugs.gnu.org; Sat, 03 Aug 2019 18:33:59 -0400
Received: from aye.elm.relay.mailchannels.net ([23.83.212.6]:3016)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1hu2b7-0003bt-Cg
for 36861 <at> debbugs.gnu.org; Sat, 03 Aug 2019 18:33:57 -0400
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
by relay.mailchannels.net (Postfix) with ESMTP id 5CEB71A1F87;
Sat, 3 Aug 2019 22:33:56 +0000 (UTC)
Received: from pdx1-sub0-mail-a75.g.dreamhost.com
(100-96-29-186.trex.outbound.svc.cluster.local [100.96.29.186])
(Authenticated sender: dreamhost)
by relay.mailchannels.net (Postfix) with ESMTPA id CBA971A1ACF;
Sat, 3 Aug 2019 22:33:55 +0000 (UTC)
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from pdx1-sub0-mail-a75.g.dreamhost.com ([TEMPUNAVAIL].
[64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)
by 0.0.0.0:2500 (trex/5.17.5); Sat, 03 Aug 2019 22:33:56 +0000
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Obese-Attack: 5f0f2301107c0cb2_1564871636120_3230769541
X-MC-Loop-Signature: 1564871636120:1528766554
X-MC-Ingress-Time: 1564871636119
Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1])
by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id E57487FED2;
Sat, 3 Aug 2019 15:33:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc
:subject:references:date:in-reply-to:message-id:mime-version
:content-type; s=linkov.net; bh=SvB+l5/LYmHt+CxqlIAVWiM+Y2M=; b=
WE/MtEqD5YXTPVfL/MpRIhiRfccbRDICZIAggD+owQ+C2k6YKjCqCtFpE/dXtu3L
Q8q6uzUWAYQ9XDClnsAjiH3xqX0iSmZEWDIu8/hnizMlq98dl+neRB32GE2yMDBS
imX4InShWcoK/kybmPp5j6BVM2G8PNmKZTJGOmLKR2Q=
Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
(Authenticated sender: jurta@HIDDEN)
by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id 7F3B57F0F9;
Sat, 3 Aug 2019 15:33:48 -0700 (PDT)
X-DH-BACKEND: pdx1-sub0-mail-a75
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in
log-edit-mode
Organization: LINKOV.NET
References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN>
<871ry6rksu.fsf@HIDDEN> <83zhksexvx.fsf@HIDDEN>
Date: Sun, 04 Aug 2019 01:31:59 +0300
In-Reply-To: <83zhksexvx.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 02 Aug
2019 12:10:10 +0300")
Message-ID: <87sgqhricg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-VR-OUT-STATUS: OK
X-VR-OUT-SCORE: -100
X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddruddtfedgtdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejieenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36861
Cc: spacibba@HIDDEN, 36861 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
>> >> (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
>> >> - (log-edit-setup-add-author . t)))
>> >> + (log-edit-setup-add-author . t)
>> >> + (display-fill-column-indicator-column . 78)
>> >> + (eval . (display-fill-column-indicator-mode))))
>> >
>> > This will cause an annoying message and prompt when editing Emacs
>> > sources with an Emacs which doesn't yet have
>> > display-fill-column-indicator-mode, right? Can we avoid that? I
>> > routinely need to work on the latest sources with an older Emacs.
>>
>> Shouldn't local-variables functions ignore undefined variables and commands?
>> Probably not, since such change won't help for older versions.
>
> Right, and we cannot summarily allow any variables a given Emacs
> doesn't know about, that'd we unsafe.
Actually by using the word "ignore" I meant to not set an unbound variable
(currently `hack-local-variables' defines and sets unbound variables).
But this is not backward-compatible change.
>> Then one way is to put such lines to the init file
>> to avoid typing `y' to confirm local variables
>> while using emacs-26 to commit emacs-27 changes:
>
> Rather than requiring users of older Emacsen to change their init
> files in such strange ways, which will/might be a problem when they
> upgrade to Emacs 27, why not expect users who want the early detection
> of long lines to turn on display-fill-column-indicator-mode in their
> init files? IOW, the solution that requires changes to one's init
> files goes both ways.
I don't understand why display-fill-column-indicator customization
should be more complicated than necessary? Why it requires adding
these lines:
(display-fill-column-indicator-column . 78)
(eval . (display-fill-column-indicator-mode))
when it should be enough to avoid eval by:
(display-fill-column-indicator-column . 78)
(display-fill-column-indicator . t)
Is it because the only purpose of display-fill-column-indicator-mode
is to set display-fill-column-indicator-character? But then why
display-fill-column-indicator-character is not nil by default?
This contradicts the docstring of display-fill-column-indicator-character
that says that the default is U+2502, but actually the default is nil.
I'm CC-ing the author of display-fill-column-indicator:
Could you please consider setting the default value of
display-fill-column-indicator-character? This could
simplify customization.
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.Received: (at 36861) by debbugs.gnu.org; 2 Aug 2019 09:10:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 02 05:10:30 2019 Received: from localhost ([127.0.0.1]:55773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1htTa0-00086s-Ff for submit <at> debbugs.gnu.org; Fri, 02 Aug 2019 05:10:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1htTZz-00086f-4m for 36861 <at> debbugs.gnu.org; Fri, 02 Aug 2019 05:10:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1htTZq-0005WM-Dj; Fri, 02 Aug 2019 05:10:20 -0400 Received: from [176.228.60.248] (port=3560 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1htTZo-0001wL-3Z; Fri, 02 Aug 2019 05:10:16 -0400 Date: Fri, 02 Aug 2019 12:10:10 +0300 Message-Id: <83zhksexvx.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-reply-to: <871ry6rksu.fsf@HIDDEN> (message from Juri Linkov on Wed, 31 Jul 2019 23:49:53 +0300) Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN> <871ry6rksu.fsf@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36861 Cc: 36861 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Juri Linkov <juri@HIDDEN> > Cc: 36861 <at> debbugs.gnu.org > Date: Wed, 31 Jul 2019 23:49:53 +0300 > > >> (log-edit-mode . ((log-edit-font-lock-gnu-style . t) > >> - (log-edit-setup-add-author . t))) > >> + (log-edit-setup-add-author . t) > >> + (display-fill-column-indicator-column . 78) > >> + (eval . (display-fill-column-indicator-mode)))) > > > > This will cause an annoying message and prompt when editing Emacs > > sources with an Emacs which doesn't yet have > > display-fill-column-indicator-mode, right? Can we avoid that? I > > routinely need to work on the latest sources with an older Emacs. > > Shouldn't local-variables functions ignore undefined variables and commands? > Probably not, since such change won't help for older versions. Right, and we cannot summarily allow any variables a given Emacs doesn't know about, that'd we unsafe. > Then one way is to put such lines to the init file > to avoid typing `y' to confirm local variables > while using emacs-26 to commit emacs-27 changes: Rather than requiring users of older Emacsen to change their init files in such strange ways, which will/might be a problem when they upgrade to Emacs 27, why not expect users who want the early detection of long lines to turn on display-fill-column-indicator-mode in their init files? IOW, the solution that requires changes to one's init files goes both ways. > And for emacs-27 and future versions this patch is required as well: > > diff --git a/lisp/cus-start.el b/lisp/cus-start.el > index e1d0bce2ad..036674ef14 100644 > --- a/lisp/cus-start.el > +++ b/lisp/cus-start.el > @@ -650,7 +650,7 @@ minibuffer-prompt-properties--setter > "26.1") > > (display-fill-column-indicator display-fill-column-indicator > - boolean "27.1") > + boolean "27.1" :safe booleanp) > (display-fill-column-indicator-column display-fill-column-indicator > (choice > (const :tag "Use fill-column variable" > @@ -659,9 +659,9 @@ minibuffer-prompt-properties--setter > :value 70 > :format "%v") > integer) > - "27.1") > + "27.1" :safe (lambda (value) (or (booleanp value) (integerp value)))) > (display-fill-column-indicator-character display-fill-column-indicator > - character "27.1") > + character "27.1" :safe characterp) > ;; xfaces.c > (scalable-fonts-allowed display boolean "22.1") > ;; xfns.c This is fine with me, but I don't think we should make the change in .dir-locals.el. Thanks.
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.
Received: (at 36861) by debbugs.gnu.org; 31 Jul 2019 21:25:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 31 17:24:59 2019
Received: from localhost ([127.0.0.1]:53193 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hsw5j-0004iw-Kh
for submit <at> debbugs.gnu.org; Wed, 31 Jul 2019 17:24:59 -0400
Received: from bonobo.elm.relay.mailchannels.net ([23.83.212.22]:60891)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1hsw5h-0004ib-T1
for 36861 <at> debbugs.gnu.org; Wed, 31 Jul 2019 17:24:58 -0400
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
by relay.mailchannels.net (Postfix) with ESMTP id CC4248C247A;
Wed, 31 Jul 2019 21:24:56 +0000 (UTC)
Received: from pdx1-sub0-mail-a99.g.dreamhost.com
(100-96-86-80.trex.outbound.svc.cluster.local [100.96.86.80])
(Authenticated sender: dreamhost)
by relay.mailchannels.net (Postfix) with ESMTPA id 040C78C235D;
Wed, 31 Jul 2019 21:24:52 +0000 (UTC)
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from pdx1-sub0-mail-a99.g.dreamhost.com ([TEMPUNAVAIL].
[64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)
by 0.0.0.0:2500 (trex/5.17.5); Wed, 31 Jul 2019 21:24:56 +0000
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Befitting-Tangy: 7453062c26d3d2dc_1564608293295_2150495787
X-MC-Loop-Signature: 1564608293295:3435206708
X-MC-Ingress-Time: 1564608293294
Received: from pdx1-sub0-mail-a99.g.dreamhost.com (localhost [127.0.0.1])
by pdx1-sub0-mail-a99.g.dreamhost.com (Postfix) with ESMTP id 430E88109E;
Wed, 31 Jul 2019 14:24:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc
:subject:references:date:in-reply-to:message-id:mime-version
:content-type; s=linkov.net; bh=KvDiwKgUUwnetFjJ17P+pFd8Bxk=; b=
ZJw74YRBXITgpgallfzwu/A2LTiTAcwVzffYth8lFco9ONQbDpEtDtv6FohSGPG8
k0r/R6U23MqELTRs279A9Xn7FfEo+2IriAIymXYrFRVjyDsuAso/O3VapvGYit4+
IYq1cHQngoZ6JEn/olTcYVa3qw4FbWP7tY4TLobsXeA=
Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
(Authenticated sender: jurta@HIDDEN)
by pdx1-sub0-mail-a99.g.dreamhost.com (Postfix) with ESMTPSA id 984DE8109C;
Wed, 31 Jul 2019 14:24:48 -0700 (PDT)
X-DH-BACKEND: pdx1-sub0-mail-a99
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in
log-edit-mode
Organization: LINKOV.NET
References: <875znjntfe.fsf@HIDDEN> <83mugvhr66.fsf@HIDDEN>
Date: Wed, 31 Jul 2019 23:49:53 +0300
In-Reply-To: <83mugvhr66.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 31 Jul
2019 05:30:09 +0300")
Message-ID: <871ry6rksu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-VR-OUT-STATUS: OK
X-VR-OUT-SCORE: -100
X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrleehgdduheelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejieenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36861
Cc: 36861 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
>> (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
>> - (log-edit-setup-add-author . t)))
>> + (log-edit-setup-add-author . t)
>> + (display-fill-column-indicator-column . 78)
>> + (eval . (display-fill-column-indicator-mode))))
>
> This will cause an annoying message and prompt when editing Emacs
> sources with an Emacs which doesn't yet have
> display-fill-column-indicator-mode, right? Can we avoid that? I
> routinely need to work on the latest sources with an older Emacs.
Shouldn't local-variables functions ignore undefined variables and commands?
Probably not, since such change won't help for older versions.
Then one way is to put such lines to the init file
to avoid typing `y' to confirm local variables
while using emacs-26 to commit emacs-27 changes:
(put 'display-fill-column-indicator 'safe-local-variable 'booleanp)
(put 'display-fill-column-indicator-character 'safe-local-variable 'characterp)
(put 'display-fill-column-indicator-column 'safe-local-variable
(lambda (value) (or (booleanp value) (integerp value))))
(defun display-fill-column-indicator-mode ())
And for emacs-27 and future versions this patch is required as well:
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
filename=display-fill-column-indicator-cus-start.patch
diff --git a/lisp/cus-start.el b/lisp/cus-start.el
index e1d0bce2ad..036674ef14 100644
--- a/lisp/cus-start.el
+++ b/lisp/cus-start.el
@@ -650,7 +650,7 @@ minibuffer-prompt-properties--setter
"26.1")
(display-fill-column-indicator display-fill-column-indicator
- boolean "27.1")
+ boolean "27.1" :safe booleanp)
(display-fill-column-indicator-column display-fill-column-indicator
(choice
(const :tag "Use fill-column variable"
@@ -659,9 +659,9 @@ minibuffer-prompt-properties--setter
:value 70
:format "%v")
integer)
- "27.1")
+ "27.1" :safe (lambda (value) (or (booleanp value) (integerp value))))
(display-fill-column-indicator-character display-fill-column-indicator
- character "27.1")
+ character "27.1" :safe characterp)
;; xfaces.c
(scalable-fonts-allowed display boolean "22.1")
;; xfns.c
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.Received: (at 36861) by debbugs.gnu.org; 31 Jul 2019 02:30:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 30 22:30:32 2019 Received: from localhost ([127.0.0.1]:51427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hseNr-0007uR-NU for submit <at> debbugs.gnu.org; Tue, 30 Jul 2019 22:30:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1hseNq-0007uF-1E for 36861 <at> debbugs.gnu.org; Tue, 30 Jul 2019 22:30:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1hseNf-0000bR-IL; Tue, 30 Jul 2019 22:30:21 -0400 Received: from [176.228.60.248] (port=1295 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1hseNf-0000ai-23; Tue, 30 Jul 2019 22:30:19 -0400 Date: Wed, 31 Jul 2019 05:30:09 +0300 Message-Id: <83mugvhr66.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-reply-to: <875znjntfe.fsf@HIDDEN> (message from Juri Linkov on Tue, 30 Jul 2019 23:44:53 +0300) Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode References: <875znjntfe.fsf@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36861 Cc: 36861 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Juri Linkov <juri@HIDDEN> > Date: Tue, 30 Jul 2019 23:44:53 +0300 > > It has an unpleasant effect when git commit abruptly fails when > the length of the first line of the commit message is longer than > 78 characters. This patch enables a visual indication in the > log-edit buffer to help not to exceed the limit beforehand: > > diff --git a/.dir-locals.el b/.dir-locals.el > index ffd65c8802..e56d8c753b 100644 > --- a/.dir-locals.el > +++ b/.dir-locals.el > @@ -10,7 +10,9 @@ > (electric-quote-comment . nil) > (electric-quote-string . nil))) > (log-edit-mode . ((log-edit-font-lock-gnu-style . t) > - (log-edit-setup-add-author . t))) > + (log-edit-setup-add-author . t) > + (fill-column . 78) > + (eval . (display-fill-column-indicator-mode)))) This will cause an annoying message and prompt when editing Emacs sources with an Emacs which doesn't yet have display-fill-column-indicator-mode, right? Can we avoid that? I routinely need to work on the latest sources with an older Emacs.
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.
Received: (at 36861) by debbugs.gnu.org; 30 Jul 2019 21:21:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 30 17:21:47 2019
Received: from localhost ([127.0.0.1]:51296 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hsZZ5-00041I-4A
for submit <at> debbugs.gnu.org; Tue, 30 Jul 2019 17:21:47 -0400
Received: from buffalo.birch.relay.mailchannels.net ([23.83.209.24]:41950)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1hsZZ3-00041A-Nw
for 36861 <at> debbugs.gnu.org; Tue, 30 Jul 2019 17:21:46 -0400
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
by relay.mailchannels.net (Postfix) with ESMTP id 87F86212BE
for <36861 <at> debbugs.gnu.org>; Tue, 30 Jul 2019 21:21:44 +0000 (UTC)
Received: from pdx1-sub0-mail-a24.g.dreamhost.com
(100-96-29-186.trex.outbound.svc.cluster.local [100.96.29.186])
(Authenticated sender: dreamhost)
by relay.mailchannels.net (Postfix) with ESMTPA id 1A517211F0
for <36861 <at> debbugs.gnu.org>; Tue, 30 Jul 2019 21:21:44 +0000 (UTC)
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from pdx1-sub0-mail-a24.g.dreamhost.com ([TEMPUNAVAIL].
[64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)
by 0.0.0.0:2500 (trex/5.17.5); Tue, 30 Jul 2019 21:21:44 +0000
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Juvenile-Language: 34c3b4d02b038c32_1564521704354_82520765
X-MC-Loop-Signature: 1564521704354:2339469596
X-MC-Ingress-Time: 1564521704354
Received: from pdx1-sub0-mail-a24.g.dreamhost.com (localhost [127.0.0.1])
by pdx1-sub0-mail-a24.g.dreamhost.com (Postfix) with ESMTP id 945C783EE1
for <36861 <at> debbugs.gnu.org>; Tue, 30 Jul 2019 14:21:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to
:subject:references:date:in-reply-to:message-id:mime-version
:content-type:content-transfer-encoding; s=linkov.net; bh=uRdLEj
VJqHxPbAtLkXwGbhAhTbs=; b=csFnHSV/OAJbkr62n8CBzZzgqSQmCxKGPUDPvV
sVV0UCZcTmL7aAlc872Wa8cgnVAlHSm5Hg86V7zk2W5J/ud+IKx0yXpxWZqTXmjl
y3fyAj89lDtQaNG9tgxHYLALkFpkhEW0ZmCRfi1SkSHu6O2h1ueTcbO9rPWZmAtt
Hnpas=
Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
(Authenticated sender: jurta@HIDDEN)
by pdx1-sub0-mail-a24.g.dreamhost.com (Postfix) with ESMTPSA id 563A083EAF
for <36861 <at> debbugs.gnu.org>; Tue, 30 Jul 2019 14:21:39 -0700 (PDT)
X-DH-BACKEND: pdx1-sub0-mail-a24
From: Juri Linkov <juri@HIDDEN>
To: 36861 <at> debbugs.gnu.org
Subject: Re: bug#36861: 27.0.50; display-fill-column-indicator-mode in
log-edit-mode
Organization: LINKOV.NET
References: <875znjntfe.fsf@HIDDEN>
Date: Wed, 31 Jul 2019 00:21:10 +0300
In-Reply-To: <875znjntfe.fsf@HIDDEN> (Juri Linkov's message of "Tue,
30 Jul 2019 23:44:53 +0300")
Message-ID: <87o91bmd6h.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
X-VR-OUT-STATUS: OK
X-VR-OUT-SCORE: 0
X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrleefgdduheejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohhfffgjkfgfgggtgfesthekredttderjeenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejieenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopeefieekieduseguvggssghughhsrdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36861
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
> + (fill-column . 78)
Sorry, I missed the special variable introduced by this feature -
=E2=80=98display-fill-column-indicator-column=E2=80=99. But =E2=80=98fil=
l-column=E2=80=99 should not be
changed, it should remain at its default value. Here's the correct patch=
:
diff --git a/.dir-locals.el b/.dir-locals.el
index ffd65c8802..ad5eb066ca 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -10,7 +10,9 @@
(electric-quote-comment . nil)
(electric-quote-string . nil)))
(log-edit-mode . ((log-edit-font-lock-gnu-style . t)
- (log-edit-setup-add-author . t)))
+ (log-edit-setup-add-author . t)
+ (display-fill-column-indicator-column . 78)
+ (eval . (display-fill-column-indicator-mode))))
(change-log-mode . ((add-log-time-zone-rule . t)
(fill-column . 74)
(eval . (bug-reference-mode))))
bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 30 Jul 2019 20:46:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 30 16:46:26 2019
Received: from localhost ([127.0.0.1]:51280 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1hsZ0r-0002wC-Sp
for submit <at> debbugs.gnu.org; Tue, 30 Jul 2019 16:46:26 -0400
Received: from lists.gnu.org ([209.51.188.17]:48481)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1hsZ0p-0002w4-T9
for submit <at> debbugs.gnu.org; Tue, 30 Jul 2019 16:46:24 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:50793)
by lists.gnu.org with esmtp (Exim 4.86_2)
(envelope-from <juri@HIDDEN>) id 1hsZ0o-0007cO-R4
for bug-gnu-emacs@HIDDEN; Tue, 30 Jul 2019 16:46:23 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE,
URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <juri@HIDDEN>) id 1hsZ0n-0007iy-Pi
for bug-gnu-emacs@HIDDEN; Tue, 30 Jul 2019 16:46:22 -0400
Received: from bonobo.birch.relay.mailchannels.net ([23.83.209.22]:16636)
by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <juri@HIDDEN>) id 1hsZ0n-0007hJ-F0
for bug-gnu-emacs@HIDDEN; Tue, 30 Jul 2019 16:46:21 -0400
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
by relay.mailchannels.net (Postfix) with ESMTP id 6F32E6A1C93
for <bug-gnu-emacs@HIDDEN>; Tue, 30 Jul 2019 20:46:19 +0000 (UTC)
Received: from pdx1-sub0-mail-a24.g.dreamhost.com
(100-96-89-15.trex.outbound.svc.cluster.local [100.96.89.15])
(Authenticated sender: dreamhost)
by relay.mailchannels.net (Postfix) with ESMTPA id F21AF6A1218
for <bug-gnu-emacs@HIDDEN>; Tue, 30 Jul 2019 20:46:18 +0000 (UTC)
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from pdx1-sub0-mail-a24.g.dreamhost.com ([TEMPUNAVAIL].
[64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)
by 0.0.0.0:2500 (trex/5.17.5); Tue, 30 Jul 2019 20:46:19 +0000
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Coil-Trouble: 647fba8a28c45c54_1564519579242_967918595
X-MC-Loop-Signature: 1564519579242:2086809354
X-MC-Ingress-Time: 1564519579242
Received: from pdx1-sub0-mail-a24.g.dreamhost.com (localhost [127.0.0.1])
by pdx1-sub0-mail-a24.g.dreamhost.com (Postfix) with ESMTP id 4934E83ECF
for <bug-gnu-emacs@HIDDEN>; Tue, 30 Jul 2019 13:46:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to
:subject:date:message-id:mime-version:content-type; s=
linkov.net; bh=UjVmDDBmTpFOGDwkzEneoplXHNQ=; b=SabvLCydDax5W5MNw
1vnaifdhPEwjTDuS8uNTIXCqAovt3J1GDmwSVj1l6vWRewWXDfGbZMmHr/SYGybU
hYci8axmgy+FIyoMcSSqQ/W7ZFVCVH12LlfBANZkAqJjzu5wTvotUVdSOp+DMDD2
CxP+4TkE96zNGNtwO9meScVDBE=
Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
(Authenticated sender: jurta@HIDDEN)
by pdx1-sub0-mail-a24.g.dreamhost.com (Postfix) with ESMTPSA id 6692083EAF
for <bug-gnu-emacs@HIDDEN>; Tue, 30 Jul 2019 13:46:12 -0700 (PDT)
X-DH-BACKEND: pdx1-sub0-mail-a24
From: Juri Linkov <juri@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 27.0.50; display-fill-column-indicator-mode in log-edit-mode
Organization: LINKOV.NET
Date: Tue, 30 Jul 2019 23:44:53 +0300
Message-ID: <875znjntfe.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-VR-OUT-STATUS: OK
X-VR-OUT-SCORE: 0
X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrleefgdduheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrjeeinecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrjeeipdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 23.83.209.22
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
It has an unpleasant effect when git commit abruptly fails when
the length of the first line of the commit message is longer than
78 characters. This patch enables a visual indication in the
log-edit buffer to help not to exceed the limit beforehand:
diff --git a/.dir-locals.el b/.dir-locals.el
index ffd65c8802..e56d8c753b 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -10,7 +10,9 @@
(electric-quote-comment . nil)
(electric-quote-string . nil)))
(log-edit-mode . ((log-edit-font-lock-gnu-style . t)
- (log-edit-setup-add-author . t)))
+ (log-edit-setup-add-author . t)
+ (fill-column . 78)
+ (eval . (display-fill-column-indicator-mode))))
(change-log-mode . ((add-log-time-zone-rule . t)
(fill-column . 74)
(eval . (bug-reference-mode))))
Juri Linkov <juri@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#36861; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.