GNU bug report logs - #36867
26.2; gamegrid-add-scrore miss lower-is-better flag

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36867 in the body.
You can then email your comments to 36867 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rolf Ade <rolf <at> pointsman.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.2; gamegrid-add-scrore miss lower-is-better flag
Date: Wed, 31 Jul 2019 02:13:18 +0200

The function gamegrid-add-scrore is handy for games developer; they get
a high-score management system with one call. That includes a threshold
for the number of entries in the high-score file.

A consequence of that is, that an entry has be removed from the list if
a new, better one must be inserted. In this situation,
gamegrid-add-scrore currently always removes the "lowest" result.

This is good and well for "more is better" games. But is wrong for
"faster is better" games. An example:
https://github.com/calancha/Minesweeper

This feature omission is on lisp level. The in the emacs sources
included tool update-game-score (which is used by gamegrid, if it is
available) support reverse opperation.

Message #10 received at 36867 <at> debbugs.gnu.org (full text, mbox):

From: Federico Tedin <federicotedin <at> gmail.com>
To: Rolf Ade <rolf <at> pointsman.de>
Cc: 36867 <at> debbugs.gnu.org
Subject: Re: bug#36867: 26.2; gamegrid-add-scrore miss lower-is-better flag
Date: Wed, 04 Sep 2019 00:29:22 +0200

[Message part 1 (text/plain, inline)]

Rolf Ade <rolf <at> pointsman.de> writes:

> The function gamegrid-add-scrore is handy for games developer; they get
> a high-score management system with one call. That includes a threshold
> for the number of entries in the high-score file.
>
> A consequence of that is, that an entry has be removed from the list if
> a new, better one must be inserted. In this situation,
> gamegrid-add-scrore currently always removes the "lowest" result.
>
> This is good and well for "more is better" games. But is wrong for
> "faster is better" games. An example:
> https://github.com/calancha/Minesweeper
>
> This feature omission is on lisp level. The in the emacs sources
> included tool update-game-score (which is used by gamegrid, if it is
> available) support reverse opperation.

I've added a new 'reverse' parameter to gamegrid-add-score that allows
switching between storing the scores normally, or in reverse order. As
Rolf mentioned, this feature was already implemented in
update-game-score. I'm attaching a patch with my changes.

- Fede

[gamegrid.patch (text/x-diff, attachment)]

Message #15 received at 36867-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Federico Tedin <federicotedin <at> gmail.com>
Cc: rolf <at> pointsman.de, 36867-done <at> debbugs.gnu.org
Subject: Re: bug#36867: 26.2; gamegrid-add-scrore miss lower-is-better flag
Date: Sat, 14 Sep 2019 11:23:39 +0300

> From: Federico Tedin <federicotedin <at> gmail.com>
> Date: Wed, 04 Sep 2019 00:29:22 +0200
> Cc: 36867 <at> debbugs.gnu.org
> 
> Rolf Ade <rolf <at> pointsman.de> writes:
> 
> > The function gamegrid-add-scrore is handy for games developer; they get
> > a high-score management system with one call. That includes a threshold
> > for the number of entries in the high-score file.
> >
> > A consequence of that is, that an entry has be removed from the list if
> > a new, better one must be inserted. In this situation,
> > gamegrid-add-scrore currently always removes the "lowest" result.
> >
> > This is good and well for "more is better" games. But is wrong for
> > "faster is better" games. An example:
> > https://github.com/calancha/Minesweeper
> >
> > This feature omission is on lisp level. The in the emacs sources
> > included tool update-game-score (which is used by gamegrid, if it is
> > available) support reverse opperation.
> 
> I've added a new 'reverse' parameter to gamegrid-add-score that allows
> switching between storing the scores normally, or in reverse order. As
> Rolf mentioned, this feature was already implemented in
> update-game-score. I'm attaching a patch with my changes.

Thanks, pushed to the master branch.

In the future, please mark NEWS entries with "---" if they don't need
to be described in the manuals, and with "+++" if the patch includes
the changes for the manuals.  (I did this for you this time.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.