GNU bug report logs - #36868
guix system build autocompletes with package list

Previous Next

Package: guix;

Reported by: Jesse Gibbons <jgibbons2357 <at> gmail.com>

Date: Wed, 31 Jul 2019 02:45:01 UTC

Severity: normal

Tags: easy

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36868 in the body.
You can then email your comments to 36868 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#36868; Package guix. (Wed, 31 Jul 2019 02:45:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jesse Gibbons <jgibbons2357 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Wed, 31 Jul 2019 02:45:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: guix system build autocompletes with package list
Date: Tue, 30 Jul 2019 20:44:41 -0600
In bash, when I type "guix system build" and press tab to autocomplete,
I get a list of packages. I would expect it to list scheme source files
like the "guix system {container,disk-image,docker-image,extension-graph,init,reconfigure,shepherd-graph,vm,vm-image}" autocompletes. 




Added tag(s) easy. Request was from Ludovic Courtès <ludo <at> gnu.org> to control <at> debbugs.gnu.org. (Fri, 23 Aug 2019 12:31:04 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#36868; Package guix. (Tue, 15 Jun 2021 20:59:01 GMT) Full text and rfc822 format available.

Message #10 received at 36868 <at> debbugs.gnu.org (full text, mbox):

From: Solene Rapenne <solene <at> perso.pw>
To: 36868 <at> debbugs.gnu.org
Subject: [PATCH] etc: completion: remove package list when using completion
 on guix system build
Date: Tue, 15 Jun 2021 22:58:18 +0200
---
 etc/completion/bash/guix | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/completion/bash/guix b/etc/completion/bash/guix
index 26480e5863..ef98e9feca 100644
--- a/etc/completion/bash/guix
+++ b/etc/completion/bash/guix
@@ -235,7 +235,7 @@ _guix_complete ()
 		fi
             elif _guix_is_command "build"
             then
-                if _guix_is_dash_L || _guix_is_dash_m || _guix_is_dash_f
+                if _guix_is_dash_L || _guix_is_dash_m || _guix_is_dash_f || _guix_is_command "system"
                 then
                     _guix_complete_file
 		else
-- 
2.32.0

I am absolutely unsure about the commit message for such changes.




Information forwarded to bug-guix <at> gnu.org:
bug#36868; Package guix. (Fri, 18 Jun 2021 10:00:03 GMT) Full text and rfc822 format available.

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Solene Rapenne via Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: Solene Rapenne <solene <at> perso.pw>, 36868 <at> debbugs.gnu.org
Subject: Re: bug#36868: [PATCH] etc: completion: remove package list when
 using completion on guix system build
Date: Fri, 18 Jun 2021 11:59:53 +0200
Hi,

Solene Rapenne via Bug reports for GNU Guix <bug-guix <at> gnu.org> skribis:

> ---
>  etc/completion/bash/guix | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/etc/completion/bash/guix b/etc/completion/bash/guix
> index 26480e5863..ef98e9feca 100644
> --- a/etc/completion/bash/guix
> +++ b/etc/completion/bash/guix
> @@ -235,7 +235,7 @@ _guix_complete ()
>  		fi
>              elif _guix_is_command "build"
>              then
> -                if _guix_is_dash_L || _guix_is_dash_m || _guix_is_dash_f
> +                if _guix_is_dash_L || _guix_is_dash_m || _guix_is_dash_f || _guix_is_command "system"

It seems to me that if _guix_is_command "build" is true, then
_guix_is_command "system" cannot also be true.  WDYT?

Thanks for addressing this longstanding issue!

Ludo’.




Information forwarded to bug-guix <at> gnu.org:
bug#36868; Package guix. (Fri, 18 Jun 2021 10:00:03 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#36868; Package guix. (Fri, 18 Jun 2021 10:35:01 GMT) Full text and rfc822 format available.

Message #19 received at 36868 <at> debbugs.gnu.org (full text, mbox):

From: Solene Rapenne <solene <at> perso.pw>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36868 <at> debbugs.gnu.org
Subject: Re: bug#36868: [PATCH] etc: completion: remove package list when
 using completion on guix system build
Date: Fri, 18 Jun 2021 12:33:53 +0200
Le Fri, 18 Jun 2021 11:59:53 +0200,
Ludovic Courtès <ludo <at> gnu.org> a écrit :

> Hi,
> 
> Solene Rapenne via Bug reports for GNU Guix <bug-guix <at> gnu.org> skribis:
> 
> > ---
> >  etc/completion/bash/guix | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/etc/completion/bash/guix b/etc/completion/bash/guix
> > index 26480e5863..ef98e9feca 100644
> > --- a/etc/completion/bash/guix
> > +++ b/etc/completion/bash/guix
> > @@ -235,7 +235,7 @@ _guix_complete ()
> >  		fi
> >              elif _guix_is_command "build"
> >              then
> > -                if _guix_is_dash_L || _guix_is_dash_m || _guix_is_dash_f
> > +                if _guix_is_dash_L || _guix_is_dash_m || _guix_is_dash_f || _guix_is_command "system"  
> 
> It seems to me that if _guix_is_command "build" is true, then
> _guix_is_command "system" cannot also be true.  WDYT?
> 
> Thanks for addressing this longstanding issue!
> 
> Ludo’.

the file has been reworked in commits

- dc3ba8c83602d69294e21d1b0c066f0d89890b56
- 80a17aae7991c6df061a98bb71734485f4ca17e2

now the code is entirely different and works as expected.

IIRC when I worked on this piece of code, _guix_is_command "foobar" was
looking for foobar in all words of the command. So you could have
_guix_is_command returning true for "build" and "system" at the same
time when using "guix system build".




Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sun, 20 Jun 2021 21:11:02 GMT) Full text and rfc822 format available.

Notification sent to Jesse Gibbons <jgibbons2357 <at> gmail.com>:
bug acknowledged by developer. (Sun, 20 Jun 2021 21:11:02 GMT) Full text and rfc822 format available.

Message #24 received at 36868-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Solene Rapenne <solene <at> perso.pw>
Cc: 36868-done <at> debbugs.gnu.org
Subject: Re: bug#36868: [PATCH] etc: completion: remove package list when
 using completion on guix system build
Date: Sun, 20 Jun 2021 23:10:23 +0200
Hi,

Solene Rapenne <solene <at> perso.pw> skribis:

> the file has been reworked in commits
>
> - dc3ba8c83602d69294e21d1b0c066f0d89890b56
> - 80a17aae7991c6df061a98bb71734485f4ca17e2
>
> now the code is entirely different and works as expected.

Heh, looks like Tobias & you felt the need to address this annoyance at
the same time.  :-)

> IIRC when I worked on this piece of code, _guix_is_command "foobar" was
> looking for foobar in all words of the command. So you could have
> _guix_is_command returning true for "build" and "system" at the same
> time when using "guix system build".

Ah OK.

Anyway, glad that it’s fixed now; thank you!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 19 Jul 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 253 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.