GNU bug report logs - #36880
[PATCH] reconfigure: Reload all shepherd files when upgrading services.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36880 in the body.
You can then email your comments to 36880 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: guix-patches <at> gnu.org
Subject: [PATCH] reconfigure: Reload all shepherd files when upgrading
 services.
Date: Wed, 31 Jul 2019 14:13:01 -0400

[Message part 1 (text/plain, inline)]

Fixes <https://bugs.gnu.org/36878>.
Reported by Robert Vollmert <rob <at> vllmrt.net>.

* guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Load
all service files, rather than just those of services to be started.
---
 guix/scripts/system/reconfigure.scm | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm
index 8c7d461585..dee0c24bd2 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -161,12 +161,7 @@ services as defined by OS."
                                              target-services)
                                         (map live-service-canonical-name
                                              live-services)))
-             (service-files
-              (map shepherd-service-file
-                   (filter (lambda (service)
-                             (memq (shepherd-service-canonical-name service)
-                                   to-start))
-                           target-services))))
+             (service-files (map shepherd-service-file target-services)))
         (eval #~(primitive-load #$(upgrade-services-program service-files
                                                             to-start
                                                             to-unload
-- 
2.22.0

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 36880-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
Cc: 36880-done <at> debbugs.gnu.org
Subject: Re: [bug#36880] [PATCH] reconfigure: Reload all shepherd files when
 upgrading services.
Date: Fri, 2 Aug 2019 11:21:56 +0200

[Message part 1 (text/plain, inline)]

I've pushed that patch to guix master as commit 1db6f137d93b59409fedb3deb24c876649e1b8f2 now.

Thanks!

[Message part 2 (application/pgp-signature, inline)]

Message #13 received at 36880-done <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 36880-done <at> debbugs.gnu.org
Subject: Re: [bug#36880] [PATCH] reconfigure: Reload all shepherd files when
 upgrading services.
Date: Fri, 02 Aug 2019 11:08:28 -0400

[Message part 1 (text/plain, inline)]

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> I've pushed that patch to guix master as commit 1db6f137d93b59409fedb3deb24c876649e1b8f2 now.
>
> Thanks!

Excellent; thank you, Danny!

Regards,
Jakob

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.