GNU bug report logs - #36905
[PATCH] gnu: gnome-control-center: Fix info-overview panel issues.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Kei Kebreau <kkebreau@HIDDEN>; Keywords: patch; Done: Kei Kebreau <kkebreau@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 36905-done <at> debbugs.gnu.org:


Received: (at 36905-done) by debbugs.gnu.org; 21 Aug 2019 15:30:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 21 11:30:20 2019
Received: from localhost ([127.0.0.1]:36294 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i0SZ1-0003xA-RV
	for submit <at> debbugs.gnu.org; Wed, 21 Aug 2019 11:30:20 -0400
Received: from mout02.posteo.de ([185.67.36.66]:50207)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kkebreau@HIDDEN>) id 1i0SYy-0003wp-TV
 for 36905-done <at> debbugs.gnu.org; Wed, 21 Aug 2019 11:30:18 -0400
Received: from submission (posteo.de [89.146.220.130]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 233D82400E5
 for <36905-done <at> debbugs.gnu.org>; Wed, 21 Aug 2019 17:30:09 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1566401410; bh=XHTYCgZ1beH/alNe0ibUQySpQff5Cd3c0L4YMlnPUKE=;
 h=From:To:Subject:Date:From;
 b=nf0hauj5iMFMKNhk4lviMkVVyhgy36ETGtu26g5LAIQVOYmKVKHC4FkXauIAklIDO
 19ipvjTHLO+zFoWJOGQ4jjlsRRrxmcIMlz8+sEwER1IPTuOxJX1qcXPskDxCCx5KQA
 VVKUMMgxAIw2sfGO7lQKWewYOATSBnSHFmX1sgIgzkGT5KTO7HUZ6XISPYay1sMUMc
 XP9MSJ255T7Gac0YEX2f9RkSxNOs2wqe8B4rM0CaZJWNs9sZWqWXKEoo8dKyeeXSYB
 1OQ//qVMq5yAHbdlGpcZgcvxFGFrnmZVbrGMCgYlaUUPoRzmIdNSBMhFvwPlVkjWNw
 BUpPZW6D2+AOA==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 46DBS05kYkz9rxN
 for <36905-done <at> debbugs.gnu.org>; Wed, 21 Aug 2019 17:30:08 +0200 (CEST)
From: Kei Kebreau <kkebreau@HIDDEN>
To: 36905-done <at> debbugs.gnu.org
Subject: Re: [bug#36905] [PATCH] gnu: gnome-control-center: Fix info-overview
 panel issues.
References: <20190803124301.14920-1-kkebreau@HIDDEN>
Date: Wed, 21 Aug 2019 11:30:07 -0400
In-Reply-To: <20190803124301.14920-1-kkebreau@HIDDEN> (Kei Kebreau's
 message of "Sat, 3 Aug 2019 08:43:01 -0400")
Message-ID: <87ef1etu2o.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 36905-done
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Kei Kebreau <kkebreau@HIDDEN> writes:

> GNOME Control Center should now display the correct GNOME version and graphics
> information in the "Details > About" panel.
>
> * gnu/packages/gnome.scm (gnome-control-center)[arguments]: Add configure
> flag.  Adjust 'patch-paths' phase accordingly.
> [inputs]: Add gnome-session.
> ---
>  gnu/packages/gnome.scm | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 3f7bbac214..72b88c73c3 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -5915,7 +5915,10 @@ devices using the GNOME desktop.")
>      (arguments
>       '(#:glib-or-gtk? #t
>         #:configure-flags
> -       (list "-Dcheese=false")
> +       (list "-Dcheese=false"
> +             (string-append "-Dgnome_session_libexecdir="
> +                            (assoc-ref %build-inputs "gnome-session")
> +                            "/libexec"))
>         #:phases
>         (modify-phases %standard-phases
>           (add-before 'configure 'patch-paths
> @@ -5923,7 +5926,8 @@ devices using the GNOME desktop.")
>               (let ((libc   (assoc-ref inputs "libc"))
>                     (tzdata (assoc-ref inputs "tzdata"))
>                     (libgnomekbd (assoc-ref inputs "libgnomekbd"))
> -                   (nm-applet   (assoc-ref inputs "network-manager-applet")))
> +                   (nm-applet   (assoc-ref inputs "network-manager-applet"))
> +                   (gnome-desktop (assoc-ref inputs "gnome-desktop")))
>                 (substitute* "panels/datetime/tz.h"
>                   (("/usr/share/zoneinfo/zone.tab")
>                    (string-append tzdata "/share/zoneinfo/zone.tab")))
> @@ -5943,6 +5947,10 @@ devices using the GNOME desktop.")
>                 (substitute* '("panels/user-accounts/run-passwd.c")
>                   (("/usr/bin/passwd")
>                    "/run/setuid-programs/passwd"))
> +               (substitute* "panels/info/cc-info-overview-panel.c"
> +                 (("DATADIR \"/gnome/gnome-version.xml\"")
> +                  (string-append "\"" gnome-desktop
> +                                 "/share/gnome/gnome-version.xml\"")))
>                 #t))))))
>      (native-inputs
>       `(("glib:bin" ,glib "bin") ; for glib-mkenums, etc.
> @@ -5962,6 +5970,7 @@ devices using the GNOME desktop.")
>         ("gnome-desktop" ,gnome-desktop)
>         ("gnome-online-accounts" ,gnome-online-accounts)
>         ("gnome-online-accounts:lib" ,gnome-online-accounts "lib")
> +       ("gnome-session" ,gnome-session)
>         ("gnome-settings-daemon" ,gnome-settings-daemon)
>         ("grilo" ,grilo)
>         ("ibus" ,ibus)

Pushed to master as 64c70430ec80c93faff6139fdb9d3de92704b81e.




Notification sent to Kei Kebreau <kkebreau@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Kei Kebreau <kkebreau@HIDDEN>:
You have taken responsibility. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 3 Aug 2019 12:43:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 03 08:43:16 2019
Received: from localhost ([127.0.0.1]:58478 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1httNU-0005LG-Lb
	for submit <at> debbugs.gnu.org; Sat, 03 Aug 2019 08:43:16 -0400
Received: from lists.gnu.org ([209.51.188.17]:55693)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kkebreau@HIDDEN>) id 1httNS-0005L6-Dy
 for submit <at> debbugs.gnu.org; Sat, 03 Aug 2019 08:43:15 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:58270)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <kkebreau@HIDDEN>) id 1httNR-000283-B6
 for guix-patches@HIDDEN; Sat, 03 Aug 2019 08:43:14 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
 URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <kkebreau@HIDDEN>) id 1httNQ-0002gS-Cj
 for guix-patches@HIDDEN; Sat, 03 Aug 2019 08:43:13 -0400
Received: from mout02.posteo.de ([185.67.36.66]:52719)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <kkebreau@HIDDEN>) id 1httNP-0002fk-QO
 for guix-patches@HIDDEN; Sat, 03 Aug 2019 08:43:12 -0400
Received: from submission (posteo.de [89.146.220.130]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 58EAD2400FC
 for <guix-patches@HIDDEN>; Sat,  3 Aug 2019 14:43:09 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1564836189; bh=htOoJADq/6SEP16nTeVNCopRs93lBiSArOTfGqysN2g=;
 h=From:To:Cc:Subject:Date:From;
 b=Yv5zQQNRzfL6pOjLuxMsWoaQXs3BPFuS4mjjkT8aYal3PIq0IAvaL6oNJzydFjIrH
 t6mM6HcK2jY/ki7Pg2P6VXeJOLy1CG4mkW55yCNDXZKzGFsCwIx3YHFXOKM+7ElQxS
 90jgiAs9korEPgEH6a0gWi5RLSiBjQqqI3vDpvEkpXDrddhivAJ42XjyzaJHarGJ1E
 lcGCZghav3c/BNkl8NoIJALO7klGWd38g/hguxM11lMnIlb4OVC+w/5o5r5vh0C9yY
 n1D6lFEabo1DzWPxd01eu1TiVgFz5b25241cON3PTSFsuVHUz4SSel83Hkuess7sYL
 hPHH9S/jhfL7w==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4613bb6RtSz9rxT;
 Sat,  3 Aug 2019 14:43:07 +0200 (CEST)
From: Kei Kebreau <kkebreau@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: gnome-control-center: Fix info-overview panel issues.
Date: Sat,  3 Aug 2019 08:43:01 -0400
Message-Id: <20190803124301.14920-1-kkebreau@HIDDEN>
X-Mailer: git-send-email 2.22.0
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 185.67.36.66
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Kei Kebreau <kkebreau@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

GNOME Control Center should now display the correct GNOME version and gra=
phics
information in the "Details > About" panel.

* gnu/packages/gnome.scm (gnome-control-center)[arguments]: Add configure
flag.  Adjust 'patch-paths' phase accordingly.
[inputs]: Add gnome-session.
---
 gnu/packages/gnome.scm | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3f7bbac214..72b88c73c3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5915,7 +5915,10 @@ devices using the GNOME desktop.")
     (arguments
      '(#:glib-or-gtk? #t
        #:configure-flags
-       (list "-Dcheese=3Dfalse")
+       (list "-Dcheese=3Dfalse"
+             (string-append "-Dgnome_session_libexecdir=3D"
+                            (assoc-ref %build-inputs "gnome-session")
+                            "/libexec"))
        #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'patch-paths
@@ -5923,7 +5926,8 @@ devices using the GNOME desktop.")
              (let ((libc   (assoc-ref inputs "libc"))
                    (tzdata (assoc-ref inputs "tzdata"))
                    (libgnomekbd (assoc-ref inputs "libgnomekbd"))
-                   (nm-applet   (assoc-ref inputs "network-manager-apple=
t")))
+                   (nm-applet   (assoc-ref inputs "network-manager-apple=
t"))
+                   (gnome-desktop (assoc-ref inputs "gnome-desktop")))
                (substitute* "panels/datetime/tz.h"
                  (("/usr/share/zoneinfo/zone.tab")
                   (string-append tzdata "/share/zoneinfo/zone.tab")))
@@ -5943,6 +5947,10 @@ devices using the GNOME desktop.")
                (substitute* '("panels/user-accounts/run-passwd.c")
                  (("/usr/bin/passwd")
                   "/run/setuid-programs/passwd"))
+               (substitute* "panels/info/cc-info-overview-panel.c"
+                 (("DATADIR \"/gnome/gnome-version.xml\"")
+                  (string-append "\"" gnome-desktop
+                                 "/share/gnome/gnome-version.xml\"")))
                #t))))))
     (native-inputs
      `(("glib:bin" ,glib "bin") ; for glib-mkenums, etc.
@@ -5962,6 +5970,7 @@ devices using the GNOME desktop.")
        ("gnome-desktop" ,gnome-desktop)
        ("gnome-online-accounts" ,gnome-online-accounts)
        ("gnome-online-accounts:lib" ,gnome-online-accounts "lib")
+       ("gnome-session" ,gnome-session)
        ("gnome-settings-daemon" ,gnome-settings-daemon)
        ("grilo" ,grilo)
        ("ibus" ,ibus)
--=20
2.22.0





Acknowledgement sent to Kei Kebreau <kkebreau@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#36905; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 21 Aug 2019 15:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.