GNU bug report logs - #36947
[PATCH] reconfigure: Fix GC root installation.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36947 in the body.
You can then email your comments to 36947 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: guix-patches <at> gnu.org
Subject: [PATCH] reconfigure: Fix GC root installation.
Date: Tue, 06 Aug 2019 13:37:32 -0400

[Message part 1 (text/plain, inline)]

Fixes <https://bugs.gnu.org/36942>.
Reported by ison <ison <at> airmail.cc>.

guix/scripts/system/reconfigure.scm (install-bootloader-program): Switch
new symlink to the canonical bootloader configuration file.
---
 guix/scripts/system/reconfigure.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm
index dee0c24bd2..72d97b6c48 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -196,7 +196,7 @@ BOOTLOADER-PACKAGE."
                         (srfi srfi-35))
            (let* ((gc-root (string-append #$target %gc-roots-directory "/bootcfg"))
                   (temp-gc-root (string-append gc-root ".new")))
-             (switch-symlinks temp-gc-root gc-root)
+             (switch-symlinks temp-gc-root #$bootcfg)
              (install-boot-config #$bootcfg #$bootcfg-file #$target)
              ;; Preserve the previous activation's garbage collector root
              ;; until the bootloader installer has run, so that a failure in
-- 
2.22.0

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 36947-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
Cc: 36947-done <at> debbugs.gnu.org, ison <ison <at> airmail.cc>
Subject: Re: [bug#36947] [PATCH] reconfigure: Fix GC root installation.
Date: Tue, 6 Aug 2019 22:27:29 +0200

[Message part 1 (text/plain, inline)]

Hi Jakob,

thanks for that patch!

Pushed to guix master with a huge comment, as commit
5f04e9f9620aeb45940855e4f655f22db55ba6eb.

Feel free to Cc me with important installation-saving patches like that one.

[Message part 2 (application/pgp-signature, inline)]

Message #13 received at 36947-done <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 36947-done <at> debbugs.gnu.org, ison <ison <at> airmail.cc>
Subject: Re: [bug#36947] [PATCH] reconfigure: Fix GC root installation.
Date: Tue, 06 Aug 2019 16:47:03 -0400

[Message part 1 (text/plain, inline)]

Hi Danny,

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> Hi Jakob,
>
> thanks for that patch!

My pleasure :)

> Pushed to guix master with a huge comment, as commit
> 5f04e9f9620aeb45940855e4f655f22db55ba6eb.
>
> Feel free to Cc me with important installation-saving patches like that one.

Heh, I'll keep that in mind

Regards,
Jakob

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.