GNU bug report logs - #36950
27.0.50; Paste to isearch does not work

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36950 in the body.
You can then email your comments to 36950 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Paste to isearch does not work
Date: Wed, 07 Aug 2019 01:12:39 +0300

This is continuation of the closed bug#18727.
The xterm paste facility needs to be rewritten
to be like the GUI paste, so pasting to isearch
doesn't hang.

Message #8 received at 36950 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 36950 <at> debbugs.gnu.org
Subject: Re: bug#36950: 27.0.50; Paste to isearch does not work
Date: Fri, 13 Dec 2019 01:58:30 +0200

> This is continuation of the closed bug#18727.

This needs to be fixed before the release.  I provided the following patch
that fixes the problem, and don't know what else is needed.

diff --git a/lisp/isearch.el b/lisp/isearch.el
index 7c22e6ad97..1705b050b5 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -2508,10 +2508,12 @@ isearch-mouse-2
 
 (declare-function xterm--pasted-text "term/xterm" ())
 
-(defun isearch-xterm-paste ()
+(defun isearch-xterm-paste (event)
   "Pull terminal paste into search string."
-  (interactive)
-  (isearch-yank-string (xterm--pasted-text)))
+  (interactive "e")
+  (when (eq (car-safe event) 'xterm-paste)
+    (let ((pasted-text (nth 1 event)))
+      (isearch-yank-string pasted-text))))
 
 (defun isearch-yank-internal (jumpform)
   "Pull the text from point to the point reached by JUMPFORM.

Message #11 received at 36950 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 36950 <at> debbugs.gnu.org
Subject: Re: bug#36950: 27.0.50; Paste to isearch does not work
Date: Fri, 13 Dec 2019 09:27:01 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Date: Fri, 13 Dec 2019 01:58:30 +0200
> 
> > This is continuation of the closed bug#18727.
> 
> This needs to be fixed before the release.  I provided the following patch
> that fixes the problem, and don't know what else is needed.

You said there that this is somewhat ugly, and that a different
implementation would be cleaner.  Can you please elaborate?

Message #14 received at 36950 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36950 <at> debbugs.gnu.org
Subject: Re: bug#36950: 27.0.50; Paste to isearch does not work
Date: Sun, 15 Dec 2019 01:18:05 +0200

>> > This is continuation of the closed bug#18727.
>> 
>> This needs to be fixed before the release.  I provided the following patch
>> that fixes the problem, and don't know what else is needed.
>
> You said there that this is somewhat ugly, and that a different
> implementation would be cleaner.  Can you please elaborate?

Those are your words, not mine.  In bug#18727 you said:

  That's somewhat ugly, IMO.  We should try making the xterm paste
  facility play by the rules, like the GUI paste functionality does.

I don't know what you meant.

Message #17 received at 36950 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 36950 <at> debbugs.gnu.org
Subject: Re: bug#36950: 27.0.50; Paste to isearch does not work
Date: Sun, 15 Dec 2019 17:27:39 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 36950 <at> debbugs.gnu.org
> Date: Sun, 15 Dec 2019 01:18:05 +0200
> 
> >> > This is continuation of the closed bug#18727.
> >> 
> >> This needs to be fixed before the release.  I provided the following patch
> >> that fixes the problem, and don't know what else is needed.
> >
> > You said there that this is somewhat ugly, and that a different
> > implementation would be cleaner.  Can you please elaborate?
> 
> Those are your words, not mine.

Oops, you are right, sorry.

So please go ahead and install this.

Message #20 received at 36950 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36950 <at> debbugs.gnu.org
Subject: Re: bug#36950: 27.0.50; Paste to isearch does not work
Date: Mon, 16 Dec 2019 02:19:09 +0200

tags 36950 fixed
close 36950 27.0.50
quit

>> >> > This is continuation of the closed bug#18727.
>> >>
>> >> This needs to be fixed before the release.  I provided the following patch
>> >> that fixes the problem, and don't know what else is needed.
>> >
>> > You said there that this is somewhat ugly, and that a different
>> > implementation would be cleaner.  Can you please elaborate?
>>
>> Those are your words, not mine.
>
> Oops, you are right, sorry.
>
> So please go ahead and install this.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.