GNU bug report logs - #36955
[PATCH] machine: Add 'build-locally?' field for managed hosts.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36955 in the body.
You can then email your comments to 36955 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: guix-patches <at> gnu.org
Subject: [PATCH] machine: Add 'build-locally?' field for managed hosts.
Date: Wed, 07 Aug 2019 08:44:18 -0400

[Message part 1 (text/plain, inline)]

* gnu/machine/ssh.scm (machine-ssh-configuration-build-locally?): New
variable.
(managed-host-remote-eval): Pass 'build-locally?' to 'remote-eval'.
---
 gnu/machine/ssh.scm | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/gnu/machine/ssh.scm b/gnu/machine/ssh.scm
index ae312597dd..1f16d9a5ea 100644
--- a/gnu/machine/ssh.scm
+++ b/gnu/machine/ssh.scm
@@ -47,6 +47,7 @@
             machine-ssh-configuration
 
             machine-ssh-configuration-host-name
+            machine-ssh-configuration-build-locally?
             machine-ssh-configuration-port
             machine-ssh-configuration-user
             machine-ssh-configuration-session))
@@ -69,15 +70,17 @@
   make-machine-ssh-configuration
   machine-ssh-configuration?
   this-machine-ssh-configuration
-  (host-name machine-ssh-configuration-host-name) ; string
-  (port      machine-ssh-configuration-port       ; integer
-             (default 22))
-  (user      machine-ssh-configuration-user       ; string
-             (default "root"))
-  (identity  machine-ssh-configuration-identity   ; path to a private key
-             (default #f))
-  (session   machine-ssh-configuration-session    ; session
-             (default #f)))
+  (host-name      machine-ssh-configuration-host-name) ; string
+  (build-locally? machine-ssh-configuration-build-locally?
+                  (default #t))
+  (port           machine-ssh-configuration-port       ; integer
+                  (default 22))
+  (user           machine-ssh-configuration-user       ; string
+                  (default "root"))
+  (identity       machine-ssh-configuration-identity   ; path to a private key
+                  (default #f))
+  (session        machine-ssh-configuration-session    ; session
+                  (default #f)))
 
 (define (machine-ssh-session machine)
   "Return the SSH session that was given in MACHINE's configuration, or create
@@ -103,7 +106,10 @@ one from the configuration's parameters if one was not provided."
   "Internal implementation of 'machine-remote-eval' for MACHINE instances with
 an environment type of 'managed-host."
   (maybe-raise-unsupported-configuration-error machine)
-  (remote-eval exp (machine-ssh-session machine)))
+  (remote-eval exp (machine-ssh-session machine)
+               #:build-locally?
+               (machine-ssh-configuration-build-locally?
+                (machine-configuration machine))))
 
 
 ;;;
-- 
2.22.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: guix-patches <at> gnu.org
Cc: 36955 <at> debbugs.gnu.org
Subject: Re: [bug#36955] [PATCH] machine: Add 'build-locally?' field for
 managed hosts.
Date: Wed, 07 Aug 2019 15:20:59 -0400

Looks good, though I assume this is a dependency for another patch
that's coming?

Jakob L. Kreuze writes:

> * gnu/machine/ssh.scm (machine-ssh-configuration-build-locally?): New
> variable.
> (managed-host-remote-eval): Pass 'build-locally?' to 'remote-eval'.
> ---
>  gnu/machine/ssh.scm | 26 ++++++++++++++++----------
>  1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/machine/ssh.scm b/gnu/machine/ssh.scm
> index ae312597dd..1f16d9a5ea 100644
> --- a/gnu/machine/ssh.scm
> +++ b/gnu/machine/ssh.scm
> @@ -47,6 +47,7 @@
>              machine-ssh-configuration
>  
>              machine-ssh-configuration-host-name
> +            machine-ssh-configuration-build-locally?
>              machine-ssh-configuration-port
>              machine-ssh-configuration-user
>              machine-ssh-configuration-session))
> @@ -69,15 +70,17 @@
>    make-machine-ssh-configuration
>    machine-ssh-configuration?
>    this-machine-ssh-configuration
> -  (host-name machine-ssh-configuration-host-name) ; string
> -  (port      machine-ssh-configuration-port       ; integer
> -             (default 22))
> -  (user      machine-ssh-configuration-user       ; string
> -             (default "root"))
> -  (identity  machine-ssh-configuration-identity   ; path to a private key
> -             (default #f))
> -  (session   machine-ssh-configuration-session    ; session
> -             (default #f)))
> +  (host-name      machine-ssh-configuration-host-name) ; string
> +  (build-locally? machine-ssh-configuration-build-locally?
> +                  (default #t))
> +  (port           machine-ssh-configuration-port       ; integer
> +                  (default 22))
> +  (user           machine-ssh-configuration-user       ; string
> +                  (default "root"))
> +  (identity       machine-ssh-configuration-identity   ; path to a private key
> +                  (default #f))
> +  (session        machine-ssh-configuration-session    ; session
> +                  (default #f)))
>  
>  (define (machine-ssh-session machine)
>    "Return the SSH session that was given in MACHINE's configuration, or create
> @@ -103,7 +106,10 @@ one from the configuration's parameters if one was not provided."
>    "Internal implementation of 'machine-remote-eval' for MACHINE instances with
>  an environment type of 'managed-host."
>    (maybe-raise-unsupported-configuration-error machine)
> -  (remote-eval exp (machine-ssh-session machine)))
> +  (remote-eval exp (machine-ssh-session machine)
> +               #:build-locally?
> +               (machine-ssh-configuration-build-locally?
> +                (machine-configuration machine))))
>  
>  
>  ;;;

Message #14 received at 36955 <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
Cc: 36955 <at> debbugs.gnu.org
Subject: Re: [bug#36955] [PATCH] machine: Add 'build-locally?' field for
 managed hosts.
Date: Wed, 07 Aug 2019 16:47:02 -0400

[Message part 1 (text/plain, inline)]

Hi Chris,

Christopher Lemmer Webber <cwebber <at> dustycloud.org> writes:

> Looks good, though I assume this is a dependency for another patch
> that's coming?

Nah, this is standalone. Just so there's an option to offload the builds
when deploying to particularly capable machines.

Regards,
Jakob

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 36955-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: "Jakob L. Kreuze" <zerodaysfordays <at> sdf.lonestar.org>
Cc: 36955-done <at> debbugs.gnu.org
Subject: Re: [bug#36955] [PATCH] machine: Add 'build-locally?' field for
 managed hosts.
Date: Wed, 07 Aug 2019 18:29:45 -0400

Jakob L. Kreuze writes:

> Hi Chris,
>
> Christopher Lemmer Webber <cwebber <at> dustycloud.org> writes:
>
>> Looks good, though I assume this is a dependency for another patch
>> that's coming?
>
> Nah, this is standalone. Just so there's an option to offload the builds
> when deploying to particularly capable machines.
>
> Regards,
> Jakob

Ok, thanks for the clarity.  Merged and pushed!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.