GNU bug report logs - #37022
27.0.50; gnus-1 and gnus have identical docstrings

Previous Next

Packages: emacs, gnus;

Reported by: Alex Branham <alex.branham <at> gmail.com>

Date: Wed, 14 Aug 2019 00:39:01 UTC

Severity: minor

Tags: fixed, patch

Found in version 27.0.50

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37022 in the body.
You can then email your comments to 37022 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#37022; Package emacs,gnus. (Wed, 14 Aug 2019 00:39:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alex Branham <alex.branham <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org. (Wed, 14 Aug 2019 00:39:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; gnus-1 and gnus have identical docstrings
Date: Tue, 13 Aug 2019 19:38:03 -0500
Hi -

The commands gnus-1 and gnus have identical docstrings. gnus-1 should
probably specify how it differs from just M-x gnus (or be
noninterative).

Thanks,
Alex




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#37022; Package emacs,gnus. (Wed, 14 Aug 2019 19:56:01 GMT) Full text and rfc822 format available.

Message #8 received at 37022 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 37022 <at> debbugs.gnu.org
Subject: Re: bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings
Date: Wed, 14 Aug 2019 12:55:34 -0700
Alex Branham <alex.branham <at> gmail.com> writes:

> Hi -
>
> The commands gnus-1 and gnus have identical docstrings. gnus-1 should
> probably specify how it differs from just M-x gnus (or be
> noninterative).

I'm inclined to think that gnus-1 (and gnus-no-server-1) shouldn't be
interactive. I can't see any point to it -- the *-1 variants live in
gnus-start.el and are not autoloaded. It seems like Gnus' entry points
should be interactive and autoloaded, and what happens after that is
internals.




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#37022; Package emacs,gnus. (Fri, 23 Aug 2019 15:56:02 GMT) Full text and rfc822 format available.

Message #11 received at 37022 <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 37022 <at> debbugs.gnu.org, Alex Branham <alex.branham <at> gmail.com>
Subject: Re: bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings
Date: Fri, 23 Aug 2019 10:55:31 -0500
[Message part 1 (text/plain, inline)]
tags 37022 + patch
quit

On Wed 14 Aug 2019 at 12:55, Eric Abrahamsen <eric <at> ericabrahamsen.net> wrote:

> Alex Branham <alex.branham <at> gmail.com> writes:
>
>> Hi -
>>
>> The commands gnus-1 and gnus have identical docstrings. gnus-1 should
>> probably specify how it differs from just M-x gnus (or be
>> noninterative).
>
> I'm inclined to think that gnus-1 (and gnus-no-server-1) shouldn't be
> interactive. I can't see any point to it -- the *-1 variants live in
> gnus-start.el and are not autoloaded. It seems like Gnus' entry points
> should be interactive and autoloaded, and what happens after that is
> internals.

Here's a patch that makes them noninteractive.

Alex

[0001-lisp-gnus-gnus-start.el-gnus-1-gnus-no-server-1-Make.patch (text/x-patch, inline)]
From 2c2411d94618d8c719c2583fe7ed1c19d02cbae9 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham <at> gmail.com>
Date: Fri, 23 Aug 2019 10:51:48 -0500
Subject: [PATCH] * lisp/gnus/gnus-start.el (gnus-1, gnus-no-server-1): Make
 noninteractive

bug#37022
---
 lisp/gnus/gnus-start.el | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el
index 930d522c41..e8775c6667 100644
--- a/lisp/gnus/gnus-start.el
+++ b/lisp/gnus/gnus-start.el
@@ -738,7 +738,6 @@ gnus-no-server-1
 and not a positive number, Gnus will prompt the user for the name
 of an NNTP server to use.  As opposed to \\[gnus], this command
 will not connect to the local server."
-  (interactive "P")
   (let ((val (or arg (1- gnus-level-default-subscribed))))
     (gnus val t slave)
     (make-local-variable 'gnus-group-use-permanent-levels)
@@ -749,8 +748,6 @@ gnus-1
 If ARG is non-nil and a positive number, Gnus will use that as the
 startup level.  If ARG is non-nil and not a positive number, Gnus will
 prompt the user for the name of an NNTP server to use."
-  (interactive "P")
-
   (if (gnus-alive-p)
       (progn
 	(gnus-run-hooks 'gnus-before-resume-hook)
-- 
2.22.0


Added tag(s) patch. Request was from Alex Branham <alex.branham <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 23 Aug 2019 15:56:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#37022; Package emacs,gnus. (Sun, 25 Aug 2019 06:07:01 GMT) Full text and rfc822 format available.

Message #16 received at 37022 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 37022 <at> debbugs.gnu.org
Subject: Re: bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings
Date: Sun, 25 Aug 2019 08:06:26 +0200
Alex Branham <alex.branham <at> gmail.com> writes:

> Here's a patch that makes them noninteractive.

Thanks; applied to the trunk.

I don't know why those functions were ever interactive.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 25 Aug 2019 06:07:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.1, send any further explanations to 37022 <at> debbugs.gnu.org and Alex Branham <alex.branham <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 25 Aug 2019 06:07:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 22 Sep 2019 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 189 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.