GNU bug report logs - #37026
[PATCH] packages: Apply target triplet in bag-transitive-host-inputs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37026 in the body.
You can then email your comments to 37026 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Thompson <dthompson2 <at> worcester.edu>
To: guix-patches <at> gnu.org
Cc: David Thompson <dthompson2 <at> worcester.edu>
Subject: [PATCH] packages: Apply target triplet in bag-transitive-host-inputs.
Date: Wed, 14 Aug 2019 08:57:55 -0400

Fixes a bug where propagated inputs that should be cross-compiled are instead
compiled for the host system.

* guix/packages.scm (bag-transitive-host-inputs): Call transitive-inputs in
  the context of the bag's target system triplet.
---
 guix/packages.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index c94a651f27..143417b861 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -796,7 +796,8 @@ dependencies are known to build on SYSTEM."
 
 (define (bag-transitive-host-inputs bag)
   "Same as 'package-transitive-target-inputs', but applied to a bag."
-  (transitive-inputs (bag-host-inputs bag)))
+  (parameterize ((%current-target-system (bag-target bag)))
+    (transitive-inputs (bag-host-inputs bag))))
 
 (define (bag-transitive-target-inputs bag)
   "Return the \"target inputs\" of BAG, recursively."
-- 
2.17.1

Message #8 received at 37026 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: David Thompson <dthompson2 <at> worcester.edu>
Cc: 37026 <at> debbugs.gnu.org
Subject: Re: [bug#37026] [PATCH] packages: Apply target triplet in
 bag-transitive-host-inputs.
Date: Fri, 23 Aug 2019 23:31:08 +0200

Hello,

David Thompson <dthompson2 <at> worcester.edu> skribis:

> Fixes a bug where propagated inputs that should be cross-compiled are instead
> compiled for the host system.
>
> * guix/packages.scm (bag-transitive-host-inputs): Call transitive-inputs in
>   the context of the bag's target system triplet.
> ---
>  guix/packages.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index c94a651f27..143417b861 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -796,7 +796,8 @@ dependencies are known to build on SYSTEM."
>  
>  (define (bag-transitive-host-inputs bag)
>    "Same as 'package-transitive-target-inputs', but applied to a bag."
> -  (transitive-inputs (bag-host-inputs bag)))
> +  (parameterize ((%current-target-system (bag-target bag)))
> +    (transitive-inputs (bag-host-inputs bag))))

Good catch, please push!

Thanks,
Ludo’.

Message #13 received at 37026-done <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37026-done <at> debbugs.gnu.org
Subject: Re: [bug#37026] [PATCH] packages: Apply target triplet in
 bag-transitive-host-inputs.
Date: Mon, 26 Aug 2019 09:38:27 -0400

On Fri, Aug 23, 2019 at 5:31 PM Ludovic Courtès <ludo <at> gnu.org> wrote:
>
> Good catch, please push!

Thanks. Done!

- Dave

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.