GNU bug report logs - #37033
[PATCH] gnu: monero: Update to 0.14.1.2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37033 in the body.
You can then email your comments to 37033 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Guillaume Le Vaillant <glv <at> posteo.net>
Subject: [PATCH] gnu: monero: Update to 0.14.1.2.
Date: Wed, 14 Aug 2019 23:30:09 +0200

* gnu/packages/finance.scm (monero): Update to 0.14.1.2.
---
 gnu/packages/finance.scm | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 7bfe5e62ff..57c12daa9b 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -445,7 +445,7 @@ other machines/servers.  Electroncash does not download the Bitcoin Cash blockch
   ;; the system's dynamically linked library.
   (package
     (name "monero")
-    (version "0.14.1.0")
+    (version "0.14.1.2")
     (source
      (origin
        (method git-fetch)
@@ -466,7 +466,7 @@ other machines/servers.  Electroncash does not download the Bitcoin Cash blockch
            #t))
        (sha256
         (base32
-         "1asa197fad81jfv12qgaa7y7pdr1r1pda96m9pvivkh4v30cx0nh"))))
+         "00zl883c7lcd9z7g4y3vv7rxmr7ppzrxdblnhk32r9l3qzyw55r6"))))
     (build-system cmake-build-system)
     (native-inputs
      `(("doxygen" ,doxygen)
@@ -508,6 +508,12 @@ other machines/servers.  Electroncash does not download the Bitcoin Cash blockch
                (("return \\(")
                 "return ((std::string(getenv(\"HOME\"))) / "))
              #t))
+         (add-after 'change-log-path 'fix-file-permissions-for-tests
+           (lambda _
+             (for-each (lambda (f)
+                         (chmod f #o644))
+                       (find-files "tests/data/" "wallet_9svHk1.*"))
+             #t))
          ;; Only try tests that don't need access to network or system
          (replace 'check
            (lambda _
@@ -522,11 +528,6 @@ other machines/servers.  Electroncash does not download the Bitcoin Cash blockch
                        "DNSResolver.DNSSECSuccess"
                        "DNSResolver.DNSSECFailure"
                        "DNSResolver.GetTXTRecord"
-                       ;; TODO: Find why portability_wallet test fails
-                       ;; Maybe the Boost version used to create the test
-                       ;; wallet and the current Boost version are not
-                       ;; completely compatible?
-                       "Serialization.portability_wallet"
                        "is_hdd.linux_os_root")
                      ":")))
                (invoke "tests/unit_tests/unit_tests"
-- 
2.22.0

Message #8 received at 37033 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 37033 <at> debbugs.gnu.org
Subject: Re: [bug#37033] [PATCH] gnu: monero: Update to 0.14.1.2.
Date: Thu, 15 Aug 2019 11:22:27 +0300

[Message part 1 (text/plain, inline)]

On Wed, Aug 14, 2019 at 11:30:09PM +0200, Guillaume Le Vaillant wrote:
> * gnu/packages/finance.scm (monero): Update to 0.14.1.2.
> ---
>  gnu/packages/finance.scm | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
>                  "return ((std::string(getenv(\"HOME\"))) / "))
>               #t))
> +         (add-after 'change-log-path 'fix-file-permissions-for-tests
> +           (lambda _
> +             (for-each (lambda (f)
> +                         (chmod f #o644))
> +                       (find-files "tests/data/" "wallet_9svHk1.*"))
> +             #t))
>           ;; Only try tests that don't need access to network or system
>           (replace 'check

Does 'make-file-writable' from (guix build utils) instead of 'chmod'
work here?


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 37033 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 37033 <at> debbugs.gnu.org
Subject: Re: [bug#37033] [PATCH v2] gnu: monero: Update to 0.14.1.2.
Date: Thu, 15 Aug 2019 14:23:48 +0200

[Message part 1 (text/plain, inline)]

Efraim Flashner a écrit :

> On Wed, Aug 14, 2019 at 11:30:09PM +0200, Guillaume Le Vaillant wrote:
>> * gnu/packages/finance.scm (monero): Update to 0.14.1.2.
>> ---
>>  gnu/packages/finance.scm | 15 ++++++++-------
>>  1 file changed, 8 insertions(+), 7 deletions(-)
>> 
>>                  "return ((std::string(getenv(\"HOME\"))) / "))
>>               #t))
>> +         (add-after 'change-log-path 'fix-file-permissions-for-tests
>> +           (lambda _
>> +             (for-each (lambda (f)
>> +                         (chmod f #o644))
>> +                       (find-files "tests/data/" "wallet_9svHk1.*"))
>> +             #t))
>>           ;; Only try tests that don't need access to network or system
>>           (replace 'check
>
> Does 'make-file-writable' from (guix build utils) instead of 'chmod'
> work here?

Yes it works. The 'make-file-writable' function is perfect here, I just
didn't know about it. Here's the updated patch:

[0001-gnu-monero-Update-to-0.14.1.2.patch (text/x-diff, inline)]

From 9ec625224313e609c4f3d50b6bd6cf3bb38450a9 Mon Sep 17 00:00:00 2001
From: Guillaume Le Vaillant <glv <at> posteo.net>
Date: Thu, 15 Aug 2019 14:07:44 +0200
Subject: [PATCH] gnu: monero: Update to 0.14.1.2.

* gnu/packages/finance.scm (monero): Update to 0.14.1.2.
---
 gnu/packages/finance.scm | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 7bfe5e62ff..fc26b77279 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -445,7 +445,7 @@ other machines/servers.  Electroncash does not download the Bitcoin Cash blockch
   ;; the system's dynamically linked library.
   (package
     (name "monero")
-    (version "0.14.1.0")
+    (version "0.14.1.2")
     (source
      (origin
        (method git-fetch)
@@ -466,7 +466,7 @@ other machines/servers.  Electroncash does not download the Bitcoin Cash blockch
            #t))
        (sha256
         (base32
-         "1asa197fad81jfv12qgaa7y7pdr1r1pda96m9pvivkh4v30cx0nh"))))
+         "00zl883c7lcd9z7g4y3vv7rxmr7ppzrxdblnhk32r9l3qzyw55r6"))))
     (build-system cmake-build-system)
     (native-inputs
      `(("doxygen" ,doxygen)
@@ -508,6 +508,11 @@ other machines/servers.  Electroncash does not download the Bitcoin Cash blockch
                (("return \\(")
                 "return ((std::string(getenv(\"HOME\"))) / "))
              #t))
+         (add-after 'change-log-path 'fix-file-permissions-for-tests
+           (lambda _
+             (for-each make-file-writable
+                       (find-files "tests/data/" "wallet_9svHk1.*"))
+             #t))
          ;; Only try tests that don't need access to network or system
          (replace 'check
            (lambda _
@@ -522,11 +527,6 @@ other machines/servers.  Electroncash does not download the Bitcoin Cash blockch
                        "DNSResolver.DNSSECSuccess"
                        "DNSResolver.DNSSECFailure"
                        "DNSResolver.GetTXTRecord"
-                       ;; TODO: Find why portability_wallet test fails
-                       ;; Maybe the Boost version used to create the test
-                       ;; wallet and the current Boost version are not
-                       ;; completely compatible?
-                       "Serialization.portability_wallet"
                        "is_hdd.linux_os_root")
                      ":")))
                (invoke "tests/unit_tests/unit_tests"
-- 
2.22.1

Message #16 received at 37033-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 37033-done <at> debbugs.gnu.org
Subject: Re: [bug#37033] [PATCH v2] gnu: monero: Update to 0.14.1.2.
Date: Tue, 20 Aug 2019 09:29:17 +0300

[Message part 1 (text/plain, inline)]

On Thu, Aug 15, 2019 at 02:23:48PM +0200, Guillaume Le Vaillant wrote:
> 
> Efraim Flashner a écrit :
> 
> >
> > Does 'make-file-writable' from (guix build utils) instead of 'chmod'
> > work here?
> 
> Yes it works. The 'make-file-writable' function is perfect here, I just
> didn't know about it. Here's the updated patch:
> 

That was the plan :)

Patch pushed with minimal changes to the commit message.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.