GNU bug report logs - #37052
[PATCH] (wip-haskell-updates) Add stylish-haskell.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37052 in the body.
You can then email your comments to 37052 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] (wip-haskell-updates) Add stylish-haskell.
Date: Fri, 16 Aug 2019 14:25:19 +0000

[Message part 1 (text/plain, inline)]

Hi everyone,

Stylish haskell is a formatting tool for haskell code. It is the default
formatting option for the emacs haskell-mode.  It is not the newest or the
best but it is good enough for me usually.

Thanks,

- John

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ghc-file-embed.patch (text/x-patch, attachment)]

[0002-gnu-Add-stylish-haskell.patch (text/x-patch, attachment)]

Message #8 received at 37052 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 37052 <at> debbugs.gnu.org, Robert Vollmert <rob <at> vllmrt.net>
Subject: Re: [bug#37052] [PATCH] (wip-haskell-updates) Add stylish-haskell.
Date: Wed, 28 Aug 2019 18:08:54 +0200

Hi John,

John Soo <jsoo1 <at> asu.edu> skribis:

> From 512eed6f9d3cc788c381378557d576e470600ca0 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1 <at> asu.edu>
> Date: Fri, 16 Aug 2019 07:18:30 -0700
> Subject: [PATCH 1/2] gnu: Add ghc-file-embed.
>
> * gnu/packages/haskell-xyz (ghc-file-embed): new file.

Please address the ‘guix lint’ warning.

> +  (package
> +    (name "ghc-file-embed")
> +    (version "0.0.11")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        (string-append
> +         "https://hackage.haskell.org/package/file-embed/"
> +         "file-embed-" version ".tar.gz"))

I think Robert (Cc’d) aims make sure all the GHC packages come from the
same Stackage “snapshot”.  Robert, could you tell whether this is the
case?

Also, please use mirror://hackage here.

> +    (home-page
> +     "https://github.com/snoyberg/file-embed")
> +    (synopsis
> +     "Use Template Haskell to embed file contents directly.")

Better to keep each on a single line.  :-)

> +    (description
> +     "Use Template Haskell to read a file or all the files in a directory,
> +and turn them into (path, bytestring) pairs embedded in your Haskell code.")

Please see
<https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>.

> From fe5cbaeb2364d5d5debd629090d4a1fdd6f5939a Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1 <at> asu.edu>
> Date: Fri, 16 Aug 2019 07:20:28 -0700
> Subject: [PATCH 2/2] gnu: Add stylish-haskell.
>
> * gnu/packages/haskell-apps (stylish-haskell): new variable.

Same comments.  :-)

Thanks,
Ludo’.

Message #11 received at 37052 <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37052 <at> debbugs.gnu.org, John Soo <jsoo1 <at> asu.edu>,
 Robert Vollmert <rob <at> vllmrt.net>
Subject: Re: [bug#37052] [PATCH] (wip-haskell-updates) Add stylish-haskell.
Date: Wed, 28 Aug 2019 20:50:15 -0400

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> John Soo <jsoo1 <at> asu.edu> skribis:
>
>> +  (package
>> +    (name "ghc-file-embed")
>> +    (version "0.0.11")
>
> I think Robert (Cc’d) aims make sure all the GHC packages come from the
> same Stackage “snapshot”.  Robert, could you tell whether this is the
> case?

It’s too new.  Right now we are following LTS 12, which has file-embed
at 0.0.10.1.  The list is at <https://www.stackage.org/lts-12>.


-- Tim

Message #14 received at 37052 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37052 <at> debbugs.gnu.org, John Soo <jsoo1 <at> asu.edu>
Subject: Re: [bug#37052] [PATCH] (wip-haskell-updates) Add stylish-haskell.
Date: Thu, 29 Aug 2019 13:15:27 +0200

On 28. Aug 2019, at 18:08, Ludovic Courtès <ludo <at> gnu.org> wrote:
> I think Robert (Cc’d) aims make sure all the GHC packages come from the
> same Stackage “snapshot”.  Robert, could you tell whether this is the
> case?

Sorry, I’m afraid I don’t really have plans here anymore / won’t be able
to take care of the Haskell packages.

Cheers
Robert

Message #17 received at 37052 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Robert Vollmert <rob <at> vllmrt.net>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 37052 <at> debbugs.gnu.org,
 John Soo <jsoo1 <at> asu.edu>
Subject: Haskell package maintenance
Date: Thu, 29 Aug 2019 14:37:47 +0200

Hi Robert,

Robert Vollmert <rob <at> vllmrt.net> skribis:

> On 28. Aug 2019, at 18:08, Ludovic Courtès <ludo <at> gnu.org> wrote:
>> I think Robert (Cc’d) aims make sure all the GHC packages come from the
>> same Stackage “snapshot”.  Robert, could you tell whether this is the
>> case?
>
> Sorry, I’m afraid I don’t really have plans here anymore / won’t be able
> to take care of the Haskell packages.

I’m sad to hear that, but thanks for letting us know.

I realize we committers have been lagging behind, and I’m afraid this
may have to do with your decision.  :-/  If you have any suggestions on
how to improve our process, please let us know.  It’s tough!

Ludo’.

Message #20 received at 37052 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: 37052 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#37052] [PATCH] (wip-haskell-updates) Add stylish-haskell.
Date: Thu, 29 Aug 2019 14:50:24 +0000

[Message part 1 (text/plain, inline)]

HI Ludo and Timothy,

Thanks for the review.

> Please address the ‘guix lint’ warning.

I fixed all the lint errors (and the offending commit message, woops!).

> Better to keep each on a single line.  :-)

I put them each on a single line, I like that better!

> +and turn them into (path, bytestring) pairs embedded in your Haskell
code.")

I used @code{(path, bytestring)} for this tuple. Is that desired?

> It’s too new.  Right now we are following LTS 12, which has file-embed
> at 0.0.10.1.

I changed it to version 0.0.10.1.

Thanks again!

- John

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ghc-file-embed.patch (text/x-patch, attachment)]

[0002-gnu-Add-stylish-haskell.patch (text/x-patch, attachment)]

Message #25 received at 37052-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 37052-done <at> debbugs.gnu.org
Subject: Re: [bug#37052] [PATCH] (wip-haskell-updates) Add stylish-haskell.
Date: Sun, 01 Sep 2019 23:06:43 +0200

Hi John,

John Soo <jsoo1 <at> asu.edu> skribis:

>> +and turn them into (path, bytestring) pairs embedded in your Haskell
> code.")
>
> I used @code{(path, bytestring)} for this tuple. Is that desired?

Yup!

>> It’s too new.  Right now we are following LTS 12, which has file-embed
>> at 0.0.10.1.
>
> I changed it to version 0.0.10.1.

Actually I just realized we already have ‘ghc-file-embed’…

Anyway, I’ve applied the ‘stylish-haskell’ patch now, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.