GNU bug report logs - #37080
[PATCH] Update emacs-org-recent-headings.

Previous Next

Package: guix-patches;

Reported by: Brian Leung <bkleung89 <at> gmail.com>

Date: Mon, 19 Aug 2019 06:36:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37080 in the body.
You can then email your comments to 37080 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#37080; Package guix-patches. (Mon, 19 Aug 2019 06:36:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Brian Leung <bkleung89 <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 19 Aug 2019 06:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update emacs-org-recent-headings.
Date: Mon, 19 Aug 2019 08:34:39 +0200
[Message part 1 (text/plain, inline)]
The version of emacs-org-recent-headings on Guix doesn't work correctly for
people with Helm installed. I submitted patches to the upstream maintainer
of emacs-org-recent-headings. Attached is a Guix patch incorporating the
changes.
[Message part 2 (text/html, inline)]
[0001-gnu-emacs-org-recent-headings-Update-to-0.1-1.6336a0.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#37080; Package guix-patches. (Tue, 27 Aug 2019 10:31:01 GMT) Full text and rfc822 format available.

Message #8 received at 37080 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 37080 <at> debbugs.gnu.org
Subject: Re: [bug#37080] [PATCH] Update emacs-org-recent-headings.
Date: Tue, 27 Aug 2019 12:30:29 +0200
Hi Brian,

Brian Leung <bkleung89 <at> gmail.com> skribis:

> The version of emacs-org-recent-headings on Guix doesn't work correctly for
> people with Helm installed. I submitted patches to the upstream maintainer
> of emacs-org-recent-headings. Attached is a Guix patch incorporating the
> changes.

Have these patches been applied upstream?

Since we’re building from an upstream commit, we might just as well wait
until the changes are available upstream.

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#37080; Package guix-patches. (Tue, 27 Aug 2019 21:41:01 GMT) Full text and rfc822 format available.

Message #11 received at 37080 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#37080] [PATCH] Update emacs-org-recent-headings.
Date: Tue, 27 Aug 2019 18:52:49 +0200
[Message part 1 (text/plain, inline)]
Hi Ludovic,

The patches haven't been applied upstream. The upstream maintainer doesn't
review PRs in a timely manner, so I thought it might be worth submitting
the patch here.

Thanks,
Brian

On Tue, Aug 27, 2019 at 12:30 PM Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi Brian,
>
> Brian Leung <bkleung89 <at> gmail.com> skribis:
>
> > The version of emacs-org-recent-headings on Guix doesn't work correctly
> for
> > people with Helm installed. I submitted patches to the upstream
> maintainer
> > of emacs-org-recent-headings. Attached is a Guix patch incorporating the
> > changes.
>
> Have these patches been applied upstream?
>
> Since we’re building from an upstream commit, we might just as well wait
> until the changes are available upstream.
>
> Thanks,
> Ludo’.
>
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#37080; Package guix-patches. (Tue, 10 Sep 2019 04:25:02 GMT) Full text and rfc822 format available.

Message #14 received at 37080 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 37080 <at> debbugs.gnu.org
Subject: Re: [bug#37080] [PATCH] Update emacs-org-recent-headings.
Date: Tue, 10 Sep 2019 13:24:44 +0900
Hello Brian,

Brian Leung <bkleung89 <at> gmail.com> writes:

> Hi Ludovic,
>
> The patches haven't been applied upstream. The upstream maintainer doesn't
> review PRs in a timely manner, so I thought it might be worth submitting
> the patch here.
>
> Thanks,
> Brian
>
> On Tue, Aug 27, 2019 at 12:30 PM Ludovic Courtès <ludo <at> gnu.org> wrote:
>
>> Hi Brian,
>>
>> Brian Leung <bkleung89 <at> gmail.com> skribis:
>>
>> > The version of emacs-org-recent-headings on Guix doesn't work correctly
>> for
>> > people with Helm installed. I submitted patches to the upstream
>> maintainer
>> > of emacs-org-recent-headings. Attached is a Guix patch incorporating the
>> > changes.
>>
>> Have these patches been applied upstream?
>>
>> Since we’re building from an upstream commit, we might just as well wait
>> until the changes are available upstream.
>>
>> Thanks,
>> Ludo’.

+1, especially since the patches submitted upstream are still a WIP, AFAICT.
(see: https://github.com/alphapapa/org-recent-headings/issues/11).

Let's wait until a conclusion for a fix is reached and merged upstream
before we continue.

Thanks for your efforts in investigating the problem and working on a fix.

Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#37080; Package guix-patches. (Tue, 23 Nov 2021 04:31:01 GMT) Full text and rfc822 format available.

Message #17 received at 37080 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 37080 <at> debbugs.gnu.org, bkleung89 <at> gmail.com, ludo <at> gnu.org,
 maxim.cournoyer <at> gmail.com
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] gnu: emacs-org-recent-headings: Update to 0.1-0.97418d5.
Date: Mon, 22 Nov 2021 23:26:27 -0500
From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/emacs-xyz.scm (emacs-org-recent-headings): Update to 0.1-0.97418d5.
[propagated-inputs]: Add emacs-s and emacs-helm
---

Looks like the issue got fixed upstream.

The issue for reference: https://github.com/alphapapa/org-recent-headings/issues/11


 gnu/packages/emacs-xyz.scm | 46 +++++++++++++++++++++-----------------
 1 file changed, 25 insertions(+), 21 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f98425eab9..0fb3ee3a0c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17702,28 +17702,32 @@ (define-public emacs-frecency
       (license license:gpl3+))))
 
 (define-public emacs-org-recent-headings
-  (package
-    (name "emacs-org-recent-headings")
-    (version "0.1")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/alphapapa/org-recent-headings")
-                    (commit version)))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "0gsrzmg3mssh9s28yjm9m866fnhm1pcligssz1q6brga6dm6f2yy"))))
-    (build-system emacs-build-system)
-    (propagated-inputs
-     `(("emacs-org" ,emacs-org)
-       ("emacs-dash" ,emacs-dash)
-       ("emacs-frecency" ,emacs-frecency)))
-    (home-page "https://github.com/alphapapa/org-recent-headings")
-    (synopsis "Navigate to recently used Org headings and lists")
-    (description "This package maintains a list of recently used Org headings,
+  (let ((commit "97418d581ea030f0718794e50b005e9bae44582e")
+        (revision "0"))
+    (package
+      (name "emacs-org-recent-headings")
+      (version (git-version "0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/alphapapa/org-recent-headings")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1y11rlnhi36lzhc1cagninv6hlcwbvj88xfr0g0xzpbzy7hys021"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("emacs-dash" ,emacs-dash)
+         ("emacs-frecency" ,emacs-frecency)
+         ("emacs-helm" ,emacs-helm)
+         ("emacs-org" ,emacs-org)
+         ("emacs-s" ,emacs-s)))
+      (home-page "https://github.com/alphapapa/org-recent-headings")
+      (synopsis "Navigate to recently used Org headings and lists")
+      (description "This package maintains a list of recently used Org headings,
 as well as functions for navigating between these headings.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-org-super-agenda
   (package
-- 
2.34.0





Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Tue, 23 Nov 2021 09:35:32 GMT) Full text and rfc822 format available.

Notification sent to Brian Leung <bkleung89 <at> gmail.com>:
bug acknowledged by developer. (Tue, 23 Nov 2021 09:35:37 GMT) Full text and rfc822 format available.

Message #22 received at 37080-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Morgan.J.Smith <at> outlook.com
Cc: bkleung89 <at> gmail.com, ludo <at> gnu.org, maxim.cournoyer <at> gmail.com,
 37080-done <at> debbugs.gnu.org
Subject: Re: [bug#37080] [PATCH] gnu: emacs-org-recent-headings: Update to
 0.1-0.97418d5.
Date: Tue, 23 Nov 2021 10:33:20 +0100
Hello,

Morgan.J.Smith <at> outlook.com writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-recent-headings): Update to 0.1-0.97418d5.
> [propagated-inputs]: Add emacs-s and emacs-helm

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 21 Dec 2021 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 88 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.