GNU bug report logs - #37094
[PATCH 1-3/3] gnu: Add nomad.

Previous Next

Package: guix-patches;

Reported by: Amar Singh <nly <at> disroot.org>

Date: Tue, 20 Aug 2019 06:54:02 UTC

Severity: normal

Tags: patch

Done: Jan Nieuwenhuizen <janneke <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37094 in the body.
You can then email your comments to 37094 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#37094; Package guix-patches. (Tue, 20 Aug 2019 06:54:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Amar Singh <nly <at> disroot.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 20 Aug 2019 06:54:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Amar Singh <nly <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: mike.rosset <at> gmail.com
Subject: [PATCH 1-3/3] gnu: Add nomad.
Date: Tue, 20 Aug 2019 12:22:36 +0530
[Message part 1 (text/plain, inline)]
From the package description:

Nomad is an Emacs-like Web Browser built using Webkitgtk and
Emacsy.  It has a small C backend and most browser features are fully
programmable in Guile.  It has hooks, keymaps, and self documentation
features.

Though it requires a few changes to existing packages:

Patches:

1. Shroud related patches
 a. update to 0.1.2: brings Guile-2.2 support

Related issue: https://issues.guix.gnu.org/issue/36576

2. Emacsy related patches
 a. Add guile-emacsy package,
   $ guix size emacsy ... total: 1136.3 MiB
   versus:
   $ guix size guile-emacsy ... total: 132.3 MiB

Related issue: https://issues.guix.gnu.org/issue/36151
(Discussion about "emacsy" vs "guile-emacsy" naming)

3. Nomad related patches
 a. Add 'Nomad' package in guile-xyz.scm

4. [Optional] Emacsy package can also be cleaned up a bit, mostly
 removal of propagated-inputs. Though that's a seperate issue.
 [patch 04 attached]

Cheers,
amar

[0001-gnu-Add-guile-emacsy.patch (text/x-patch, attachment)]
[0002-gnu-shroud-Update-to-0.1.2.patch (text/x-patch, attachment)]
[0003-gnu-Add-nomad.patch (text/x-patch, attachment)]
[0004-gnu-emacsy-cleanup-build.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#37094; Package guix-patches. (Wed, 21 Aug 2019 01:28:01 GMT) Full text and rfc822 format available.

Message #8 received at 37094 <at> debbugs.gnu.org (full text, mbox):

From: Amar Singh <nly <at> disroot.org>
To: 37094 <at> debbugs.gnu.org
Subject: [PATCH 1-1] gnu: Add nomad
Date: Wed, 21 Aug 2019 06:57:34 +0530
[Message part 1 (text/plain, inline)]
"Patch 003: Add nomad" might not apply cleanly(thanks str1ngs). So this
is an alternative. The fault was that the patch mentions g-golf which is
not packaged in guix master yet. This was resolved by moving around the
nomad package.

This patch adds package Nomad to guile-xyz.scm.

[0003-gnu-Add-nomad.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#37094; Package guix-patches. (Wed, 21 Aug 2019 08:36:01 GMT) Full text and rfc822 format available.

Message #11 received at 37094 <at> debbugs.gnu.org (full text, mbox):

From: Amar Singh <nly <at> disroot.org>
To: 37094 <at> debbugs.gnu.org
Cc: mike.rosset <at> gmail.com
Subject: [PATCH 1-3/3] Add nomad
Date: Wed, 21 Aug 2019 14:04:47 +0530
[Message part 1 (text/plain, inline)]
After a few suggestions from Mike and Janneke:
1. Rename guile-emacsy --> emacsy-minimal
2. Removed glib-or-gtk-build-system in patch 004

cheers,
amar

[0001-gnu-Add-emacsy-minimal.patch (text/x-patch, attachment)]
[0002-gnu-shroud-Update-to-0.1.2.patch (text/x-patch, attachment)]
[0003-gnu-Add-nomad.patch (text/x-patch, attachment)]
[0004-gnu-emacsy-cleanup-build.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#37094; Package guix-patches. (Wed, 21 Aug 2019 16:54:01 GMT) Full text and rfc822 format available.

Message #14 received at 37094 <at> debbugs.gnu.org (full text, mbox):

From: Mike Rosset <mike.rosset <at> gmail.com>
To: Amar Singh <nly <at> disroot.org>
Cc: 37094 <at> debbugs.gnu.org
Subject: Re: [PATCH 1-3/3] Add nomad
Date: Wed, 21 Aug 2019 09:53:05 -0700
[Message part 1 (text/plain, inline)]
use version 0.1.0-alpha as version and git tag.

On Wed, Aug 21, 2019 at 1:34 AM Amar Singh <nly <at> disroot.org> wrote:
>
>
> After a few suggestions from Mike and Janneke:
> 1. Rename guile-emacsy --> emacsy-minimal
> 2. Removed glib-or-gtk-build-system in patch 004
>
> cheers,
> amar
>
[0005-gnu-nomad-Update-to-0.1.0-alpha.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#37094; Package guix-patches. (Thu, 22 Aug 2019 16:48:02 GMT) Full text and rfc822 format available.

Message #17 received at 37094 <at> debbugs.gnu.org (full text, mbox):

From: Mike Rosset <mike.rosset <at> gmail.com>
To: Amar Singh <nly <at> disroot.org>
Cc: 37094 <at> debbugs.gnu.org
Subject: Re: [PATCH 1-3/3] Add nomad
Date: Thu, 22 Aug 2019 09:47:15 -0700
[Message part 1 (text/plain, inline)]
Minor version bump to address outdated README and some minor fix's

On Wed, Aug 21, 2019 at 1:34 AM Amar Singh <nly <at> disroot.org> wrote:
>
>
> After a few suggestions from Mike and Janneke:
> 1. Rename guile-emacsy --> emacsy-minimal
> 2. Removed glib-or-gtk-build-system in patch 004
>
> cheers,
> amar
>
[0006-gnu-nomad-Update-to-0.1.1-alpha.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#37094; Package guix-patches. (Sun, 25 Aug 2019 20:49:01 GMT) Full text and rfc822 format available.

Message #20 received at 37094 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Amar Singh <nly <at> disroot.org>
Cc: mike.rosset <at> gmail.com, 37094 <at> debbugs.gnu.org,
 Jan Nieuwenhuizen <janneke <at> gnu.org>
Subject: Re: [bug#37094] [PATCH 1-3/3] Add nomad
Date: Sun, 25 Aug 2019 22:48:18 +0200
Hello!

Amar Singh <nly <at> disroot.org> skribis:

> After a few suggestions from Mike and Janneke:
> 1. Rename guile-emacsy --> emacsy-minimal
> 2. Removed glib-or-gtk-build-system in patch 004

Nice!  Janneke, could you take a look and apply the Emacsy patches?

I’ve applied the Shroud patch.

Thanks,
Ludo’.




Reply sent to Jan Nieuwenhuizen <janneke <at> gnu.org>:
You have taken responsibility. (Tue, 27 Aug 2019 15:07:03 GMT) Full text and rfc822 format available.

Notification sent to Amar Singh <nly <at> disroot.org>:
bug acknowledged by developer. (Tue, 27 Aug 2019 15:07:04 GMT) Full text and rfc822 format available.

Message #25 received at 37094-done <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: Amar Singh <nly <at> disroot.org>
Cc: mike.rosset <at> gmail.com, 37094-done <at> debbugs.gnu.org
Subject: Re: [bug#37094] [PATCH 1-3/3] Add nomad
Date: Tue, 27 Aug 2019 17:06:14 +0200
Amar Singh writes:

Hello,

> After a few suggestions from Mike and Janneke:
> 1. Rename guile-emacsy --> emacsy-minimal
> 2. Removed glib-or-gtk-build-system in patch 004
>
> cheers,
> amar
>
>>From 7040563cb1386c672c75ddb141b235d5895adfdf Mon Sep 17 00:00:00 2001
> From: Amar Singh <nly <at> disroot.org>

Your attachments start with an escaped `>From' line, it's long ago that
I saw those in emails, any idea where they come from?

> Date: Mon, 8 Jul 2019 12:04:56 +0530
> Subject: [PATCH 1/4] gnu: Add emacsy-minimal.
>
> *  (guile-emacsy): New variable.
    ^extra space

I have removed the extra space, we want just one here.

> +++ b/gnu/packages/guile-xyz.scm
> @@ -2377,6 +2377,36 @@ comes with a simple counter example using FreeGLUT and browser examples
>  in C using Gtk+-3 and WebKitGtk.")
>      (license license:gpl3+)))

I have added:

@@ -21,6 +21,7 @@
 ;;; Copyright © 2018 Pierre-Antoine Rouby <pierre-antoine.rouby <at> inria.fr>
 ;;; Copyright © 2018 Eric Bavier <bavier <at> member.fsf.org>
 ;;; Copyright © 2019 swedebugia <swedebugia <at> riseup.net>
+;;; Copyright © 2019 Amar Singh <nly <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;

Note the use of © instead of (C), no `by' and a space after your name.

For the rest, LGTM.

>>From ede5e0fd3234d82bd7158f0a58f58efc27d26850 Mon Sep 17 00:00:00 2001
> From: Amar Singh <nly <at> disroot.org>
> Date: Wed, 10 Jul 2019 16:46:35 +0530
> Subject: [PATCH 3/4] gnu: Add nomad.
>
> * gnu/packages/guile-xyz.scm (nomad): New variable.
> ---
>  gnu/packages/guile-xyz.scm | 91 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 91 insertions(+)
>
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index 77a765b52c..573dd461ad 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -58,6 +58,7 @@
>    #:use-module (gnu packages gperf)
>    #:use-module (gnu packages gtk)
>    #:use-module (gnu packages guile)
> +  #:use-module (gnu packages gnupg)

I have put this in its alphabetical place

@@ -56,6 +56,7 @@
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gnupg)
   #:use-module (gnu packages gperf)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)

> +    (version "v0.1.0-alpha")

and from here on, merged Mike's update.

>>From b082d2b141f87f91330e8416c40622b6213c9c9c Mon Sep 17 00:00:00 2001
> From: Amar Singh <nly <at> disroot.org>
> Date: Wed, 10 Jul 2019 16:45:50 +0530
> Subject: [PATCH 4/4] gnu: emacsy: cleanup build

I have changed this to

gnu: emacsy: Cleanup build.


> fix conflicts; emacsy requires guile-2.2.4 but found guile-2.2.6 in profile etc.
>
> build: add phase 'wrap-binaries
> bulid: glib-or-gtk-build-system wraps binaries to work with glib or gtk
> propagated-inputs: remove all but glib-network and gsettings
> ---
>  gnu/packages/guile-xyz.scm | 37 ++++++++++++++++++++++++++++++++-----
>  1 file changed, 32 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index 573dd461ad..88fc2eef2a 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -21,6 +21,7 @@
>  ;;; Copyright © 2018 Pierre-Antoine Rouby <pierre-antoine.rouby <at> inria.fr>
>  ;;; Copyright © 2018 Eric Bavier <bavier <at> member.fsf.org>
>  ;;; Copyright © 2019 swedebugia <swedebugia <at> riseup.net>
> +;;; Copyright (C) 2019 by Amar Singh<nly <at> disroot.org>

Removed this bit, see remarks above.

> +    (propagated-inputs
> +     `(("glib-networking" ,glib-networking)
> +       ("gssettings-desktop-schemas" ,gsettings-desktop-schemas)))

I have added ("glib" ,glib), which fixes

    Settings schema 'org.gnome.system.proxy' is not installed

> +         (add-after 'install 'wrap-binaries
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (effective (read-line
> +                                (open-pipe* OPEN_READ
> +                                            "guile" "-c"
> +                                            "(display (effective-version))")))
> +                    (deps (map (cut assoc-ref inputs <>) '("guile-lib" "guile-readline")))
> +                    (scm-path (map (cut string-append <> "/share/guile/site/" effective) `(,out ,@deps)))
> +                    (go-path (map (cut string-append <> "/lib/guile/" effective "/site-ccache/") `(,out ,@deps)))

I have reformatted this to not exceed 80 columns.

Thanks, I'm very excited to have nomad in Guix!

Pushed to master as 114f02bac47d86c04bf211e33864beffcde74aab

Greetings,
janneke

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com




Information forwarded to guix-patches <at> gnu.org:
bug#37094; Package guix-patches. (Tue, 27 Aug 2019 15:10:03 GMT) Full text and rfc822 format available.

Message #28 received at 37094 <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Amar Singh <nly <at> disroot.org>, 37094 <at> debbugs.gnu.org, mike.rosset <at> gmail.com
Subject: Re: [bug#37094] [PATCH 1-3/3] Add nomad
Date: Tue, 27 Aug 2019 17:09:36 +0200
Ludovic Courtès writes:

>> After a few suggestions from Mike and Janneke:
>> 1. Rename guile-emacsy --> emacsy-minimal
>> 2. Removed glib-or-gtk-build-system in patch 004
>
> Nice!  Janneke, could you take a look and apply the Emacsy patches?

Thanks for the ping/encouragement.

> I’ve applied the Shroud patch.

Thanks, done.

janneke

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com




Information forwarded to guix-patches <at> gnu.org:
bug#37094; Package guix-patches. (Tue, 27 Aug 2019 15:26:02 GMT) Full text and rfc822 format available.

Message #31 received at 37094-done <at> debbugs.gnu.org (full text, mbox):

From: Amar Singh <nly <at> disroot.org>
To: Jan Nieuwenhuizen <janneke <at> gnu.org>
Cc: mike.rosset <at> gmail.com, 37094-done <at> debbugs.gnu.org
Subject: Re: [bug#37094] [PATCH 1-3/3] Add nomad
Date: Tue, 27 Aug 2019 20:55:10 +0530
Your attachments start with an escaped `>From' line, it's long ago that
I saw those in emails, any idea where they come from?

Sorry, I don't have any idea. I use Emacs and K-9(Android) for mails.

Nomad in Guix, awesome!

Thanks,
Amar Singh<nly <at> disroot.org>
----------------
Sent fromK-9 Mail. Please excuse my brevity.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 25 Sep 2019 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 186 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.