GNU bug report logs - #37138
[PATCH] gnu: Add speedcrunch.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37138 in the body.
You can then email your comments to 37138 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Steve Sprang <steve.sprang <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add speedcrunch.
Date: Wed, 21 Aug 2019 17:25:41 -0700

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-speedcrunch.patch (text/x-patch, attachment)]

Message #8 received at 37138 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Steve Sprang <steve.sprang <at> gmail.com>
Cc: 37138 <at> debbugs.gnu.org
Subject: Re: [bug#37138] [PATCH] gnu: Add speedcrunch.
Date: Wed, 28 Aug 2019 18:33:29 +0200

Hello Steve,

Steve Sprang <steve.sprang <at> gmail.com> skribis:

> From a3dfe6c0fa6f5fddc3c47e7501e37ba11902eb80 Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs <at> stevesprang.com>
> Date: Wed, 21 Aug 2019 17:17:02 -0700
> Subject: [PATCH] gnu: Add speedcrunch.
>
> * gnu/packages/maths.scm (speedcrunch): New variable.

Nice.  A couple of comments:

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://bitbucket.org/heldercorreia/"
> +                                  "speedcrunch/get/release-" version
> +                                  ".tar.gz"))

I suspect this /get URL returns a generated tarball, whose exact content
might change over time.  If that is the case, could you instead use
‘git-fetch’ (or ‘hg-fetch’)?

> +    (inputs `(("qt" ,qt)))

Please use ‘qtbase’ & co., aka. the “modular Qt packages”.  The ‘qt’
package is the old monolithic package and is actually deprecated.

Could you send an updated patch?

Thanks!

Ludo’.

Message #11 received at 37138 <at> debbugs.gnu.org (full text, mbox):

From: Steve Sprang <steve.sprang <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37138 <at> debbugs.gnu.org
Subject: Re: [bug#37138] [PATCH] gnu: Add speedcrunch.
Date: Wed, 28 Aug 2019 13:58:27 -0700

[Message part 1 (text/plain, inline)]

Thanks for the feedback! Attached an updated patch.

-Steve

On Wed, Aug 28, 2019 at 9:33 AM Ludovic Courtès <ludo <at> gnu.org> wrote:
>
> Hello Steve,
>
> Steve Sprang <steve.sprang <at> gmail.com> skribis:
>
> > From a3dfe6c0fa6f5fddc3c47e7501e37ba11902eb80 Mon Sep 17 00:00:00 2001
> > From: Steve Sprang <scs <at> stevesprang.com>
> > Date: Wed, 21 Aug 2019 17:17:02 -0700
> > Subject: [PATCH] gnu: Add speedcrunch.
> >
> > * gnu/packages/maths.scm (speedcrunch): New variable.
>
> Nice.  A couple of comments:
>
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append "https://bitbucket.org/heldercorreia/"
> > +                                  "speedcrunch/get/release-" version
> > +                                  ".tar.gz"))
>
> I suspect this /get URL returns a generated tarball, whose exact content
> might change over time.  If that is the case, could you instead use
> ‘git-fetch’ (or ‘hg-fetch’)?
>
> > +    (inputs `(("qt" ,qt)))
>
> Please use ‘qtbase’ & co., aka. the “modular Qt packages”.  The ‘qt’
> package is the old monolithic package and is actually deprecated.
>
> Could you send an updated patch?
>
> Thanks!
>
> Ludo’.

[0001-gnu-Add-speedcrunch.patch (text/x-patch, attachment)]

Message #16 received at 37138-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Steve Sprang <steve.sprang <at> gmail.com>
Cc: 37138-done <at> debbugs.gnu.org
Subject: Re: [bug#37138] [PATCH] gnu: Add speedcrunch.
Date: Sat, 31 Aug 2019 20:58:27 +0200

Hi,

Steve Sprang <steve.sprang <at> gmail.com> skribis:

> From 6726ff51bde52459c1b27b4441c2fd070e489364 Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs <at> stevesprang.com>
> Date: Wed, 21 Aug 2019 17:17:02 -0700
> Subject: [PATCH] gnu: Add speedcrunch.
>
> * gnu/packages/maths.scm (speedcrunch): New variable.

Perfect, applied!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.