Received: (at 37150) by debbugs.gnu.org; 23 Aug 2019 03:55:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 22 23:55:13 2019
Received: from localhost ([127.0.0.1]:38745 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1i10fR-0005IJ-4q
for submit <at> debbugs.gnu.org; Thu, 22 Aug 2019 23:55:13 -0400
Received: from mail-pf1-f172.google.com ([209.85.210.172]:35524)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <alexvong1995@HIDDEN>) id 1i10fP-0005I2-Lb
for 37150 <at> debbugs.gnu.org; Thu, 22 Aug 2019 23:55:12 -0400
Received: by mail-pf1-f172.google.com with SMTP id d85so5529670pfd.2
for <37150 <at> debbugs.gnu.org>; Thu, 22 Aug 2019 20:55:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=references:user-agent:from:to:cc:subject:in-reply-to:date
:message-id:mime-version;
bh=6P3AY70xXN9wZ2FFKhEDpfwZ17RZRaQMpHlaoe28UoE=;
b=Kj3WixDbsDZOm0jV2QNOP70FJ3ZVhhUWVkYITO0dA0dn9CxBlz5pxlNS/7dSQX5+MU
vwqXhHiP69qioQ0+BbwHG4nnCom6Yx1arTwKcUn2AoV6jaNFqBFmwcYvs1rQ3iwyjCc6
VYTbRQKhHc1uDdFbPeyzV0C6zff96qoGakVwSLIKAU1wp+pbF4vI1GjgJ/TKdaRHKVj5
0LpzLYIq7Rvu37Za7vJLmC+zpHSjnW/0IC/5roRueJZq/py/LORATCwh4iPTzMmRKtTw
GHausAerogiaIJzu88t6pv6KRarkMOwmLKPe+kjQv7TFyvJ27kSv0FTBRq51n/uxjT5P
6hmA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:references:user-agent:from:to:cc:subject
:in-reply-to:date:message-id:mime-version;
bh=6P3AY70xXN9wZ2FFKhEDpfwZ17RZRaQMpHlaoe28UoE=;
b=c9I6BuQvcKczGqgH+EZQ2/Lob/KE4eYC0NUi123sOK9YQRRbV2/DsSngjfdkkljVXX
bvuSzXtfE5RmBykForJnYGS4VlA6DDVIO1WkFfqnh27RIqbP9DKV91NDuD13shCSviZN
pyJb5VYH/K8+JNBGAYwUwjKzK9QHKpaZR2NK1RTkospSH2N8gc8hT77L8WXefu7EU8J9
SBzHbp5MIjNYbYNiqbS9EwSik9EVgdQd/9aXeHdhathLbT1mPnHupD4W4kF9RxGtPIlA
mEnFn8u4HmZG9RnDs6RwD5iXdvWW7nkYE5n3pHP2VVwdwUAESH2UYNRGwuW/Hb9HBqsr
DyZA==
X-Gm-Message-State: APjAAAW1V/Sf7V17lRBSQRw+8s/3dVvycwNtHMihmvR6xDeadnCwtWd0
wLvdfWVFHrUqhj+c1+k3YbU=
X-Google-Smtp-Source: APXvYqzLNVVY+P/u2alDH0/3SriaOoOtAhgjaP70v7PxnSM4e8AafR3UaDZfWkefKiD9Q48DsniwQg==
X-Received: by 2002:a17:90a:9301:: with SMTP id
p1mr1251053pjo.22.1566532505715;
Thu, 22 Aug 2019 20:55:05 -0700 (PDT)
Received: from debian (42-98-181-003.static.netvigator.com. [42.98.181.3])
by smtp.gmail.com with ESMTPSA id a16sm973199pfk.5.2019.08.22.20.55.03
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 22 Aug 2019 20:55:04 -0700 (PDT)
References: <864l29iki4.fsf@HIDDEN> <87mug1ylg3.fsf@HIDDEN>
<861rxcioit.fsf@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.2
From: Alex Vong <alexvong1995@HIDDEN>
To: 37150 <at> debbugs.gnu.org
Subject: Re: Erroneous uses of regex in the invokation of FIND-FILES
In-reply-to: <861rxcioit.fsf@HIDDEN>
Date: Fri, 23 Aug 2019 11:55:00 +0800
Message-ID: <86zhk0h6y3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 37150
Cc: Mark H Weaver <mhw@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)
--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="
--=-=-=
Content-Type: text/plain
Hello Mark,
>> You're right. It would be good to fix these problems incrementally, as
>> long as the changes don't cause too many rebuilds.
>>
I agree we should fix it incrementally, like how the 'invoke' transition
was handled. The patch below does exactly that (it fixes the problem for
delta which causes 6 rebuilds only according to "guix refresh -l").
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
filename=0001-gnu-delta-Fix-regex-in-the-invokation-of-find-files.patch
Content-Transfer-Encoding: quoted-printable
From=20cb5f2febd564a2bcb550de537156db59588098c4 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@HIDDEN>
Date: Fri, 23 Aug 2019 11:06:49 +0800
Subject: [PATCH] gnu: delta: Fix regex in the invokation of 'find-files'.
See <https://bugs.gnu.org/37150> for more information.
* gnu/packages/debug.scm (delta)[arguments]: Fix regex.
=2D--
gnu/packages/debug.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm
index 82631deef6..e1cba5d3fe 100644
=2D-- a/gnu/packages/debug.scm
+++ b/gnu/packages/debug.scm
@@ -75,7 +75,7 @@
(begin
(for-each (lambda (h)
(install-file h doc))
=2D `("License.txt" ,@(find-files "www" ".*\\.htm=
l")))
+ `("License.txt" ,@(find-files "www" "\\.html$")=
))
(for-each (lambda (b)
(install-file b bin))
`("delta" "multidelta" "topformflat"))))
=2D-=20
2.23.0
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
>> Changes to core packages will need to wait for now, since 'core-updates'
>> is frozen, and 'core-updates-next' should also be considered frozen,
>> since it will become 'core-updates' as soon as Berlin has built it out a
>> bit more. (The only change in 'core-updates-next' relative to
>> 'core-updates' is that the new bootstrap tarballs have been fixed to be
>> deterministic.)
>>
>> For some of these fixes, it might be best to apply them to 'staging'.
>>
>>> Right now, the erroneous use of regex in CUSTOM-GCC casues the 'bin/'
>>> directory of the output of gccgo, gcc-objc and gcc-objc++ to be empty.
>>
>> I'm uncertain how many rebuilds it would trigger to change 'custom-gcc',
>> and I don't have confidence that "guix refresh -l" is capable of giving
>> us a reliable answer. In the meantime, would you like to file a bug
>> report for this, so it's not forgotten?
>>
It would probably cause a world rebuild... I will wait for the next
cycle for patch submittion.
>> Thanks for looking into it.
>>
>> Best,
>> Mark
You're welcomed!
=2D-=20
Stand with Hong Kong!
#Eye4HK #BoycottMulan
Alex
https://twitter.com/freedomhkg
https://twitter.com/stand_with_hk
--=-=-=--
--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iHUEARYIAB0WIQQwb8uPLAHCXSnTBVZh71Au9gJS8gUCXV9jlAAKCRBh71Au9gJS
8m0xAP9eWbx+nuJ7TlmIUiinZA//diChWzWivt0ay23kR806tQD+LuqLxadqBzgo
NE5rZb0DbRkdhmQoF5MVdJ8+4bdq0Qw=
=8hgq
-----END PGP SIGNATURE-----
--==-=-=--
bug-guix@HIDDEN:bug#37150; Package guix.
Full text available.Received: (at submit) by debbugs.gnu.org; 23 Aug 2019 02:50:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 22 22:50:32 2019 Received: from localhost ([127.0.0.1]:38674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1i0zep-0007xU-MI for submit <at> debbugs.gnu.org; Thu, 22 Aug 2019 22:50:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:41152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <alexvong1995@HIDDEN>) id 1i0zen-0007xM-Qv for submit <at> debbugs.gnu.org; Thu, 22 Aug 2019 22:50:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58968) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <alexvong1995@HIDDEN>) id 1i0zel-0007rY-6I for bug-guix@HIDDEN; Thu, 22 Aug 2019 22:50:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <alexvong1995@HIDDEN>) id 1i0zej-0001n2-Tv for bug-guix@HIDDEN; Thu, 22 Aug 2019 22:50:26 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:45312) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <alexvong1995@HIDDEN>) id 1i0zej-0001ma-M3 for bug-guix@HIDDEN; Thu, 22 Aug 2019 22:50:25 -0400 Received: by mail-pg1-x52e.google.com with SMTP id o13so4863999pgp.12 for <bug-guix@HIDDEN>; Thu, 22 Aug 2019 19:50:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:date:message-id:mime-version; bh=BdEmbzfxHDzkPlbqjipQG/2on6CxRNambTNACc1jPbg=; b=IHO+HgQAAjEXvUlQ/yVPT+eNb2lyEinAae85B1rxQQcF4RAacIzKMuX9he7zw6K3um EDj5PqdeDDCX5wZ3EIKiaqRoQdbcl48gKmHLyFl+HaZ2cjV3snvT11j+HOSK3OmPpuPZ 5nkdcybUTMZdqPbLuxo8PMj3oe2jPSLzrkG6R3pccy6w5DbeHsJmtzBbHvnhXluDCLc2 JTXezg/y5xSDh+QmOWfe8kO4imDq2xoWo1BH3wsuNK1AxxV3HC25+ZxLY5t2UTZ6867B j2tbMrjHF3/d0hPwdXg8eL1cyjCgSrSdc0t4Z0fufDZeSLKcwh6BRtsD5yufDYCr5Bxb Gqkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject:date :message-id:mime-version; bh=BdEmbzfxHDzkPlbqjipQG/2on6CxRNambTNACc1jPbg=; b=s4z7vx7HuyycrOQnccqKUiC/2Dt+6yeSCMbA+016Od4gUHRY4JQSbxc2lBkWBiO/jv ffEydEqKscH8TFyB198wt9xpNwqczfI2N67+/JOYADiF3kSnWzZGyfcBOvU4sB0JSBYV ouZm2BwkiniB/ZtIE2C0eu1b9tzGHq/sA6NMIPgcdE9jxmYoo6fUbQfv1CCklB5/w87K /KpiDx3IG4rfGhDbysTkeVbLf6crvr6d6GugdpNZU6rXmRUmZtTEQzsxjuGm3yjjAvyu Z54R1uotyuPm34ggqi1yks/ueN2yR5Ih9tufqVfj+/VNhnE4ym70L64EA/4T3hmZw2Ew 48Cw== X-Gm-Message-State: APjAAAVqxQ3ua9hMceM5oSKo+FvXPIxGulZp/IOE8xKh8sh9halK0o+G iLTk9oi5y0mi42GAWOLwzhzChy7w X-Google-Smtp-Source: APXvYqyc+p1XB3GEQ6QjO7Iln038tuz4+jQIddZziUeWb5aPl6SUNoOON5g5UI8x9aHRHOZ8DyIENQ== X-Received: by 2002:a62:6045:: with SMTP id u66mr2500684pfb.261.1566528624271; Thu, 22 Aug 2019 19:50:24 -0700 (PDT) Received: from debian (42-98-181-003.static.netvigator.com. [42.98.181.3]) by smtp.gmail.com with ESMTPSA id e9sm817520pfh.155.2019.08.22.19.50.22 for <bug-guix@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 19:50:23 -0700 (PDT) References: <864l29iki4.fsf@HIDDEN> <87mug1ylg3.fsf@HIDDEN> User-agent: mu4e 1.2.0; emacs 26.2 From: Alex Vong <alexvong1995@HIDDEN> To: bug-guix@HIDDEN Subject: Erroneous uses of regex in the invokation of FIND-FILES Date: Fri, 23 Aug 2019 10:50:02 +0800 Message-ID: <861rxcioit.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52e X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello guix, Currently, there are a lot of erroneous uses of regex in the invokation of FIND-FILES. Please see the conversations below (taken from https://lists.gnu.org/archive/html/guix-devel/2019-08/msg00149.html). Mark H Weaver writes: > Hi Alex, > > Alex Vong <alexvong1995@HIDDEN> writes: > >> I find out that there are a lof of erroneous uses of regex in the >> invokation of FIND-FILES. The correct usage should be: >> >> (find-files "." "\\.c$") >> >> Instead people write: >> >> (find-files "." ".*\\.c") >> >> which match unwanted files. >> >> For examples, in the procedure CUSTOM-GCC, the correct regex should be: >> >> "(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)$" >> >> instead of: >> >> ".*(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)" >> >> Please correct me if I am wrong. > > You're right. It would be good to fix these problems incrementally, as > long as the changes don't cause too many rebuilds. > > Changes to core packages will need to wait for now, since 'core-updates' > is frozen, and 'core-updates-next' should also be considered frozen, > since it will become 'core-updates' as soon as Berlin has built it out a > bit more. (The only change in 'core-updates-next' relative to > 'core-updates' is that the new bootstrap tarballs have been fixed to be > deterministic.) > > For some of these fixes, it might be best to apply them to 'staging'. > >> Right now, the erroneous use of regex in CUSTOM-GCC casues the 'bin/' >> directory of the output of gccgo, gcc-objc and gcc-objc++ to be empty. > > I'm uncertain how many rebuilds it would trigger to change 'custom-gcc', > and I don't have confidence that "guix refresh -l" is capable of giving > us a reliable answer. In the meantime, would you like to file a bug > report for this, so it's not forgotten? > > Thanks for looking into it. > > Best, > Mark =2D-=20 Stand with Hong Kong! #Eye4HK Alex https://twitter.com/freedomhkg https://twitter.com/stand_with_hk --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQwb8uPLAHCXSnTBVZh71Au9gJS8gUCXV9UWgAKCRBh71Au9gJS 8kCUAQCllDPx3sygAoAI2qJv74Dz6fKvF9FNh+j+WfJ+p/T9UAEA9CU9RJSp/0DA SxHDGeHMcetMoj9nkgQq8AZPTrjaAgc= =fvZ/ -----END PGP SIGNATURE----- --=-=-=--
Alex Vong <alexvong1995@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#37150; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.