GNU bug report logs - #37169
[PATCH] gnu: Add lib3mf.

Previous Next

Package: guix-patches;

Reported by: Steve Sprang <steve.sprang <at> gmail.com>

Date: Sat, 24 Aug 2019 00:13:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37169 in the body.
You can then email your comments to 37169 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#37169; Package guix-patches. (Sat, 24 Aug 2019 00:13:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Steve Sprang <steve.sprang <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 24 Aug 2019 00:13:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Steve Sprang <steve.sprang <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add lib3mf.
Date: Fri, 23 Aug 2019 17:12:32 -0700
[Message part 1 (text/plain, inline)]

[0001-gnu-Add-lib3mf.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#37169; Package guix-patches. (Wed, 28 Aug 2019 16:39:02 GMT) Full text and rfc822 format available.

Message #8 received at 37169 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Steve Sprang <steve.sprang <at> gmail.com>
Cc: 37169 <at> debbugs.gnu.org
Subject: Re: [bug#37169] [PATCH] gnu: Add lib3mf.
Date: Wed, 28 Aug 2019 18:38:51 +0200
Steve Sprang <steve.sprang <at> gmail.com> skribis:

> From 09b40a31d69ca6f6894d9ed33ef519efc64b220b Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs <at> stevesprang.com>
> Date: Fri, 23 Aug 2019 15:23:00 -0700
> Subject: [PATCH] gnu: Add lib3mf.
>
> * gnu/packages/engineering.scm (lib3mf): New variable.

Could you address the ‘guix lint’ warnings?  In particular, you’ll have
to use ‘git-fetch’ to get the source.

> +	 (add-after 'unpack 'unpack-googletest
> +	   (lambda* (#:key inputs #:allow-other-keys)
> +	     (copy-recursively (assoc-ref inputs "googletest-source")
> +			       "UnitTests/googletest")

Would it work to simply pass ‘googletest’ as an input?
If not, this approach is fine IMO.

> +     "Lib3MF is a C++ implementation of the 3D Manufacturing Format (3MF) file
> +standard.  It offers a way to integrate 3MF reading and writing capabilities, as
> +well as conversion and validation tools for input and output data.  The
> +specification can be downloaded at http://3mf.io/specification/.")
                                      ^
You can write: @url{http://…}.

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#37169; Package guix-patches. (Wed, 28 Aug 2019 21:28:02 GMT) Full text and rfc822 format available.

Message #11 received at 37169 <at> debbugs.gnu.org (full text, mbox):

From: Steve Sprang <steve.sprang <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37169 <at> debbugs.gnu.org
Subject: Re: [bug#37169] [PATCH] gnu: Add lib3mf.
Date: Wed, 28 Aug 2019 14:27:09 -0700
[Message part 1 (text/plain, inline)]
On Wed, Aug 28, 2019 at 9:38 AM Ludovic Courtès <ludo <at> gnu.org> wrote:

> > +      (add-after 'unpack 'unpack-googletest
> > +        (lambda* (#:key inputs #:allow-other-keys)
> > +          (copy-recursively (assoc-ref inputs "googletest-source")
> > +                            "UnitTests/googletest")
>
> Would it work to simply pass ‘googletest’ as an input?
> If not, this approach is fine IMO.

Unfortunately, no, the build process expects to see the googletest
source in a sub-module directory.

Attached a new patch with the fixes you suggested.
[0001-gnu-Add-lib3mf.patch (text/x-patch, attachment)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sat, 31 Aug 2019 19:03:01 GMT) Full text and rfc822 format available.

Notification sent to Steve Sprang <steve.sprang <at> gmail.com>:
bug acknowledged by developer. (Sat, 31 Aug 2019 19:03:02 GMT) Full text and rfc822 format available.

Message #16 received at 37169-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Steve Sprang <steve.sprang <at> gmail.com>
Cc: 37169-done <at> debbugs.gnu.org
Subject: Re: [bug#37169] [PATCH] gnu: Add lib3mf.
Date: Sat, 31 Aug 2019 21:02:41 +0200
Steve Sprang <steve.sprang <at> gmail.com> skribis:

> From a691020809334c94a33a9632c8a7fd75102fd8f2 Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs <at> stevesprang.com>
> Date: Fri, 23 Aug 2019 15:23:00 -0700
> Subject: [PATCH] gnu: Add lib3mf.
>
> * gnu/packages/engineering.scm (lib3mf): New variable.

Applied, thanks!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 29 Sep 2019 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 182 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.