GNU bug report logs - #37180
[PATCH] gnu: gcl: Enable tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37180 in the body.
You can then email your comments to 37180 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gcl: Enable tests.
Date: Sun, 25 Aug 2019 11:42:05 -0400

This patch enables tests in GNU Common Lisp and also seems to repair Maxima's
build failure on master (at least on x86_64). Review and more testing would be
appreciated.

Message #8 received at 37180 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: 37180 <at> debbugs.gnu.org
Cc: Kei Kebreau <kkebreau <at> posteo.net>
Subject: [PATCH] gnu: gcl: Enable tests.
Date: Sun, 25 Aug 2019 11:44:01 -0400

* gnu/packages/lisp.scm (gcl)[arguments]: Remove #:tests? flag and set the
  #:test-target to "ansi-tests/test_results".
---
 gnu/packages/lisp.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index d32f4b19bd..2c08e06a55 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -113,7 +113,7 @@
       (build-system gnu-build-system)
       (arguments
        `(#:parallel-build? #f  ; The build system seems not to be thread safe.
-         #:tests? #f  ; There does not seem to be make check or anything similar.
+         #:test-target "ansi-tests/test_results"
          #:configure-flags '("--enable-ansi") ; required for use by the maxima package
          #:make-flags (list
                        (string-append "GCL_CC=" (assoc-ref %build-inputs "gcc")
-- 
2.23.0

Message #13 received at 37180-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: 37180-done <at> debbugs.gnu.org
Subject: Re: [bug#37180] [PATCH] gnu: gcl: Enable tests.
Date: Mon, 02 Sep 2019 14:16:03 -0400

Kei Kebreau <kkebreau <at> posteo.net> writes:

> * gnu/packages/lisp.scm (gcl)[arguments]: Remove #:tests? flag and set the
>   #:test-target to "ansi-tests/test_results".
> ---
>  gnu/packages/lisp.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index d32f4b19bd..2c08e06a55 100644
> --- a/gnu/packages/lisp.scm
> +++ b/gnu/packages/lisp.scm
> @@ -113,7 +113,7 @@
>        (build-system gnu-build-system)
>        (arguments
>         `(#:parallel-build? #f  ; The build system seems not to be thread safe.
> -         #:tests? #f  ; There does not seem to be make check or anything similar.
> +         #:test-target "ansi-tests/test_results"
>           #:configure-flags '("--enable-ansi") ; required for use by the maxima package
>           #:make-flags (list
>                         (string-append "GCL_CC=" (assoc-ref %build-inputs "gcc")

Pushed to master. The patch doesn't appear to negatively affect the
i686-linux, x86_64-linux and armhf-linux architectures.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.