GNU bug report logs - #37214
[PATCH] vc-svn error messages are used as ignore list

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37214 in the body.
You can then email your comments to 37214 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] vc-svn error messages are used as ignore list
Date: Wed, 28 Aug 2019 20:54:22 +0200

Function `vc-svn-ignore-completion-table' in `lisp/vc/vc-svn.el'
does not work properly.

If the property "svn:ignore" does not exist, an error message is
written to the output buffer, which is then used as a list of
ignored files.

The output buffer is split whitespace, which creates problems
with whitespace in file names.

The attached patch fixes both problems.

Message #8 received at 37214 <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
To: 37214 <at> debbugs.gnu.org
Subject: Re: bug#37214: [PATCH] vc-svn error messages are used as ignore list
Date: Wed, 28 Aug 2019 21:06:13 +0200

[Message part 1 (text/plain, inline)]

Forgot the patch file.

[0001-Do-not-use-error-messages-as-list-of-ignored-files.patch (text/x-patch, attachment)]

Message #11 received at 37214 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
Cc: 37214 <at> debbugs.gnu.org
Subject: Re: bug#37214: [PATCH] vc-svn error messages are used as ignore list
Date: Sun, 15 Sep 2019 15:16:16 +0200

Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de> writes:

> * lisp/vc/vc-svn.el: (vc-svn-ignore-completion-table) Ignore buffer
> contents, if exit status is not 0.  Split buffer by lines.

I don't use svn, but:


[...]

> -    (vc-svn-command t t nil "propget" "svn:ignore" (expand-file-name directory))
> -    (split-string (buffer-string))))
> +    (if (= (vc-svn-command t t nil "propget" "svn:ignore" (expand-file-name directory)) 0)
> +        (split-string (buffer-string) "\n"))))

This looked "obviously correct", so I've applied it without testing
(after a slight stylistic change).  If this leads to errors with actual
svn users, please revert.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.