GNU bug report logs - #37217
[PATCH] vc-default-ignore implementation is incorrect

Previous Next

Package: emacs;

Reported by: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>

Date: Thu, 29 Aug 2019 00:54:02 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37217 in the body.
You can then email your comments to 37217 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#37217; Package emacs. (Thu, 29 Aug 2019 00:54:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 29 Aug 2019 00:54:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] vc-default-ignore implementation is incorrect
Date: Thu, 29 Aug 2019 02:53:20 +0200
[Message part 1 (text/plain, inline)]
Only the basename of FILE is written to the ignore file. This is
wrong for all filenames relative to project root with one ore
more parent directories.

The remove option is also implemented incorrectly.

The attached patch fixes these errors.

[0001-Fixes-vc-default-ignore.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37217; Package emacs. (Thu, 29 Aug 2019 15:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 37217 <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
To: 37217 <at> debbugs.gnu.org
Subject: Re: bug#37217: Acknowledgement ([PATCH] vc-default-ignore
 implementation is incorrect)
Date: Thu, 29 Aug 2019 17:44:23 +0200
[Message part 1 (text/plain, inline)]
A unit test showed, that the removal regexp was faulty. New version of patch attached.

[0001-Fix-vc-default-ignore.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37217; Package emacs. (Sun, 15 Sep 2019 13:07:01 GMT) Full text and rfc822 format available.

Message #11 received at 37217 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
Cc: 37217 <at> debbugs.gnu.org
Subject: Re: bug#37217: [PATCH] vc-default-ignore implementation is incorrect
Date: Sun, 15 Sep 2019 15:06:04 +0200
Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de> writes:

> Only the basename of FILE is written to the ignore file. This is
> wrong for all filenames relative to project root with one ore
> more parent directories.
>
> The remove option is also implemented incorrectly.

[...]

> A unit test showed, that the removal regexp was faulty. New version of
> patch attached.

Thanks; I've only lightly tested this, but if I read the code correctly,
I think it makes sense, so I've now applied it to Emacs 27.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 15 Sep 2019 13:07:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.1, send any further explanations to 37217 <at> debbugs.gnu.org and Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 15 Sep 2019 13:07:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 14 Oct 2019 11:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 168 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.