GNU bug report logs - #37223
26.2; vc does not honor backup-directory-alist

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37223 in the body.
You can then email your comments to 37223 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ndame <emacsuser <at> freemail.hu>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 26.2; vc does not honor backup-directory-alist
Date: Thu, 29 Aug 2019 21:55:32 +0200 (CEST)

[Message part 1 (text/plain, inline)]

I often use vc log and then f (log-view-find-revision) to view a
specific revision of a file.

The problem is the file is checked out to the same directory as the
original file with a backup file name (~, polluting the directory with
such files if multiple versions are perused.

These are backup files, the vc function uses that name too
(vc-version-backup-file-name), so their placements should honor
backup-directory-alist which is currently ignored.

[Message part 2 (text/html, inline)]

Message #10 received at 37223 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: ndame <emacsuser <at> freemail.hu>, 37223 <at> debbugs.gnu.org
Subject: Re: bug#37223: 26.2; vc does not honor backup-directory-alist
Date: Sat, 14 Sep 2019 03:40:48 +0300

On 29.08.2019 22:55, ndame wrote:
> I often use vc log and then f (log-view-find-revision) to view a
> specific revision of a file.
> 
> The problem is the file is checked out to the same directory as the
> original file with a backup file name (~, polluting the directory with
> such files if multiple versions are perused.
> 
> These are backup files, the vc function uses that name too
> (vc-version-backup-file-name), so their placements should honor
> backup-directory-alist which is currently ignored.

I don't know if they should. The current behavior is a long-standing one.

But more opinions are welcome.

Message #13 received at 37223 <at> debbugs.gnu.org (full text, mbox):

From: ndame <emacsuser <at> freemail.hu>
To: "37223 <at> debbugs.gnu.org" <37223 <at> debbugs.gnu.org>,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#37223: 26.2; vc does not honor backup-directory-alist
Date: Sat, 14 Sep 2019 19:20:25 +0000 (GMT)

[Message part 1 (text/plain, inline)]

> 
> >
> > These are backup files, the vc function uses that name too
> > (vc-version-backup-file-name), so their placements should honor
> > backup-directory-alist which is currently ignored.
> 
> I don't know if they should. The current behavior is a long-standing
> one.  But more opinions are welcome.

The main problem is the user may not want these files at all.

I usually look at a particular version then close the buffer, I don't
want a file created and having such files polluting the directory. I
just want to see the contents.

I'd say more people use log to look up something in a certain version
than actually wanting to get a certain version on disk.

So there's two possible solutions:

1. Add an option to control if backup-directory-alist is honored by
these files and this can be off by default to keep current default
behavior.

2. Do not create files at all on disk, just read the selected
version's contents into a new buffer. The user can decide if he wants
to just look at the file and then close the buffer, or if he wants the
given version on disk then he can save the buffer.

The 2nd option seems better, since it gives control to the user to do
with the buffer as he wishes.

[Message part 2 (text/html, inline)]

Message #16 received at 37223 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: ndame <emacsuser <at> freemail.hu>
Cc: "37223 <at> debbugs.gnu.org" <37223 <at> debbugs.gnu.org>,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#37223: 26.2; vc does not honor backup-directory-alist
Date: Thu, 19 Sep 2019 23:22:42 +0300

> 2. Do not create files at all on disk, just read the selected
> version's contents into a new buffer. The user can decide if he wants
> to just look at the file and then close the buffer, or if he wants the
> given version on disk then he can save the buffer.
>
> The 2nd option seems better, since it gives control to the user to do
> with the buffer as he wishes.

Please try a new option 'vc-find-revision-no-save' added in Emacs 27.
If you like it, then this report could be closed.

Message #19 received at 37223 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: ndame <emacsuser <at> freemail.hu>
Cc: "37223 <at> debbugs.gnu.org" <37223 <at> debbugs.gnu.org>,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#37223: 26.2; vc does not honor backup-directory-alist
Date: Wed, 13 Nov 2019 22:47:06 +0200

tags 37223 + fixed
close 37223 27.0.50
quit

>> 2. Do not create files at all on disk, just read the selected
>> version's contents into a new buffer. The user can decide if he wants
>> to just look at the file and then close the buffer, or if he wants the
>> given version on disk then he can save the buffer.
>>
>> The 2nd option seems better, since it gives control to the user to do
>> with the buffer as he wishes.
>
> Please try a new option 'vc-find-revision-no-save' added in Emacs 27.
> If you like it, then this report could be closed.

No response within last 2 months, so I guess everything is alright,
thus closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.