GNU bug report logs - #37277
[PATCHES] Thunar: Update to 1.8.9.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37277 in the body.
You can then email your comments to 37277 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: L  p R n  d n    <guix <at> lprndn.info>
To: guix-patches <at> gnu.org 
Subject: [PATCHES] Thunar: Update to 1.8.9.
Date: Mon, 02 Sep 2019 16:10:29 +0200

[0013-gnu-Thunar-Update-to-1.8.9.patch (text/x-patch, attachment)]

[0014-gnu-Thunar-Add-gobject-introspection-support.patch (text/x-patch, attachment)]

Message #8 received at 37277 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: L p R n d n <guix <at> lprndn.info>
Cc: 37277 <at> debbugs.gnu.org
Subject: Re: [bug#37277] [PATCHES] Thunar: Update to 1.8.9.
Date: Sun, 08 Sep 2019 14:33:40 +0200

L  p R n  d n    <guix <at> lprndn.info> skribis:

>>From 49d9ed778206d6af039029298f0f8f9aa47171ae Mon Sep 17 00:00:00 2001
> From: L  p R n  d n <guix <at> lprndn.info>
> Date: Mon, 19 Aug 2019 14:01:52 +0200
> Subject: [PATCH 13/19] gnu: Thunar: Update to 1.8.9.
>
> * gnu/packages/xfce.scm (thunar): Update to 1.8.9.
> [propagated-inputs] Add gtk+.
> ---
>  gnu/packages/xfce.scm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index b27e489678..db8387b9ad 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.")
>  (define-public thunar
>    (package
>      (name "thunar")
> -    (version "1.8.7")
> +    (version "1.8.9")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/src/xfce/"
> @@ -649,11 +649,14 @@ like appearance, display, keyboard and mouse settings.")
>                                    "Thunar-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))
> +                "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)))
> +    (propagated-inputs
> +     ;; Required by thunarx-3.pc
> +     `(("gtk+" ,gtk+)))

Hi!  We usually propagated in similar cases.  However, here that would
lead to propagating all of gtk+ to the user’s profile, which is
undesirable.  Furthermore, since thunar has only two dependents, it’s
probably not a problem if we don’t propagate gtk+.

WDYT?

Thanks,
Ludo’.

Message #11 received at 37277 <at> debbugs.gnu.org (full text, mbox):

From: L  p R n  d n    <guix <at> lprndn.info>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37277 <at> debbugs.gnu.org
Subject: Re: [bug#37277] [PATCHES] Thunar: Update to 1.8.9.
Date: Thu, 12 Sep 2019 10:18:46 +0200

[Message part 1 (text/plain, inline)]

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> L  p R n  d n    <guix <at> lprndn.info> skribis:
>
>>>From 49d9ed778206d6af039029298f0f8f9aa47171ae Mon Sep 17 00:00:00 2001
>> From: L  p R n  d n <guix <at> lprndn.info>
>> Date: Mon, 19 Aug 2019 14:01:52 +0200
>> Subject: [PATCH 13/19] gnu: Thunar: Update to 1.8.9.
>>
>> * gnu/packages/xfce.scm (thunar): Update to 1.8.9.
>> [propagated-inputs] Add gtk+.
>> ---
>>  gnu/packages/xfce.scm | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
>> index b27e489678..db8387b9ad 100644
>> --- a/gnu/packages/xfce.scm
>> +++ b/gnu/packages/xfce.scm
>> @@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.")
>>  (define-public thunar
>>    (package
>>      (name "thunar")
>> -    (version "1.8.7")
>> +    (version "1.8.9")
>>      (source (origin
>>                (method url-fetch)
>>                (uri (string-append "http://archive.xfce.org/src/xfce/"
>> @@ -649,11 +649,14 @@ like appearance, display, keyboard and mouse settings.")
>>                                    "Thunar-" version ".tar.bz2"))
>>                (sha256
>>                 (base32
>> -                "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))
>> +                "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs"))))
>>      (build-system gnu-build-system)
>>      (native-inputs
>>       `(("pkg-config" ,pkg-config)
>>         ("intltool" ,intltool)))
>> +    (propagated-inputs
>> +     ;; Required by thunarx-3.pc
>> +     `(("gtk+" ,gtk+)))
>
> Hi!  We usually propagated in similar cases.  However, here that would
> lead to propagating all of gtk+ to the user’s profile, which is
> undesirable.  Furthermore, since thunar has only two dependents, it’s
> probably not a problem if we don’t propagate gtk+.
>
> WDYT?

I don't have enough knowledge about how this works to give a useful hint
here so I would probably just follow your advice. Yet I quickly tested without
propagated-inputs and it seems to work without trouble.
So here is the new patch.

> Thanks,
> Ludo’.

Thank you and have a nice day,

L  p R n  d n

[0001-gnu-Thunar-Update-to-1.8.9.patch (text/x-patch, attachment)]

Message #16 received at 37277-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: L p R n d n <guix <at> lprndn.info>
Cc: 37277-done <at> debbugs.gnu.org
Subject: Re: [bug#37277] [PATCHES] Thunar: Update to 1.8.9.
Date: Fri, 13 Sep 2019 10:29:28 +0200

Hi,

L  p R n  d n    <guix <at> lprndn.info> skribis:

> From f57c21a46a0cdf23085195e3645b4f1aae9e8cbd Mon Sep 17 00:00:00 2001
> From: L  p R n  d n <guix <at> lprndn.info>
> Date: Mon, 19 Aug 2019 14:01:52 +0200
> Subject: [PATCH] gnu: Thunar: Update to 1.8.9.
>
> * gnu/packages/xfce.scm (thunar): Update to 1.8.9.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.