GNU bug report logs - #37295
[PATCH] services: ntp: Support different NTP server types and options.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37295 in the body.
You can then email your comments to 37295 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] services: ntp: Support different NTP server types and options.
Date: Tue, 03 Sep 2019 21:21:44 +0900

[Message part 1 (text/plain, inline)]

Hello!

This patch series aims at improving our NTP service.

While traveling, my date wouldn't be synchronized correctly, due to my
hardware clock (the one configurable through the BIOS) was more than
1000 s off the time queried from the NTP servers, and 'ntpd' was not
configured by default to allow an initial correction larger than 1000 s.

This patch series fixes this use case (travelling across timezones) and
further the ntp-configuration record to allow specifying different types
of NTP servers as well as their options.

[0001-services-ntp-Allow-large-adjustment-by-default.patch (text/x-patch, attachment)]

[0002-services-ntp-Fix-KOD-warning.patch (text/x-patch, attachment)]

[0003-doc-Add-index-to-find-ntpd.patch (text/x-patch, attachment)]

[0004-services-ntp-Support-different-NTP-server-types-and-.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 37295 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 37295 <at> debbugs.gnu.org
Subject: [PATCHv2] services: ntp: Support different NTP server types and
 options.
Date: Wed, 04 Sep 2019 09:25:52 +0900

[Message part 1 (text/plain, inline)]

Hello,

I had forgotten to register the new test module in the file Makefile.am.

Attached is the corrected patch.

[0001-services-ntp-Support-different-NTP-server-types-and-.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 37295 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 37295 <at> debbugs.gnu.org
Subject: Re: [bug#37295] [PATCHv2] services: ntp: Support different NTP
 server types and options.
Date: Thu, 5 Sep 2019 10:09:43 +0300

[Message part 1 (text/plain, inline)]

Can you check how this affects the openntpd service? It currently also
uses %ntp-servers


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 37295 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 37295 <at> debbugs.gnu.org
Subject: Re: [bug#37295] [PATCHv3] services: ntp: Support different NTP server
 types and options.
Date: Tue, 03 Sep 2019 17:04:27 +0900

[Message part 1 (text/plain, inline)]

Hello Efraim,

Efraim Flashner <efraim <at> flashner.co.il> writes:

> Can you check how this affects the openntpd service? It currently also
> uses %ntp-servers

I had overlooked this important detail; thanks for pointing it out!

I made the simplest change possible, by introducing a %openntpd-servers
variable that holds a list of addresses (strings), which is defined as
(map ntp-server-address %ntp-servers).  This variable is used as the new
default value for the "servers" field of the openntpd-configuration
record.  See the attached patch for details.

[0001-services-ntp-Support-different-NTP-server-types-and-.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

We could also overhaul the code of the openntpd-service-type so that it'd
be possible to provide different server types and options like for the
'ntp-service-type', but I'm not sure it's worth it, given that OpenNTPD
is more spartan than NTP (it only supports two server types ('server' vs
'servers'), already captured as fields in its configuration record; and
its server directives only support one option, 'weight', which can
currently be included in the server string if desired).

However, I noticed that the configuration file produced by the openntpd
service, while valid, is not very clean.

For the documented following openntpd-service-type definition:

--8<---------------cut here---------------start------------->8---
(openntpd-configuration
            (listen-on '("127.0.0.1" "::1"))
            (sensor '("udcf0 correction 70000"))
            (constraint-from '("www.gnu.org"))
            (constraints-from '("https://www.google.com/"))
            (allow-large-adjustment? #t)))
--8<---------------cut here---------------end--------------->8---

The following configuration file is generated:

--8<---------------cut here---------------start------------->8---
listen on 127.0.0.1
 listen on ::1
constraints from "https://www.google.com/"
constraints from "https://www.google.com/"
sensor udcf0 correction 70000
constraints from "https://www.google.com/"
constraints from "https://www.google.com/"
servers 0.guix.pool.ntp.org
constraints from "https://www.google.com/"
constraint from www.gnu.org
--8<---------------cut here---------------end--------------->8---

This is reproducible when testing without my changes (with the difference
that multiple servers were used instead of a single "pool" entry point).

I've opened an issue so that this issue can be tracked separately here:
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37318.

Thank you!

Maxim

Message #17 received at 37295 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 37295 <at> debbugs.gnu.org
Subject: Re: [bug#37295] [PATCHv3] services: ntp: Support different NTP
 server types and options.
Date: Fri, 6 Sep 2019 13:46:13 +0300

[Message part 1 (text/plain, inline)]

I like the changes to the openntpd service in relation to the other
changes.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 37295 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 37295 <at> debbugs.gnu.org
Subject: Re: [bug#37295] [PATCHv3] services: ntp: Support different NTP server
 types and options.
Date: Sat, 07 Sep 2019 13:27:15 +0900

Efraim Flashner <efraim <at> flashner.co.il> writes:

> I like the changes to the openntpd service in relation to the other
> changes.

Great!  I'll be awaiting an OK or let some time pass (2 weeks from now)
before I merge these patches into master.

You may want to check out the fixes I did to the openntp package/service
here as well: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37318.

Thank you,

Maxim

Message #23 received at 37295 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 37295 <at> debbugs.gnu.org
Subject: Re: [bug#37295] [PATCHv3] services: ntp: Support different NTP
 server types and options.
Date: Sun, 8 Sep 2019 11:06:35 +0300

[Message part 1 (text/plain, inline)]

On Sat, Sep 07, 2019 at 01:27:15PM +0900, Maxim Cournoyer wrote:
> Efraim Flashner <efraim <at> flashner.co.il> writes:
> 
> > I like the changes to the openntpd service in relation to the other
> > changes.
> 
> Great!  I'll be awaiting an OK or let some time pass (2 weeks from now)
> before I merge these patches into master.
> 
> You may want to check out the fixes I did to the openntp package/service
> here as well: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37318.
> 

This looks good to me!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 37295-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 37295-done <at> debbugs.gnu.org
Subject: Re: [bug#37295] [PATCHv3] services: ntp: Support different NTP server
 types and options.
Date: Sun, 08 Sep 2019 23:19:36 +0900

Hi!

Efraim Flashner <efraim <at> flashner.co.il> writes:

> On Sat, Sep 07, 2019 at 01:27:15PM +0900, Maxim Cournoyer wrote:
>> Efraim Flashner <efraim <at> flashner.co.il> writes:
>> 
>> > I like the changes to the openntpd service in relation to the other
>> > changes.
>> 
>> Great!  I'll be awaiting an OK or let some time pass (2 weeks from now)
>> before I merge these patches into master.
>> 
>> You may want to check out the fixes I did to the openntp package/service
>> here as well: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37318.
>> 
>
> This looks good to me!

Thanks for the quick feedback; I've merged this into master with commit
5658ae8a0a.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.