GNU bug report logs - #37317
[PATCH] Add emacs-flyspell-grammalecte

Previous Next

Package: guix-patches;

Reported by: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Date: Thu, 5 Sep 2019 23:12:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37317 in the body.
You can then email your comments to 37317 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#37317; Package guix-patches. (Thu, 05 Sep 2019 23:12:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 05 Sep 2019 23:12:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add emacs-flyspell-grammalecte
Date: Fri, 06 Sep 2019 01:11:29 +0200
[Message part 1 (text/plain, inline)]
Hello,

The following patch adds emacs-flyspell-grammalecte.

Feedback welcome.

Regards,

-- 
Nicolas Goaziou
[0001-gnu-Add-emacs-flycheck-grammalecte.patch (text/x-diff, inline)]
From d362da36f369d0bf98d49c484ce9fd6b0603b5b2 Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Date: Fri, 6 Sep 2019 01:10:10 +0200
Subject: [PATCH] gnu: Add emacs-flycheck-grammalecte.

* gnu/packages/emacs-xyz.scm (emacs-flycheck-grammalecte): New variable.
---
 gnu/packages/emacs-xyz.scm | 54 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8f866fbc28..7ca3f8e4ca 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -88,6 +88,7 @@
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages code)
   #:use-module (gnu packages databases)
+  #:use-module (gnu packages dictionaries)
   #:use-module (gnu packages emacs)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages gtk)
@@ -3076,6 +3077,59 @@ boundaries defined by syntax highlighting.")
 for Flow files.")
       (license license:gpl3+))))
 
+(define-public emacs-flycheck-grammalecte
+  (package
+    (name "emacs-flycheck-grammalecte")
+    (version "0.9")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://git.deparis.io/"
+                                  "flycheck-grammalecte/snapshot/"
+                                  "flycheck-grammalecte-" version ".tar.xz"))
+              (sha256
+               (base32
+                "0wjm9xyra870pci4bcrbnc9x66x18mi7iz08rkxa4clxv28xzryb"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:include '("\\.(el|py)$")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-python
+           ;; Hardcode python3 executable in the Emacs library.
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((python3 (string-append (assoc-ref inputs "python")
+                                           "/bin/python3")))
+               (substitute* "flycheck-grammalecte.el"
+                 (("python3") python3))
+               #t)))
+         (add-after 'install 'link-to-grammalecte
+           ;; The package expects grammalecte to be in a sub-directory.
+           ;; Symlink it there from the store.
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((grammalecte (assoc-ref inputs "grammalecte"))
+                   (out (assoc-ref outputs "out"))
+                   (version ,(version-major+minor (package-version python))))
+               (with-directory-excursion
+                   (string-append out
+                                  "/share/emacs/site-lisp/guix.d/"
+                                  "flycheck-grammalecte-" ,version)
+                 (symlink (string-append grammalecte "/lib/"
+                                         "python" version "/site-packages/"
+                                         "grammalecte")
+                          "grammalecte"))))))))
+    (inputs
+     `(("grammalecte" ,grammalecte)
+       ("python" ,python)))
+    (propagated-inputs
+     `(("emacs-flycheck" ,emacs-flycheck)))
+    (home-page "https://git.deparis.io/flycheck-grammalecte/")
+    (synopsis "Integrate Grammalecte with Flycheck")
+    (description "Integrate the French grammar and typography checker
+Grammalecte with Flycheck to automatically look for mistakes in your
+writings. It also provides an easy way to find synonyms and antonyms for
+a given word (to avoid repetitions for example).")
+    (license license:gpl3+)))
+
 (define-public emacs-elisp-demos
   (package
     (name "emacs-elisp-demos")
-- 
2.23.0


Information forwarded to guix-patches <at> gnu.org:
bug#37317; Package guix-patches. (Fri, 06 Sep 2019 07:10:01 GMT) Full text and rfc822 format available.

Message #8 received at 37317 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 37317 <at> debbugs.gnu.org
Subject: Re: [bug#37317] [PATCH] Add emacs-flyspell-grammalecte
Date: Fri, 06 Sep 2019 09:09:55 +0200
Completing myself,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> +         (add-after 'install 'link-to-grammalecte
> +           ;; The package expects grammalecte to be in a sub-directory.
> +           ;; Symlink it there from the store.
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let ((grammalecte (assoc-ref inputs "grammalecte"))
> +                   (out (assoc-ref outputs "out"))
> +                   (version ,(version-major+minor (package-version python))))
> +               (with-directory-excursion
> +                   (string-append out
> +                                  "/share/emacs/site-lisp/guix.d/"
> +                                  "flycheck-grammalecte-" ,version)
> +                 (symlink (string-append grammalecte "/lib/"
> +                                         "python" version "/site-packages/"
> +                                         "grammalecte")
> +                          "grammalecte"))))))))

I forgot a #t here. I'll add it. I'm not sending the updated patch.

> +    (inputs
> +     `(("grammalecte" ,grammalecte)
> +       ("python" ,python)))
> +    (propagated-inputs
> +     `(("emacs-flycheck" ,emacs-flycheck)))
> +    (home-page "https://git.deparis.io/flycheck-grammalecte/")
> +    (synopsis "Integrate Grammalecte with Flycheck")
> +    (description "Integrate the French grammar and typography checker
> +Grammalecte with Flycheck to automatically look for mistakes in your
> +writings. It also provides an easy way to find synonyms and antonyms for

Missing space here. Also fixed.




Information forwarded to guix-patches <at> gnu.org:
bug#37317; Package guix-patches. (Thu, 26 Sep 2019 21:12:02 GMT) Full text and rfc822 format available.

Message #11 received at 37317 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 37317 <at> debbugs.gnu.org
Subject: Re: [bug#37317] [PATCH] Add emacs-flyspell-grammalecte
Date: Thu, 26 Sep 2019 23:11:04 +0200
Hi Nicolas,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

>>From d362da36f369d0bf98d49c484ce9fd6b0603b5b2 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
> Date: Fri, 6 Sep 2019 01:10:10 +0200
> Subject: [PATCH] gnu: Add emacs-flycheck-grammalecte.
>
> * gnu/packages/emacs-xyz.scm (emacs-flycheck-grammalecte): New variable.

LGTM, thanks!

Ludo’.




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Fri, 27 Sep 2019 19:49:02 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
bug acknowledged by developer. (Fri, 27 Sep 2019 19:49:03 GMT) Full text and rfc822 format available.

Message #16 received at 37317-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37317-done <at> debbugs.gnu.org
Subject: Re: [bug#37317] [PATCH] Add emacs-flyspell-grammalecte
Date: Fri, 27 Sep 2019 21:48:35 +0200
Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> LGTM, thanks!

Applied. Thank you!

Regards,

-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 26 Oct 2019 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 155 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.