GNU bug report logs - #37329
[PATCH] gnu: Add audacious.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Kei Kebreau <kkebreau@HIDDEN>; Keywords: patch; dated Sat, 7 Sep 2019 04:59:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 37329 <at> debbugs.gnu.org:


Received: (at 37329) by debbugs.gnu.org; 8 Sep 2019 00:18:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 07 20:18:41 2019
Received: from localhost ([127.0.0.1]:38244 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i6kuf-0006gq-60
	for submit <at> debbugs.gnu.org; Sat, 07 Sep 2019 20:18:41 -0400
Received: from mout02.posteo.de ([185.67.36.66]:35487)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kkebreau@HIDDEN>) id 1i6kuc-0006gb-JC
 for 37329 <at> debbugs.gnu.org; Sat, 07 Sep 2019 20:18:39 -0400
Received: from submission (posteo.de [89.146.220.130]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 5693A2400FB
 for <37329 <at> debbugs.gnu.org>; Sun,  8 Sep 2019 02:18:32 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1567901912; bh=D6CxAC7c47KyTVX4gGJKBESZy4CNg+6jtPEJbvwlmXo=;
 h=From:To:Cc:Subject:Date:From;
 b=YDf49RhOLJEjQMIg2U6hwZw9NXKRprIuYH9d2P4l8OVNnPjjlfg0YuXndzVoA3qHW
 c/f56UZTMuaWm56RdwNjYOAsxRnJeHLpVhs460dl0G2PZ8JH7wxkqhCnPoaU6gvQ2O
 Z1i9LNzH+N8nmfJYr9nwbZ8jsvhY9LZCD+GvISY5FeNnss/aDuqpvWgDTMgYY2JxhL
 utSshONjdSUo+e/IRG3xSItVf3i771R+pKE78oRCdXW34cYInPnJLEbrWLrS8un0gG
 +y9Om5YwFqYnZO2X+k/n6U9khonpkqz/7pKWK1uQWzE14NKK4AcsRjpswNIkZPH9Hh
 AydbMoaTkGgmQ==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 46QsMp3lNjz9rxG;
 Sun,  8 Sep 2019 02:18:30 +0200 (CEST)
From: Kei Kebreau <kkebreau@HIDDEN>
To: Ricardo Wurmus <rekado@HIDDEN>
Subject: Re: [bug#37329] [PATCH] gnu: Add audacious.
References: <20190907045755.6578-1-kkebreau@HIDDEN> <87ef0swcrf.fsf@nckx>
 <87imq4xiil.fsf@HIDDEN> <87y2yzu9as.fsf@HIDDEN>
Date: Sat, 07 Sep 2019 20:18:28 -0400
In-Reply-To: <87y2yzu9as.fsf@HIDDEN> (Ricardo Wurmus's message of "Sat,
 07 Sep 2019 22:43:23 +0200")
Message-ID: <87muffiqsr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 37329
Cc: Tobias Geerinckx-Rice <me@HIDDEN>, 37329 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ricardo Wurmus <rekado@HIDDEN> writes:

> Kei Kebreau <kkebreau@HIDDEN> writes:
>
>>>> +    (arguments
>>>> +     `(#:configure-flags
>>>> +       (list "--disable-gtk" "--enable-qt"
>>
>> In reply to your later email: I used Qt instead of the default GTK+ 2
>> because of a personal preference, but apparently it's possible to enable
>> both to let users choose what they prefer.
>
> Would this retain references to *both* toolkits?  Wouldn=E2=80=99t this m=
ake the
> package much bigger than it otherwise would be?
>
> What=E2=80=99s the smaller variant=E2=80=A6?
>

Enabling both toolkits would retain references to both, but it isn't
much larger than enabling only Qt.  That said, a GTK+ 2
exclusive build is smaller than a Qt exclusive one by a large margin:

Excluding plugins:
* Both toolkits: 1495.1 MiB
* Qt only:       1344.2 MiB
* GTK+ 2 only:    538.0 MiB

Including plugins:
* Both toolkits: 1736.2 MiB
* Qt only:       1734.9 MiB
* GTK+ 2 only:   1126.6 MiB

>>>> +       #:phases
>>>> +       (modify-phases %standard-phases
>>>> +         (add-after 'install 'unpack-plugins
>>>> +           (lambda* (#:key inputs #:allow-other-keys)
>>>> +             (let ((plugins (assoc-ref inputs
>>>> "audacious-plugins")))
>>>> +               (invoke "tar" "xvf" plugins)
>>>> +               (chdir (string-append "audacious-plugins-"=20
>>>> ,version))
>>>
>>> It's not wrong, and I know this saves (with-directory-excursion)s down
>>> the road, but brr.  :-)
>>>
>>
>> Is it the lack of clarity in later phases that's undesirable?
>
> It=E2=80=99s a littly icky to have phases modify global state (other than=
 the
> files they operate on), because it is no longer enough to look at just=20
> the phase of interest.  If it can be avoided without making things too
> ugly I=E2=80=99d prefer to avoid =E2=80=9Cchdir=E2=80=9D here.

Understood.  Adding a few "with-directory-excursion" calls isn't a bad
addition here.  I've attached a new patch with all three toolkit options
(Qt only, GTK+ 2 only, both) included for testing purposes.


--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment; filename=0001-gnu-Add-audacious.patch
Content-Transfer-Encoding: quoted-printable

From=207b2b638fc518d9362f1715144d4f50fa5761dcb0 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kkebreau@HIDDEN>
Date: Sat, 7 Sep 2019 00:48:16 -0400
Subject: [PATCH] gnu: Add audacious.

* gnu/packages/music.scm (audacious): New variable.
=2D--
 gnu/packages/music.scm | 147 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 146 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a43bccf4f8..0037566519 100644
=2D-- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -141,7 +141,7 @@
   #:use-module (gnu packages xiph)
   #:use-module (gnu packages golang)
   #:use-module (gnu packages lua)
=2D  #:use-module ((srfi srfi-1) #:select (last)))
+  #:use-module ((srfi srfi-1) #:select (alist-delete last)))
=20
 (define-public aria-maestosa
   (package
@@ -203,6 +203,151 @@ and play MIDI files with a few clicks in a user-frien=
dly interface offering
 score, keyboard, guitar, drum and controller views.")
     (license license:gpl3+)))
=20
+(define-public audacious
+  (package
+    (name "audacious")
+    (version "3.10.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://distfiles.audacious-media-playe=
r.org/"
+                                  "audacious-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "14vbkhld5hwh96j8p8hjq9ybvc2m060a1y8crz14i51wpd0fhrl3"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list (string-append "LDFLAGS=3D-Wl,-rpath=3D" %output "/lib"))
+       #:tests? #f                      ; no check target
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'unpack-plugins
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((plugins (assoc-ref inputs "audacious-plugins")))
+               (invoke "tar" "xvf" plugins)
+               #t)))
+         (add-after 'unpack-plugins 'configure-plugins
+           (lambda* (#:key configure-flags outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (with-directory-excursion
+                   (string-append "audacious-plugins-" ,version)
+                 (substitute* "configure"
+                   (("/bin/sh") (which "sh")))
+                 (apply invoke "./configure"
+                        (append configure-flags
+                                ;; audacious-plugins requires audacious to=
 build.
+                                (list (string-append "PKG_CONFIG_PATH=3D"
+                                                     out "/lib/pkgconfig:"
+                                                     (getenv "PKG_CONFIG_P=
ATH"))
+                                      (string-append "--prefix=3D" out))))=
))))
+         (add-after 'configure-plugins 'build-plugins
+           (lambda _
+             (with-directory-excursion
+                 (string-append "audacious-plugins-" ,version)
+               (invoke "make" "-j" (number->string (parallel-job-count))))=
))
+         (add-after 'build-plugins 'install-plugins
+           (lambda _
+             (with-directory-excursion
+                 (string-append "audacious-plugins-" ,version)
+               (invoke "make" "install")))))))
+    (native-inputs
+     `(("audacious-plugins"
+        ,(origin
+           (method url-fetch)
+           (uri (string-append "https://distfiles.audacious-media-player.o=
rg/"
+                               "audacious-plugins-" version ".tar.bz2"))
+           (sha256
+            (base32
+             "0hi61825ayrwc4snwr76f2669k06fii3n8ll1szjk5zr65v1ghzf"))))
+       ("gettext" ,gettext-minimal)
+       ("glib:bin" ,glib "bin")         ; for gdbus-codegen
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("dbus" ,dbus)
+       ("glib" ,glib)
+       ("gtk+" ,gtk+-2)
+       ;; Plugin dependencies
+       ("alsa-lib" ,alsa-lib)
+       ("curl" ,curl)
+       ("faad2" ,faad2)
+       ("ffmpeg" ,ffmpeg)
+       ("flac" ,flac)
+       ("fluidsynth" ,fluidsynth)
+       ("gdk-pixbuf" ,gdk-pixbuf)
+       ("lame" ,lame)
+       ("libbs2b" ,libbs2b)
+       ("libcddb" ,libcddb)
+       ("libcdio-paranoia" ,libcdio-paranoia)
+       ("libcue" ,libcue)
+       ("libmodplug" ,libmodplug)
+       ("libnotify" ,libnotify)
+       ("libogg" ,libogg)
+       ("libsamplerate" ,libsamplerate)
+       ("libsndfile" ,libsndfile)
+       ("libvorbis" ,libvorbis)
+       ("libxcomposite" ,libxcomposite)
+       ("libxml2" ,libxml2)
+       ("libxrender" ,libxrender)
+       ("lirc" ,lirc)
+       ("jack" ,jack-1)
+       ("mesa" ,mesa)
+       ("mpg123" ,mpg123)
+       ("neon" ,neon)
+       ("pulseaudio" ,pulseaudio)
+       ("sdl2" ,sdl2)
+       ("soxr" ,soxr)
+       ("wavpack" ,wavpack)))
+    (home-page "https://audacious-media-player.org")
+    (synopsis "Modular and skinnable audio player")
+    (description
+     "Audacious is an audio player descended from XMMS.  Drag and drop fol=
ders
+and individual song files, search for artists and albums in your entire mu=
sic
+library, or create and edit your own custom playlists.  Listen to CD=E2=80=
=99s or stream
+music from the Internet.  Tweak the sound with the graphical equalizer or
+experiment with LADSPA effects.  Enjoy the modern GTK-themed interface or =
change
+things up with Winamp Classic skins.  Use the plugins included with Audaci=
ous to
+fetch lyrics for your music, to set an alarm in the morning, and more.")
+    ;; According to COPYING, Audacious and its plugins are licensed under =
the
+    ;; BSD 2-clause license and libguess is licensed under the BSD 3-clause
+    ;; license.
+    (license (list license:bsd-2
+                   license:bsd-3
+                   ;; Plugin licenses that aren't BSD 2- or 3-clause.
+                   license:lgpl2.1+
+                   license:gpl2
+                   license:gpl2+
+                   license:gpl3
+                   license:gpl3+
+                   license:expat
+                   license:isc
+                   license:lgpl2.0))))
+
+(define-public audacious-qt
+  (package
+    (inherit audacious)
+    (name "audacious-qt")
+    (arguments
+     (substitute-keyword-arguments (package-arguments audacious)
+       ((#:configure-flags flags)
+        `(cons* "--disable-gtk" "--enable-qt" ,flags))))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qtmultimedia" ,qtmultimedia)
+       ,@(alist-delete "gtk+" (package-inputs audacious))))))
+
+(define-public audacious-both
+  (package
+    (inherit audacious)
+    (name "audacious-both")
+    (arguments
+     (substitute-keyword-arguments (package-arguments audacious)
+       ((#:configure-flags flags)
+        `(cons* "--enable-qt" ,flags))))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qtmultimedia" ,qtmultimedia)
+       ,@(package-inputs audacious)))))
+
 ;; We don't use the latest release because it depends on Qt4.  Instead we
 ;; download the sources from the tip of the "qt5" branch.
 (define-public clementine
=2D-=20
2.23.0


--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAl10SNQACgkQ5qXuPBlG
eg1CLw/7BXdBhlpWzBD3Mxr3l6dcsaIBP/rIyXY/B8X62nlQV1JDta77kQzvXPwE
odLJEYRoyyzBQtoMVo5VlNBN6EeeEwPcTKosc3wPZt0a0uatKNB8WFQsLTqURERU
hN3psBUh2TVucp//PnmF37NACD97WQ1c+1khrQDPaENPywTsIR9ehinQA4Pbrtn8
CJW17F7QSzjsLHV+m6h8eOLkCWG4jFnfc0FV8WrBf3RCKNurk8Xf+sddicK/t3q6
wqKXvP1zBEVrS0QbAku9l5bViMBdoNyim9jFzdqzYXNErBvixVsvig0J20PeIbeQ
lsM9gg9RtjWONctKBlkFUu6MTsN/jmpkYlUPoX62CrXOyrklD7rEYFD733YkVKnd
lmKXPZ++SHX4yitipwvMf5z3/XzRi8K2BzcxWjDneyr6HfK3w1CfjmoadvHjENAz
02l57N65+F1aA3LaSzNMed0fX3V/kisRooeYTpHNNJh58ChLPTUXrWczVVlw4bWh
bfrjkmy8OkeK306TdFgviM+7MjSzoYjZcs0l1um/6CcyCwt6hiTSK8wQ18K4FVam
8oswkpvcE3emI8LPij4aAaYqDNOVRFUeIT9D0XnaYZk6BvphriBVoWeepv3c5OD3
PBR/CXXyLhVDCPuj3BP1W2i2eFzYoA+ZvxiBAdeMQmIGcKwWcJc=
=CItw
-----END PGP SIGNATURE-----
--==-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#37329; Package guix-patches. Full text available.

Message received at 37329 <at> debbugs.gnu.org:


Received: (at 37329) by debbugs.gnu.org; 7 Sep 2019 20:43:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 07 16:43:33 2019
Received: from localhost ([127.0.0.1]:38126 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i6hYT-0000IK-DA
	for submit <at> debbugs.gnu.org; Sat, 07 Sep 2019 16:43:33 -0400
Received: from sender4-of-o52.zoho.com ([136.143.188.52]:21246)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rekado@HIDDEN>) id 1i6hYP-0000I5-VS
 for 37329 <at> debbugs.gnu.org; Sat, 07 Sep 2019 16:43:30 -0400
ARC-Seal: i=1; a=rsa-sha256; t=1567889007; cv=none; d=zoho.com; s=zohoarc; 
 b=lbRPUyrrKTLAVwueRjr3MmfA+395GdpP5ZnM819Ky5c8qEGK1MtkQxgmz5SDcG2kyM+tF730cAoGvIETmKeGejWQSvQ/BF29ECof2T62YyBysQJFoXi5IUL8Z3vE2phJ70PWG3moH048TrDbkSGUxrXxfVTdhVi4nHYt0CUuNIA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc; t=1567889007;
 h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results;
 bh=yk13vTlKR9Qd3FXCj7DWrucuBRr1sFIMX5M462PbX4Q=; 
 b=Gy+mUvnMNfZ2hhJ4dQrfIR6NNHIPOAPAyM7I3n9amaFsE5vQnfnXMeI4d/793jkOGnllSM8gmtCBEiHZ4DbVVEWTf9o+K5SGI9CM4fBUNnQF0YYWvKHdFuxLNnJ1NzpP5aOOP4q9bFRuIq4MCsAwFbVkoKbhGwW247WuK7x3oEs=
ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass  header.i=elephly.net;
 spf=pass  smtp.mailfrom=rekado@HIDDEN;
 dmarc=pass header.from=<rekado@HIDDEN> header.from=<rekado@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1567889007; 
 s=zoho; d=elephly.net; i=rekado@HIDDEN;
 h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding;
 l=1329; bh=yk13vTlKR9Qd3FXCj7DWrucuBRr1sFIMX5M462PbX4Q=;
 b=FjXz4Dl4/ei9bEnmOGGvGtt8LockP8c5Ezr22kGaCoWmw+0D6RI/6wq9a5sskOvk
 0d55tg93WPY6+PJii3PMTZcx23VI+D/KOOfMwxHXmnh7i2cK14LPLq1unrskfUZfSHd
 qgjrwsdXl9XgMelYe++vYHwMqH4SB1LEP1mxjOKc=
Received: from localhost (p54AD4D31.dip0.t-ipconnect.de [84.173.77.49]) by
 mx.zohomail.com with SMTPS id 1567889007155479.52345572567344;
 Sat, 7 Sep 2019 13:43:27 -0700 (PDT)
References: <20190907045755.6578-1-kkebreau@HIDDEN> <87ef0swcrf.fsf@nckx>
 <87imq4xiil.fsf@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.2
From: Ricardo Wurmus <rekado@HIDDEN>
To: Kei Kebreau <kkebreau@HIDDEN>
Subject: Re: [bug#37329] [PATCH] gnu: Add audacious.
In-reply-to: <87imq4xiil.fsf@HIDDEN>
X-URL: https://elephly.net
X-PGP-Key: https://elephly.net/rekado.pubkey
X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
Date: Sat, 07 Sep 2019 22:43:23 +0200
Message-ID: <87y2yzu9as.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 37329
Cc: Tobias Geerinckx-Rice <me@HIDDEN>, 37329 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Kei Kebreau <kkebreau@HIDDEN> writes:

>>> +    (arguments
>>> +     `(#:configure-flags
>>> +       (list "--disable-gtk" "--enable-qt"
>
> In reply to your later email: I used Qt instead of the default GTK+ 2
> because of a personal preference, but apparently it's possible to enable
> both to let users choose what they prefer.

Would this retain references to *both* toolkits?  Wouldn=E2=80=99t this mak=
e the
package much bigger than it otherwise would be?

What=E2=80=99s the smaller variant=E2=80=A6?

>>> +       #:phases
>>> +       (modify-phases %standard-phases
>>> +         (add-after 'install 'unpack-plugins
>>> +           (lambda* (#:key inputs #:allow-other-keys)
>>> +             (let ((plugins (assoc-ref inputs
>>> "audacious-plugins")))
>>> +               (invoke "tar" "xvf" plugins)
>>> +               (chdir (string-append "audacious-plugins-"=20
>>> ,version))
>>
>> It's not wrong, and I know this saves (with-directory-excursion)s down
>> the road, but brr.  :-)
>>
>
> Is it the lack of clarity in later phases that's undesirable?

It=E2=80=99s a littly icky to have phases modify global state (other than t=
he
files they operate on), because it is no longer enough to look at just=20
the phase of interest.  If it can be avoided without making things too
ugly I=E2=80=99d prefer to avoid =E2=80=9Cchdir=E2=80=9D here.

--=20
Ricardo





Information forwarded to guix-patches@HIDDEN:
bug#37329; Package guix-patches. Full text available.

Message received at 37329 <at> debbugs.gnu.org:


Received: (at 37329) by debbugs.gnu.org; 7 Sep 2019 14:56:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 07 10:56:17 2019
Received: from localhost ([127.0.0.1]:37987 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i6c8P-0002p8-BK
	for submit <at> debbugs.gnu.org; Sat, 07 Sep 2019 10:56:17 -0400
Received: from mout02.posteo.de ([185.67.36.66]:56541)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kkebreau@HIDDEN>) id 1i6c8M-0002ot-FO
 for 37329 <at> debbugs.gnu.org; Sat, 07 Sep 2019 10:56:15 -0400
Received: from submission (posteo.de [89.146.220.130]) 
 by mout02.posteo.de (Postfix) with ESMTPS id C0C102400E5
 for <37329 <at> debbugs.gnu.org>; Sat,  7 Sep 2019 16:56:07 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1567868167; bh=eo9e33X29iVbeqKp8+qXAm/pnMc2pYolvDTfUoFViSk=;
 h=From:To:Cc:Subject:Date:From;
 b=olTLcxrXNou8iWHm53i1fbdwVHtlvljZR0fW4bd244OTE9BgcbGDF9D3qvkgCaHg6
 mILBtDCPgJjgE4WSEF9ekf0vMu0Xb8P/PNVFeg1HiQnC3VGDDvKfb6p5aviAW8pqZ4
 iqQfSYOzJH/y2MVBOuRPYVDHj1tZSbAXgZDn1h+SGm0JcIOHH388rIDeYn0tYx/Lfv
 JhV9SWN/8YPn3FuHwyj6hCN1fgIF9Z6JE4gtocPyB4KlPIiV5H0avxWFqPnZ5Xuog5
 vl43YY3Xt1ryyoCih1mCUmvJiKLZVmCzxwOgLJMEhHrSkXyDchVSvDRNxSLQ7z7Lsr
 nIOcruOfq0hRQ==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 46Qctq6CYNz9rxR;
 Sat,  7 Sep 2019 16:56:03 +0200 (CEST)
From: Kei Kebreau <kkebreau@HIDDEN>
To: Tobias Geerinckx-Rice <me@HIDDEN>
Subject: Re: [bug#37329] [PATCH] gnu: Add audacious.
References: <20190907045755.6578-1-kkebreau@HIDDEN> <87ef0swcrf.fsf@nckx>
Date: Sat, 07 Sep 2019 10:56:02 -0400
In-Reply-To: <87ef0swcrf.fsf@nckx> (Tobias Geerinckx-Rice's message of "Sat,
 07 Sep 2019 13:45:40 +0200")
Message-ID: <87imq4xiil.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 37329
Cc: 37329 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Tobias Geerinckx-Rice <me@HIDDEN> writes:

> Kei,
>
> Kei Kebreau =E5=86=99=E9=81=93=EF=BC=9A
>> * gnu/packages/music.scm (audacious): New variable.
>> ---
>>  gnu/packages/music.scm | 102
>> +++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 102 insertions(+)
>>
>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>> index a43bccf4f8..33c53dec35 100644
>> --- a/gnu/packages/music.scm
>> +++ b/gnu/packages/music.scm
>> @@ -203,6 +203,108 @@ and play MIDI files with a few clicks in a
>> user-friendly interface offering
>>  score, keyboard, guitar, drum and controller views.")
>>      (license license:gpl3+)))
>>  +(define-public audacious
>> +  (package
>> +    (name "audacious")
>> +    (version "3.10.1")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append
>> "https://distfiles.audacious-media-player.org/"
>> +                                  "audacious-" version ".tar.bz2"))
>> +              (sha256
>> +               (base32
>> + "14vbkhld5hwh96j8p8hjq9ybvc2m060a1y8crz14i51wpd0fhrl3"))))
>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:configure-flags
>> +       (list "--disable-gtk" "--enable-qt"

In reply to your later email: I used Qt instead of the default GTK+ 2
because of a personal preference, but apparently it's possible to enable
both to let users choose what they prefer.

>> +             ;; Add the output lib directory to the RUNPATH.
>> +             (string-append "LDFLAGS=3D-Wl,-rpath=3D" %output "/lib"))
>
> This comment just repeats the code, so it's not needed.
>
>> +       #:tests? #f ; no check target
>
> Could you run C-M-q (or etc/indent-code.el) on the whole definition?
> That will allow later editors to do the same without changing
> unrelated lines.
>

Done for both!

>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'install 'unpack-plugins
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             (let ((plugins (assoc-ref inputs
>> "audacious-plugins")))
>> +               (invoke "tar" "xvf" plugins)
>> +               (chdir (string-append "audacious-plugins-"=20
>> ,version))
>
> It's not wrong, and I know this saves (with-directory-excursion)s down
> the road, but brr.  :-)
>

Is it the lack of clarity in later phases that's undesirable?

>> +               #t)))
>> +         (add-after 'unpack-plugins 'configure-plugins
>> +           (lambda* (#:key configure-flags outputs
>> #:allow-other-keys)
>> +             (let ((out (assoc-ref outputs "out")))
>> +               (substitute* "configure"
>> +                 (("/bin/sh") (which "sh")))
>> +               (apply invoke "./configure"
>> +                      (append configure-flags
>> +                              ;; audacious-plugins requires
>> audacious to build.
>> +                              (list (string-append
>> "PKG_CONFIG_PATH=3D"
>> +                                                   out
>> "/lib/pkgconfig:"
>> +                                                   (getenv
>> "PKG_CONFIG_PATH"))
>> +                                    (string-append "--prefix=3D"
>> out)))))))
>> +         (add-after 'configure-plugins 'build-plugins
>> +           (lambda _
>> +             (invoke "make" "-j" (number->string
>> (parallel-job-count)))))
>> +         (add-after 'build-plugins 'install-plugins
>> +           (lambda _
>> +             (invoke "make" "install"))))))
>> +    (native-inputs
>> +     `(("audacious-plugins"
>> +        ,(origin
>> +           (method url-fetch)
>> +           (uri (string-append
>> "https://distfiles.audacious-media-playerorg/"
>                                                                     ^^^^^=
^^^^
> Typo!
>

Nice catch, thanks!

>> +                               "audacious-plugins-" version
>> ".tar.bz2"))
>> +           (sha256
>> +            (base32
>> + "0hi61825ayrwc4snwr76f2669k06fii3n8ll1szjk5zr65v1ghzf"))))
>
> I don't mind bundling these like this (Audacious's a leaf package and
> =E2=80=94 subjectively =E2=80=94 media things are allowed/expected to be =
a bit
> bloaty), but it may prove controversial :-)
>
> Would it not be worth supporting a plug-in search path?  Are there,
> for example, well-supported Audacious plug-ins that aren't part of
> this collection?
>
>  $ guix size audacious-with-plugins # although I'd prefer 2 packages
>  =E2=80=A6
>  total: 1649.2 MiB
>
>  $ guix size audacious # no plugins or plugin inputs
>  =E2=80=A6
>  total: 1333.9 MiB
>
> Have you considered a separate =E2=80=98audacious-plugins=E2=80=99 packag=
e that could
> use that mechanism?  Why [not]?
>

Audacious fails to run without output plugins (e.g. Pulseaudio, JACK,
etc.), immediately asking the user whether audacious-plugins is
installed.  A separate audacious-plugins package would require audacious
as a dependency, and since such basic plugins are needed to run
audacious, I'm not sure how to split the packages in a way that would
avoid a dependency loop.

>> +       ("gettext" ,gettext-minimal)
>> +       ("glib:bin" ,glib "bin") ; for gdbus-codegen
>> +       ("pkg-config" ,pkg-config)))
>> +    (inputs
>> +     `(("dbus" ,dbus)
>> +       ("glib" ,glib)
>> +       ("qtbase" ,qtbase)
>> +       ;; Plugin dependencies
>> +       ("alsa-lib" ,alsa-lib)
>> +       ("curl" ,curl)
>> +       ("ffmpeg" ,ffmpeg)
>> +       ("flac" ,flac)
>> +       ("fluidsynth" ,fluidsynth)
>> +       ("gdk-pixbuf" ,gdk-pixbuf)
>> +       ("libbs2b" ,libbs2b)
>> +       ("libcddb" ,libcddb)
>> +       ("libcdio-paranoia" ,libcdio-paranoia)
>> +       ("libcue" ,libcue)
>> +       ("libmodplug" ,libmodplug)
>> +       ("libnotify" ,libnotify)
>> +       ("libogg" ,libogg)
>> +       ("libsamplerate" ,libsamplerate)
>> +       ("libsndfile" ,libsndfile)
>> +       ("libvorbis" ,libvorbis)
>> +       ("libxml2" ,libxml2)
>> +       ("lirc" ,lirc)
>> +       ("jack" ,jack-1)
>> +       ("mpg123" ,mpg123)
>> +       ("neon" ,neon)
>> +       ("pulseaudio" ,pulseaudio)
>> +       ("qtmultimedia" ,qtmultimedia)
>> +       ("soxr" ,soxr)
>> +       ("wavpack" ,wavpack)))
>> +    (home-page "https://audacious-media-player.org")
>> +    (synopsis "Audio player based on XMMS")
>
> Hmm.  To me, =E2=80=98Foo copied a lot of files from bar once=E2=80=99 is=
 never a
> useful answer to =E2=80=98What is foo?=E2=80=99.
>
> All =E2=80=98XMMS=E2=80=99 means to me is =E2=80=98that ugly audio player=
 I installed and then
> immediately removed in the nineties=E2=80=99.  Now, that may be all I nee=
d to
> know about Audacious, I don't know :o)
>
> I hope it's not.  Is there something in particular that distinguishes
> Audacious from most other players that we could mention instead?
>

How about: "Modular and skinnable audio player"?

>> +    (description
>> +     "Audacious is an audio player descended from XMMS.  Drag and
>> drop folders
>> +and individual song files, search for artists and albums in your
>> entire music
>> +library, or create and edit your own custom playlists.  Listen to
>> CD=E2=80=99s or stream
>> +music from the Internet.  Tweak the sound with the graphical
>> equalizer or
>> +experiment with LADSPA effects.  Enjoy the modern GTK-themed
>> interface or change
>> +things up with Winamp Classic skins.  Use the plugins included with
>> Audacious to
>> +fetch lyrics for your music, to set an alarm in the morning, and
>> more.")
>> +    ;; According to COPYING, Audacious and its plugins are licensed
>> under the
>> +    ;; BSD 2-clause license and libguess is licensed under the BSD
>> 3-clause
>> +    ;; license.
>> +    (license (list license:bsd-2
>> +                   license:bsd-3))))
>
> From COPYING:
>
>  =E2=80=9CPlease note that many of the plugins distributed with Audacious=
 are
> under
>  different licenses.=E2=80=9D
>
> And indeed, I see quite a bit of GPL and some ISC code in there.
>

I'll root around for those extra licenses!

> Thanks!
>
> T G-R

Thanks for reviewing!

Kei

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAl1zxQIACgkQ5qXuPBlG
eg1Fag/9EQ7ZHeVngVcDlWu7I6kK5qlxqFQ/Q/SyOhoqYixJTf10JoIcAVwH9hUn
4cHJggGe2rUwGgMZGnh/0CQjTeXL8Gx09K+rz6pIedFY5PIeYOVVMBZcHlGLaBcf
0GZF/7mRT7O+TBvIuxp3NeaiBinQaC0tXPXKirKjJCBhReDRlhS3e2qjsAXonFNs
XD2WFoBupJM/6eHuMe8jqKk3sLzjBgQsF0ET8R/RoajMHr1aqUaxjUyjJ+nAhF8k
ObXw4tGpB51cOnCFemtNA1/Wuo54YLmysmXgoerT8BQxUeCQibl48Zmz58V59Huf
VXZUI0XFzLxILNgZFknSiA2YFITn8Lwp6/izDcAynji5dbSPeAYUNdcDZ5AcGGMq
LEmbNEOYM5Txj1idvH5BkMzlOLPcEPrXwW+M7EcpuZ6x8C80G6Uq+l1yhtzA1PjV
ngiSktqL9U654P+5yzZ9JWP0fdrnHdc+mro4Y3x8NaIcmVtBsxi1ibDJK07SJV7T
bhPFdkEqPM7USMl8ThDgukXimhYsEp3A6h7OZpS+SUjw88JFge3ZeOoRh88GtSNP
GKAf913EsNbJ4RJ8IFp7ZsEC1bSakch9VBADn2cxR5793SOYQjgr8W9wyCd6dXBh
y2TC1hmCIMe/eUawXJonTGdXwykcWx04wpFodoRXQL/jgt8q5wM=
=Fo8P
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#37329; Package guix-patches. Full text available.

Message received at 37329 <at> debbugs.gnu.org:


Received: (at 37329) by debbugs.gnu.org; 7 Sep 2019 12:04:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 07 08:04:26 2019
Received: from localhost ([127.0.0.1]:37594 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i6ZS5-0007Ea-Vy
	for submit <at> debbugs.gnu.org; Sat, 07 Sep 2019 08:04:26 -0400
Received: from tobias.gr ([80.241.217.52]:43870)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1i6ZS2-0007EQ-SL
 for 37329 <at> debbugs.gnu.org; Sat, 07 Sep 2019 08:04:24 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id e72dfcd9;
 Sat, 7 Sep 2019 12:04:20 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=pHNLyGhBEMX7sUPS73pfnT
 hXHDwAgwjjA9qPn3d8k2k=; b=R2pfgTvM56ldyG2a1vJqPuOauf9C+c6hc3y4Gp
 ZsCFhP7f0ZmOms2U2RDEsaJAD3z1JzfxMqahXF3lwpQ17PSS9RFTVI0wj0tX+Mue
 moOwcuWOiY3JeV/5IejIu6nERR7+spLmVAy615m11FpBXDdgsL21vTcJBLGUHlem
 5LW/8E1OkU7XJdrWWqNG6e+rfNWY2HAn++iegWUkoy9WRPmu9iIh3zIxNWaUOK+L
 pGQgDKL++NY8az0fZ1XX1eLzshux9E6LjnPw1mFCr73H+qbZW+JbOxI1mR+JwVqv
 oWbFnYxzG6/FtD32TJGna1SpZ0o2eGKUur/oJZVEnGjvS8Yg==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id a4204d8e
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Sat, 7 Sep 2019 12:04:20 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: 37329 <at> debbugs.gnu.org, kkebreau@HIDDEN
Subject: Re: [bug#37329] [PATCH] gnu: Add audacious.
References: <20190907045755.6578-1-kkebreau@HIDDEN> <87ef0swcrf.fsf@nckx>
In-reply-to: <87ef0swcrf.fsf@nckx>
Date: Sat, 07 Sep 2019 14:04:19 +0200
Message-ID: <87d0gcwbwc.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 37329
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Kei,

Tobias Geerinckx-Rice via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A
>> +    (arguments
>> +     `(#:configure-flags
>> +       (list "--disable-gtk" "--enable-qt"
>> +             ;; Add the output lib directory to the RUNPATH.
>> +             (string-append "LDFLAGS=3D-Wl,-rpath=3D" %output=20
>> "/lib"))
>
> This comment just repeats the code, so it's not needed.

I forgot to ask: why Qt over GTK?  That would probably make an=20
interesting comment.

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXXOcwwAKCRANsP+IT1Vt
eUjYAQDMgZM3SsMckqJ0xMkF9YoRLVKGC5BeTlw9FkPrQjncFQEAzFk/sWS5AUbR
JzZlqgB+PkRDwF3vLl/EDTtbLmlMpQI=
=yPN2
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#37329; Package guix-patches. Full text available.

Message received at 37329 <at> debbugs.gnu.org:


Received: (at 37329) by debbugs.gnu.org; 7 Sep 2019 11:45:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 07 07:45:49 2019
Received: from localhost ([127.0.0.1]:37579 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i6ZA5-0006mp-8T
	for submit <at> debbugs.gnu.org; Sat, 07 Sep 2019 07:45:49 -0400
Received: from tobias.gr ([80.241.217.52]:43454)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1i6Z9z-0006mc-7o
 for 37329 <at> debbugs.gnu.org; Sat, 07 Sep 2019 07:45:47 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id 9e175f8c;
 Sat, 7 Sep 2019 11:45:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=mKmbOmvTuzzE92N+Yj3WAe
 XjeJOLOvWJvDmvUyyplnU=; b=APIUEpi9zq/0mb8fvTR8xUJMCz47Bqm8Nxr5Xi
 XX0WGTsGdGB7hajGMglu+AqlmuG0u3jQP9/meGd2sQ0G9FaUEGuNahEeoeZIMKoM
 drVYuLnEhqX+qg2vSPZqYYRJnNPpbkJYG0UvQv82nM+xTWmXRdzy+/1bUND5J1P3
 i9V7MunPNXoT5BiSdH52J6WZPZtTeHs3ikDPkx8YDaS71JL2nAlBXY0hxSf+Szvu
 aBx00++K2Xp+dweCx2kQfOqy3u/oZFtyvxnJd8raYBQw8ad3s5s488qsSS4t611s
 dImz1bPVE5BR23zM9b+KckRoFoI+0W2ESUaOC/kz9ZqdD1dQ==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 59c640a9
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Sat, 7 Sep 2019 11:45:41 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: guix-patches@HIDDEN
Subject: Re: [bug#37329] [PATCH] gnu: Add audacious.
References: <20190907045755.6578-1-kkebreau@HIDDEN>
In-reply-to: <20190907045755.6578-1-kkebreau@HIDDEN>
Date: Sat, 07 Sep 2019 13:45:40 +0200
Message-ID: <87ef0swcrf.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 37329
Cc: Kei Kebreau <kkebreau@HIDDEN>, 37329 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Kei,

Kei Kebreau =E5=86=99=E9=81=93=EF=BC=9A
> * gnu/packages/music.scm (audacious): New variable.
> ---
>  gnu/packages/music.scm | 102=20
>  +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 102 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index a43bccf4f8..33c53dec35 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -203,6 +203,108 @@ and play MIDI files with a few clicks in a=20
> user-friendly interface offering
>  score, keyboard, guitar, drum and controller views.")
>      (license license:gpl3+)))
>=20=20
> +(define-public audacious
> +  (package
> +    (name "audacious")
> +    (version "3.10.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append=20
> "https://distfiles.audacious-media-player.org/"
> +                                  "audacious-" version=20
> ".tar.bz2"))
> +              (sha256
> +               (base32
> +=20
> "14vbkhld5hwh96j8p8hjq9ybvc2m060a1y8crz14i51wpd0fhrl3"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       (list "--disable-gtk" "--enable-qt"
> +             ;; Add the output lib directory to the RUNPATH.
> +             (string-append "LDFLAGS=3D-Wl,-rpath=3D" %output=20
> "/lib"))

This comment just repeats the code, so it's not needed.

> +       #:tests? #f ; no check target

Could you run C-M-q (or etc/indent-code.el) on the whole=20
definition?  That will allow later editors to do the same without=20
changing unrelated lines.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'unpack-plugins
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let ((plugins (assoc-ref inputs=20
> "audacious-plugins")))
> +               (invoke "tar" "xvf" plugins)
> +               (chdir (string-append "audacious-plugins-"=20
> ,version))

It's not wrong, and I know this saves (with-directory-excursion)s=20
down the road, but brr.  :-)

> +               #t)))
> +         (add-after 'unpack-plugins 'configure-plugins
> +           (lambda* (#:key configure-flags outputs=20
> #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (substitute* "configure"
> +                 (("/bin/sh") (which "sh")))
> +               (apply invoke "./configure"
> +                      (append configure-flags
> +                              ;; audacious-plugins requires=20
> audacious to build.
> +                              (list (string-append=20
> "PKG_CONFIG_PATH=3D"
> +                                                   out=20
> "/lib/pkgconfig:"
> +                                                   (getenv=20
> "PKG_CONFIG_PATH"))
> +                                    (string-append "--prefix=3D"=20
> out)))))))
> +         (add-after 'configure-plugins 'build-plugins
> +           (lambda _
> +             (invoke "make" "-j" (number->string=20
> (parallel-job-count)))))
> +         (add-after 'build-plugins 'install-plugins
> +           (lambda _
> +             (invoke "make" "install"))))))
> +    (native-inputs
> +     `(("audacious-plugins"
> +        ,(origin
> +           (method url-fetch)
> +           (uri (string-append=20
> "https://distfiles.audacious-media-playerorg/"
                                                                     ^^^^^^=
^^^
Typo!

> +                               "audacious-plugins-" version=20
> ".tar.bz2"))
> +           (sha256
> +            (base32
> +=20
> "0hi61825ayrwc4snwr76f2669k06fii3n8ll1szjk5zr65v1ghzf"))))

I don't mind bundling these like this (Audacious's a leaf package=20
and =E2=80=94 subjectively =E2=80=94 media things are allowed/expected to b=
e a bit=20
bloaty), but it may prove controversial :-)

Would it not be worth supporting a plug-in search path?  Are=20
there, for example, well-supported Audacious plug-ins that aren't=20
part of this collection?

  $ guix size audacious-with-plugins # although I'd prefer 2=20
  packages
  =E2=80=A6
  total: 1649.2 MiB

  $ guix size audacious # no plugins or plugin inputs
  =E2=80=A6
  total: 1333.9 MiB

Have you considered a separate =E2=80=98audacious-plugins=E2=80=99 package =
that=20
could use that mechanism?  Why [not]?

> +       ("gettext" ,gettext-minimal)
> +       ("glib:bin" ,glib "bin") ; for gdbus-codegen
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("dbus" ,dbus)
> +       ("glib" ,glib)
> +       ("qtbase" ,qtbase)
> +       ;; Plugin dependencies
> +       ("alsa-lib" ,alsa-lib)
> +       ("curl" ,curl)
> +       ("ffmpeg" ,ffmpeg)
> +       ("flac" ,flac)
> +       ("fluidsynth" ,fluidsynth)
> +       ("gdk-pixbuf" ,gdk-pixbuf)
> +       ("libbs2b" ,libbs2b)
> +       ("libcddb" ,libcddb)
> +       ("libcdio-paranoia" ,libcdio-paranoia)
> +       ("libcue" ,libcue)
> +       ("libmodplug" ,libmodplug)
> +       ("libnotify" ,libnotify)
> +       ("libogg" ,libogg)
> +       ("libsamplerate" ,libsamplerate)
> +       ("libsndfile" ,libsndfile)
> +       ("libvorbis" ,libvorbis)
> +       ("libxml2" ,libxml2)
> +       ("lirc" ,lirc)
> +       ("jack" ,jack-1)
> +       ("mpg123" ,mpg123)
> +       ("neon" ,neon)
> +       ("pulseaudio" ,pulseaudio)
> +       ("qtmultimedia" ,qtmultimedia)
> +       ("soxr" ,soxr)
> +       ("wavpack" ,wavpack)))
> +    (home-page "https://audacious-media-player.org")
> +    (synopsis "Audio player based on XMMS")

Hmm.  To me, =E2=80=98Foo copied a lot of files from bar once=E2=80=99 is n=
ever=20
a useful answer to =E2=80=98What is foo?=E2=80=99.

All =E2=80=98XMMS=E2=80=99 means to me is =E2=80=98that ugly audio player I=
 installed=20
and then immediately removed in the nineties=E2=80=99.  Now, that may be=20
all I need to know about Audacious, I don't know :o)

I hope it's not.  Is there something in particular that=20
distinguishes Audacious from most other players that we could=20
mention instead?

> +    (description
> +     "Audacious is an audio player descended from XMMS.  Drag=20
> and drop folders
> +and individual song files, search for artists and albums in=20
> your entire music
> +library, or create and edit your own custom playlists.  Listen=20
> to CD=E2=80=99s or stream
> +music from the Internet.  Tweak the sound with the graphical=20
> equalizer or
> +experiment with LADSPA effects.  Enjoy the modern GTK-themed=20
> interface or change
> +things up with Winamp Classic skins.  Use the plugins included=20
> with Audacious to
> +fetch lyrics for your music, to set an alarm in the morning,=20
> and more.")
> +    ;; According to COPYING, Audacious and its plugins are=20
> licensed under the
> +    ;; BSD 2-clause license and libguess is licensed under the=20
> BSD 3-clause
> +    ;; license.
> +    (license (list license:bsd-2
> +                   license:bsd-3))))

From=20COPYING:

  =E2=80=9CPlease note that many of the plugins distributed with=20
  Audacious are under
  different licenses.=E2=80=9D

And indeed, I see quite a bit of GPL and some ISC code in there.

Thanks!

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXXOYZAAKCRANsP+IT1Vt
eRc1AQDAzQJpRojV1SWKz5Iy9MNyCUxUcmELO0v0eMfumcgtuAD/S8FU56+WGj8z
j5kf2gxIVwDfiOuYkC7YT49/KtD+TQ0=
=Znuo
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#37329; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 7 Sep 2019 11:45:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 07 07:45:54 2019
Received: from localhost ([127.0.0.1]:37583 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i6ZA9-0006n8-Qf
	for submit <at> debbugs.gnu.org; Sat, 07 Sep 2019 07:45:54 -0400
Received: from lists.gnu.org ([209.51.188.17]:40703)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1i6ZA8-0006n0-UR
 for submit <at> debbugs.gnu.org; Sat, 07 Sep 2019 07:45:53 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60651)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <me@HIDDEN>) id 1i6ZA7-0004DT-AJ
 for guix-patches@HIDDEN; Sat, 07 Sep 2019 07:45:52 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED
 autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <me@HIDDEN>) id 1i6ZA4-00073q-BL
 for guix-patches@HIDDEN; Sat, 07 Sep 2019 07:45:49 -0400
Received: from tobias.gr ([2001:470:7405::1]:53336)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <me@HIDDEN>) id 1i6ZA4-00071F-0l
 for guix-patches@HIDDEN; Sat, 07 Sep 2019 07:45:48 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id 9e175f8c;
 Sat, 7 Sep 2019 11:45:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=mKmbOmvTuzzE92N+Yj3WAe
 XjeJOLOvWJvDmvUyyplnU=; b=APIUEpi9zq/0mb8fvTR8xUJMCz47Bqm8Nxr5Xi
 XX0WGTsGdGB7hajGMglu+AqlmuG0u3jQP9/meGd2sQ0G9FaUEGuNahEeoeZIMKoM
 drVYuLnEhqX+qg2vSPZqYYRJnNPpbkJYG0UvQv82nM+xTWmXRdzy+/1bUND5J1P3
 i9V7MunPNXoT5BiSdH52J6WZPZtTeHs3ikDPkx8YDaS71JL2nAlBXY0hxSf+Szvu
 aBx00++K2Xp+dweCx2kQfOqy3u/oZFtyvxnJd8raYBQw8ad3s5s488qsSS4t611s
 dImz1bPVE5BR23zM9b+KckRoFoI+0W2ESUaOC/kz9ZqdD1dQ==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 59c640a9
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Sat, 7 Sep 2019 11:45:41 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: guix-patches@HIDDEN
Subject: Re: [bug#37329] [PATCH] gnu: Add audacious.
References: <20190907045755.6578-1-kkebreau@HIDDEN>
In-reply-to: <20190907045755.6578-1-kkebreau@HIDDEN>
Date: Sat, 07 Sep 2019 13:45:40 +0200
Message-ID: <87ef0swcrf.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-Received-From: 2001:470:7405::1
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: Kei Kebreau <kkebreau@HIDDEN>, 37329 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Kei,

Kei Kebreau =E5=86=99=E9=81=93=EF=BC=9A
> * gnu/packages/music.scm (audacious): New variable.
> ---
>  gnu/packages/music.scm | 102=20
>  +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 102 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index a43bccf4f8..33c53dec35 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -203,6 +203,108 @@ and play MIDI files with a few clicks in a=20
> user-friendly interface offering
>  score, keyboard, guitar, drum and controller views.")
>      (license license:gpl3+)))
>=20=20
> +(define-public audacious
> +  (package
> +    (name "audacious")
> +    (version "3.10.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append=20
> "https://distfiles.audacious-media-player.org/"
> +                                  "audacious-" version=20
> ".tar.bz2"))
> +              (sha256
> +               (base32
> +=20
> "14vbkhld5hwh96j8p8hjq9ybvc2m060a1y8crz14i51wpd0fhrl3"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       (list "--disable-gtk" "--enable-qt"
> +             ;; Add the output lib directory to the RUNPATH.
> +             (string-append "LDFLAGS=3D-Wl,-rpath=3D" %output=20
> "/lib"))

This comment just repeats the code, so it's not needed.

> +       #:tests? #f ; no check target

Could you run C-M-q (or etc/indent-code.el) on the whole=20
definition?  That will allow later editors to do the same without=20
changing unrelated lines.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'unpack-plugins
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let ((plugins (assoc-ref inputs=20
> "audacious-plugins")))
> +               (invoke "tar" "xvf" plugins)
> +               (chdir (string-append "audacious-plugins-"=20
> ,version))

It's not wrong, and I know this saves (with-directory-excursion)s=20
down the road, but brr.  :-)

> +               #t)))
> +         (add-after 'unpack-plugins 'configure-plugins
> +           (lambda* (#:key configure-flags outputs=20
> #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (substitute* "configure"
> +                 (("/bin/sh") (which "sh")))
> +               (apply invoke "./configure"
> +                      (append configure-flags
> +                              ;; audacious-plugins requires=20
> audacious to build.
> +                              (list (string-append=20
> "PKG_CONFIG_PATH=3D"
> +                                                   out=20
> "/lib/pkgconfig:"
> +                                                   (getenv=20
> "PKG_CONFIG_PATH"))
> +                                    (string-append "--prefix=3D"=20
> out)))))))
> +         (add-after 'configure-plugins 'build-plugins
> +           (lambda _
> +             (invoke "make" "-j" (number->string=20
> (parallel-job-count)))))
> +         (add-after 'build-plugins 'install-plugins
> +           (lambda _
> +             (invoke "make" "install"))))))
> +    (native-inputs
> +     `(("audacious-plugins"
> +        ,(origin
> +           (method url-fetch)
> +           (uri (string-append=20
> "https://distfiles.audacious-media-playerorg/"
                                                                     ^^^^^^=
^^^
Typo!

> +                               "audacious-plugins-" version=20
> ".tar.bz2"))
> +           (sha256
> +            (base32
> +=20
> "0hi61825ayrwc4snwr76f2669k06fii3n8ll1szjk5zr65v1ghzf"))))

I don't mind bundling these like this (Audacious's a leaf package=20
and =E2=80=94 subjectively =E2=80=94 media things are allowed/expected to b=
e a bit=20
bloaty), but it may prove controversial :-)

Would it not be worth supporting a plug-in search path?  Are=20
there, for example, well-supported Audacious plug-ins that aren't=20
part of this collection?

  $ guix size audacious-with-plugins # although I'd prefer 2=20
  packages
  =E2=80=A6
  total: 1649.2 MiB

  $ guix size audacious # no plugins or plugin inputs
  =E2=80=A6
  total: 1333.9 MiB

Have you considered a separate =E2=80=98audacious-plugins=E2=80=99 package =
that=20
could use that mechanism?  Why [not]?

> +       ("gettext" ,gettext-minimal)
> +       ("glib:bin" ,glib "bin") ; for gdbus-codegen
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("dbus" ,dbus)
> +       ("glib" ,glib)
> +       ("qtbase" ,qtbase)
> +       ;; Plugin dependencies
> +       ("alsa-lib" ,alsa-lib)
> +       ("curl" ,curl)
> +       ("ffmpeg" ,ffmpeg)
> +       ("flac" ,flac)
> +       ("fluidsynth" ,fluidsynth)
> +       ("gdk-pixbuf" ,gdk-pixbuf)
> +       ("libbs2b" ,libbs2b)
> +       ("libcddb" ,libcddb)
> +       ("libcdio-paranoia" ,libcdio-paranoia)
> +       ("libcue" ,libcue)
> +       ("libmodplug" ,libmodplug)
> +       ("libnotify" ,libnotify)
> +       ("libogg" ,libogg)
> +       ("libsamplerate" ,libsamplerate)
> +       ("libsndfile" ,libsndfile)
> +       ("libvorbis" ,libvorbis)
> +       ("libxml2" ,libxml2)
> +       ("lirc" ,lirc)
> +       ("jack" ,jack-1)
> +       ("mpg123" ,mpg123)
> +       ("neon" ,neon)
> +       ("pulseaudio" ,pulseaudio)
> +       ("qtmultimedia" ,qtmultimedia)
> +       ("soxr" ,soxr)
> +       ("wavpack" ,wavpack)))
> +    (home-page "https://audacious-media-player.org")
> +    (synopsis "Audio player based on XMMS")

Hmm.  To me, =E2=80=98Foo copied a lot of files from bar once=E2=80=99 is n=
ever=20
a useful answer to =E2=80=98What is foo?=E2=80=99.

All =E2=80=98XMMS=E2=80=99 means to me is =E2=80=98that ugly audio player I=
 installed=20
and then immediately removed in the nineties=E2=80=99.  Now, that may be=20
all I need to know about Audacious, I don't know :o)

I hope it's not.  Is there something in particular that=20
distinguishes Audacious from most other players that we could=20
mention instead?

> +    (description
> +     "Audacious is an audio player descended from XMMS.  Drag=20
> and drop folders
> +and individual song files, search for artists and albums in=20
> your entire music
> +library, or create and edit your own custom playlists.  Listen=20
> to CD=E2=80=99s or stream
> +music from the Internet.  Tweak the sound with the graphical=20
> equalizer or
> +experiment with LADSPA effects.  Enjoy the modern GTK-themed=20
> interface or change
> +things up with Winamp Classic skins.  Use the plugins included=20
> with Audacious to
> +fetch lyrics for your music, to set an alarm in the morning,=20
> and more.")
> +    ;; According to COPYING, Audacious and its plugins are=20
> licensed under the
> +    ;; BSD 2-clause license and libguess is licensed under the=20
> BSD 3-clause
> +    ;; license.
> +    (license (list license:bsd-2
> +                   license:bsd-3))))

From=20COPYING:

  =E2=80=9CPlease note that many of the plugins distributed with=20
  Audacious are under
  different licenses.=E2=80=9D

And indeed, I see quite a bit of GPL and some ISC code in there.

Thanks!

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXXOYZAAKCRANsP+IT1Vt
eRc1AQDAzQJpRojV1SWKz5Iy9MNyCUxUcmELO0v0eMfumcgtuAD/S8FU56+WGj8z
j5kf2gxIVwDfiOuYkC7YT49/KtD+TQ0=
=Znuo
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#37329; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 7 Sep 2019 04:58:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 07 00:58:17 2019
Received: from localhost ([127.0.0.1]:37500 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i6Sng-00033h-QO
	for submit <at> debbugs.gnu.org; Sat, 07 Sep 2019 00:58:17 -0400
Received: from lists.gnu.org ([209.51.188.17]:60946)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kkebreau@HIDDEN>) id 1i6Snf-00033Z-4m
 for submit <at> debbugs.gnu.org; Sat, 07 Sep 2019 00:58:15 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:54514)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <kkebreau@HIDDEN>) id 1i6Snd-0003u7-DT
 for guix-patches@HIDDEN; Sat, 07 Sep 2019 00:58:14 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED,
 URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <kkebreau@HIDDEN>) id 1i6Snb-0004Ko-4P
 for guix-patches@HIDDEN; Sat, 07 Sep 2019 00:58:13 -0400
Received: from mout02.posteo.de ([185.67.36.66]:33025)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <kkebreau@HIDDEN>) id 1i6SnY-0004JF-1R
 for guix-patches@HIDDEN; Sat, 07 Sep 2019 00:58:09 -0400
Received: from submission (posteo.de [89.146.220.130]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 055292400E6
 for <guix-patches@HIDDEN>; Sat,  7 Sep 2019 06:58:03 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1567832284; bh=P4uG+ptVIJkzCD0YzQY1lQJOi5e9XfJheo8g9unWzu4=;
 h=From:To:Cc:Subject:Date:From;
 b=k5NyAyRe2MY4xOTuobzmB1B66msPjmKDtf+WI5T2zPN5gRZAoCNeYvFdXkBo7WAbV
 nqDKGoo+qvjYWApp4bYBFNBO7F78FWdL+WGbWCBkKp1kZmpB899gM0v9k5NAvXxrmt
 KrTIZZd6cNoMGLNZ/hv37J6jwJR0nCdQ5Z6PfEGVdgvYgNEcxYM+nGTrHJrxcX2uYg
 Vu4NSatCYkTAPYrwlShoA+vzv4y5DsYMvRtY+tcLYjuLwSc3+UfWdCIHNQzayfDaYP
 rXF+cVUIS4HUTI2tJiuHSPwEp1npL58RZjsQWgbEx8EdUqWyv5pW+aa2Xjqv5m7QG2
 lMXXDj7o9WLDQ==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 46QMcp1QbWz9rxL;
 Sat,  7 Sep 2019 06:58:01 +0200 (CEST)
From: Kei Kebreau <kkebreau@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add audacious.
Date: Sat,  7 Sep 2019 00:57:55 -0400
Message-Id: <20190907045755.6578-1-kkebreau@HIDDEN>
X-Mailer: git-send-email 2.23.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 185.67.36.66
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Kei Kebreau <kkebreau@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

* gnu/packages/music.scm (audacious): New variable.
---
 gnu/packages/music.scm | 102 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 102 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a43bccf4f8..33c53dec35 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -203,6 +203,108 @@ and play MIDI files with a few clicks in a user-fri=
endly interface offering
 score, keyboard, guitar, drum and controller views.")
     (license license:gpl3+)))
=20
+(define-public audacious
+  (package
+    (name "audacious")
+    (version "3.10.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://distfiles.audacious-media-pla=
yer.org/"
+                                  "audacious-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "14vbkhld5hwh96j8p8hjq9ybvc2m060a1y8crz14i51wpd0fhrl3"))=
))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--disable-gtk" "--enable-qt"
+             ;; Add the output lib directory to the RUNPATH.
+             (string-append "LDFLAGS=3D-Wl,-rpath=3D" %output "/lib"))
+       #:tests? #f ; no check target
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'unpack-plugins
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((plugins (assoc-ref inputs "audacious-plugins")))
+               (invoke "tar" "xvf" plugins)
+               (chdir (string-append "audacious-plugins-" ,version))
+               #t)))
+         (add-after 'unpack-plugins 'configure-plugins
+           (lambda* (#:key configure-flags outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* "configure"
+                 (("/bin/sh") (which "sh")))
+               (apply invoke "./configure"
+                      (append configure-flags
+                              ;; audacious-plugins requires audacious to=
 build.
+                              (list (string-append "PKG_CONFIG_PATH=3D"
+                                                   out "/lib/pkgconfig:"
+                                                   (getenv "PKG_CONFIG_P=
ATH"))
+                                    (string-append "--prefix=3D" out))))=
)))
+         (add-after 'configure-plugins 'build-plugins
+           (lambda _
+             (invoke "make" "-j" (number->string (parallel-job-count))))=
)
+         (add-after 'build-plugins 'install-plugins
+           (lambda _
+             (invoke "make" "install"))))))
+    (native-inputs
+     `(("audacious-plugins"
+        ,(origin
+           (method url-fetch)
+           (uri (string-append "https://distfiles.audacious-media-player=
.org/"
+                               "audacious-plugins-" version ".tar.bz2"))
+           (sha256
+            (base32
+             "0hi61825ayrwc4snwr76f2669k06fii3n8ll1szjk5zr65v1ghzf"))))
+       ("gettext" ,gettext-minimal)
+       ("glib:bin" ,glib "bin") ; for gdbus-codegen
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("dbus" ,dbus)
+       ("glib" ,glib)
+       ("qtbase" ,qtbase)
+       ;; Plugin dependencies
+       ("alsa-lib" ,alsa-lib)
+       ("curl" ,curl)
+       ("ffmpeg" ,ffmpeg)
+       ("flac" ,flac)
+       ("fluidsynth" ,fluidsynth)
+       ("gdk-pixbuf" ,gdk-pixbuf)
+       ("libbs2b" ,libbs2b)
+       ("libcddb" ,libcddb)
+       ("libcdio-paranoia" ,libcdio-paranoia)
+       ("libcue" ,libcue)
+       ("libmodplug" ,libmodplug)
+       ("libnotify" ,libnotify)
+       ("libogg" ,libogg)
+       ("libsamplerate" ,libsamplerate)
+       ("libsndfile" ,libsndfile)
+       ("libvorbis" ,libvorbis)
+       ("libxml2" ,libxml2)
+       ("lirc" ,lirc)
+       ("jack" ,jack-1)
+       ("mpg123" ,mpg123)
+       ("neon" ,neon)
+       ("pulseaudio" ,pulseaudio)
+       ("qtmultimedia" ,qtmultimedia)
+       ("soxr" ,soxr)
+       ("wavpack" ,wavpack)))
+    (home-page "https://audacious-media-player.org")
+    (synopsis "Audio player based on XMMS")
+    (description
+     "Audacious is an audio player descended from XMMS.  Drag and drop f=
olders
+and individual song files, search for artists and albums in your entire =
music
+library, or create and edit your own custom playlists.  Listen to CD=E2=80=
=99s or stream
+music from the Internet.  Tweak the sound with the graphical equalizer o=
r
+experiment with LADSPA effects.  Enjoy the modern GTK-themed interface o=
r change
+things up with Winamp Classic skins.  Use the plugins included with Auda=
cious to
+fetch lyrics for your music, to set an alarm in the morning, and more.")
+    ;; According to COPYING, Audacious and its plugins are licensed unde=
r the
+    ;; BSD 2-clause license and libguess is licensed under the BSD 3-cla=
use
+    ;; license.
+    (license (list license:bsd-2
+                   license:bsd-3))))
+
 ;; We don't use the latest release because it depends on Qt4.  Instead w=
e
 ;; download the sources from the tip of the "qt5" branch.
 (define-public clementine
--=20
2.23.0





Acknowledgement sent to Kei Kebreau <kkebreau@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#37329; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.