GNU bug report logs - #37358
Add emacs-doom-themes

Previous Next

Package: guix-patches;

Reported by: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>

Date: Mon, 9 Sep 2019 16:57:01 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37358 in the body.
You can then email your comments to 37358 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#37358; Package guix-patches. (Mon, 09 Sep 2019 16:57:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 09 Sep 2019 16:57:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
To: guix-patches <at> gnu.org
Subject: Add emacs-doom-themes
Date: Mon, 09 Sep 2019 18:56:15 +0200
[Message part 1 (text/plain, inline)]
Hi Guix,
I packaged emacs-doom-themes. It would be nice if it could be included
into Guix.
It would be nice if someone could point out a nicer way to handle the
nested directories.

Tim.

[0001-gnu-Add-emacs-doom-themes.patch (text/x-patch, inline)]
From 3fc45dd06f11523f2f7494bcd69790a879635ae4 Mon Sep 17 00:00:00 2001
From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Date: Mon, 9 Sep 2019 18:48:31 +0200
Subject: [PATCH] gnu: Add emacs-doom-themes

* gnu/packages/emacs-xyz.scm (emacs-doom-themes): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f3de24d825..daf3099328 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -18200,3 +18200,28 @@ You can customize: @code{tao-theme-scale-fn}, that returns 16 2-digit numbers;
 @code{tao-theme-scale-filter-fn}, for edge filter; and
 @code{tao-theme-use-height}.")
       (license license:gpl3+))))
+
+(define-public emacs-doom-themes
+  (package
+    (name "emacs-doom-themes")
+    (version "2.1.6")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/hlissner/emacs-doom-themes.git")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256 (base32 "042pzcdhxi2z07jcscgjbaki9nrrm0cbgbbrnymd1r4q8ckkn8l9"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack
+             'move-themes
+           (lambda _
+             (copy-recursively "themes/" "."))))))
+    (synopsis "Wide collection of color themes for emacs")
+    (description "emacs-doom-themes contains numerous popular color themes for
+emacs that integrate with major modes like org-mode.")
+    (home-page "https://github.com/hlissner/emacs-doom-themes")
+    (license license:expat)))
-- 
2.23.0


Information forwarded to guix-patches <at> gnu.org:
bug#37358; Package guix-patches. (Tue, 10 Sep 2019 22:04:02 GMT) Full text and rfc822 format available.

Message #8 received at 37358 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Cc: 37358 <at> debbugs.gnu.org
Subject: Re: [bug#37358] Add emacs-doom-themes
Date: Wed, 11 Sep 2019 00:03:29 +0200
Hello,

Tim Gesthuizen <tim.gesthuizen <at> yahoo.de> skribis:

>>From 3fc45dd06f11523f2f7494bcd69790a879635ae4 Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
> Date: Mon, 9 Sep 2019 18:48:31 +0200
> Subject: [PATCH] gnu: Add emacs-doom-themes
>
> * gnu/packages/emacs-xyz.scm (emacs-doom-themes): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-after 'unpack
> +             'move-themes
> +           (lambda _
> +             (copy-recursively "themes/" "."))))))

Why is this needed?

I could suggest:

  (for-each (lambda (file)
              (rename-file file (string-append (dirname file) "/..")))
            (find-files themes))

… which would really move files, but it also more verbose.

WDYT?

Thank you,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#37358; Package guix-patches. (Wed, 11 Sep 2019 16:49:01 GMT) Full text and rfc822 format available.

Message #11 received at 37358 <at> debbugs.gnu.org (full text, mbox):

From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37358 <at> debbugs.gnu.org
Subject: Re: [bug#37358] Add emacs-doom-themes
Date: Wed, 11 Sep 2019 18:48:33 +0200
[Message part 1 (text/plain, inline)]
Hi,

Ludovic Courtès writes:
> Why is this needed?

I am pretty sure that this is not what I want (did I miss a build-system
option?):
The themes of the package are in a subdirectory that is not byte
compiled or installed to the store when the package is build.
The easiest workaround I could come up with is copying all .el files to
the root of the package.
The package is pretty useless without the theme .el files.

> I could suggest:
>
>   (for-each (lambda (file)
>               (rename-file file (string-append (dirname file) "/..")))
>             (find-files themes))
>
> … which would really move files, but it also more verbose.

A version moving the files is attached. I would prefer the copying
version however: The files will not get installed, we are talking about
a few kilobytes in /tmp/, and it is easier to read.
Choose the version you like :)

Tim.

[0001-gnu-Add-emacs-doom-themes.patch (text/x-patch, inline)]
From b775f49533df6af3a3646547abeb2ca627f401c8 Mon Sep 17 00:00:00 2001
From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Date: Mon, 9 Sep 2019 18:48:31 +0200
Subject: [PATCH] gnu: Add emacs-doom-themes

* gnu/packages/emacs-xyz.scm (emacs-doom-themes): New variable.
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f3de24d825..d39a176e4f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -18200,3 +18200,31 @@ You can customize: @code{tao-theme-scale-fn}, that returns 16 2-digit numbers;
 @code{tao-theme-scale-filter-fn}, for edge filter; and
 @code{tao-theme-use-height}.")
       (license license:gpl3+))))
+
+(define-public emacs-doom-themes
+  (package
+    (name "emacs-doom-themes")
+    (version "2.1.6")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/hlissner/emacs-doom-themes.git")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256 (base32 "042pzcdhxi2z07jcscgjbaki9nrrm0cbgbbrnymd1r4q8ckkn8l9"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack
+             'move-themes
+           (lambda _
+             (for-each
+              (lambda (file)
+                (rename-file file (string-append (dirname file) "/../" (basename file))))
+              (find-files "themes")))))))
+    (synopsis "Wide collection of color themes for emacs")
+    (description "emacs-doom-themes contains numerous popular color themes for
+emacs that integrate with major modes like org-mode.")
+    (home-page "https://github.com/hlissner/emacs-doom-themes")
+    (license license:expat)))
-- 
2.23.0


Information forwarded to guix-patches <at> gnu.org:
bug#37358; Package guix-patches. (Wed, 11 Sep 2019 18:14:02 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: brettg <at> posteo.net
To: Tim Gesthuizen via Guix-patches <guix-patches <at> gnu.org>
Cc: Guix-patches <guix-patches-bounces+brettg=posteo.net <at> gnu.org>,
 Ludovic Courtès <ludo <at> gnu.org>, 37358 <at> debbugs.gnu.org
Subject: Re: [bug#37358] Add emacs-doom-themes
Date: Wed, 11 Sep 2019 20:13:43 +0200
Hi all,

I have a copy of emacs-doom-themes in my channel here. I never pushed it 
because I didnt feel it was good enough for upstream.

It works though, feel free to tweak it and push it.

https://git.sr.ht/~brettgilio/cfg/tree/master/guix-channel/non-gnu/packages/emacs-xyz.scm#L10

On 11.09.2019 18:48, Tim Gesthuizen via Guix-patches via wrote:
> Hi,
> 
> Ludovic Courtès writes:
>> Why is this needed?
> 
> I am pretty sure that this is not what I want (did I miss a 
> build-system
> option?):
> The themes of the package are in a subdirectory that is not byte
> compiled or installed to the store when the package is build.
> The easiest workaround I could come up with is copying all .el files to
> the root of the package.
> The package is pretty useless without the theme .el files.
> 
>> I could suggest:
>> 
>>   (for-each (lambda (file)
>>               (rename-file file (string-append (dirname file) "/..")))
>>             (find-files themes))
>> 
>> … which would really move files, but it also more verbose.
> 
> A version moving the files is attached. I would prefer the copying
> version however: The files will not get installed, we are talking about
> a few kilobytes in /tmp/, and it is easier to read.
> Choose the version you like :)
> 
> Tim.




Information forwarded to guix-patches <at> gnu.org:
bug#37358; Package guix-patches. (Wed, 11 Sep 2019 18:14:02 GMT) Full text and rfc822 format available.

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Thu, 12 Sep 2019 21:24:02 GMT) Full text and rfc822 format available.

Notification sent to Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>:
bug acknowledged by developer. (Thu, 12 Sep 2019 21:24:02 GMT) Full text and rfc822 format available.

Message #22 received at 37358-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: brettg <at> posteo.net
Cc: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>, 37358-done <at> debbugs.gnu.org
Subject: Re: [bug#37358] Add emacs-doom-themes
Date: Thu, 12 Sep 2019 23:22:58 +0200
Hi Brett,

brettg <at> posteo.net skribis:

> I have a copy of emacs-doom-themes in my channel here. I never pushed
> it because I didnt feel it was good enough for upstream.

Ah ha, too much self-censorship!

> It works though, feel free to tweak it and push it.
>
> https://git.sr.ht/~brettgilio/cfg/tree/master/guix-channel/non-gnu/packages/emacs-xyz.scm#L10

I’ve added some of the bits of your version that were missing, marked
you as co-author, and committed.

Thanks to both of you!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 11 Oct 2019 11:24:12 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 171 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.