GNU bug report logs - #37365
[PATCH] Add package zsh-autosuggestions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37365 in the body.
You can then email your comments to 37365 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add package zsh-autosuggestions
Date: Mon, 09 Sep 2019 23:14:23 -0400

[Message part 1 (text/plain, inline)]

Add package for zsh-autosuggestions.

[0001-gnu-Add-zsh-autosuggestions.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Message #8 received at 37365 <at> debbugs.gnu.org (full text, mbox):

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: 37365 <at> debbugs.gnu.org
Subject: [PATCH] Ammendment - zsh-autosuggestions
Date: Mon, 09 Sep 2019 23:27:25 -0400

[Message part 1 (text/plain, inline)]

I failed to run `guix lint` prior to submitting the patch in my previous
submission. I have included the updated patch here. Please disregard the
earlier patch and use this one instead.

Thank you.

[0001-gnu-Add-zsh-autosuggestions.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Message #11 received at 37365 <at> debbugs.gnu.org (full text, mbox):

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: 37365 <at> debbugs.gnu.org
Subject: [PATCH] - Amendment #2: and copyright line and sign message with gpg
Date: Tue, 10 Sep 2019 10:37:10 -0400

[Message part 1 (text/plain, inline)]

I apologize for the churn on this patch. I had forgotten a Copyright
line at the top of the modified file.

Kind regards,

[Message part 2 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]

[0001-gnu-Add-zsh-autosuggestions.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Message #14 received at 37365 <at> debbugs.gnu.org (full text, mbox):

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: 37365 <at> debbugs.gnu.org
Subject: [PATCH] - Amendment: Enable tests
Date: Tue, 10 Sep 2019 23:18:52 -0400

[Message part 1 (text/plain, inline)]

Enable tests for zsh-autosuggetions. These tests use tmux, zsh, and ruby
with rspec, inspecting output after simulating input.

Many thanks to rekado for his advise on IRC.

This is ready to merge.

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

[signature.asc (application/pgp-signature, inline)]

[0001-gnu-Add-zsh-autosuggestions.patch (text/x-patch, attachment)]

Message #17 received at 37365 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: "Collin J. Doering" <collin <at> rekahsoft.ca>
Cc: 37365 <at> debbugs.gnu.org
Subject: Re: [bug#37365] [PATCH] - Amendment: Enable tests
Date: Wed, 11 Sep 2019 10:37:19 +0300

[Message part 1 (text/plain, inline)]

These should be two patches, the first one to add the ruby package and
the second to add the zsh package.

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (install-path (string-append out "/share/zsh/plugins/zsh-autosuggestions")))
> +               (mkdir-p install-path)
> +               (invoke "make" "all")
> +               (copy-file "zsh-autosuggestions.zsh" (string-append install-path "/zsh-autosuggestions.zsh"))
> +               #t))))))

I don't use zsh so I'm asking without knowing anything about the
directory structure, is %out/share/zsh/plugins/zsh-autosuggestions the
correct folder? The only folder I currently have after zsh is
site-functions.

(ins)efraim <at> E5400 ~$ tree .guix-profile/share/zsh/
.guix-profile/share/zsh/
 site-functions
     _mpv -> /gnu/store/acrlmdnmrkivbdrry756pf9grsx2x814-mpv-0.29.1/share/zsh/site-functions/_mpv
     _vifm -> /gnu/store/1l9b676paigfc3fx9r8h6h2k5d33wrhk-vifm-0.10.1/share/zsh/site-functions/_vifm
     _wgetpaste -> /gnu/store/k5g3fa3i59yxy3n9vf8lm1nfbz5whq2i-wgetpaste-2.29/share/zsh/site-functions/_wgetpaste



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 37365 <at> debbugs.gnu.org (full text, mbox):

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 37365 <at> debbugs.gnu.org, "Collin J. Doering" <collin <at> rekahsoft.ca>
Subject: Re: [bug#37365] [PATCH] - Amendment: Enable tests
Date: Thu, 12 Sep 2019 17:15:06 -0400

[Message part 1 (text/plain, inline)]

Hi Efraim,

Firstly, thanks for taking the time to review this. I have attached
updated patches with your suggested changes.

On 11 Sep 2019 at 03:37, Efraim Flashner wrote:

> These should be two patches, the first one to add the ruby package and
> the second to add the zsh package.

Makes sense.

>
>> +         (replace 'install
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let* ((out (assoc-ref outputs "out"))
>> +                    (install-path (string-append out "/share/zsh/plugins/zsh-autosuggestions")))
>> +               (mkdir-p install-path)
>> +               (invoke "make" "all")
>> +               (copy-file "zsh-autosuggestions.zsh" (string-append install-path "/zsh-autosuggestions.zsh"))
>> +               #t))))))
>
> I don't use zsh so I'm asking without knowing anything about the
> directory structure, is %out/share/zsh/plugins/zsh-autosuggestions the
> correct folder? The only folder I currently have after zsh is
> site-functions.
>
> (ins)efraim <at> E5400 ~$ tree .guix-profile/share/zsh/
> .guix-profile/share/zsh/
>  site-functions
>      _mpv -> /gnu/store/acrlmdnmrkivbdrry756pf9grsx2x814-mpv-0.29.1/share/zsh/site-functions/_mpv
>      _vifm -> /gnu/store/1l9b676paigfc3fx9r8h6h2k5d33wrhk-vifm-0.10.1/share/zsh/site-functions/_vifm
>      _wgetpaste -> /gnu/store/k5g3fa3i59yxy3n9vf8lm1nfbz5whq2i-wgetpaste-2.29/share/zsh/site-functions/_wgetpaste

I did some more looking into this (as I just copied what I saw done for
a few zsh plugin packages for archlinux). The directories you list above
(namely .../'share/zsh/site-functions/_...') are for zsh site-functions (begin
with an underscore) and not plugins that extend the functionality of zsh
(which will have to be sourced from the users `~/.zshrc`). Something
like this should do:

source ~/.guix-profile/share/zsh/plugins/zsh-autosuggestions/zsh-autosuggestions.zsh

Anyways, I think that `.../share/zsh/plugins/<plugin_name>/...` is a
good place for this (and any other zsh plugins). WDYT?

Finally, you will find an updated patch set attached to this email that
includes splitting the ruby package out into its own patch, as well as
minor touch up to be more consistent with naming throughout the rest of
the guix code base.

Kind regards,

[signature.asc (application/pgp-signature, inline)]

[0001-gnu-Add-ruby-rspec-wait.patch (text/x-patch, attachment)]

[0002-gnu-Add-zsh-autosuggestions.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Message #25 received at 37365-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: "Collin J. Doering" <collin <at> rekahsoft.ca>
Cc: 37365-done <at> debbugs.gnu.org
Subject: Re: [bug#37365] [PATCH] - Amendment: Enable tests
Date: Fri, 13 Sep 2019 15:47:28 +0300

[Message part 1 (text/plain, inline)]

Patches pushed with some small changes.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.