GNU bug report logs - #37394
[PATCH] gnu: Add tigervnc

Previous Next

Package: guix-patches;

Reported by: Todor Kondić <tk.code <at> protonmail.com>

Date: Thu, 12 Sep 2019 19:35:02 UTC

Severity: normal

Tags: patch

Done: Danny Milosavljevic <dannym <at> scratchpost.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37394 in the body.
You can then email your comments to 37394 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#37394; Package guix-patches. (Thu, 12 Sep 2019 19:35:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Todor Kondić <tk.code <at> protonmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 12 Sep 2019 19:35:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Todor Kondić <tk.code <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add tigervnc
Date: Thu, 12 Sep 2019 19:33:45 +0000
[Message part 1 (text/plain, inline)]
Hi,

I needed a decent VNC server, so I wrapped up TigerVNC into two guix packages. One is for the client, and another for the server. Since the build procedure is non-standard (a combination of cmake for the viewer and some parts, but  then patch-and-compile  Xorg server for the VNC server) , I could not follow the ([understandably] scarcely documented) package definition procedures in Guix docs and, instead, mixed and matched things I gleaned from other Guix packages. The result works as far as I can tell and was tested in a VM, however, some parts of the package definition could probably be expressed more elegantly.

Also, it would be nice if the folks who created xorg-server package definition could check the various configure options in the server part, since the tigervnc-server inherits from xorg-server. For example, was it really necessary to disable Xephyr? I do not even know what is it for.

The vncserver script surprisingly works, but could probably customised a bit for the Guix distro. In addition, most distros have a systemd service to start the server. I do not  see this as a very important addition, given the Guix orientation towards user managed configs, but if someone wants to help me define one, I am open to it. One nice application for a service would be to implement the multi-user vnc server as described here https://developer.ibm.com/tutorials/os-multiuserloginsvnc/

Finally, the packages were linted, and indented using the script. The lint complains about certain minor things that I feel are better left the way they are.

Hopefully someone will find this useful.

Cheers,

Todor
[Message part 2 (text/html, inline)]
[0001-Add-tigervnc-client.patch (text/x-patch, attachment)]
[0002-Add-tigervnc-server.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#37394; Package guix-patches. (Tue, 01 Oct 2019 23:29:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Todor Kondić via Guix-patches via <guix-patches <at> gnu.org>
Cc: 37394-done <at> debbugs.gnu.org
Subject: Re: [bug#37394] [PATCH] gnu: Add tigervnc
Date: Wed, 2 Oct 2019 01:28:37 +0200
[Message part 1 (text/plain, inline)]
Hi,

thanks for the patches!

On Thu, 12 Sep 2019 19:33:45 +0000
Todor Kondić via Guix-patches via <guix-patches <at> gnu.org> wrote:

> Also, it would be nice if the folks who created xorg-server package definition could check the various configure options in the server part, since the tigervnc-server inherits from xorg-server. For example, was it really necessary to disable Xephyr? I do not even know what is it for.

Xephyr is an X server whose output is a window instead of the entire screen.  That doesn't sound like one needs that in a VNC server (which does not render to a screen anyway).
[Message part 2 (application/pgp-signature, inline)]

Reply sent to Danny Milosavljevic <dannym <at> scratchpost.org>:
You have taken responsibility. (Tue, 01 Oct 2019 23:29:02 GMT) Full text and rfc822 format available.

Notification sent to Todor Kondić <tk.code <at> protonmail.com>:
bug acknowledged by developer. (Tue, 01 Oct 2019 23:29:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 30 Oct 2019 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 179 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.