GNU bug report logs - #37409
[PATCH] gnu: guile-email: Add phase to patch the module directory.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37409 in the body.
You can then email your comments to 37409 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: guile-email: Add phase to patch the module directory.
Date: Sun, 15 Sep 2019 13:33:31 +0100

Otherwise the .go files appear within share, and Guile doesn't find them. With
this patch they appear in lib within the output. One thing this means is that
stack traces include the filenames.

* gnu/packages/guile-xyz.scm (guile-email)[arguments]: Add 'patch-module-dir
phase.
---
 gnu/packages/guile-xyz.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index b765ef36e1..4fa2759205 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -927,7 +927,16 @@ tracker's SOAP service, such as @url{https://bugs.gnu.org}.")
     (inputs
      `(("guile" ,guile-2.2)))
     (arguments
-     '(#:make-flags '("GUILE_AUTO_COMPILE=0"))) ; to prevent guild warnings
+     '(#:make-flags '("GUILE_AUTO_COMPILE=0") ; to prevent guild warnings
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'patch-module-dir
+           (lambda _
+             (substitute* "Makefile.in"
+               (("^godir = ([[:graph:]]+)")
+                "godir = \
+$(libdir)/guile/@GUILE_EFFECTIVE_VERSION@/site-ccache\n"))
+             #t)))))
     (home-page "https://guile-email.systemreboot.net")
     (synopsis "Guile email parser")
     (description "guile-email is a collection of email utilities implemented
-- 
2.23.0

Message #8 received at 37409 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 37409 <at> debbugs.gnu.org
Subject: Re: [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the
 module directory.
Date: Mon, 16 Sep 2019 09:56:31 +0200

Hello,

Christopher Baines <mail <at> cbaines.net> skribis:

> Otherwise the .go files appear within share, and Guile doesn't find them. With
> this patch they appear in lib within the output. One thing this means is that
> stack traces include the filenames.
>
> * gnu/packages/guile-xyz.scm (guile-email)[arguments]: Add 'patch-module-dir
> phase.

LGTM!

Ludo’.

Message #11 received at 37409 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 37409 <at> debbugs.gnu.org
Subject: Re: [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the
 module directory.
Date: Mon, 16 Sep 2019 14:07:39 +0530

[Message part 1 (text/plain, inline)]

> Otherwise the .go files appear within share, and Guile doesn't find them. With
> this patch they appear in lib within the output. One thing this means is that
> stack traces include the filenames.

LGTM! I'll also make this modification to guile-email upstream so this
phase won't be necessary after the next update of guile-email.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 37409 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 37409 <at> debbugs.gnu.org
Subject: Re: [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the
 module directory.
Date: Sat, 21 Sep 2019 17:37:27 +0100

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

>> Otherwise the .go files appear within share, and Guile doesn't find them. With
>> this patch they appear in lib within the output. One thing this means is that
>> stack traces include the filenames.
>
> LGTM! I'll also make this modification to guile-email upstream so this
> phase won't be necessary after the next update of guile-email.

Awesome, thanks Arun :)

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 37409-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37409-done <at> debbugs.gnu.org
Subject: Re: [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the
 module directory.
Date: Sat, 21 Sep 2019 17:37:07 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Otherwise the .go files appear within share, and Guile doesn't find them. With
>> this patch they appear in lib within the output. One thing this means is that
>> stack traces include the filenames.
>>
>> * gnu/packages/guile-xyz.scm (guile-email)[arguments]: Add 'patch-module-dir
>> phase.
>
> LGTM!

Great, I've pushed this now (as
c219104c7803cd31ab1cf4bef142a8fbf8ed5b7a).

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.