GNU bug report logs - #37417
26.3; [PATCH] Isearch yank text at point improvements

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37417 in the body.
You can then email your comments to 37417 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.3; [PATCH] Isearch yank text at point improvements
Date: Sun, 15 Sep 2019 17:59:38 -0700 (PDT)

[Message part 1 (text/plain, inline)]

The attached patches and change-log entry implement what is
discussed in emacs-devel thread "PATCH: isearch-yank-until-match"
and part of thread "PATCH: isearch-yank-until-char".

1. They fix commands that yank consecutive text at point so that
   they respect search direction.  This is controlled by option
   `isearch-directional-yank'.

2. Related new yank commands are provided:
   `isearch-yank-through-new-match', bound to `C-M-m'
   `isearch-yank-through-key-move', bound to `M-s k'
   `isearch-yank-through-rec-edit-move', bound to `C-M-c'

3. Emacs manual node `Isearch Yank' is updated accordingly.

In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
 of 2019-08-29
Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
Windowing system distributor `Microsoft Corp.', version 10.0.17763
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

[isearch-el-2019-09-14c.patch (application/octet-stream, attachment)]

[search-texi-2019-09-14c.patch (application/octet-stream, attachment)]

[NEWS-2019-09-14c.patch (application/octet-stream, attachment)]

[isearch-ChangeLog-2019-09-14a (application/octet-stream, attachment)]

Message #8 received at 37417 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: 37417 <at> debbugs.gnu.org
Subject: RE: bug#37417: 26.3; [PATCH] Isearch yank text at point improvements
Date: Tue, 19 Nov 2019 08:44:36 -0800 (PST)

ping

Message #11 received at 37417 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 37417 <at> debbugs.gnu.org
Subject: Re: bug#37417: 26.3; [PATCH] Isearch yank text at point improvements
Date: Wed, 20 Nov 2019 01:13:13 +0200

> ping

Sorry, your patch is unacceptable large for such a minor peripheral feature.

Either create a separate package that implements this feature,
or rewrite the patch using the seq library that would help
to implement the same feature in just a few lines of code.

Message #14 received at 37417 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37417 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#37417: 26.3; [PATCH] Isearch yank text at point improvements
Date: Sun, 09 Aug 2020 21:00:54 +0200

Juri Linkov <juri <at> linkov.net> writes:

>> ping
>
> Sorry, your patch is unacceptable large for such a minor peripheral feature.
>
> Either create a separate package that implements this feature,
> or rewrite the patch using the seq library that would help
> to implement the same feature in just a few lines of code.

It was indeed a surprisingly large patch, but the feature does seem
useful.

I've only skimmed the patch, but could you really replace all that with
just a few lines if you used the seq library?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 37417 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 37417 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#37417: 26.3; [PATCH] Isearch yank text at point improvements
Date: Mon, 10 Aug 2020 02:28:17 +0300

> It was indeed a surprisingly large patch, but the feature does seem
> useful.
>
> I've only skimmed the patch, but could you really replace all that with
> just a few lines if you used the seq library?

Actually there are several diverse features mingled in the same patch.
Do you think all of them might be useful to add to isearch.el?
I doubt that many users might want to use them.

Message #20 received at 37417 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37417 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#37417: 26.3; [PATCH] Isearch yank text at point improvements
Date: Mon, 10 Aug 2020 12:48:12 +0200

Juri Linkov <juri <at> linkov.net> writes:

>> It was indeed a surprisingly large patch, but the feature does seem
>> useful.
>>
>> I've only skimmed the patch, but could you really replace all that with
>> just a few lines if you used the seq library?
>
> Actually there are several diverse features mingled in the same patch.
> Do you think all of them might be useful to add to isearch.el?
> I doubt that many users might want to use them.

OK, so your objection wasn't the lack of the use of the seq library, but
that the patch implements functionality you don't think is useful?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #23 received at 37417 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 37417 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#37417: 26.3; [PATCH] Isearch yank text at point improvements
Date: Tue, 11 Aug 2020 02:45:19 +0300

>> Actually there are several diverse features mingled in the same patch.
>> Do you think all of them might be useful to add to isearch.el?
>> I doubt that many users might want to use them.
>
> OK, so your objection wasn't the lack of the use of the seq library, but
> that the patch implements functionality you don't think is useful?

Actually I expressed this opinion in context of my own situation that
is similar to this feature request - some time ago I wrote a patch
for isearch.el that implements a new feature of displaying numeric hints
on each visible lazy-isearch match.  But then my doubt was that it will
impact the size of isearch.el that is already one of the biggest files
in the Emacs repository.  Then I rewrote the patch using the seq library
that helped to squeeze the patch down to a couple dozen of lines,
but still I doubt the usefulness of my implemented feature.
This is why I decided to release it as a separate package.
So this is what I suggest to do with features that are not in high demand,
or are stil experimental, or are too big to fit into the existing packages.

Message #26 received at 37417 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37417 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#37417: 26.3; [PATCH] Isearch yank text at point improvements
Date: Tue, 11 Aug 2020 13:07:57 +0200

Juri Linkov <juri <at> linkov.net> writes:

> This is why I decided to release it as a separate package.
> So this is what I suggest to do with features that are not in high demand,
> or are stil experimental, or are too big to fit into the existing packages.

Yeah, these new features proposed by Drew seem somewhat complicated, so
having them in a separate package might make sense.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #29 received at 37417 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37417 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#37417: 26.3; [PATCH] Isearch yank text at point improvements
Date: Tue, 18 Aug 2020 18:13:25 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Juri Linkov <juri <at> linkov.net> writes:
>
>> This is why I decided to release it as a separate package.
>> So this is what I suggest to do with features that are not in high demand,
>> or are stil experimental, or are too big to fit into the existing packages.
>
> Yeah, these new features proposed by Drew seem somewhat complicated, so
> having them in a separate package might make sense.

Nobody seems to have an further comments here, so I'm closing this bug
report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.