GNU bug report logs - #37421
node fails to build during update

Previous Next

Package: guix;

Reported by: sirmacik <sirmacik <at> wioo.waw.pl>

Date: Mon, 16 Sep 2019 08:59:02 UTC

Severity: normal

Merged with 37386, 37407

Done: Tobias Geerinckx-Rice <me <at> tobias.gr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37421 in the body.
You can then email your comments to 37421 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#37421; Package guix. (Mon, 16 Sep 2019 08:59:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to sirmacik <sirmacik <at> wioo.waw.pl>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Mon, 16 Sep 2019 08:59:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: sirmacik <sirmacik <at> wioo.waw.pl>
To: bug-guix <at> gnu.org
Subject: node fails to build during update
Date: Mon, 16 Sep 2019 10:57:55 +0200
[Message part 1 (text/plain, inline)]
Hi,

I'm trying to update ungoogled-chromium package but it fails on node
build and this happens repeatedly:

(guix pull done before)
$ guix package -u
substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
building /gnu/store/vk49dlkkixsik0fw9gsmnqn4jmgfw099-node-10.15.3.drv...
| 'check' phasebuilder for `/gnu/store/vk49dlkkixsik0fw9gsmnqn4jmgfw099-node-10.15.3.drv' failed with exit code 1
build of /gnu/store/vk49dlkkixsik0fw9gsmnqn4jmgfw099-node-10.15.3.drv failed
View build log at '/var/log/guix/drvs/vk/49dlkkixsik0fw9gsmnqn4jmgfw099-node-10.15.3.drv.bz2'.
cannot build derivation `/gnu/store/n6h5fv4isjjnqchpjfb5m7cv765s3vi0-ungoogled-chromium-76.0.3809.132-0.8eba5c0.drv': 1 dependencies couldn't be built
guix package: error: build of `/gnu/store/n6h5fv4isjjnqchpjfb5m7cv765s3vi0-ungoogled-chromium-76.0.3809.132-0.8eba5c0.drv' failed

I'm attaching log file from the build. 

[49dlkkixsik0fw9gsmnqn4jmgfw099-node-10.15.3.drv.bz2 (application/octet-stream, attachment)]
[Message part 3 (text/plain, inline)]
--
Thank you for your time!
sirmacik
PGP: 0xE0DC81D523891771

Merged 37386 37421. Request was from Tobias Geerinckx-Rice <me <at> tobias.gr> to control <at> debbugs.gnu.org. (Mon, 16 Sep 2019 10:16:01 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#37421; Package guix. (Mon, 16 Sep 2019 13:54:01 GMT) Full text and rfc822 format available.

Message #10 received at 37421 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 37421 <at> debbugs.gnu.org
Subject: [PATCH] gnu: node: Disable tests that fail with openssl <at> 1.1.1d.
Date: Mon, 16 Sep 2019 15:52:28 +0200
Work around <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37386>.

* gnu/packages/node.scm (node)[arguments]: Disable failing tests.
---

Jelle, Guix,

So here's the obvious non-solution, ignoring test failures being the lesser evil compared to 4 potential CVEs anywhere in a Web browser's closure.

It seems to ‘work’ in a short VM Chromium test.  As in, nothing broke.  Don't know how to test Node.  Thoughts?

Kind regards,

T G-R

 gnu/packages/node.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index fc43fcb04c..f467be7665 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -91,6 +91,11 @@
          (add-before 'configure 'patch-files
            (lambda* (#:key inputs #:allow-other-keys)
 
+             ;; FIXME: These tests fail with openssl <at> 1.1.1d.
+             (for-each delete-file
+                       '("test/parallel/test-crypto-binary-default.js"
+                         "test/parallel/test-crypto-dh.js"))
+
              ;; Fix hardcoded /bin/sh references.
              (substitute* '("lib/child_process.js"
                             "lib/internal/v8_prof_polyfill.js"
-- 
2.23.0





Merged 37386 37407 37421. Request was from Ludovic Courtès <ludo <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 16 Sep 2019 16:08:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#37421; Package guix. (Mon, 16 Sep 2019 16:10:02 GMT) Full text and rfc822 format available.

Message #15 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 37421 <at> debbugs.gnu.org
Subject: Re: bug#37421: [PATCH] gnu: node: Disable tests that fail with
 openssl <at> 1.1.1d.
Date: Mon, 16 Sep 2019 18:09:00 +0200
Hello,

Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix <at> gnu.org>
skribis:

> Work around <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37386>.
>
> * gnu/packages/node.scm (node)[arguments]: Disable failing tests.

[...]

> +             ;; FIXME: These tests fail with openssl <at> 1.1.1d.
> +             (for-each delete-file
> +                       '("test/parallel/test-crypto-binary-default.js"
> +                         "test/parallel/test-crypto-dh.js"))

It may be the best short-term solution.

Could we take a look at what these failures are about to see how bad
that might be?

Thanks,
Ludo’.




Information forwarded to bug-guix <at> gnu.org:
bug#37421; Package guix. (Mon, 16 Sep 2019 16:10:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#37421; Package guix. (Mon, 16 Sep 2019 18:58:01 GMT) Full text and rfc822 format available.

Message #21 received at 37421 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Ludovic Courtès <ludo <at> gnu.org>, 37421 <at> debbugs.gnu.org
Subject: Re: bug#37421: [PATCH] gnu: node: Disable tests that fail with
 openssl <at> 1.1.1d.
Date: Mon, 16 Sep 2019 20:57:53 +0200
Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello,
>
> Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix <at> gnu.org>
> skribis:
>
>> Work around <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37386>.
>>
>> * gnu/packages/node.scm (node)[arguments]: Disable failing tests.
>
> [...]
>
>> +             ;; FIXME: These tests fail with openssl <at> 1.1.1d.
>> +             (for-each delete-file
>> +                       '("test/parallel/test-crypto-binary-default.js"
>> +                         "test/parallel/test-crypto-dh.js"))
>
> It may be the best short-term solution.
Agreed, if ungoogled-chromium works with this that would probably be the
best option.
>
> Could we take a look at what these failures are about to see how bad
> that might be?

Interestingly enough, https://github.com/nodejs/node/issues/3881 notes
issues with exactly these two tests. Perhaps there is a regressions in
our case?




Information forwarded to bug-guix <at> gnu.org:
bug#37421; Package guix. (Mon, 16 Sep 2019 21:40:02 GMT) Full text and rfc822 format available.

Message #24 received at 37421 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ludovic Courtès <ludo <at> gnu.org>, Jelle Licht
 <jlicht <at> fsfe.org>
Cc: 37421 <at> debbugs.gnu.org
Subject: Re: bug#37421: [PATCH] gnu: node: Disable tests that fail with
 openssl <at> 1.1.1d.
Date: Mon, 16 Sep 2019 23:39:10 +0200
[Message part 1 (text/plain, inline)]
Ludovic Courtès 写道:
> Could we take a look at what these failures are about to see how 
> bad
> that might be?

Jelle Licht 写道:
> Interestingly enough, https://github.com/nodejs/node/issues/3881 
> notes
> issues with exactly these two tests. Perhaps there is a 
> regressions in
> our case?

Thanks, and indeed!  That is _quite_ the coincidence…

Unfortunately, I don't see any mention of a time-out in my logs & 
the truncation of the backtrace

 at Object.<anonymous> (…/test/parallel/test-crypto-dh.js:124:8)
 at Module._compile (internal/modules/cjs/loader.js:701:30)
 at Object.Module._extensions..js 
 (internal/modules/cjs/loader.js:712:10)
 at Module.load (internal/modules/cjs/loader.js:600:32)
 at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
 at Function.Module._load (internal/modules/cjs/loader.js:531:3)
 at Function.Module.runMain 
 (internal/modules/cjs/loader.js:754:12)
 at startup (internal/bootstrap/node.js:283:19)
 at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
 ...

happens at run time: grepping the output of ‘--keep’ doesn't 
reveal a more complete one :-(

I don't know how to hack the tests to spit out more.  Someone who 
knows node/js more than I do needs to step in and save us.  Is 
that you, Jelle? :-)

Kind regards,

T G-R
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#37421; Package guix. (Tue, 17 Sep 2019 14:44:01 GMT) Full text and rfc822 format available.

Message #27 received at 37421 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, Ludovic Courtès
 <ludo <at> gnu.org>
Cc: 37421 <at> debbugs.gnu.org
Subject: Re: bug#37421: [PATCH] gnu: node: Disable tests that fail with
 openssl <at> 1.1.1d.
Date: Tue, 17 Sep 2019 16:43:47 +0200
Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> Ludovic Courtès 写道:
>> Could we take a look at what these failures are about to see how 
>> bad
>> that might be?
>
> Jelle Licht 写道:
>> Interestingly enough, https://github.com/nodejs/node/issues/3881 
>> notes
>> issues with exactly these two tests. Perhaps there is a 
>> regressions in
>> our case?
>
> Thanks, and indeed!  That is _quite_ the coincidence…
>
> Unfortunately, I don't see any mention of a time-out in my logs & 
> the truncation of the backtrace
>
>   at Object.<anonymous> (…/test/parallel/test-crypto-dh.js:124:8)
>   at Module._compile (internal/modules/cjs/loader.js:701:30)
>   at Object.Module._extensions..js 
>   (internal/modules/cjs/loader.js:712:10)
>   at Module.load (internal/modules/cjs/loader.js:600:32)
>   at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
>   at Function.Module._load (internal/modules/cjs/loader.js:531:3)
>   at Function.Module.runMain 
>   (internal/modules/cjs/loader.js:754:12)
>   at startup (internal/bootstrap/node.js:283:19)
>   at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
>   ...
>
> happens at run time: grepping the output of ‘--keep’ doesn't 
> reveal a more complete one :-(
>
> I don't know how to hack the tests to spit out more.  Someone who 
> knows node/js more than I do needs to step in and save us.  Is 
> that you, Jelle? :-)

I believe in learning by doing, so I'll have a go at it somewhere early
next week :-).

For now, I think it makes sense to push this patch so we can have a
(hopefully) working and secure ungoogled-chromium.

>
> Kind regards,
>
> T G-R




Information forwarded to bug-guix <at> gnu.org:
bug#37421; Package guix. (Fri, 20 Sep 2019 15:12:02 GMT) Full text and rfc822 format available.

Message #30 received at 37421 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 37421 <at> debbugs.gnu.org
Subject: Apply nodejs test workaround?
Date: Fri, 20 Sep 2019 11:11:33 -0400 (EDT)
Hi Guix,

I wanted to ping this issue. From the discussion in #37421, it seems like 
we are OK with disabling the problematic tests as a work-around for now.

Should we go ahead and apply the patch?

Best,
Jack




Reply sent to Tobias Geerinckx-Rice <me <at> tobias.gr>:
You have taken responsibility. (Fri, 20 Sep 2019 15:32:02 GMT) Full text and rfc822 format available.

Notification sent to sirmacik <sirmacik <at> wioo.waw.pl>:
bug acknowledged by developer. (Fri, 20 Sep 2019 15:32:02 GMT) Full text and rfc822 format available.

Message #35 received at 37421-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 37421-done <at> debbugs.gnu.org
Subject: Re: bug#37421: Apply nodejs test workaround?
Date: Fri, 20 Sep 2019 17:31:29 +0200
[Message part 1 (text/plain, inline)]
Jack,

Jack Hill 写道:
> I wanted to ping this issue. From the discussion in #37421, it 
> seems
> like we are OK with disabling the problematic tests as a 
> work-around
> for now.

We are.  Done as aae65db560bd146ba47774cca46056d72be2a5d4 and 
closing.

Kind regards,

T G-R
[signature.asc (application/pgp-signature, inline)]

Reply sent to Tobias Geerinckx-Rice <me <at> tobias.gr>:
You have taken responsibility. (Fri, 20 Sep 2019 15:32:03 GMT) Full text and rfc822 format available.

Notification sent to Jelle Licht <jlicht <at> fsfe.org>:
bug acknowledged by developer. (Fri, 20 Sep 2019 15:32:03 GMT) Full text and rfc822 format available.

Reply sent to Tobias Geerinckx-Rice <me <at> tobias.gr>:
You have taken responsibility. (Fri, 20 Sep 2019 15:32:03 GMT) Full text and rfc822 format available.

Notification sent to "Reza Alizadeh Majd" <r.majd <at> pantherx.org>:
bug acknowledged by developer. (Fri, 20 Sep 2019 15:32:06 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 19 Oct 2019 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 162 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.