GNU bug report logs - #37434
[PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37434 in the body.
You can then email your comments to 37434 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ericbavier <at> centurylink.net
To: guix-patches <at> gnu.org
Cc: Eric Bavier <bavier <at> member.fsf.org>
Subject: [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Mon, 16 Sep 2019 22:37:29 -0500

From: Eric Bavier <bavier <at> member.fsf.org>

* gnu/packages/haskell.scm (ghc-megaparsec): Update to 7.0.5
[arguments]: Remove field.
---
 gnu/packages/haskell.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 8787f10789..960068ab23 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -4050,7 +4050,7 @@ combinators.")
 (define-public ghc-megaparsec
   (package
     (name "ghc-megaparsec")
-    (version "6.5.0")
+    (version "7.0.5")
     (source
      (origin
        (method url-fetch)
@@ -4059,11 +4059,8 @@ combinators.")
                            version ".tar.gz"))
        (sha256
         (base32
-         "12iggy7qpf8x93jm64zf0g215xwy779bqyfyjk2bhmxqqr1yzgdy"))))
+         "0bqx1icbmk8s7wmbcdzsgnlh607c7kzg8l80cp02dxr5valjxp7j"))))
     (build-system haskell-build-system)
-    (arguments
-     `(#:cabal-revision
-       ("4" "0ij3asi5vwlhbgwsy6nhli9a0qb7926mg809fsgyl1rnhs9fvpx1")))
     (inputs
      `(("ghc-case-insensitive" ,ghc-case-insensitive)
        ("ghc-parser-combinators" ,ghc-parser-combinators)
-- 
2.23.0

Message #8 received at 37434 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: ericbavier <at> centurylink.net
Cc: 37434 <at> debbugs.gnu.org, Timothy Sample <samplet <at> ngyro.com>,
 Eric Bavier <bavier <at> member.fsf.org>
Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Fri, 20 Sep 2019 22:32:50 +0200

Hi Eric,

ericbavier <at> centurylink.net skribis:

> From: Eric Bavier <bavier <at> member.fsf.org>
>
> * gnu/packages/haskell.scm (ghc-megaparsec): Update to 7.0.5
> [arguments]: Remove field.

Since <https://www.stackage.org/lts-14.6> lists megaparsec 7.0.5, I
think this is OK.  Am I right, Timothy?

Thanks,
Ludo’.

Message #11 received at 37434 <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37434 <at> debbugs.gnu.org, Eric Bavier <bavier <at> member.fsf.org>,
 ericbavier <at> centurylink.net
Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Fri, 20 Sep 2019 18:21:14 -0400

Hi Ludo and Eric,

Ludovic Courtès <ludo <at> gnu.org> writes:

> ericbavier <at> centurylink.net skribis:
>
>> From: Eric Bavier <bavier <at> member.fsf.org>
>>
>> * gnu/packages/haskell.scm (ghc-megaparsec): Update to 7.0.5
>> [arguments]: Remove field.
>
> Since <https://www.stackage.org/lts-14.6> lists megaparsec 7.0.5, I
> think this is OK.  Am I right, Timothy?

No!  :)

Stackage LTS 14 targets GHC 8.6, which we are not (yet) using for
Haskell builds.  We still use GHC 8.4, so we follow Stackage LTS 12
(<https://www.stackage.org/lts-12>), which lists megaparsec at 1.0.0.


-- Tim

Message #14 received at 37434 <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37434 <at> debbugs.gnu.org, Eric Bavier <bavier <at> member.fsf.org>,
 ericbavier <at> centurylink.net
Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Fri, 20 Sep 2019 18:25:01 -0400

Timothy Sample <samplet <at> ngyro.com> writes:

> Stackage LTS 14 targets GHC 8.6, which we are not (yet) using for
> Haskell builds.  We still use GHC 8.4, so we follow Stackage LTS 12
> (<https://www.stackage.org/lts-12>), which lists megaparsec at 1.0.0.

That should 6.5.0.  Sorry!  I was looking at hspec-megaparsec.


-- Tim

Message #17 received at 37434 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Timothy Sample <samplet <at> ngyro.com>
Cc: 37434 <at> debbugs.gnu.org, Eric Bavier <bavier <at> member.fsf.org>,
 ericbavier <at> centurylink.net
Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Mon, 23 Sep 2019 10:25:37 +0200

Hello!

Timothy Sample <samplet <at> ngyro.com> skribis:

> Timothy Sample <samplet <at> ngyro.com> writes:
>
>> Stackage LTS 14 targets GHC 8.6, which we are not (yet) using for
>> Haskell builds.  We still use GHC 8.4, so we follow Stackage LTS 12
>> (<https://www.stackage.org/lts-12>), which lists megaparsec at 1.0.0.
>
> That should 6.5.0.

OK, got it—I had “LTS” right but the number wrong, which is
unfortunate.  :-)

Eric, could you adjust accordingly?

Thanks,
Ludo’.

Message #20 received at 37434 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37434 <at> debbugs.gnu.org, Timothy Sample <samplet <at> ngyro.com>,
 bavier <bavier <at> member.fsf.org>
Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Mon, 23 Sep 2019 21:59:24 -0400 (EDT)

Idris 1.3.2 unfortunately needs megaparsec>=7.0.4.

FWIW, idris is our only package that depends on ghc-megaparsec. :)  So maybe an upgrade is fine?

I was under the impression that our 'guix refresh' updater was supposed to use the appropriate stackage version?  But it seems to be referencing version 14.6.


----- On Sep 23, 2019, at 3:25 AM, Ludovic Courtès ludo <at> gnu.org wrote:

> Hello!
> 
> Timothy Sample <samplet <at> ngyro.com> skribis:
> 
>> Timothy Sample <samplet <at> ngyro.com> writes:
>>
>>> Stackage LTS 14 targets GHC 8.6, which we are not (yet) using for
>>> Haskell builds.  We still use GHC 8.4, so we follow Stackage LTS 12
>>> (<https://www.stackage.org/lts-12>), which lists megaparsec at 1.0.0.
>>
>> That should 6.5.0.
> 
> OK, got it—I had “LTS” right but the number wrong, which is
> unfortunate.  :-)
> 
> Eric, could you adjust accordingly?
> 
> Thanks,
> Ludo’.

-- 
`~Eric

Message #23 received at 37434 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 37434 <at> debbugs.gnu.org, Timothy Sample <samplet <at> ngyro.com>,
 bavier <bavier <at> member.fsf.org>
Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Tue, 24 Sep 2019 09:16:34 +0200

Hello,

Eric Bavier <ericbavier <at> centurylink.net> skribis:

> Idris 1.3.2 unfortunately needs megaparsec>=7.0.4.
>
> FWIW, idris is our only package that depends on ghc-megaparsec. :)  So maybe an upgrade is fine?

For the sake of consistency, what about adding a variant of megaparsec
for use by Idris, and keeping the LTS-12 version?

> I was under the impression that our 'guix refresh' updater was supposed to use the appropriate stackage version?  But it seems to be referencing version 14.6.

Looking at ‘latest-lts-release’ in (guix import stackage), the updater
seems to just take the latest LTS version.

We should probably fix that by having the argument to
‘stackage-lts-info-fetch’ default to the currently targeted LTS version.
Otherwise one has to know the LTS version and pass it to ‘guix import
stackage --lts-version’, which is error-prone.

Thoughts?

Ludo’.

Message #26 received at 37434 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37434 <37434 <at> debbugs.gnu.org>, Timothy Sample <samplet <at> ngyro.com>,
 bavier <bavier <at> member.fsf.org>
Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Tue, 24 Sep 2019 10:06:59 -0400 (EDT)

[Message part 1 (text/plain, inline)]

----- On Sep 24, 2019, at 2:16 AM, Ludovic Courtès ludo <at> gnu.org wrote:

> Hello,
> 
> Eric Bavier <ericbavier <at> centurylink.net> skribis:
> 
>> Idris 1.3.2 unfortunately needs megaparsec>=7.0.4.
>>
>> FWIW, idris is our only package that depends on ghc-megaparsec. :)  So maybe an
>> upgrade is fine?
> 
> For the sake of consistency, what about adding a variant of megaparsec
> for use by Idris, and keeping the LTS-12 version?

That sounds appropriate to me.  New patch attached.

> 
>> I was under the impression that our 'guix refresh' updater was supposed to use
>> the appropriate stackage version?  But it seems to be referencing version 14.6.
> 
> Looking at ‘latest-lts-release’ in (guix import stackage), the updater
> seems to just take the latest LTS version.
> 
> We should probably fix that by having the argument to
> ‘stackage-lts-info-fetch’ default to the currently targeted LTS version.
> Otherwise one has to know the LTS version and pass it to ‘guix import
> stackage --lts-version’, which is error-prone.
> 
> Thoughts?

I think that would be the right thing to do, imo.

-- 
`~Eric

[0001-gnu-idris-Update-to-1.3.2.patch (text/x-patch, attachment)]

Message #29 received at 37434 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 37434 <37434 <at> debbugs.gnu.org>, Timothy Sample <samplet <at> ngyro.com>,
 bavier <bavier <at> member.fsf.org>
Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Tue, 24 Sep 2019 19:08:03 +0200

Hi Eric,

Eric Bavier <ericbavier <at> centurylink.net> skribis:

> From 832529b71c2c5c7e6aa6e88a206c0db65e8a0c2e Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier <at> member.fsf.org>
> Date: Mon, 16 Sep 2019 22:20:23 -0500
> Subject: [PATCH] gnu: idris: Update to 1.3.2.
>
> * gnu/packages/idris.scm (ghc-network-2.8, ghc-megaparsec-7): New variables.
> (idris): Update to 1.3.2.
> [source]: Remove patch.
> [inputs]: Use ghc-network-2.8 and ghc-megaparsec-7.
> * gnu/packages/patches/idris-test-no-node.patch: Delete.
> * gnu/local.mk (dist_patch_DATA): Remove it.

[...]

> +++ b/gnu/packages/idris.scm
> @@ -30,15 +30,50 @@
>    #:use-module (gnu packages perl)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system haskell)
> +  #:use-module (guix utils)
>    #:use-module (guix download)
>    #:use-module (guix git-download)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages))
>  
> +;;; Until we update our default GHC to >=8.6 we cannot update our ghc-network
> +;;; package, since the 'cabal-install' package that supports the current
> +;;; 'Cabal' module requires 'network==2.6.*'.  Providing a local ghc-network
> +;;; works in this case since we use it only for a standalone program.
> +(define ghc-network-2.8
> +  (package
> +    (inherit ghc-network)

You should only inherit from packages defined in the same module,
otherwise we risk hitting the dreaded circular dependency mess (actually
this particular case is fine because idris.scm is a “leaf”, but still,
let’s not take this risk.)

So I recommend moving these two ghc-* packages next to their friends.

With this change the patch LGTM.

Thanks,
Ludo’.

Message #34 received at 37434-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37434-done <at> debbugs.gnu.org, Timothy Sample <samplet <at> ngyro.com>,
 37435-done <at> debbugs.gnu.org
Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Tue, 24 Sep 2019 22:20:28 -0400 (EDT)

----- On Sep 24, 2019, at 12:08 PM, Ludovic Courtès ludo <at> gnu.org wrote:

> Hi Eric,
> 
> Eric Bavier <ericbavier <at> centurylink.net> skribis:
> 
>> From 832529b71c2c5c7e6aa6e88a206c0db65e8a0c2e Mon Sep 17 00:00:00 2001
>> From: Eric Bavier <bavier <at> member.fsf.org>
>> Date: Mon, 16 Sep 2019 22:20:23 -0500
>> Subject: [PATCH] gnu: idris: Update to 1.3.2.
>>
>> * gnu/packages/idris.scm (ghc-network-2.8, ghc-megaparsec-7): New variables.
>> (idris): Update to 1.3.2.
>> [source]: Remove patch.
>> [inputs]: Use ghc-network-2.8 and ghc-megaparsec-7.
>> * gnu/packages/patches/idris-test-no-node.patch: Delete.
>> * gnu/local.mk (dist_patch_DATA): Remove it.
> 
> [...]
>> +;;; Until we update our default GHC to >=8.6 we cannot update our ghc-network
>> +;;; package, since the 'cabal-install' package that supports the current
>> +;;; 'Cabal' module requires 'network==2.6.*'.  Providing a local ghc-network
>> +;;; works in this case since we use it only for a standalone program.
>> +(define ghc-network-2.8
>> +  (package
>> +    (inherit ghc-network)
> 
> You should only inherit from packages defined in the same module,
> otherwise we risk hitting the dreaded circular dependency mess (actually
> this particular case is fine because idris.scm is a “leaf”, but still,
> let’s not take this risk.)
> 
> So I recommend moving these two ghc-* packages next to their friends.

Makes sense.  Done.

> With this change the patch LGTM.

Pushed with that change and other small adjustments for latest master in commit 4780db2c93.

-- 
`~Eric

Message #37 received at 37434 <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 37434 <37434 <at> debbugs.gnu.org>,
 Ludovic Courtès <ludo <at> gnu.org>,
 bavier <bavier <at> member.fsf.org>
Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Wed, 25 Sep 2019 13:49:36 -0400

Hi Eric and Ludo,

Eric Bavier <ericbavier <at> centurylink.net> writes:

> ----- On Sep 24, 2019, at 2:16 AM, Ludovic Courtès ludo <at> gnu.org wrote:
>
>> For the sake of consistency, what about adding a variant of megaparsec
>> for use by Idris, and keeping the LTS-12 version?
>
> That sounds appropriate to me.  New patch attached.

Very good idea!  Thanks.

>>> I was under the impression that our 'guix refresh' updater was
>>> supposed to use
>>> the appropriate stackage version?  But it seems to be referencing
>>> version 14.6.
>> 
>> Looking at ‘latest-lts-release’ in (guix import stackage), the updater
>> seems to just take the latest LTS version.
>> 
>> We should probably fix that by having the argument to
>> ‘stackage-lts-info-fetch’ default to the currently targeted LTS version.
>> Otherwise one has to know the LTS version and pass it to ‘guix import
>> stackage --lts-version’, which is error-prone.
>> 
>> Thoughts?
>
> I think that would be the right thing to do, imo.

I believe we have a patch series from Robert that does this.  There were
a few things to fix up, but it is the right thing to do.

    https://bugs.gnu.org/36653

Unfortunately, I don’t do a lot of Haskell stuff for myself these days,
so my motivation here is pretty limited.  (There are only so many hours
in the week to tinker with Guix....)  Applying this patch and getting
the ball rolling on Stackage LTS 14 are on my to-do list, but I don’t
know when I’ll get around to them.  :(


-- Tim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.