GNU bug report logs - #37457
[PATCH] gnu: Add makeself-safeextract.

Previous Next

Package: guix-patches;

Reported by: Pierre Neidhardt <mail <at> ambrevar.xyz>

Date: Thu, 19 Sep 2019 10:37:02 UTC

Severity: normal

Tags: patch

Done: Pierre Neidhardt <mail <at> ambrevar.xyz>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37457 in the body.
You can then email your comments to 37457 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#37457; Package guix-patches. (Thu, 19 Sep 2019 10:37:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Pierre Neidhardt <mail <at> ambrevar.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 19 Sep 2019 10:37:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add makeself-safeextract.
Date: Thu, 19 Sep 2019 12:35:52 +0200
* gnu/packages/compression.scm (makeself-safeextract): New variable.
---
 gnu/packages/compression.scm | 49 +++++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index bda43bfd18..9785fa7a60 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -22,7 +22,7 @@
 ;;; Copyright © 2017 Julien Lepiller <julien <at> lepiller.eu>
 ;;; Copyright © 2018 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2018 Joshua Sierles, Nextjournal <joshua <at> nextjournal.com>
-;;; Copyright © 2018 Pierre Neidhardt <mail <at> ambrevar.xyz>
+;;; Copyright © 2018, 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
 ;;; Copyright © 2019 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -48,6 +48,7 @@
   #:use-module (guix git-download)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
   #:use-module (gnu packages assembly)
   #:use-module (gnu packages autotools)
@@ -2000,3 +2001,49 @@ external compressors: the compressor to be used for each format is configurable
 at run time, and must be installed separately.")
     (license (list license:bsd-2        ; arg_parser.{cc,h}
                    license:gpl2+))))    ; the rest
+
+(define-public makeself-safeextract
+  (let ((commit "1a95e121fa8e3c02d307ae37b9b7834e616c3683"))
+    (package
+      (name "makeself-safeextract")
+      (version (git-version "0.0.0" "1" commit))
+      (home-page "https://github.com/ssokolow/makeself_safeextract")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url home-page)
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1anlinaj9lvfi8bn00wp11vzqq0f9sig4fm9yrspisx31v0z4a2c"))))
+      (build-system trivial-build-system)
+      (inputs
+       `(("python" ,python-2)
+         ("p7zip" ,p7zip)
+         ("unzip" ,unzip)))
+      (arguments
+       `(#:modules ((guix build utils))
+         #:builder
+         (begin
+           (use-modules (guix build utils))
+           (let* ((name "makeself_safeextract")
+                  (source (string-append (assoc-ref %build-inputs "source")
+                                         "/" name ".py"))
+                  (bin (string-append (assoc-ref %outputs "out") "/bin"))
+                  (target (string-append bin "/" name))
+                  (python (string-append (assoc-ref %build-inputs "python") "/bin"))
+                  (7z (string-append (assoc-ref %build-inputs "p7zip") "/bin/7z"))
+                  (unzip (string-append (assoc-ref %build-inputs "unzip") "/bin/unzip")))
+             (setenv "PATH" (string-append (getenv "PATH") ":" python))
+             (mkdir-p bin)
+             (copy-file source target)
+             (substitute* target
+               (("'7z'") (format #f "'~a'" 7z))
+               (("'unzip'") (format #f "'~a'" unzip)))
+             (patch-shebang target)))))
+      (synopsis "Extract makeself and mojo archives without running untrusted code")
+      (description "A simple script to unpack makeself-generated
+self-extractors without running the possibly untrusted shell script.")
+      (license license:gpl3+))))
-- 
2.23.0





Information forwarded to guix-patches <at> gnu.org:
bug#37457; Package guix-patches. (Thu, 26 Sep 2019 21:10:02 GMT) Full text and rfc822 format available.

Message #8 received at 37457 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 37457 <at> debbugs.gnu.org
Subject: Re: [bug#37457] [PATCH] gnu: Add makeself-safeextract.
Date: Thu, 26 Sep 2019 23:09:42 +0200
Hello,

Pierre Neidhardt <mail <at> ambrevar.xyz> skribis:

> * gnu/packages/compression.scm (makeself-safeextract): New variable.

[...]

> +      (synopsis "Extract makeself and mojo archives without running untrusted code")
> +      (description "A simple script to unpack makeself-generated
> +self-extractors without running the possibly untrusted shell script.")

What about:

  This package provides a script to unpack self-extracting archives
  generated by @command{makeself} or @command{mojo} without running the
  possibly untrusted extraction shell script.

?

(I didn’t know about these things.)

Otherwise LGTM, thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#37457; Package guix-patches. (Fri, 27 Sep 2019 07:59:02 GMT) Full text and rfc822 format available.

Message #11 received at 37457 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37457 <at> debbugs.gnu.org
Subject: Re: [bug#37457] [PATCH] gnu: Add makeself-safeextract.
Date: Fri, 27 Sep 2019 09:58:16 +0200
[Message part 1 (text/plain, inline)]
Done, thanks!

-- 
Pierre Neidhardt
https://ambrevar.xyz/
[signature.asc (application/pgp-signature, inline)]

bug closed, send any further explanations to 37457 <at> debbugs.gnu.org and Pierre Neidhardt <mail <at> ambrevar.xyz> Request was from Pierre Neidhardt <mail <at> ambrevar.xyz> to control <at> debbugs.gnu.org. (Fri, 27 Sep 2019 07:59:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#37457; Package guix-patches. (Fri, 27 Sep 2019 20:02:02 GMT) Full text and rfc822 format available.

Message #16 received at 37457-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 37457-done <at> debbugs.gnu.org
Subject: Re: [bug#37457] [PATCH] gnu: Add makeself-safeextract.
Date: Fri, 27 Sep 2019 22:01:12 +0200
Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> Done, thanks!

Thanks, closing.

-- 
Ricardo





Information forwarded to guix-patches <at> gnu.org:
bug#37457; Package guix-patches. (Fri, 27 Sep 2019 20:08:01 GMT) Full text and rfc822 format available.

Message #19 received at 37457-done <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 37457-done <at> debbugs.gnu.org
Subject: Re: [bug#37457] [PATCH] gnu: Add makeself-safeextract.
Date: Fri, 27 Sep 2019 22:07:35 +0200
[Message part 1 (text/plain, inline)]
Ricardo Wurmus <rekado <at> elephly.net> writes:

> Thanks, closing.

Hmm?  I had already closed it, hadn't I?
I received a confirmation from control <at> debbugs.gnu.org.

--8<---------------cut here---------------start------------->8---
Processing commands for control <at> debbugs.gnu.org:

> close 37457
bug#37457: [PATCH] gnu: Add makeself-safeextract.
bug closed, send any further explanations to
37457 <at> debbugs.gnu.org and Pierre Neidhardt <mail <at> ambrevar.xyz>

> quit
Stopping processing here.
--8<---------------cut here---------------end--------------->8---

-- 
Pierre Neidhardt
https://ambrevar.xyz/
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#37457; Package guix-patches. (Fri, 27 Sep 2019 21:59:02 GMT) Full text and rfc822 format available.

Message #22 received at 37457-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 37457-done <at> debbugs.gnu.org
Subject: Re: [bug#37457] [PATCH] gnu: Add makeself-safeextract.
Date: Fri, 27 Sep 2019 23:58:30 +0200
Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
>> Thanks, closing.
>
> Hmm?  I had already closed it, hadn't I?
> I received a confirmation from control <at> debbugs.gnu.org.

Oh, my bad.  I only saw a last email without message to
*-done <at> debbugs.gnu.org; didn’t stop to check the current status of the
issue first.

--
Ricardo





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 26 Oct 2019 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 155 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.