GNU bug report logs - #37465
add xftwidth displayed textwidth calculator package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37465 in the body.
You can then email your comments to 37465 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kyle Andrews <kyle.c.andrews <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: add xftwidth displayed textwidth calculator package
Date: Thu, 19 Sep 2019 20:25:42 -0400

[Message part 1 (text/plain, inline)]

Hello,

I'd like to provide a package definition for the xftwidth calculator
utility so that it may be included into guix. Please see the attached
patch. 

Regards,

Kyle Andrews

[0001-gnu-Add-xftwidth.patch (text/x-patch, attachment)]

Message #8 received at 37465 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Kyle Andrews <kyle.c.andrews <at> gmail.com>
Cc: 37465 <at> debbugs.gnu.org
Subject: Re: [bug#37465] add xftwidth displayed textwidth calculator package
Date: Wed, 25 Sep 2019 15:32:32 +0200

Hello Kyle,

Kyle Andrews <kyle.c.andrews <at> gmail.com> skribis:

> From 60deaa526b4a6ca5a66f3b67ba77aa353409d542 Mon Sep 17 00:00:00 2001
> From: Kyle Andrews <kyle.c.andrews <at> gmail.com>
> Date: Thu, 19 Sep 2019 20:16:28 -0400
> Subject: [PATCH] gnu: Add xftwidth.
>
> * gnu/packages/wm.scm: added xftwidth package.

I think this should rather go to xdisorg.scm, WDYT?

> +    (build-system gnu-build-system)
> +    (inputs `(("freetype"    ,freetype)
> +              ("libx11"      ,libx11)
> +              ("fontconfig"  ,fontconfig)
> +              ("libxft"      ,libxft)))

Nitpicking: we don’t usually align input tuples like that.  :-)

> +    (synopsis "Calculator for determining displayed text widths using Xft fonts.")
> +    (description "A small C program to calculate pixel widths for displayed
> +text using Xft fonts (given a specific font name and size). It is ideal for
> +scripts including text into the custom (e.g. dzen and xmobar based) panels
> +often used in conjunction with minimalistic window managers.")

Could you address the warnings reported by ‘guix lint’ here?  Also, make
sure to write full sentences in the description:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

The rest LGTM!  Could you send an updated patch?

Thanks,
Ludo’.

Message #11 received at 37465 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Andrews <kyle.c.andrews <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37465 <at> debbugs.gnu.org
Subject: Re: [bug#37465] add xftwidth displayed textwidth calculator package
Date: Sun, 29 Sep 2019 10:24:32 -0400

[Message part 1 (text/plain, inline)]

Hi Ludo,

On Wed, 2019-09-25 at 15:32 +0200, Ludovic Courtès wrote:
> Hello Kyle,
> 
> Kyle Andrews <kyle.c.andrews <at> gmail.com> skribis:
> 
> > From 60deaa526b4a6ca5a66f3b67ba77aa353409d542 Mon Sep 17 00:00:00
> > 2001
> > From: Kyle Andrews <kyle.c.andrews <at> gmail.com>
> > Date: Thu, 19 Sep 2019 20:16:28 -0400
> > Subject: [PATCH] gnu: Add xftwidth.
> > 
> > * gnu/packages/wm.scm: added xftwidth package.
> 
> I think this should rather go to xdisorg.scm, WDYT?

That makes sense to me. I have added fontutils as an additional module
dependency in xdisorg.scm to satisfy the inputs.

> > +    (build-system gnu-build-system)
> > +    (inputs `(("freetype"    ,freetype)
> > +              ("libx11"      ,libx11)
> > +              ("fontconfig"  ,fontconfig)
> > +              ("libxft"      ,libxft)))
> 
> Nitpicking: we don’t usually align input tuples like that.  :-)
> 

Okay. I've removed the alignment. However, note that the dzen package
in xdisorg.scm uses this same aligned format for it's inputs.

> > +    (synopsis "Calculator for determining displayed text widths
> > using Xft fonts.")
> > +    (description "A small C program to calculate pixel widths for
> > displayed
> > +text using Xft fonts (given a specific font name and size). It is
> > ideal for
> > +scripts including text into the custom (e.g. dzen and xmobar
> > based) panels
> > +often used in conjunction with minimalistic window managers.")
> 
> Could you address the warnings reported by ‘guix lint’ here?  Also,
> make
> sure to write full sentences in the description:
> 
>   https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.
> html
> The rest LGTM!  Could you send an updated patch?
> 
> Thanks,
> Ludo’.

I've fixed the notes I saw from guix lint:

1. https -> http for github urls
2. Removed period from synopsis
3. Rewrote the description using full sentences

Please see the attached patch.

Regards,
Kyle

[0001-gnu-Add-xftwidth.patch (text/x-patch, attachment)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>, 37465 <at> debbugs.gnu.org
Subject: Re: [bug#37465] add xftwidth displayed textwidth calculator package
Date: Sun, 29 Sep 2019 17:32:31 +0200

[Message part 1 (text/plain, inline)]

Kyle,

Thanks for the patch.

Kyle Andrews 写道：
> I've fixed the notes I saw from guix lint:
>
> 1. https -> http for github urls

I thought this was just a typo, but the patch agrees.  Our linter 
doesn't recommend HTTP over HTTPS for GitHub (or indeed any) URLs. 
In fact, it should now warn about a

 gnu/packages/xftwidth <at> 20170402: permanent redirect from
 http://github.com/vixus0/xftwidth to
 https://github.com/vixus0/xftwidth

Also, the GNU/Guix style is to…
- never use tabs for indentation, only spaces.
- use two spaces between prose sentences: ‘…Xft fonts.  It is…’.
                                                     ^^
The linter should have warned you about both of these, too.

It sounds like yours is behaving quite strangely.  What, exactly, 
did it say?

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 37465-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Kyle Andrews <kyle.c.andrews <at> gmail.com>
Cc: 37465-done <at> debbugs.gnu.org
Subject: Re: [bug#37465] add xftwidth displayed textwidth calculator package
Date: Sun, 29 Sep 2019 21:46:24 +0200

Hi Kyle,

Kyle Andrews <kyle.c.andrews <at> gmail.com> skribis:

> I've fixed the notes I saw from guix lint:
>
> 1. https -> http for github urls
> 2. Removed period from synopsis
> 3. Rewrote the description using full sentences

I fixed a these additional warnings reported by ‘guix lint’ and
committed:

--8<---------------cut here---------------start------------->8---
gnu/packages/xdisorg.scm:1359:17: xftwidth <at> 20170402: sentences in description should be followed by two spaces; possible infractions at 96, 234
/home/ludo/src/guix/gnu/packages/xdisorg.scm:1335:0: xftwidth <at> 20170402: tabulation on line 1335, column 0
/home/ludo/src/guix/gnu/packages/xdisorg.scm:1336:0: xftwidth <at> 20170402: tabulation on line 1336, column 0
/home/ludo/src/guix/gnu/packages/xdisorg.scm:1338:0: xftwidth <at> 20170402: tabulation on line 1338, column 0
/home/ludo/src/guix/gnu/packages/xdisorg.scm:1339:0: xftwidth <at> 20170402: tabulation on line 1339, column 0
gnu/packages/xdisorg.scm:1364:15: xftwidth <at> 20170402: permanent redirect from http://github.com/vixus0/xftwidth to https://github.com/vixus0/xftwidth
--8<---------------cut here---------------end--------------->8---

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.